Re: [Spice-devel] [vdagent-win PATCH] fix format string for Visual Studio

On Mon, Jul 24, 2017 at 11:44:25AM -0400, Frediano Ziglio wrote: > > > > The "z" size specifier is not supported by Visual Studio. > > Use "I" if Visual Studio is detected. > > > > Signed-off-by: Frediano Ziglio > > --- > > vdagent/desktop_layout.cpp | 12 +++- > >

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > Not really familiar with GitLab merge requests but on GitHub they > remain open till closed so this would help with old ones. This would help until there are enough old ones piled up that we no longer know if they are still

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > > Not really familiar with GitLab merge requests but on GitHub they > > remain open till closed so this would help with old ones. > > This would help until there are enough old ones piled up that we no > longer know if

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Hi - Original Message - > ... > > > > > > > 3. If you want to test, a git checkout is enough to test (assuming you > > > > did > > > > the git fetch above). Simpler IMO than git am (even if I assume most of > > > > us > > > > have scripts to process incoming mail) > > > > qemu uses

Re: [Spice-devel] [vdagent-win PATCH v2] fix format string for Visual Studio

Acked-by: Christophe Fergeau On Mon, Jul 24, 2017 at 04:57:53PM +0100, Frediano Ziglio wrote: > The "z" size specifier is not supported by Visual Studio. > Cast to unsigned long and use "l" specifier as the type has > enough precision for this vector. > > Signed-off-by:

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

Hi - Original Message - > > > > > On 21 Jul 2017, at 12:41, Frediano Ziglio wrote: > > > > > >> > > >> On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > >>> Beside that I wonder why I had to wait 8 months for these reviews, > > >>> not counting

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > Hi, > > On Fri, Jul 21, 2017 at 06:41:01AM -0400, Frediano Ziglio wrote: > > > > > > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > > > Beside that I wonder why I had to wait 8 months for these reviews, > > > > not counting the time to decide to rewrite this part of

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

... > > > > 3. If you want to test, a git checkout is enough to test (assuming you > > > did > > > the git fetch above). Simpler IMO than git am (even if I assume most of > > > us > > > have scripts to process incoming mail) > > qemu uses patchew, I think it would be worth to consider it for

[Spice-devel] [vdagent-win PATCH] fix format string for Visual Studio

The "z" size specifier is not supported by Visual Studio. Use "I" if Visual Studio is detected. Signed-off-by: Frediano Ziglio --- vdagent/desktop_layout.cpp | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/vdagent/desktop_layout.cpp

Re: [Spice-devel] [vdagent-win PATCH] fix format string for Visual Studio

> > The "z" size specifier is not supported by Visual Studio. > Use "I" if Visual Studio is detected. > > Signed-off-by: Frediano Ziglio > --- > vdagent/desktop_layout.cpp | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git

[Spice-devel] [vdagent-win PATCH v2] fix format string for Visual Studio

The "z" size specifier is not supported by Visual Studio. Cast to unsigned long and use "l" specifier as the type has enough precision for this vector. Signed-off-by: Frediano Ziglio --- vdagent/desktop_layout.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [Spice-devel] [vdagent-win PATCH] log: add comment to make clear code

Thanks for adding this, Acked-by: Christophe Fergeau On Mon, Jul 24, 2017 at 02:57:40PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > common/vdlog.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> > > On 21 Jul 2017, at 12:41, Frediano Ziglio wrote: > > > >> > >> On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > >>> Beside that I wonder why I had to wait 8 months for these reviews, > >>> not counting the time to decide to rewrite this part of code

Re: [Spice-devel] [vdagent-win PATCH v10 1/6] Move image handling to a separate file

On Fri, Jul 21, 2017 at 02:51:36PM +0100, Frediano Ziglio wrote: > This will make easier to change code that handle images. > > Signed-off-by: Frediano Ziglio > Acked-by: Christophe Fergeau > --- > Makefile.am | 2 ++ > vdagent/image.cpp | 88

Re: [Spice-devel] [vdagent-win PATCH v10 2/6] Initial rewrite of image conversion code

Acked-by: Christophe Fergeau On Fri, Jul 21, 2017 at 02:51:37PM +0100, Frediano Ziglio wrote: > Remove CxImage linking. > Support Windows BMP format. > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 4 +- > configure.ac

Re: [Spice-devel] [spice-server] Prepare for 0.13.90 release

Hey, On Thu, 2017-07-20 at 17:12 +0200, Christophe Fergeau wrote: > Update NEWS and soname. > --- > NEWS | 19 +++ > configure.ac | 2 +- > 2 files changed, 20 insertions(+), 1 deletion(-) > > Hey, > > It's high time that we have an unstable release, and I'd like to

Re: [Spice-devel] [vdagent-win PATCH v10 3/6] Write code to decode PNG format

On Fri, Jul 21, 2017 at 02:51:38PM +0100, Frediano Ziglio wrote: > +const int palette_colors = out_bits > 8 ? 0 : 1 << (bits == 2 ? 2 : > out_bits); This really deserves to be split in multiple statements to make this easier to parse :) Looks good otherwise. Christophe signature.asc

Re: [Spice-devel] [vdagent-win PATCH v10 4/6] Support encoding PNG images

On Fri, Jul 21, 2017 at 02:51:39PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > Acked-by: Christophe Fergeau > --- > vdagent/imagepng.cpp | 110 > +-- > 1 file changed, 106

Re: [Spice-devel] [spice-common] Some steps toward quic_tmpl.c and quic_rgb_tmpl.c 'unification'

On Sat, Jul 22, 2017 at 04:24:14AM -0400, Frediano Ziglio wrote: > > Isn't the s/decorrelate_drow/correlate_row patch part of 2). Ah that one too yeah, missed it when quickly glancing through it. > I remember you mentioned also the fact that Windows driver contains > Quic code. I checked and is

Re: [Spice-devel] [vdagent-win PATCH] log: avoid crash on failure in log_version

On Sun, Jul 23, 2017 at 10:37:05AM +0100, Frediano Ziglio wrote: > The "throw" statement alone are used to throw an already existing > exception however in log_version they were meant to raise an exception. > This would have caused a termination of the program. > > Signed-off-by: Frediano Ziglio

[Spice-devel] [vdagent-win PATCH] log: rewrite log_version using config.h definitions

Instead of having to get the version information from the executable resources get from the build configuration file. The same version is used to build the version information resource. This also remove a bug in log_version where "throw" statements were used to raise again a not existing exception

[Spice-devel] [vdagent-win PATCH v11 6/6] spec: run tests during RPM build if possible

Currently to fully run checks we need Wine for both 32 and 64 bit. Some distros (like RHEL 7) don't seem to allow installing both 32 and 64 bit versions so turn on checks based on distro versions. Signed-off-by: Frediano Ziglio --- mingw-spice-vdagent.spec.in | 27

[Spice-devel] [vdagent-win PATCH v11 1/6] Move image handling to a separate file

This will make easier to change code that handle images. Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- Makefile.am | 2 ++ vdagent/image.cpp | 88 + vdagent/image.h |

Re: [Spice-devel] [vdagent-win PATCH] log: avoid crash on failure in log_version

On Mon, Jul 24, 2017 at 07:19:45AM -0400, Frediano Ziglio wrote: > > > > On Sun, Jul 23, 2017 at 10:37:05AM +0100, Frediano Ziglio wrote: > > > The "throw" statement alone are used to throw an already existing > > > exception however in log_version they were meant to raise an exception. > > >

[Spice-devel] [vdagent-win PATCH v11 0/6] Rewrite image support

CxImage is used for image conversion for clipboard support. CxImage have currently some issue: - library is old and unsupported; - required an old libpng library. Currently the MingW binary we distribute due to some issue have PNG disabled (so no clipboard image support). Note that currently we

[Spice-devel] [vdagent-win PATCH v11 5/6] Add test for PNG files

Test various image and formats. The idea is to decode and encode again an image and check for differences. ImageMagick is used to create some test image and compare results. Wine is used to execute a test helper. Signed-off-by: Frediano Ziglio --- Makefile.am | 20

[Spice-devel] [vdagent-win PATCH v11 3/6] Write code to decode PNG format

Signed-off-by: Frediano Ziglio --- Makefile.am | 6 +- configure.ac | 3 + vdagent/image.cpp| 8 +- vdagent/imagepng.cpp | 238 +++ vdagent/imagepng.h | 25 ++ 5 files changed, 271

Re: [Spice-devel] [vdagent-win PATCH] log: avoid crash on failure in log_version

> > On Mon, Jul 24, 2017 at 07:19:45AM -0400, Frediano Ziglio wrote: > > > > > > On Sun, Jul 23, 2017 at 10:37:05AM +0100, Frediano Ziglio wrote: > > > > The "throw" statement alone are used to throw an already existing > > > > exception however in log_version they were meant to raise an

Re: [Spice-devel] [vdagent-win PATCH] log: avoid crash on failure in log_version

On Mon, Jul 24, 2017 at 08:19:00AM -0400, Frediano Ziglio wrote: > > > > On Mon, Jul 24, 2017 at 07:19:45AM -0400, Frediano Ziglio wrote: > > > > > > > > On Sun, Jul 23, 2017 at 10:37:05AM +0100, Frediano Ziglio wrote: > > > > > The "throw" statement alone are used to throw an already existing >

Re: [Spice-devel] [vdagent-win PATCH] log: rewrite log_version using config.h definitions

On Mon, Jul 24, 2017 at 01:06:17PM +0100, Frediano Ziglio wrote: > Instead of having to get the version information from the > executable resources get from the build configuration file. > The same version is used to build the version information > resource. > This also remove a bug in log_version

[Spice-devel] [vdagent-win PATCH v12 3/6] Write code to decode PNG format

Signed-off-by: Frediano Ziglio --- Makefile.am | 6 +- configure.ac | 3 + vdagent/image.cpp| 8 +- vdagent/imagepng.cpp | 244 +++ vdagent/imagepng.h | 25 ++ 5 files changed, 277

Re: [Spice-devel] [vdagent-win PATCH v10 4/6] Support encoding PNG images

> > On 07/24/2017 01:22 PM, Christophe Fergeau wrote: > > On Fri, Jul 21, 2017 at 02:51:39PM +0100, Frediano Ziglio wrote: > >> Signed-off-by: Frediano Ziglio > >> Acked-by: Christophe Fergeau > >> --- > >> vdagent/imagepng.cpp | 110 > >>

Re: [Spice-devel] [vdagent-win PATCH v10 3/6] Write code to decode PNG format

> > On Fri, Jul 21, 2017 at 02:51:38PM +0100, Frediano Ziglio wrote: > > +const int palette_colors = out_bits > 8 ? 0 : 1 << (bits == 2 ? 2 : > > out_bits); > > This really deserves to be split in multiple statements to make this > easier to parse :) > > Looks good otherwise. > >

Re: [Spice-devel] [PATCH linux vdagent v2] Add systemd socket activation

Hi, On Fri, Jul 21, 2017 at 11:09:24AM -0500, Jonathon Jongsma wrote: > If we are configured to use the systemd init script, also add support > for systemd socket activation. systemd will listen on the socket that is > used to communicate between the session agent and the system daemon. > When

Re: [Spice-devel] [vdagent-win PATCH v10 4/6] Support encoding PNG images

On 07/24/2017 01:22 PM, Christophe Fergeau wrote: On Fri, Jul 21, 2017 at 02:51:39PM +0100, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- vdagent/imagepng.cpp | 110

Re: [Spice-devel] [vdagent-win PATCH v10 4/6] Support encoding PNG images

On Mon, Jul 24, 2017 at 02:15:24PM +0300, Uri Lublin wrote: > On 07/24/2017 01:22 PM, Christophe Fergeau wrote: > > On Fri, Jul 21, 2017 at 02:51:39PM +0100, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > Acked-by: Christophe Fergeau >

Re: [Spice-devel] [vdagent-win PATCH v10 5/6] Add test for PNG files

Acked-by: Christophe Fergeau On Fri, Jul 21, 2017 at 02:51:40PM +0100, Frediano Ziglio wrote: > Test various image and formats. > The idea is to decode and encode again an image and > check for differences. ImageMagick is used to create > some test image and compare

Re: [Spice-devel] [vdagent-win PATCH v10 6/6] RFC spec: run tests during RPM build if possible

On Fri, Jul 21, 2017 at 02:51:41PM +0100, Frediano Ziglio wrote: > Currently to fully run checks we need Wine for both 32 and 64 bit. > Some distros (like RHEL 7) don't seem to allow installing > both 32 and 64 bit versions so turn on checks based on distro > versions. > > Signed-off-by: Frediano