Re: [Spice-devel] [nsis v3 2/2] build: Don't add .pdb debug files to the installer

2017-12-31 Thread Yan Vugenfirer
> On 31 Dec 2017, at 08:55, Yedidyah Bar David wrote: > > On Fri, Dec 29, 2017 at 3:36 AM, Vadim Rozenfeld > wrote: >> >> >> On 29/12/17 03:31, Yan Vugenfirer wrote: >> >> >> >> On 28 Dec 2017, at 16:44, Amnon Ilan

Re: [Spice-devel] [nsis v3 2/2] build: Don't add .pdb debug files to the installer

2017-12-31 Thread Vadim Rozenfeld
On 31/12/17 19:24, Yan Vugenfirer wrote: On 31 Dec 2017, at 08:55, Yedidyah Bar David > wrote: On Fri, Dec 29, 2017 at 3:36 AM, Vadim Rozenfeld > wrote: On 29/12/17 03:31, Yan Vugenfirer wrote:

Re: [Spice-devel] [PATCH spice-server v3 03/12] red-stream: Avoid to specify 2 mech names during SASL

2017-12-31 Thread Snir Sheriber
Hi On 12/22/2017 12:07 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- server/red-stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-stream.c b/server/red-stream.c index 3dbdfca82..fccad8b27 100644 ---

Re: [Spice-devel] [PATCH spice-server v3 10/12] red-stream: Handle properly endianness in SASL code

2017-12-31 Thread Snir Sheriber
Hi On 12/22/2017 12:07 PM, Frediano Ziglio wrote: All SPICE protocol is little endian, there's no agreement on other endian and currently we support only little endian so make sure this will work even possibly running on a big endian machine. Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [nsis v3 2/2] build: Don't add .pdb debug files to the installer

2017-12-31 Thread Lev Veyde
Hi Didi, After discussing with Yan offline I think that we indeed don't need to install the files into the guest and merely having the files on the ISO is enough. BTW I re-checked what we do in d/s, and while we don't ever install the files into the guest and don't provide them as part of the

[Spice-devel] [PATCH spice-gtk 0/2] stream decoding using gstreamer

2017-12-31 Thread Snir Sheriber
spice gstreamer decoder decodes streams using the gstreamer framework., In order to do that it uses pipeline of gst elements that is being built automatically by the playbin element. Currently the basic image drawing in spice-client is done in-memory and using BGRA raw images, so the pipeline

[Spice-devel] [PATCH spice-gtk 1/2] gstreamer: use custom playbin sink

2017-12-31 Thread Snir Sheriber
Use custom playbin sink instead of just appsink. In order to allow playbin to choose decoders that requires more complex pipelines (e.g. pipeline that requires color space conversion & uses gl memory). The new sink composed as such: ... ! autovideoconvert ! gldownload ! appsink ---

Re: [Spice-devel] [PATCH spice-server v3 01/12] red-stream: Simplify mechname matching

2017-12-31 Thread Snir Sheriber
Hi On 12/22/2017 12:07 PM, Frediano Ziglio wrote: Avoid over complicated matching using quoting and a simple strstr operation. The mech names are separated and quoted with the same chararacter (',') making possible to search for ",MECHNAME," instead of manually check for prefix and suffix

Re: [Spice-devel] [PATCH spice-server v3 02/12] red-stream: Avoid infinite loop on sasl_encode/decode failure

2017-12-31 Thread Snir Sheriber
Hi On 12/22/2017 12:07 PM, Frediano Ziglio wrote: These functions do not set errno so is possible that errno is EAGAIN. s/is possible/it is possible/ This would cause an infinite loop in functions like red_stream_write_all (or potentially using the event loop). Signed-off-by: Frediano

[Spice-devel] [PATCH spice-gtk 2/2] Let user rank gstreamer element

2017-12-31 Thread Snir Sheriber
User can now rank a gstreamer element with high rank by setting SPICE_GST_RANK_HIGH to the element's name. This can be used to prioritize specific decoder to be chosen by playbin. --- src/channel-display-gst.c | 23 +++ 1 file changed, 23 insertions(+) diff --git