Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

> > > On 20 Mar 2018, at 12:28, Frediano Ziglio wrote: > > > >> > >> Looks good, with minor nits. > >> > >>> On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: > >>> > >>> Handle capabilities from guest device. > >>> Send capability to the guest when

Re: [Spice-devel] [PATCH spice-server] stream-channel: Implements monitors_config

> On 21 Mar 2018, at 10:22, Lukáš Hrázký wrote: > > On Wed, 2018-03-21 at 08:54 +0100, Christophe de Dinechin wrote: >>> On 20 Mar 2018, at 12:14, Frediano Ziglio wrote: >>> > On 19 Mar 2018, at 11:39, Frediano Ziglio wrote:

Re: [Spice-devel] [PATCH spice-server] stream-channel: Implements monitors_config

On Wed, 2018-03-21 at 08:54 +0100, Christophe de Dinechin wrote: > > On 20 Mar 2018, at 12:14, Frediano Ziglio wrote: > > > > > > On 19 Mar 2018, at 11:39, Frediano Ziglio wrote: > > > > > > > > > > > > > > On 03/13/2018 08:21 AM, Frediano Ziglio wrote:

Re: [Spice-devel] [spice-vdagnet (linux) PATCH] x11-randr: do not assume each output has ncrtc=1

Typo in the subject line, spice-vdagent. > On 20 Mar 2018, at 16:24, Uri Lublin wrote: > > This was true for virtual graphic cards, but not true for > device-assigned graphic cards. I would rephrase without referring to the subject line, e.g. “Unlike virtual graphic cards,

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

> > On 03/20/2018 01:28 PM, Frediano Ziglio wrote: > >> > >> Looks good, with minor nits. > >> > >>> On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: > >>> > >>> Handle capabilities from guest device. > >>> Send capability to the guest when device is opened. > >>> Currently

Re: [Spice-devel] [PATCH spice-server] stream-channel: Implements monitors_config

> On 20 Mar 2018, at 12:14, Frediano Ziglio wrote: > >>> On 19 Mar 2018, at 11:39, Frediano Ziglio wrote: >>> On 03/13/2018 08:21 AM, Frediano Ziglio wrote: > Although not necessary for a single monitor DisplayChannel implementation

Re: [Spice-devel] [PATCH spice-common 1/3] Fix integer overflows computing sizes

> On 20 Mar 2018, at 11:41, Frediano Ziglio wrote: > >>> >>> On 19 Mar 2018, at 11:06, Frediano Ziglio wrote: >>> >>> Make code safe using both 32 and 64 bit machine. >>> Consider that this code can be compiled for machines with 32 bit. >>> There are

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

> On 20 Mar 2018, at 12:28, Frediano Ziglio wrote: > >> >> Looks good, with minor nits. >> >>> On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: >>> >>> Handle capabilities from guest device. >>> Send capability to the guest when device is opened. >>>

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

> > On 03/19/2018 06:46 PM, Frediano Ziglio wrote: > > Handle capabilities from guest device. > > Send capability to the guest when device is opened. > > Currently there's no capabilities set on the message sent. > > On the tests we need to discard the capability message before > > reading the

Re: [Spice-devel] [PATCH spice-common 1/2] Add --enable-extra-checks option

> On 20 Mar 2018, at 12:07, Frediano Ziglio wrote: > >>> On 19 Mar 2018, at 14:46, Frediano Ziglio wrote: >>> >>> Allow to enable code to do additional or expensive checks. >> >> “Allow to enable…” -> “Add configuration option enabling expensive

Re: [Spice-devel] [PATCH spice-server] stream-channel: Implements monitors_config

On Wed, 2018-03-21 at 10:51 +0100, Christophe de Dinechin wrote: > > On 21 Mar 2018, at 10:22, Lukáš Hrázký wrote: > > > > On Wed, 2018-03-21 at 08:54 +0100, Christophe de Dinechin wrote: > > > > On 20 Mar 2018, at 12:14, Frediano Ziglio wrote: > > > > >

Re: [Spice-devel] [PATCH spice-common 1/3] Fix integer overflows computing sizes

> > On 20 Mar 2018, at 11:41, Frediano Ziglio wrote: > > > >>> > >>> On 19 Mar 2018, at 11:06, Frediano Ziglio wrote: > >>> > >>> Make code safe using both 32 and 64 bit machine. > >>> Consider that this code can be compiled for machines with 32 bit. >