Re: [Spice-devel] [spice-gtk v2] usb-device-widget: Fix crash on no USB devices

Hi, On Fri, Apr 13, 2018 at 03:14:56PM -0300, Eduardo Lima (Etrunko) wrote: > On 13/04/18 05:50, Victor Toso wrote: > > From: goldengdeng <907246...@qq.com> > > > > The spice_usb_device_manager_get_devices() is only checking for NULL > > while the program can crash when no USB devices are

Re: [Spice-devel] [spice-gtk v2] usb-device-widget: Fix crash on no USB devices

On 13/04/18 05:50, Victor Toso wrote: > From: goldengdeng <907246...@qq.com> > > The spice_usb_device_manager_get_devices() is only checking for NULL > while the program can crash when no USB devices are available. > > Signed-off-by: Victor Toso > --- >

[Spice-devel] [spice-gtk v1] usb-device-widget: Fix crash on no USB devices

From: goldengdeng <907246...@qq.com> The spice_usb_device_manager_get_devices() is only checking for NULL while the program can crash when no USB devices are available. Signed-off-by: Victor Toso --- src/usb-device-widget.c | 2 +- 1 file changed, 1 insertion(+), 1

[Spice-devel] [spice-gtk v2] usb-device-widget: Fix crash on no USB devices

From: goldengdeng <907246...@qq.com> The spice_usb_device_manager_get_devices() is only checking for NULL while the program can crash when no USB devices are available. Signed-off-by: Victor Toso --- src/usb-device-widget.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Spice-devel] spice-gtk patch

Hi, On Fri, Apr 13, 2018 at 03:00:13PM +0800, GLODEN wrote: > patch for commit number:f94f0012b8cd2c69e8e06de44dd2a7a7d9bf7428 > commit msg:spice-channel: Disable TLS v1.0 Thanks for taking the time fix this issue. * Do you happen to have a backtrace of the crash? * I've kept the check for

Re: [Spice-devel] bad id bug in glz decoder

Hello all, I was wondering if you have had a chance to look at the e-mail below yet? It's about the wrong id problem of glz algorithm. Many thanks On Wed, Apr 11, 2018 at 12:28 PM, Usepr Xf wrote: > Hi all, > > Sorry to be a bother. > > After a long time running of glz

[Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

Limited the installation of the driver to Windows 8 and up in order to prevent false driver installation on unsupported OSes which lead to BSODs. Signed-off-by: Basil Salman Signed-off-by: Sameeh Jubran --- qxldod/qxldod.inx | 4 ++-- 1 file changed, 2

[Spice-devel] spice-gtk patch

patch for commit number:f94f0012b8cd2c69e8e06de44dd2a7a7d9bf7428 commit msg:spice-channel: Disable TLS v1.0 0001-fix-bug-of-usb-device-widget.patch Description: Binary data ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

Hi, We received a bug report: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/244 (BZ - Bug 1542909), regarding BSOD on Windows 7 when letting windows automatically choose the driver from virtio-win iso. After debugging the issue, we found out that Windows was falsely installing

[Spice-devel] spice-window7 redirection of USB

hi： I want to help for spice . To get USB redirection working on Windows clients, you need to install UsbDk---the windows is windows7 or windows10？ sorry,my english is poor！ i want to know， Does it support window7 systemUSB redirection？

Re: [Spice-devel] [PATCH spice-server 1/3] stream: implement interface for manual flush

> > Hey, I would just squash this with the next commit. > I prefer to keep separate, patch 2/3 is just using the interface for a possible optimization, for instance it does not touch TLS code mentioned in this commit message > On Tue, Jan 16, 2018 at 02:18:13PM +, Frediano Ziglio wrote: >

Re: [Spice-devel] bad id bug in glz decoder

Hi, On Wed, Apr 11, 2018 at 12:28:15PM +0800, Usepr Xf wrote: > Hi all, > > Sorry to be a bother. Thanks for taking the time to report this. > After a long time running of glz encode (approx. 4hrs), > I came across this error. It is windows client, correct? Could you confirm remote-viewer's

Re: [Spice-devel] [spice-server 2/2] cursor: Rename cursor_marshall to red_marshall_cursor_command

> > On Thu, Apr 12, 2018 at 11:09:39AM +0200, Christophe Fergeau wrote: > > On Wed, Apr 11, 2018 at 01:16:57PM -0400, Frediano Ziglio wrote: > > > > > > > > The name is more consistent with red_marshall_cursor_init. > > > > --- > > > > server/cursor-channel.c | 8 > > > > 1 file

Re: [Spice-devel] spice-window7 redirection of USB

HI，windows xp support USB redirection？ thank you ！ dongzhen_...@nfs-china.com From: Victor Toso Date: 2018-04-13 16:58 To: dongzhen_hlj CC: spice-devel Subject: Re: [Spice-devel] spice-window7 redirection of USB Hi, On Fri, Apr 13, 2018 at 04:29:52PM +0800, dongzhen_hlj wrote: > > hi： > >

Re: [Spice-devel] [PATCH spice-server 2/3] stream: implements flush using TCP_CORK

> > On Tue, Jan 16, 2018 at 02:18:14PM +, Frediano Ziglio wrote: > > Cork is a system interface implemented by Linux and some *BSD systems to > > tell the system that other data are expected to be written to a socket. > > This allows the system to reduce network fragmentation waiting a

Re: [Spice-devel] spice-window7 redirection of USB

Hi, On Fri, Apr 13, 2018 at 04:29:52PM +0800, dongzhen_hlj wrote: > > hi： > > I want to help for spice . > > To get USB redirection working on Windows clients, you need > to install UsbDk Yes > the windows is windows7 or windows10？ Should work with both, windows 7

Re: [Spice-devel] [spice-server 2/2] cursor: Rename cursor_marshall to red_marshall_cursor_command

On Thu, Apr 12, 2018 at 11:09:39AM +0200, Christophe Fergeau wrote: > On Wed, Apr 11, 2018 at 01:16:57PM -0400, Frediano Ziglio wrote: > > > > > > The name is more consistent with red_marshall_cursor_init. > > > --- > > > server/cursor-channel.c | 8 > > > 1 file changed, 4

Re: [Spice-devel] [PATCH spice-server 3/3] common-graphics-channel: use manual flushing on stream to decrease packet fragmentation

> > On Tue, Jan 16, 2018 at 02:18:15PM +, Frediano Ziglio wrote: > > In order to use new TCP_CORK feature disable auto flush. > > 'the new TCP_CORK feature, disable auto flush' > Might be worth explaining in the commit log why you disable auto_flush > only for RedCommonGraphicsChannel. >

[Spice-devel] [PATCH spice-server 1/3] red-stream: Define interface for manual flush

The writing to network was always immediate. Every write in the stream causes a write to the OS. This can have some penalty if you don't write large data as network packets can be more fragmented or you encrypt data in smaller chunks (when data are encrypted some padding is added then data is

[Spice-devel] [PATCH spice-server 3/3] common-graphics-channel: Use manual flushing on stream to decrease packet fragmentation

In order to use the new TCP_CORK feature, disable auto flush. Depending on channel implementation and purpose of the channel enabling blindly for all channels could cause performance issues, specifically if flush is not done at the right time. CommonGraphicsChannel channels were tested to make

[Spice-devel] [PATCH spice-server 2/3] red-stream: Implements flush using TCP_CORK

Cork is a system interface implemented by Linux and some *BSD systems to tell the system that other data are expected to be written to a socket. This allows the system to reduce network fragmentation waiting for network packets to be complete. Using some replay capture and some instrumentation

Re: [Spice-devel] not clear how to use streaming agent

Hello Delin, On Thu, 2018-04-12 at 10:37 +0800, 孙得霖 wrote: > hi, > I use spice for remote view, I want to captures the guest video output, > encodes it and send through, so I choose streaming agent, how to build and > run it is not clear, can you help me? Sure, first off, what exactly do

[Spice-devel] [PATCH spice-gtk 1/4] gio-coroutine: Fix C inheritance

GConditionWaitSource should inherit from GSource so GSource should be the first field. Signed-off-by: Frediano Ziglio --- src/gio-coroutine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gio-coroutine.c b/src/gio-coroutine.c index c866e15..1322f01

[Spice-devel] [PATCH spice-gtk 0/4] Miscellaneous small patches

Frediano Ziglio (4): gio-coroutine: Fix C inheritance gio-coroutine: Make waitFuncs static gio-coroutine: Remove only assigned self field channel-display: Update debug message src/channel-display.c | 2 +- src/gio-coroutine.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-)

[Spice-devel] [PATCH spice-gtk 2/4] gio-coroutine: Make waitFuncs static

Signed-off-by: Frediano Ziglio --- src/gio-coroutine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gio-coroutine.c b/src/gio-coroutine.c index 1322f01..86623c3 100644 --- a/src/gio-coroutine.c +++ b/src/gio-coroutine.c @@ -118,7 +118,7 @@ static

[Spice-devel] [PATCH spice-gtk 3/4] gio-coroutine: Remove only assigned self field

Signed-off-by: Frediano Ziglio --- src/gio-coroutine.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gio-coroutine.c b/src/gio-coroutine.c index 86623c3..59ae06c 100644 --- a/src/gio-coroutine.c +++ b/src/gio-coroutine.c @@ -25,7 +25,6 @@ typedef struct

[Spice-devel] [PATCH spice-gtk 4/4] channel-display: Update debug message

The flags field in SpiceMsgSurfaceCreate does not only contains the primary flag. Signed-off-by: Frediano Ziglio --- src/channel-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-display.c b/src/channel-display.c index 2ea0922..5329ed0

Re: [Spice-devel] spice-window7 redirection of USB

Hi, On Fri, Apr 13, 2018 at 05:39:13PM +0800, dongzhen_...@nfs-china.com wrote: > HI，windows xp support USB redirection？ > thank you ！ GTK dropped support to windows xp a while back. > > > > dongzhen_...@nfs-china.com > > From: Victor Toso > Date: 2018-04-13 16:58 > To: dongzhen_hlj > CC:

Re: [Spice-devel] bad id bug in glz decoder

> Hi all, > Sorry to be a bother. > After a long time running of glz encode (approx. 4hrs), I came across > this error. > The higher bits (> 24) of the image id is truncated, which makes dist less > than id . This error seems to happen when the dist across (1<<24) Is normal that dist is less

[Spice-devel] [PATCH spice-gtk] gio-coroutine: Fix C inheritance

GConditionWaitSource should inherit from GSource so GSource should be the first field. Signed-off-by: Frediano Ziglio --- src/gio-coroutine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gio-coroutine.c b/src/gio-coroutine.c index c866e15..1322f01

[Spice-devel] [PATCH spice-gtk] gio-coroutine: Make waitFuncs static

Signed-off-by: Frediano Ziglio --- src/gio-coroutine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gio-coroutine.c b/src/gio-coroutine.c index 1322f01..86623c3 100644 --- a/src/gio-coroutine.c +++ b/src/gio-coroutine.c @@ -118,7 +118,7 @@ static

Re: [Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

> > Limited the installation of the driver to Windows 8 and up > in order to prevent false driver installation on unsupported OSes > which lead to BSODs. > > Signed-off-by: Basil Salman > Signed-off-by: Sameeh Jubran > --- > qxldod/qxldod.inx | 4 ++-- > 1

Re: [Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

> > Limited the installation of the driver to Windows 8 and up > in order to prevent false driver installation on unsupported OSes > which lead to BSODs. > > Signed-off-by: Basil Salman > Signed-off-by: Sameeh Jubran > --- > qxldod/qxldod.inx | 4 ++-- > 1