Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

2018-04-25 Thread Victor Toso
Ping On Fri, Apr 06, 2018 at 09:59:43AM +0200, Victor Toso wrote: > From: Victor Toso > > This reverts commit 291f3e4419e6fb4077ae43a5e09eb1c37b9dd729 > > Follow up patch should address rhbz#1399838 mentioned in commit above > in a different way. > > Major reason to revert is that the SpiceUsb

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

2018-04-25 Thread Frediano Ziglio
> > Ping > Looking back at the comments looks like this new set is still not doing the right thing and you agree, which is confusing to me. It's replacing a crash with a critical warning ignoring the problem. Well... maybe this is actually a progress. Maybe if you have an idea how it should beh

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

2018-04-25 Thread Victor Toso
Hi, On Wed, Apr 25, 2018 at 04:05:00AM -0400, Frediano Ziglio wrote: > > > > Ping > > > > Looking back at the comments looks like this new set is still > not doing the right thing and you agree, which is confusing to > me. Well, spice-session holds the reference to SpiceUsbDeviceManager and ha

[Spice-devel] lz decode error(spice-common)

2018-04-25 Thread GLODEN
0001-Fix-bug-of-lz-decode.patch Description: Binary data ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

2018-04-25 Thread Frediano Ziglio
> > Hi, > > On Wed, Apr 25, 2018 at 04:05:00AM -0400, Frediano Ziglio wrote: > > > > > > Ping > > > > > > > Looking back at the comments looks like this new set is still > > not doing the right thing and you agree, which is confusing to > > me. > > Well, spice-session holds the reference to S

Re: [Spice-devel] lz decode error(spice-common)

2018-04-25 Thread Frediano Ziglio
I think this recently was tested quite intensively. Which branch is this patch intended? Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

2018-04-25 Thread Victor Toso
Hi, On Wed, Apr 25, 2018 at 04:26:40AM -0400, Frediano Ziglio wrote: > > Besides avoiding regression... SpiceUsbDeviceManager is only > > initialized on UI objects in spice-gtk. That should be fixed > > at some point as non gtk tools like spicy-stats might do usb > > redirection. > > > > If this

Re: [Spice-devel] 回复: lz decode error(spice-common)

2018-04-25 Thread Frediano Ziglio
Probably what is missing in your code if you have that call is this: https://gitlab.com/spice/spice-common/commit/637621a9b99d2159b83272154b9d725cb7754e04 The canvas_fix_alignment call is not present in 0.12.8 version (or at least should not, probably you are using a patched version). Fredi

[Spice-devel] [RFC spice-gtk v3 0/1] Direct rendering

2018-04-25 Thread Snir Sheriber
Changes from v2 are mainly in the signal-handle path, now it works as follows: By default, spice-gst-decoder will be asking for the window handle, if the stream is indeed full-screen\streaming-mode stream a signal will be sent to the widget that will return (as part of the signal) the window handl

[Spice-devel] [RFC spice-gtk v3 1/1] Gstreamer: Use GstVideoOverlay if possible

2018-04-25 Thread Snir Sheriber
Currently when gstreamer is used to decode a full-screen stream sent from the server, the decoding frames are being forced to RBGA format and pushed using appsink to be scaled and rendered to screen. Today most of the gstreamer sinks supports the GstVideoOverlay interface which allows to render di

Re: [Spice-devel] [PATCH spice-gtk] tests: Shut up warnings about unitialized struct fields

2018-04-25 Thread Eduardo Lima (Etrunko)
On 25/04/18 01:44, Frediano Ziglio wrote: >> >> Build complains about lots of unitialized fields in TestCase definition, >> for instance: >> >> ../tests/session.c:276:11: warning: missing initializer for field ‘message’ >> of ‘TestCase {aka const struct }’ [-Wmissing-field-initializers] >>

Re: [Spice-devel] bad id bug in glz decoder

2018-04-25 Thread Frediano Ziglio
> Hi Ziglio, > I was wondering if you have had a chance to look at the email below yet. > Best regards, > Zhongqiang Huang Yes, weird, usually git CC people in the commit message, but see https://lists.freedesktop.org/archives/spice-devel/2018-April/043230.html this was acked and merged. C

[Spice-devel] how to debug spice-gtk on windows

2018-04-25 Thread Dingliguo
Hi , I compiled spice-gtk-0.33 and virt viewer with mingw32 , there is no pdb file, so how to debug when the process crash on windows? Thanks Ding - 本邮件及其附件含有新华三集团的