Re: [Spice-devel] Windows guest skipping chkdsk if using Spice display

2018-11-05 Thread Gionatan Danti
On 30/10/2018 16:20, Gionatan Danti wrote: Hi Frediano, it really seems related to the NumLock state, because: - with client NumLock enabled and spice connected, chkdsk is skipped; - with client NumLock enabled but spice not connected, chkdsk is not skipped; - with client NumLock not enabled,

Re: [Spice-devel] [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Gerd Hoffmann
Hi, > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > +if (qxl->id != 0) { > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > + "(first display device

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Frediano Ziglio
> > > 2. Have a single function as follows: > > > > void spice_qxl_set_device_info(QXLInstance *instance, > >const char *device_address, > >uint32_t device_display_id_start, > >uint32_t

Re: [Spice-devel] [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Frediano Ziglio
> > Hi, > > > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > > +if (qxl->id != 0) { > > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > > + "(first

Re: [Spice-devel] [libvirt-users] Windows guest skipping chkdsk if using Spice display

2018-11-05 Thread Erik Skultety
On Fri, Oct 26, 2018 at 09:13:59AM +0200, Gionatan Danti wrote: > On 19/10/2018 08:13, Gionatan Danti wrote: > > Il 17-10-2018 09:15 Gionatan Danti ha scritto: > > > Hi all, > > > as per subject, when a Windows guest using a Spice display is rebooted > > > with a planned chkdsk, the consistency

Re: [Spice-devel] [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Frediano Ziglio
> Hi, > > > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > > +if (qxl->id != 0) { > > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > > + "(first

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Gerd Hoffmann
On Mon, Nov 05, 2018 at 03:46:37AM -0500, Frediano Ziglio wrote: > > > > > 2. Have a single function as follows: > > > > > > void spice_qxl_set_device_info(QXLInstance *instance, > > >const char *device_address, > > >uint32_t

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Lukáš Hrázký
On Mon, 2018-11-05 at 03:46 -0500, Frediano Ziglio wrote: > > > > > 2. Have a single function as follows: > > > > > > void spice_qxl_set_device_info(QXLInstance *instance, > > >const char *device_address, > > >uint32_t

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Lukáš Hrázký
On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote: > > 2. Have a single function as follows: > > > > void spice_qxl_set_device_info(QXLInstance *instance, > >const char *device_address, > >uint32_t device_display_id_start, > >

Re: [Spice-devel] Windows guest skipping chkdsk if using Spice display

2018-11-05 Thread Frediano Ziglio
> On 30/10/2018 16:20, Gionatan Danti wrote: > > Hi Frediano, it really seems related to the NumLock state, because: > > > > - with client NumLock enabled and spice connected, chkdsk is skipped; > > - with client NumLock enabled but spice not connected, chkdsk is not > > skipped; > > - with

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Frediano Ziglio
> On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote: > > > 2. Have a single function as follows: > > > > > > void spice_qxl_set_device_info(QXLInstance *instance, > > >const char *device_address, > > >uint32_t

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Gerd Hoffmann
On Mon, Nov 05, 2018 at 01:18:57PM +0100, Lukáš Hrázký wrote: > On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote: > > > 2. Have a single function as follows: > > > > > > void spice_qxl_set_device_info(QXLInstance *instance, > > >const char *device_address, >

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Lukáš Hrázký
On Mon, 2018-11-05 at 14:08 +0100, Gerd Hoffmann wrote: > On Mon, Nov 05, 2018 at 01:18:57PM +0100, Lukáš Hrázký wrote: > > On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote: > > > > 2. Have a single function as follows: > > > > > > > > void spice_qxl_set_device_info(QXLInstance *instance, >

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Frediano Ziglio
> > On Mon, 2018-11-05 at 14:08 +0100, Gerd Hoffmann wrote: > > On Mon, Nov 05, 2018 at 01:18:57PM +0100, Lukáš Hrázký wrote: > > > On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote: > > > > > 2. Have a single function as follows: > > > > > > > > > > void

[Spice-devel] [RFC linux vdagent] Add POC for getting xrandr output from monitor ID

2018-11-05 Thread Jonathon Jongsma
This is just a proof of concept utility that takes a PCI device address and a monitor ID and finds the xrandr output associated with that monitor id. --- Changes in v2: - used different format for specifying the PCI address (pci/$domain/$dev.$fn) - used err()/errx() to report errors (from

Re: [Spice-devel] [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Gerd Hoffmann
Hi, > > I can see that it simplifies the logic in spice-server if we have a > > single function call instead of two. So we could deprecate > > spice_qxl_set_max_monitors() in favour of your > > spice_qxl_set_device_info() variant. > > > > spice_qxl_set_max_monitors() would then basically do