Re: [Spice-devel] [PATCH spice 0/2] small refactor of char-device buffer creation

2018-11-08 Thread Frediano Ziglio
> > Hello, > > this is a small refactor I did for the char-device write buffer > creation, in particular for creating a write buffer for the vd_agent. > > Of note, I didn't know how to test the smartcard and spicevmc codepaths, > I just assume they should be fine... > > Lukáš Hrázký (2): >

Re: [Spice-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-08 Thread Lukáš Hrázký
Hello, On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > Hi, > > > + * The device_display_id_{start,count} denotes the sequence of device > > display > > + * IDs that map to the zero-based sequence of monitor IDs provided by > > monitors > > + * config on this interface. For example

Re: [Spice-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-08 Thread Lukáš Hrázký
On Wed, 2018-11-07 at 16:01 -0600, Jonathon Jongsma wrote: > On Wed, 2018-11-07 at 11:49 +0100, Lukáš Hrázký wrote: > > Adds a function to let QEMU provide information to identify graphics > > devices and their monitors in the guest. The function > > (spice_qxl_set_device_info) sets the device

Re: [Spice-devel] [RFC PATCH vd_agent 3/3] Receive the graphics_device_info message

2018-11-08 Thread Frediano Ziglio
> > The graphics_device_info message contains the device display ID > information (device address and device display ID). Stores the data in a > hash table in vdagent. > > Signed-off-by: Lukáš Hrázký > --- > src/vdagent/vdagent.c| 69 >

Re: [Spice-devel] [RFC linux vdagent] Add POC for getting xrandr output from monitor ID

2018-11-08 Thread Lukáš Hrázký
Hello, On Mon, 2018-11-05 at 17:09 -0600, Jonathon Jongsma wrote: > This is just a proof of concept utility that takes a PCI device address > and a monitor ID and finds the xrandr output associated with that > monitor id. > --- > > Changes in v2: > - used different format for specifying the PCI

[Spice-devel] [PATCH spice-server] char-device: Remove initial underscores from __red_char_device_write_buffer_get

2018-11-08 Thread Frediano Ziglio
Just cosmetic changes, the static function had underscores to distinguish from the exported one which was recently renamed. Signed-off-by: Frediano Ziglio --- server/char-device.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/server/char-device.c

Re: [Spice-devel] [PATCH spice-server] test-display-base: Avoid spurious errors due to listen failures

2018-11-08 Thread Frediano Ziglio
ping > > To set up a listening socket usually you call in sequence: > - socket; > - bind; > - listen. > Usually if you try to listen to a post already in listening state > the bind will fail. However is possible that the listen will fail, > like in this sequence: > - socket 1; > - bind 1; > -

Re: [Spice-devel] [PATCH spice-server] char-device: Remove initial underscores from __red_char_device_write_buffer_get

2018-11-08 Thread Lukáš Hrázký
On Thu, 2018-11-08 at 08:53 +, Frediano Ziglio wrote: > Just cosmetic changes, the static function had underscores to > distinguish from the exported one which was recently renamed. > > Signed-off-by: Frediano Ziglio > --- > server/char-device.c | 19 +-- > 1 file changed, 9

Re: [Spice-devel] [RFC PATCH vd_agent 3/3] Receive the graphics_device_info message

2018-11-08 Thread Lukáš Hrázký
On Thu, 2018-11-08 at 05:18 -0500, Frediano Ziglio wrote: > > > > The graphics_device_info message contains the device display ID > > information (device address and device display ID). Stores the data in a > > hash table in vdagent. > > > > Signed-off-by: Lukáš Hrázký > > --- > >

[Spice-devel] spice-streaming-agent can't work correctly

2018-11-08 Thread wangjiedong
Recently I compile spice-protocol-0.12.15 and spice-server-0.14.1(--enable-lz4=yes --enable-gstreamer=yes --enable-smartcard=yes --with-sasl=yes) on host Ubuntu 18.04, and compile spice-protocol-0.12.15 and spice-streaming-agent-0.2 on guest VM. I use remote-viewer to connect guest VM , and

[Spice-devel] [PATCH spice-server] ci: Do not try to downgrade asciidoc anymore

2018-11-08 Thread Frediano Ziglio
Is not more necessary to downgrade asciidoc, the issue was fixed in Fedora 29, now used by CI. Signed-off-by: Frediano Ziglio -- See https://gitlab.freedesktop.org/fziglio/spice/pipelines/7888 (which contains other issues related to Fedora 29 but not this one) --- .gitlab-ci.yml | 1 - 1 file

Re: [Spice-devel] spice-streaming-agent can't work correctly

2018-11-08 Thread Lukáš Hrázký
Hello, On Thu, 2018-11-08 at 17:38 +0800, wangjiedong wrote: > Recently I compile spice-protocol-0.12.15 and > spice-server-0.14.1(--enable-lz4=yes --enable-gstreamer=yes > --enable-smartcard=yes --with-sasl=yes) on host Ubuntu 18.04, and compile > spice-protocol-0.12.15 and

Re: [Spice-devel] [PATCH spice-server] test-display-base: Avoid spurious errors due to listen failures

2018-11-08 Thread Jonathon Jongsma
On Thu, 2018-11-08 at 11:57 -0500, Frediano Ziglio wrote: > > > > On Mon, 2018-10-29 at 11:58 +, Frediano Ziglio wrote: > > > To set up a listening socket usually you call in sequence: > > > - socket; > > > - bind; > > > - listen. > > > Usually if you try to listen to a post already in

Re: [Spice-devel] [RFC PATCH spice 2/3] Send the graphics device info to the vd_agent

2018-11-08 Thread Jonathon Jongsma
On Wed, 2018-11-07 at 18:23 +0100, Lukáš Hrázký wrote: > Sends the device address and device display IDs to the vdagent. The > message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START > message or when the graphics device ino changes. typo: "ino"? Otherwise looks OK > >

Re: [Spice-devel] spice-streaming-agent can't work correctly

2018-11-08 Thread wangjiedong
Yes, display 2 is showing the same content as display 1. I use spice-streaming-agent with the goal that it can make the video more fluent and use less bandwidth, because in my condition classic SPICE can't do well with playing HD video and use high bandwidth. I think SPICE have resolution to

Re: [Spice-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-08 Thread Jonathon Jongsma
On Thu, 2018-11-08 at 11:05 +0100, Lukáš Hrázký wrote: > Hello, > > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > + * The device_display_id_{start,count} denotes the sequence of > > > device display > > > + * IDs that map to the zero-based sequence of monitor IDs >

Re: [Spice-devel] [PATCH spice-server] test-display-base: Avoid spurious errors due to listen failures

2018-11-08 Thread Jonathon Jongsma
On Mon, 2018-10-29 at 11:58 +, Frediano Ziglio wrote: > To set up a listening socket usually you call in sequence: > - socket; > - bind; > - listen. > Usually if you try to listen to a post already in listening state > the bind will fail. I find this sentence confusing... If you try to

Re: [Spice-devel] [PATCH spice-server] test-display-base: Avoid spurious errors due to listen failures

2018-11-08 Thread Frediano Ziglio
> > On Mon, 2018-10-29 at 11:58 +, Frediano Ziglio wrote: > > To set up a listening socket usually you call in sequence: > > - socket; > > - bind; > > - listen. > > Usually if you try to listen to a post already in listening state > > the bind will fail. > > I find this sentence confusing...

Re: [Spice-devel] [PATCH spice-server] ci: Do not try to downgrade asciidoc anymore

2018-11-08 Thread Jonathon Jongsma
I'm just trusting you that CI is using f29 ;) Acked-by: Jonathon Jongsma On Thu, 2018-11-08 at 08:59 +, Frediano Ziglio wrote: > Is not more necessary to downgrade asciidoc, the issue was fixed > in Fedora 29, now used by CI. > > Signed-off-by: Frediano Ziglio > -- > See

Re: [Spice-devel] [RFC PATCH spice-protocol 1/3] Add a graphics device info message

2018-11-08 Thread Jonathon Jongsma
On Wed, 2018-11-07 at 18:23 +0100, Lukáš Hrázký wrote: > The message serves for passing the device address and device display > ID "serves for passing..." is a little strange to my ear. "serves to pass..." sounds OK. Or "is used for passing..." > information for all display channels from SPICE