[Spice-devel] [linux/vd-agent] vdagent: Do not send empty screen resolution messages

2018-11-15 Thread Victor Toso
From: Victor Toso Easier to trigger on Wayland guest by running > xrandr --output XWAYLAND0 --rotate left In current master, this causes the spice-vdagentd to disconnect from the client. In 0.18 branch (latest release), mouse becomes unusable as mentioned in the referred bug below. Resolves:

Re: [Spice-devel] [PATCH spice-gtk v2] channel-display-mjpeg: Fix encoding for big endian machines

2018-11-15 Thread Victor Toso
On Fri, Nov 02, 2018 at 09:38:12AM +, Frediano Ziglio wrote: > Make sure components are ordered in the same way in memory. > This was tested with a virtual MIPS machine. > > Signed-off-by: Frediano Ziglio > --- > src/channel-display-mjpeg.c | 4 > 1 file changed, 4 insertions(+) > >

Re: [Spice-devel] [PATCH spice-gtk v2] channel-display-mjpeg: Fix encoding for big endian machines

2018-11-15 Thread Frediano Ziglio
> > On Fri, Nov 02, 2018 at 09:38:12AM +, Frediano Ziglio wrote: > > Make sure components are ordered in the same way in memory. > > This was tested with a virtual MIPS machine. > > > > Signed-off-by: Frediano Ziglio > > --- > > src/channel-display-mjpeg.c | 4 > > 1 file changed, 4

[Spice-devel] [PATCH spice-gtk v3] channel-display-mjpeg: Fix encoding for big endian machines

2018-11-15 Thread Frediano Ziglio
Make sure components are ordered in the same way in memory. This was tested with a virtual MIPS machine. Signed-off-by: Frediano Ziglio --- src/channel-display-mjpeg.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Changes since v2: - use if instead of #if, compile all code and

Re: [Spice-devel] [linux/vd-agent] vdagent: Do not send empty screen resolution messages

2018-11-15 Thread Frediano Ziglio
> > From: Victor Toso > > Easier to trigger on Wayland guest by running > > > xrandr --output XWAYLAND0 --rotate left > > In current master, this causes the spice-vdagentd to disconnect from > the client. In 0.18 branch (latest release), mouse becomes unusable as > mentioned in the referred

[Spice-devel] [PATCH] x11-randr: Fix typo in error message

2018-11-15 Thread Frediano Ziglio
The function name is XRRGetScreenSizeRange not RRGetScreenSizeRange. Signed-off-by: Frediano Ziglio --- src/vdagent/x11-randr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vdagent/x11-randr.c b/src/vdagent/x11-randr.c index c5fba51..be6a43a 100644 ---

[Spice-devel] [PATCH] udscs: Avoid file descriptor leak

2018-11-15 Thread Frediano Ziglio
If connection fails the socket descriptor is not closed causing a leak. Signed-off-by: Frediano Ziglio --- src/udscs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/udscs.c b/src/udscs.c index 62abc97..7fe74b9 100644 --- a/src/udscs.c +++ b/src/udscs.c @@ -119,6 +119,7 @@ struct

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

2018-11-15 Thread wangjiedong
Hi , I'm using spice web client because of your introduction.i have some questions to ask for help. i configure webcocket with command "python2-websockify 5959 192.168.84.203:5900" , then if i use url "http://192.168.84.203/spice-web-client/index.html?host=192.168.84.203=5959;, if failed

[Spice-devel] [PATCH spice-gtk] channel-display-gst: Fix typo in comment

2018-11-15 Thread Frediano Ziglio
gstvideoooverlay -> gstvideooverlay Signed-off-by: Frediano Ziglio --- src/channel-display-gst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c index c909e206..2c07f350 100644 --- a/src/channel-display-gst.c +++

Re: [Spice-devel] [PATCH spice-gtk] channel-display-gst: Fix typo in comment

2018-11-15 Thread Victor Toso
On Thu, Nov 15, 2018 at 08:53:13AM +, Frediano Ziglio wrote: > gstvideoooverlay -> gstvideooverlay > > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso > --- > src/channel-display-gst.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-display-gst.c

Re: [Spice-devel] [PATCH spice-gtk v2] channel-display-mjpeg: Fix encoding for big endian machines

2018-11-15 Thread Frediano Ziglio
ping > > Make sure components are ordered in the same way in memory. > This was tested with a virtual MIPS machine. > > Signed-off-by: Frediano Ziglio > --- > src/channel-display-mjpeg.c | 4 > 1 file changed, 4 insertions(+) > > Changes since v1: > - fix typo in commit message title >

Re: [Spice-devel] [PATCH spice-server] red-replay-qxl: Remove useless end of line

2018-11-15 Thread Frediano Ziglio
ping > > spice_debug already add a end of line. > > Signed-off-by: Frediano Ziglio > --- > server/red-replay-qxl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c > index bd33b581..6958a495 100644 > ---