Re: [Spice-devel] [PATCH spice-server] char-device: Fix some comments

2019-06-02 Thread Snir Sheriber
Acked-by: Snir Sheriber On 5/31/19 7:52 AM, Frediano Ziglio wrote: Some function names where changed. Signed-off-by: Frediano Ziglio --- server/char-device.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/char-device.h b/server/char-device.h index 62d2fa61

Re: [Spice-devel] [PATCH spice-server 1/3] spicevmc: Reuse "sin" variable

2019-06-02 Thread Snir Sheriber
ack On 6/1/19 3:14 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index 460edb04f..84bbb73c2 100644 --- a/server/spicevmc.c +++ b/server/spicevmc.c @@ -7

Re: [Spice-devel] [PATCH v3 spice-gtk] Adjust to window scaling

2019-06-02 Thread Snir Sheriber
Hi, On 5/27/19 8:29 PM, Marc-André Lureau wrote: Hi On Mon, May 27, 2019 at 10:04 AM Snir Sheriber wrote: When GDK_SCALE is != 1 and egl is used, the image presented does not fit to the window (scale of 2 is often used with hidpi monitors). Usually this is not a problem since all components

Re: [Spice-devel] [PATCH spice-server 2/3] spicevmc: Do not use RedCharDevice pipe items handling

2019-06-02 Thread Uri Lublin
On 6/1/19 3:14 PM, Frediano Ziglio wrote: As we don't use any token there's no reason to not queue directly instead of passing through RedCharDevice. This will make easier to limit the queue which currently is unlimited. Hi, If we need flow control, how difficult would it be to add support for

[Spice-devel] [PATCH spice-server] smartcard-channel-client: Fix some typos in a comment

2019-06-02 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/smartcard-channel-client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c index e22b39adf..e462401e0 100644 --- a/server/smartcard-channel-client.c +++ b/ser

[Spice-devel] [PATCH spice-server] red-parse-qxl: Reset mask attributes if brush image is missing

2019-06-02 Thread Frediano Ziglio
The attributes in this case are not used to apply the mask. Doing so avoid sending garbage from the guest which usually don't initialise the memory in case the mask is missing. Guest should have cleared these bytes by its own however doing so on the server fixes the problem too. Considering that th

[Spice-devel] [PATCH spice-server v2 1/2] char-device: Don't use RedClient API

2019-06-02 Thread Frediano Ziglio
RedClient was an opaque structure for RedCharDevice. It started to be used when RedsState started to contain all the global state. Make it opaque again using a new RedCharDeviceClientOpaque. The RedCharDeviceClientOpaque define in the header allows users of the class to override the type to get a m

[Spice-devel] [PATCH spice-server v2 2/2] smartcard: Use RedChannelClient as the type for RedCharDevice client

2019-06-02 Thread Frediano Ziglio
As now is an opaque type for RedCharDevice use the type that better suits us. This avoid useless conversions or look ups. Signed-off-by: Frediano Ziglio --- server/smartcard-channel-client.c | 5 +++-- server/smartcard.c| 16 2 files changed, 11 insertions(+), 1