On 9/1/19 7:20 PM, Frediano Ziglio wrote:
If name is null num_entries may hold garbage value
clang warning: Assigned value is garbage or undefined
g_assert_cmpint(num_entries, ==, entry_count);
^
Also check name before num_entries.
Why
This patch enables the SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE
capability for the stream-channel.
video_stream_parse_preferred_codecs: new function for parsing the
SPICE protocol message. This code used to in inside
dcc_handle_preferred_video_codec_type.
struct
>
> This patch enables the SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE
> capability for the stream-channel.
>
> video_stream_parse_preferred_codecs: new function for parsing the
> SPICE protocol message. This code used to in inside
> dcc_handle_preferred_video_codec_type.
>
> struct
>
> This patch enables the SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE
> capability for the stream-channel.
>
> video_stream_parse_preferred_codecs: new function for parsing the
> SPICE protocol message. This code used to in inside
> dcc_handle_preferred_video_codec_type.
>
> struct
This patch enables the SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE
capability for the stream-channel.
video_stream_parse_preferred_codecs: new function for parsing the
SPICE protocol message. This code used to in inside
dcc_handle_preferred_video_codec_type.
struct
Hi,
On Thu, Jul 25, 2019 at 02:43:53PM +0100, Frediano Ziglio wrote:
> They were the same structure.
Right, the changes in the design made this happen.
Patch seems fine but you might need to rebase, I couldn't apply
it cleanly. Really sorry for the delay.
> Signed-off-by: Frediano Ziglio
>
Allows to remove _SpiceUsbDevice structure.
_SpiceUsbDevice is only caching this value from SpiceUsbBackendDevice.
Signed-off-by: Frediano Ziglio
---
src/usb-backend.c | 9 +
1 file changed, 9 insertions(+)
Changes since v1:
- use bool instead of bit fields
diff --git
Report directly value from SpiceUsbBackendDevice.
Signed-off-by: Frediano Ziglio
---
src/usb-device-manager.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index b3db5de6..b85b20de 100644
--- a/src/usb-device-manager.c
They were the same structure.
Signed-off-by: Frediano Ziglio
---
src/usb-backend.c| 6 +++---
src/usb-backend.h| 6 +++---
src/usb-device-manager.c | 42 +++-
3 files changed, 17 insertions(+), 37 deletions(-)
diff --git a/src/usb-backend.c
>
> Hi,
>
> On Thu, Jul 25, 2019 at 02:43:51PM +0100, Frediano Ziglio wrote:
> > Allows to remove _SpiceUsbDevice structure.
> > _SpiceUsbDevice is only caching this value from SpiceUsbBackendDevice.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/usb-backend.c | 9 +
> > 1
Acked-by: Thomas Zimmermann
Am 02.09.19 um 14:41 schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann
> ---
> drivers/gpu/drm/qxl/qxl_drv.h| 1 +
> drivers/gpu/drm/qxl/qxl_object.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_drv.h
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
This is required to switch from GST video decoding to native MJPEG
decoding, otherwise the gst-area remained on top and the MJPEG video
stream was never shown.
From: Victor Toso
This means we can drop gstvideo_init() function and replace its calls
with gst_is_initialized().
A small code refactor was done in spice_gstaudio_new() to make a early
return on error.
Signed-off-by: Victor Toso
---
src/spice-gstaudio.c | 59
From: Victor Toso
GStreamer is required since v0.36 with 83ab7ca "build-sys: drop
gstvideo option, make it required" in 2019-01-15 by Marc-André Lureau
Both channel-display-gst.c and spice-gstaudio.c have to double check
that GStreamer was initialized with gst_init_check() but this can be
done
From: Victor Toso
Let's gst_deinit() if we initialize it for the same rationale pointed out
in 0381e62 "spicy: Add call of gst_deinit at program exit" in
2017-10-20 by Christophe de Dinechin
Signed-off-by: Victor Toso
---
src/spice-session.c | 8
1 file changed, 8 insertions(+)
From: Victor Toso
Does not work properly just because gst_is_initialized() checks if
gst_init() or gst_check_init() was ever called but it does not
consider if gst_deinit() was called too. I'm sending this RFC to check
if should be added or wait till feedback on upstream about the API,
that is,
From: Victor Toso
Hi,
Considering that we depend on GStreamer, let's move the initialization
to SpiceSession so we can guarantee one init and one deinit on spice-gtk
level. Works as well if gst_init() was called outside spice-gtk.
Tested with spicy which does call gst_init() and gst_deinit()
From: Victor Toso
> 184 bytes in 1 blocks are definitely lost in loss record 12,668 of 14,231
>at 0x483880B: malloc (vg_replace_malloc.c:309)
>by 0x4A64C98: g_malloc (in /usr/lib64/libglib-2.0.so.0.6000.6)
>by 0x4A7CFB5: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.6000.6)
>
From: Victor Toso
This means we can drop gstvideo_init() function and replace its calls
with gst_is_initialized().
Signed-off-by: Victor Toso
---
src/channel-display-gst.c | 23 +--
1 file changed, 5 insertions(+), 18 deletions(-)
diff --git a/src/channel-display-gst.c
Switch qxl to use drm_gem_object_funcs callbacks
instead of drm_driver callbacks.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/qxl/qxl_drv.c| 8
drivers/gpu/drm/qxl/qxl_object.c | 12
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git
This patch seems unrelated.
Am 02.09.19 um 14:41 schrieb Gerd Hoffmann:
> Switch qxl to use drm_gem_object_funcs callbacks
> instead of drm_driver callbacks.
>
> Signed-off-by: Gerd Hoffmann
> ---
> drivers/gpu/drm/qxl/qxl_drv.c| 8
> drivers/gpu/drm/qxl/qxl_object.c | 12
Frediano Ziglio writes:
>>
>> Frediano Ziglio writes:
>>
>> >>
>> >> It's slightly better, but I was more thinking about adding (later) a
>> >> comment to spice_usbredir_write_callback, in order to indicate that it
>> >> does NOT deal with the HELLO packet, i.e. that the data processing logic
>>
Hi,
On Thu, Jul 25, 2019 at 02:43:51PM +0100, Frediano Ziglio wrote:
> Allows to remove _SpiceUsbDevice structure.
> _SpiceUsbDevice is only caching this value from SpiceUsbBackendDevice.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/usb-backend.c | 9 +
> 1 file changed, 9
Hi,
On Fri, Aug 30, 2019 at 09:54:18AM -0400, Frediano Ziglio wrote:
> ping
>
> >
> > ping
> >
> > >
> > > ping
> > >
> > > >
> > > > ping
> > > >
> > > > >
> > > > > ping
> > > > >
> > > > > >
> > > > > > ping the series
I swear I was testing this last week and it seemed fine but
On Mon, Sep 02, 2019 at 11:35:20AM +0100, Frediano Ziglio wrote:
> They were the same structure.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/usb-backend.c| 6 +++---
> src/usb-backend.h| 6 +++---
> src/usb-device-manager.c | 42 +++-
> 3
Hi,
On 8/29/19 7:17 PM, Frediano Ziglio wrote:
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
This is required to switch from GST video decoding to native MJPEG
decoding, otherwise the gst-area remained
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/qxl/qxl_drv.h| 1 +
drivers/gpu/drm/qxl/qxl_object.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 9e034c5fa87d..d4051409ce64 100644
---
Frediano Ziglio writes:
>> Frediano Ziglio writes:
>>
>> > Do not use G_GUINT32_FORMAT.
>> > We support a minimum of 32 bit architectures.
>>
>> What was wrong with the old code?
>>
>
> Shorter and easier to read. I mean '%u' and '%" G_GUINT32_FORMAT "',
> if you have an issue is harder to get
28 matches
Mail list logo
