Re: [Spice-devel] [PATCH 1/1] client: add verbose link error messages

2010-10-25 Thread Hans de Goede
Ack. On 10/25/2010 02:19 PM, Alon Levy wrote: --- client/red_channel.cpp | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/client/red_channel.cpp b/client/red_channel.cpp index 54caccf..273b28d 100644 --- a/client/red_channel.cpp +++ b/client/red_cha

[Spice-devel] [PATCH 1/1] client: add verbose link error messages

2010-10-25 Thread Alon Levy
--- client/red_channel.cpp | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/client/red_channel.cpp b/client/red_channel.cpp index 54caccf..273b28d 100644 --- a/client/red_channel.cpp +++ b/client/red_channel.cpp @@ -42,6 +42,23 @@ RedChannelBase::~RedCha

Re: [Spice-devel] [PATCH] vdagent-x11: reopen tablet on resolution change to register new resolution

2010-10-25 Thread Alon Levy
On Mon, Oct 25, 2010 at 11:44:08AM +0200, Hans de Goede wrote: > Ok, > > On 10/25/2010 10:48 AM, Alon Levy wrote: > >On Mon, Oct 25, 2010 at 09:30:02AM +0200, Hans de Goede wrote: > >>Hi, > >> > >>On 10/24/2010 03:13 PM, Alon Levy wrote: > >>>The tablet uinput device is closed and opened by vdagen

Re: [Spice-devel] [PATCH] spicec-win: remove redundent strdup & buggy free

2010-10-25 Thread Uri Lublin
On 10/25/2010 12:03 PM, Arnon Gilboa wrote: text refered a substr of item_dup and was used after free(item_dup). no need to strdup, we can destroy the resource string. ACK. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.fr

[Spice-devel] [PATCH spice 1/1] spicec-tests: add controller_test (v2)

2010-10-25 Thread Arnon Gilboa
use chars for title & menu instead of wchars --- client/tests/controller_test/build |4 + client/tests/controller_test/controller_test.cpp | 202 client/tests/controller_test/controller_test.sln | 20 ++ .../tests/controller_test/controller_test.vcpr

Re: [Spice-devel] [PATCH 1/4] spicec-tests: add controller_test

2010-10-25 Thread Arnon Gilboa
ignore this one Arnon Gilboa wrote: --- client/tests/controller_test/build |4 + client/tests/controller_test/controller_test.cpp | 201 client/tests/controller_test/controller_test.sln | 20 ++ .../tests/controller_test/controller_test.vcproj |

[Spice-devel] [PATCH 1/4] spicec-tests: add controller_test

2010-10-25 Thread Arnon Gilboa
--- client/tests/controller_test/build |4 + client/tests/controller_test/controller_test.cpp | 201 client/tests/controller_test/controller_test.sln | 20 ++ .../tests/controller_test/controller_test.vcproj | 198 +++ 4 files chan

[Spice-devel] [PATCH] spicec-win: remove redundent strdup & buggy free

2010-10-25 Thread Arnon Gilboa
text refered a substr of item_dup and was used after free(item_dup). no need to strdup, we can destroy the resource string. --- client/controller.cpp |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/client/controller.cpp b/client/controller.cpp index eabbcd4..cf06aa

Re: [Spice-devel] [PATCH] vdagent-x11: reopen tablet on resolution change to register new resolution

2010-10-25 Thread Hans de Goede
Ok, On 10/25/2010 10:48 AM, Alon Levy wrote: On Mon, Oct 25, 2010 at 09:30:02AM +0200, Hans de Goede wrote: Hi, On 10/24/2010 03:13 PM, Alon Levy wrote: The tablet uinput device is closed and opened by vdagentd as a result of guest_xorg_res. So far this message was only sent on startup of vd

Re: [Spice-devel] [PATCH spice] controller: Make menu text utf-8

2010-10-25 Thread Arnon Gilboa
Ack, and also revealed another bug for which I'll send a patch in a few moments. Hans de Goede wrote: We are making all text send over the controller socket utf-8, rather then having somethings as 8 bit (hostname) and others (title, menu) unicode16, this patch completes this change by convertin

Re: [Spice-devel] [PATCH spice-protocol] controller: Make all text utf-8

2010-10-25 Thread Arnon Gilboa
ack Hans de Goede wrote: We are making all text send over the controller socket utf-8, rather then having somethings as 8 bit (hostname) and others unicode16. Adjust the CONTROLLER_MENU_*_DELIMITER defines for this. --- spice/controller_prot.h |4 ++-- 1 files changed, 2 insertions(+), 2 d

Re: [Spice-devel] [PATCH] vdagent-x11: reopen tablet on resolution change to register new resolution

2010-10-25 Thread Alon Levy
On Mon, Oct 25, 2010 at 09:30:02AM +0200, Hans de Goede wrote: > Hi, > > On 10/24/2010 03:13 PM, Alon Levy wrote: > >The tablet uinput device is closed and opened by vdagentd as a result of > >guest_xorg_res. > >So far this message was only sent on startup of vdagent. Unless we resend it > >uinpu

Re: [Spice-devel] [PATCH spice 1/1] spicec-win: map title string from utf8 to utf16

2010-10-25 Thread Arnon Gilboa
Hans de Goede wrote: Hi, On 10/24/2010 05:54 PM, Arnon Gilboa wrote: Fix win client broken by the utf8 patch. --- client/windows/red_window.cpp | 9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/client/windows/red_window.cpp b/client/windows/red_window.cpp index 8248

Re: [Spice-devel] [PATCH] vdagent-x11: reopen tablet on resolution change to register new resolution

2010-10-25 Thread Hans de Goede
Hi, On 10/24/2010 03:13 PM, Alon Levy wrote: The tablet uinput device is closed and opened by vdagentd as a result of guest_xorg_res. So far this message was only sent on startup of vdagent. Unless we resend it uinput doesn't know of the changed resolution, and the mouse position in the guest

Re: [Spice-devel] [PATCH spice 1/1] spicec-win: map title string from utf8 to utf16

2010-10-25 Thread Hans de Goede
Hi, On 10/24/2010 05:54 PM, Arnon Gilboa wrote: Fix win client broken by the utf8 patch. --- client/windows/red_window.cpp |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/client/windows/red_window.cpp b/client/windows/red_window.cpp index 8248aee..145f6b2 1006