This breaks opengl compilation, I'll send a fixed patch
On Fri, Apr 22, 2011 at 06:43:08PM +0200, Christophe Fergeau wrote:
---
common/glc.c |8
common/rop3.c |8 ++--
common/spice_common.h |2 ++
3 files changed, 4 insertions(+), 14 deletions(-)
On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote:
Also I've attached the patch which fixes a few things here and there... With
this it builds fine.
Can you clean up the commenting out part of the patch (Makefile.am you comment
out a single line, you can probably ifdef it based on
Hi all,
I finally decided to give a try to the gtk version of spice client. First, I
have to say that I'm quite impressed (and I understand why it tends to become
the baseline client).
Still, there is one bug that I would consider blocking (as far as I'm
concerned) : I'm pretty used to the
On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy al...@redhat.com wrote:
On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote:
Hi,
I started to see frequent crashes with my guests running windows xp and
windows server 2003 x86. The bsod appears on qxldd.dll. I can give
further
On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote:
Also I've attached the patch which fixes a few things here and there... With
this it builds fine.
Ah, so you've already built spice-gtk on macosx? How well did it work?
I had some questions about your patch, it would be really
Yep,it's really nasty.
But if I want to leverage FULL spice image ability,I have to:
1.Fix the bugs of sigbus in quic.c on Android by rewriting the
pointer-type-cast into memcpy.etc..
2.Then,then,I got the processed image buffer in memory,BUT,HOW can I output
it??? AFAIK,android offer no image
I finally build it on OSX 10.6.6 successfully :-)
From the patches below I only used :
common/lines.c
gtk/Makefile.am
Then a
./configure --with-audio=gstreamer --without-python
--with-coroutine=gthread
did the trick, I think --with-coroutine=gthread avoid the _XOPEN_SOURCE
patches.
Best
On Tue, Apr 26, 2011 at 05:10:43PM +0200, Kai Mosebach wrote:
I just triesbuild the OSX gtk client, my findings :
1.) Installed gtk2 and gstreamer via ports
Do you get a gtk2 version using x11 or the native osx port when you get
it from (mac?)ports ?
Christophe
pgp3ZllVEhXHR.pgp
Regarding the native gtk2 build I think its not possible with macports.
You would need to use this I guess : http://gtk-osx.sourceforge.net/
Cheers Kai
On 4/27/11 11:18 AM, Christophe Fergeau cferg...@redhat.com wrote:
On Tue, Apr 26, 2011 at 05:10:43PM +0200, Kai Mosebach wrote:
I just
On Wed, Apr 27, 2011 at 04:54:55PM +0800, Shuxiang Lim wrote:
Yep,it's really nasty.
But if I want to leverage FULL spice image ability,I have to:
1.Fix the bugs of sigbus in quic.c on Android by rewriting the
pointer-type-cast into memcpy.etc..
No idea what the problem is, is it a compile
On Wed, Apr 27, 2011 at 12:38:04PM +0400, Emre Erenoglu wrote:
On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy al...@redhat.com wrote:
On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote:
Hi,
I started to see frequent crashes with my guests running windows xp and
windows
On Wed, Apr 27, 2011 at 11:27:53AM +0200, Kai Mosebach wrote:
Regarding the native gtk2 build I think its not possible with macports.
You would need to use this I guess : http://gtk-osx.sourceforge.net/
yes, trying out http://sourceforge.net/apps/trac/gtk-osx/wiki/Build is part
of my medium
?
Christophe
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL:
http://lists.freedesktop.org/archives/spice-devel/attachments/20110427/3b
fdde35/attachment-0001.pgp
Hello spice-devel@lists.freedesktop.org,
Kai Mosebach kai.moseb...@bsse.ethz.ch has stored a file on our server for
you to download. File information appears below.
From: Kai Mosebach
Email:kai.moseb...@bsse.ethz.ch
The file
Please note that these are the libs + the client only and they rely on
working versions of the depending libs (such as gstreamer etc)
To find out where it expects what you can run
$ otool -L libspice-client-glib-2.0.2.dylib
(ldd equivalent in osx)
Cheers Kai
On 4/27/11 11:51 AM, Kai Mosebach
On Wed, Apr 27, 2011 at 10:38 AM, Emre Erenoglu ereno...@gmail.com wrote:
On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy al...@redhat.com wrote:
On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote:
Hi,
I started to see frequent crashes with my guests running windows xp and
For this you should have a working build process and then write some
after processing script which packs things together automatically (such
as the binaries below) + all needed libs and the throw it into a pkg or
dmg automatically. It'd be a nice to have but surely takes more than some
minutes ...
On Wed, Apr 27, 2011 at 2:00 PM, Gianluca Cecchi
gianluca.cec...@gmail.comwrote:
On Wed, Apr 27, 2011 at 10:38 AM, Emre Erenoglu ereno...@gmail.com
wrote:
On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy al...@redhat.com wrote:
On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote:
On Wed, Apr 27, 2011 at 12:00:34PM +0200, Gianluca Cecchi wrote:
On Wed, Apr 27, 2011 at 10:38 AM, Emre Erenoglu ereno...@gmail.com wrote:
On Wed, Apr 27, 2011 at 12:07 PM, Alon Levy al...@redhat.com wrote:
On Wed, Apr 27, 2011 at 01:16:01AM +0400, Emre Erenoglu wrote:
Hi,
I
On Tue, Jan 25, 2011 at 07:17:20PM +0100, Marc-André Lureau wrote:
This patch make it easier to spot warnings in compilation. It should
work with older versions of automake that don't support silent rules.
This one was already applied in 0e64e2d0 in November
Christophe
pgpJjjGKTG7sS.pgp
Why do you want to require c99? Do the compilers we use on windows have
good enough c99 support?
Christophe
On Tue, Jan 25, 2011 at 07:17:21PM +0100, Marc-André Lureau wrote:
---
configure.ac |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure.ac
On Tue, Jan 25, 2011 at 07:17:22PM +0100, Marc-André Lureau wrote:
This patch has not been verified. Somebody with VS should check if it
still compiles and run fine before applying it.
Making gdi_handlers makes a lot of sense to me. I couldn't find on google
or with git grep anything that would
On Tue, Jan 25, 2011 at 07:17:25PM +0100, Marc-André Lureau wrote:
diff --git a/common/mem.c b/common/mem.c
index b0a7eb1..4db8a2c 100644
--- a/common/mem.c
+++ b/common/mem.c
@@ -71,6 +71,10 @@ void *spice_memdup(const void *mem, size_t n_bytes)
{
void *copy;
+if (mem ==
- Original Message -
Why do you want to require c99? Do the compilers we use on windows
have
good enough c99 support?
Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, // comments,
...
Actually, I wonder if 43c5b4f97334f0f4ca61bdd679b68d079575deac is redundant if
we
- Original Message -
On Tue, Jan 25, 2011 at 07:17:25PM +0100, Marc-André Lureau wrote:
diff --git a/common/mem.c b/common/mem.c
index b0a7eb1..4db8a2c 100644
--- a/common/mem.c
+++ b/common/mem.c
@@ -71,6 +71,10 @@ void *spice_memdup(const void *mem, size_t
n_bytes)
{
On Wed, Apr 27, 2011 at 07:22:34AM -0400, Marc-André Lureau wrote:
- Original Message -
Why do you want to require c99? Do the compilers we use on windows
have
good enough c99 support?
Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, //
comments, ...
On Wed, Apr 27, 2011 at 02:06:48PM +0200, Christophe Fergeau wrote:
On Wed, Apr 27, 2011 at 07:27:18AM -0400, Marc-André Lureau wrote:
Sigh.. i would prefer to avoid ASSERT, and instead use return_val_if_fail()
or so.
That's probably why I didn't add it in the first place.
The old
Hi
On Wed, Apr 27, 2011 at 11:19 AM, Christophe Fergeau
cferg...@redhat.com wrote:
I've sent a merge request, so hopefully it will get upstream soon :)
Merged a few hours ago.
thanks
--
Marc-André Lureau
___
Spice-devel mailing list
On Tue, Jan 25, 2011 at 02:33:34PM -0500, Marc-André Lureau wrote:
Hi
+static inline unsigned int ring_get_length(Ring *ring)
This won't compile if no one uses it - so you probably want to make
it non static (or do a hack by doing (void)ring_get_length somewhere).
Correct, if you
- Original Message -
On Tue, Jan 25, 2011 at 02:33:34PM -0500, Marc-André Lureau wrote:
Hi
+static inline unsigned int ring_get_length(Ring *ring)
This won't compile if no one uses it - so you probably want to
make
it non static (or do a hack by doing
Hi
On Thu, Apr 21, 2011 at 2:00 PM, Christophe Fergeau cferg...@redhat.com wrote:
Hi,
The autotools build system looked a bit convoluted when I looked at it,
and after toying a bit with it when preparing the earlier patchset, it
seemed more fragile than autotools build systems generally are.
On Wed, Apr 27, 2011 at 10:24:01AM -0400, Marc-André Lureau wrote:
Do you mean it should be #ifdef'ed? or that it's better to add the
equivalent of G_GNUC_UNUSED to the function definition to avoid the
compiler
warning?
Is there such warning? I was expecting unused inline functions not
---
src/qxl.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 60a1046..9451d05 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -20,6 +20,9 @@
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
+#ifndef QXL_H
---
src/qxl_mem.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qxl_mem.c b/src/qxl_mem.c
index bce80ad..705eb83 100644
--- a/src/qxl_mem.c
+++ b/src/qxl_mem.c
@@ -18,7 +18,7 @@ qxl_mem_create (void *base,
if (!mem)
goto out;
Add a qxl_screen_t* member to qxl_ring to make generelizing outb to
ioport_write easier in the next patch. This means we do an extra deref
and addition for every outb, but it means the code becomes simpler for
doing outb in qxl_drv.so and a function call for spiceqxl_drv.so
---
src/qxl.h|
replace everywhere it is needed for xspice - places left out are ifdefed
out later based on the same define mentioned in qxl.h, XSPICE.
note: leave spaces between function name and open paren?
note2: ioport_write is added at the end of the file because the xspice
implementation
will need access
---
src/qxl_driver.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index a0aea25..ee6b892 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -908,13 +908,13 @@ qxl_screen_init(int scrnIndex, ScreenPtr pScreen, int
argc,
used in qxl_reset. Later ifdefed with XSPICE, which only uses a single
slot covering all memory (really it should just avoid calling the translation
mechanism, but for now this is simple enough).
---
src/qxl_driver.c | 87 ++
1 files changed,
---
src/qxl_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 3514360..dced9fb 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -60,7 +60,7 @@ qxl_garbage_collect (qxl_screen_t *qxl)
union
---
src/qxl.h| 10 ++
src/qxl_driver.c |6 ++
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 9683966..7c889d3 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -82,6 +82,14 @@ typedef struct
typedef struct qxl_surface_t
qxl_map_memory_helper and qxl_unmap_memory_helper introduced, here as
a simple split, later different implementation if XSPICE defined will
be added. Nicer then putting an ifdef inside the map/unmap functions.
---
src/qxl_driver.c | 52
1
removing whitespace in lines consisting only of it.
most of those areas are touched later, but not all.
---
src/qxl_driver.c | 50 +-
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index
---
configure.ac|2 ++
src/Makefile.am | 23 +++
2 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 99bc517..6a183df 100644
--- a/configure.ac
+++ b/configure.ac
@@ -86,6 +86,8 @@ PKG_CHECK_MODULES([SPICE], [spice-server
Fixes a few places that have hardcoded qxl to use the already defined
QXL_DRIVER_NAME.
---
src/qxl.h|5 +
src/qxl_driver.c |6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 7c889d3..ba2b0eb 100644
--- a/src/qxl.h
+++
---
src/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 8f048c8..6f2cb56 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -53,7 +53,7 @@ spiceqxl_drv_la_LTLIBRARIES = spiceqxl_drv.la
spiceqxl_drv_la_LDFLAGS =
---
src/qxl.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index e45066c..3fddef3 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -28,6 +28,7 @@
#include stdint.h
#include spice/qxl_dev.h
+
#include compiler.h
#include xf86.h
#if
---
src/qxl_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index ba3170e..198af00 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1115,7 +1115,7 @@ qxl_check_device(ScrnInfoPtr pScrn, qxl_screen_t *qxl)
---
src/qxl_driver.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 198af00..548bc15 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -424,6 +424,9 @@ qxl_reset (qxl_screen_t *qxl)
qxl-mem_slots = xnfalloc
---
src/qxl_driver.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 548bc15..3834d3a 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1341,9 +1341,12 @@ qxl_pre_init(ScrnInfoPtr pScrn, int flags)
Memory is taken from malloc instead of from the pci bar.
Adds shadow_rom to qxl_screen_t.
Introduces init_qxl_rom, which is directly taken from the qxl device
in qemu. Plenty of TODO's added in this commit about various constants
and about factoring out the code to not do this copy paste from
---
src/qxl.h|3 +++
src/qxl_driver.c |3 +++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 4b78076..2dc4cf9 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -96,6 +96,9 @@ typedef struct qxl_surface_t qxl_surface_t;
*/
enum {
+#ifdef
Initialize a SpiceServer instance, and implement SpiceCoreInterface,
that is fd read, write notification and watchs (timers).
The fd implementation is off because Xserver doesn't allow us to be
notified on write unblock, only read. Workaround is to poll.
---
src/Makefile.am |1 +
---
src/Makefile.am|1 +
src/qxl.h | 24
src/qxl_driver.c |3 +
src/spiceqxl_display.c | 319
src/spiceqxl_display.h | 11 ++
5 files changed, 358 insertions(+), 0 deletions(-)
create mode 100644
---
src/qxl_driver.c |2 +
src/spiceqxl_io_port.c | 49
src/spiceqxl_io_port.h |4 +++
3 files changed, 55 insertions(+), 0 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index fe2f532..ef3139b 100644
---
---
src/Makefile.am |1 +
src/qxl_driver.c |2 +
src/spiceqxl_inputs.c | 353 +
src/spiceqxl_inputs.h |9 ++
4 files changed, 365 insertions(+), 0 deletions(-)
create mode 100644 src/spiceqxl_inputs.c
create mode 100644
---
README.xspice | 109
TODO.xspice| 27 +
spiceqxl.xorg.conf | 15 +++
xspice | 21 ++
4 files changed, 172 insertions(+), 0 deletions(-)
create mode 100644 README.xspice
create mode
---
src/qxl_ring.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/src/qxl_ring.c b/src/qxl_ring.c
index 0870ef1..02c4c35 100644
--- a/src/qxl_ring.c
+++ b/src/qxl_ring.c
@@ -75,7 +75,11 @@ qxl_ring_push (struct qxl_ring *ring,
while (header-prod - header-cons
On Wed, Apr 27, 2011 at 05:53:34PM +0200, Christophe Fergeau wrote:
On Wed, Apr 27, 2011 at 10:24:01AM -0400, Marc-André Lureau wrote:
Do you mean it should be #ifdef'ed? or that it's better to add the
equivalent of G_GNUC_UNUSED to the function definition to avoid the
compiler
On Wed, Apr 27, 2011 at 06:00:25PM +0200, Marc-André Lureau wrote:
-Wunused-function
Warn whenever a static function is declared but not defined or a
non-inline static function is unused. This warning is enabled by
-Wall.
I don't know if there is a flag to warn about unused static inline
When building spice-gtk after loading tons of MacPorts dependencies -- I was
getting the following error.
make all-recursive
Making all in common
Making all in win
Making all in my_getopt-1.5
make[4]: Nothing to be done for `all'.
make[4]: Nothing to be done for `all-am'.
make[3]: Nothing to be
On Wed, Apr 27, 2011 at 11:07:55AM -0500, Cliff Sharp wrote:
When building spice-gtk after loading tons of MacPorts dependencies -- I was
getting the following error.
To build from git (not from source tar balls) you need pyparsing. I think it's
pure python, so should pose
absolutely no
Yea, you can even just take the pyparsing.py from the .tgz and put it in the
source base dir. (where you run make from)
Best Regards,
Attila Sukosd
-
DTU Computing Center - www.cc.dtu.dk
att...@cc.dtu.dk, gba...@student.dtu.dk, s070...@student.dtu.dk
As Cliff stated on the very end of the mail, taking pyparsing from the original
website and manually installing it resolved the problem…
Cheers Kai
From: Attila Sukosd attila.suk...@gmail.commailto:attila.suk...@gmail.com
Date: Wed, 27 Apr 2011 18:30:58 +0200
To: Cliff Sharp
Do you guys have an idea why sound may not be working (it works with the
windows client)
and why the bandwidth increases by ~70% compared to the spicec.exe from
windows?
Cheers Kai
On 4/27/11 6:34 PM, Mosebach Kai kai.moseb...@bsse.ethz.ch wrote:
As Cliff stated on the very end of the mail,
On Wed, Apr 27, 2011 at 06:36:24PM +0200, Kai Mosebach wrote:
Do you guys have an idea why sound may not be working (it works with the
windows client)
and why the bandwidth increases by ~70% compared to the spicec.exe from
windows?
The bandwidth thing is just a result of using a different
On Wed, Apr 27, 2011 at 4:34 PM, Gianluca Cecchi
gianluca.cec...@gmail.comwrote:
On Wed, Apr 27, 2011 at 12:41 PM, Alon Levy al...@redhat.com wrote:
hello,
I could send my self compiled qxldd.dll and qxl.sys as described in
thread for w2k3 32bit:
Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/
Another note, on building the OSX client the symbol _g_get_monotonic_clock
is missing.
I think this comes from gtk/spice-session.c but does not seem to resolve
the glib version correctly.
I had to uncomment this pretty
On Wed, Apr 27, 2011 at 07:27:58PM +0200, Kai Mosebach wrote:
Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/
Another note, on building the OSX client the symbol _g_get_monotonic_clock
is missing.
I think this comes from gtk/spice-session.c but does not seem to
On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote:
diff --git a/gtk/continuation.h b/gtk/continuation.h
index 585788e..6822757 100644
--- a/gtk/continuation.h
+++ b/gtk/continuation.h
@@ -21,7 +21,8 @@
#ifndef _CONTINUATION_H_
#define _CONTINUATION_H_
-#include
If I run configure --with-coroutine=gthread I don¹t need those patches
below.
Are there any disadvantages out of the gthreads?
On 4/27/11 7:28 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote:
diff --git a/gtk/continuation.h
On Wed, Apr 27, 2011 at 06:36:24PM +0200, Kai Mosebach wrote:
and why the bandwidth increases by ~70% compared to the spicec.exe from
windows?
The bandwidth thing is just a result of using a different client? that is
very bizzarre, since it's all server-client and there is no negotiation
that
The wonderful news is that spice-gtk is built and running OSX.
AND
I have a spice server running on a server and waiting on a connection. A
connection is actually made:
SERVER ---
Apr-27 16:48:11 1-I added listener socket 3
Apr-27 16:48:21 1-I Accepted a SPICE connection
Apr-27 16:48:21 1-I
On Wed, Apr 27, 2011 at 5:28 PM, Alon Levy al...@redhat.com wrote:
On Wed, Apr 27, 2011 at 04:54:55PM +0800, Shuxiang Lim wrote:
Yep,it's really nasty.
But if I want to leverage FULL spice image ability,I have to:
1.Fix the bugs of sigbus in quic.c on Android by rewriting the
73 matches
Mail list logo
