On 07/06/2011 02:01 AM, John A. Sullivan III wrote:
On Tue, 2011-07-05 at 09:35 +0300, Arnon Gilboa wrote:
Hi John,
See my comments below.
Arnon
John A. Sullivan III wrote:
Hello, all. Being a Windows ignoramus, I am having a nightmare of a
time compiling the Windows client on our Windows 7 b
On Tue, 2011-07-05 at 09:35 +0300, Arnon Gilboa wrote:
> Hi John,
> See my comments below.
> Arnon
>
> John A. Sullivan III wrote:
> > Hello, all. Being a Windows ignoramus, I am having a nightmare of a
> > time compiling the Windows client on our Windows 7 build system. I'll
> > recount them fo
On Mon, Jul 04, 2011 at 11:33:57AM +0300, Yonit Halperin wrote:
> When the worker was stoped, the cursor was copied from guest ram to the host
> ram,
> and its corresponding qxl command was released.
> This is unecessary, since the qxl ram still exists (we keep references
> to the surfaces in the
On Tue, Jul 05, 2011 at 03:50:40PM +0300, Yonit Halperin wrote:
> fixes "display_channel_release_item: panic: invalid item type"
>
ACK all.
> Before changing the red_worker to use the red_channel interface, there
> was a devoted red_pipe_clear routine for the display channel and cursor
> channe
On Mon, Jul 04, 2011 at 03:32:39PM +0300, Yonit Halperin wrote:
> On migration, destroy_surfaces is called from qxl (qxl_hard_reset), before
> the device was loaded (on destination).
> handle_dev_destroy_surfaces led to red_process_commands, which read the qxl
> command ring
> (which appeared to
On Tue, Jul 05, 2011 at 03:50:41PM +0300, Yonit Halperin wrote:
> same as commit 74a9d10af96f4d7c8c1b1d7fca124a8df9180787 for cursor channel
ACK. (note this requires the local cursor drop patch)
> ---
> server/red_worker.c | 43 ++-
> 1 files changed, 34
On Tue, Jul 05, 2011 at 03:50:40PM +0300, Yonit Halperin wrote:
> fixes "display_channel_release_item: panic: invalid item type"
>
ACK.
> Before changing the red_worker to use the red_channel interface, there
> was a devoted red_pipe_clear routine for the display channel and cursor
> channel.
>
On 07/05/2011 03:22 PM, Alon Levy wrote:
On Mon, Jun 20, 2011 at 10:57:58AM +0200, Alon Levy wrote:
ping?
qemu calls spice_server_migrate_switch even if it didn't do a
spice_server_migrate_info first. Fix the resulting error by not pushing
a switch host tag to the pipe in this case, and add a
same as commit 74a9d10af96f4d7c8c1b1d7fca124a8df9180787 for cursor channel
---
server/red_worker.c | 43 ++-
1 files changed, 34 insertions(+), 9 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index fc4326c..8e8ec13 100644
--- a/serve
fixes "display_channel_release_item: panic: invalid item type"
Before changing the red_worker to use the red_channel interface, there
was a devoted red_pipe_clear routine for the display channel and cursor channel.
However, clearing the pipe in red_channel, uses the release_item callback
the worke
On Mon, Jun 20, 2011 at 10:57:58AM +0200, Alon Levy wrote:
ping?
> qemu calls spice_server_migrate_switch even if it didn't do a
> spice_server_migrate_info first. Fix the resulting error by not pushing
> a switch host tag to the pipe in this case, and add a check anyway in the
> marshalling code
On 07/05/2011 11:57 AM, Christophe Fergeau wrote:
On Mon, Jul 04, 2011 at 02:37:09PM +0200, Christophe Fergeau wrote:
On Mon, Jul 04, 2011 at 01:27:16PM +0200, Gerd Hoffmann wrote:
On 07/01/11 15:58, Christophe Fergeau wrote:
if (strcmp(interface->type, SPICE_INTERFACE_RECORD) == 0) {
red
On Tue, Jul 05, 2011 at 01:35:06PM +0200, Christophe Fergeau wrote:
> On Sat, Jul 02, 2011 at 04:49:44AM +0200, Alon Levy wrote:
> > if the environment variable in the title is set and can be
> > opened for writing a log of all display commands (no cursor
> > commands yet) and any QXLWorker calls (
On Sat, Jul 02, 2011 at 04:49:44AM +0200, Alon Levy wrote:
> if the environment variable in the title is set and can be
> opened for writing a log of all display commands (no cursor
> commands yet) and any QXLWorker calls (particularily primary
> create and destroy) will be logged to that file, and
On Tue, Jul 05, 2011 at 01:01:54PM +0200, Marc-André Lureau wrote:
> We don't see it in the diff, but the resulting code may leak here:
>
> g_object_get(G_OBJECT(session),
> "smartcard-db", &dbname,
> "smartcard-certificates", &certificates,
>
Hi
On Tue, Jul 5, 2011 at 10:37 AM, Christophe Fergeau wrote:
> Now that libcacard initialization is run asynchronously,
> the methods to insert/remove a software smartcard need to make
> sure libcacard is initialized before trying to trigger such an
> insertion/removal. When these functions are
Hi,
We don't see it in the diff, but the resulting code may leak here:
g_object_get(G_OBJECT(session),
"smartcard-db", &dbname,
"smartcard-certificates", &certificates,
NULL);
if ((certificates == NULL) || (g_strv_length(certificates) !=
I have read the document "spice_for_newbies.pdf", that describes how spice
works.
When I play a video on the guest, the video is decoded then the user
application requests the OS graphic engine (X in linux), to perform a
rendering operation. X passes the command to the QXL driver which translates
t
I finally ran some performance test on these changes on a small theora
clip, average compression time goes down from 17,7 ms per frame to 14 ms
per frame which corresponds to a 20% improvement.
Christophe
On Tue, Jun 28, 2011 at 01:18:01PM +0200, Christophe Fergeau wrote:
> Hi,
>
> Currently, th
On Tue, 2011-07-05 at 12:31 +0300, Arnon Gilboa wrote:
> John A. Sullivan III wrote:
> > On Tue, 2011-07-05 at 09:44 +0300, Arnon Gilboa wrote:
> >
> >> Hi John,
> >> See my comments below.
> >> Arnon
> >>
> >> John A. Sullivan III wrote:
> >>
> >>> Hello, all. I'm spinning this off of the
John A. Sullivan III wrote:
On Tue, 2011-07-05 at 09:44 +0300, Arnon Gilboa wrote:
Hi John,
See my comments below.
Arnon
John A. Sullivan III wrote:
Hello, all. I'm spinning this off of the "Unfair Comparisons with RDP"
thread as that one is getting a bit long. However, in it, Yaniv
I think you should just commit this since it fixes a bug anyway.
Christophe
On Wed, Jun 29, 2011 at 02:14:07PM +0200, Alon Levy wrote:
> ---
> server/reds.c |4
> server/smartcard.c | 11 +--
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/server/reds
On Mon, Jul 04, 2011 at 02:37:09PM +0200, Christophe Fergeau wrote:
> On Mon, Jul 04, 2011 at 01:27:16PM +0200, Gerd Hoffmann wrote:
> > On 07/01/11 15:58, Christophe Fergeau wrote:
> > >if (strcmp(interface->type, SPICE_INTERFACE_RECORD) == 0) {
> > > red_printf("SPICE_INTERFACE_RECORD");
> >
On Tue, 2011-07-05 at 09:44 +0300, Arnon Gilboa wrote:
> Hi John,
> See my comments below.
> Arnon
>
> John A. Sullivan III wrote:
> > Hello, all. I'm spinning this off of the "Unfair Comparisons with RDP"
> > thread as that one is getting a bit long. However, in it, Yaniv
> > identified that we
Now that libcacard initialization is run asynchronously,
the methods to insert/remove a software smartcard need to make
sure libcacard is initialized before trying to trigger such an
insertion/removal. When these functions are called too early,
the insertion/removal attempt is ignored.
---
gtk/sma
It can blocked for up to 5 seconds when trying to spawn
the pcsc-lite daemon, so better to run it from a thread to avoid
blocking the mainloop. The cold plug insertion events will be
caught from the mainloop thread, so this shouldn't cause issues.
---
gtk/smartcard-manager.c | 31 +++
The goal is to make initialization of libcacard async, so we
can't return a meaningful value from this function.
---
gtk/smartcard-manager-priv.h |2 +-
gtk/smartcard-manager.c | 13 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/gtk/smartcard-manager-priv
By freeing memory as soon as it's not longer used, we can
remove the end: label and the retval variable.
---
gtk/smartcard-manager.c | 14 +-
1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/gtk/smartcard-manager.c b/gtk/smartcard-manager.c
index 86c5509..0aeb4f1 100644
28 matches
Mail list logo
