Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-19 Thread Alon Levy
On Tue, Oct 18, 2011 at 11:50:37PM +0200, Yaniv Kaul wrote: On 18/10/2011 19:20, Uri Lublin wrote: WAN accelerators may compress the zeros which results with a wrong bandwidth calculation. Is this really the right approach? Why not calculate the latency based on the time it takes to send

[Spice-devel] [PATCH 4/4] do not segfault if link message header size is set to 0

2011-10-19 Thread Marc-André Lureau
https://bugs.freedesktop.org/show_bug.cgi?id=41988 --- gtk/spice-channel.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 5bc244f..23c16e7 100644 --- a/gtk/spice-channel.c +++ b/gtk/spice-channel.c @@ -976,6 +976,11 @@

Re: [Spice-devel] [PATCH 1/4] gtk: warn if argument is invalid instead of crash

2011-10-19 Thread Alon Levy
On Wed, Oct 19, 2011 at 11:29:27AM +0200, Marc-André Lureau wrote: Series Reviewed-by: Alon Levy al...@redhat.com --- gtk/spice-widget.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index afe030d..fa7f675 100644 ---

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-19 Thread Uri Lublin
On 10/18/2011 11:50 PM, Yaniv Kaul wrote: On 18/10/2011 19:20, Uri Lublin wrote: WAN accelerators may compress the zeros which results with a wrong bandwidth calculation. Is this really the right approach? Why not calculate the latency based on the time it takes to send the first image? That

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-19 Thread Frédéric Grelot
That seems like a good idea. Note that if the first image is not compressed, we may have a similar problem with WAN accelerators. Also maybe it is better to always compress it. This random buffer was intended as a quick fix. In the long run, we would like to measure network statistics

Re: [Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-19 Thread Uri Lublin
On 10/18/2011 11:53 PM, Yaniv Kaul wrote: On 18/10/2011 19:20, Uri Lublin wrote: Currently spice-server network bandwidth estimation is: send an empty ping packet to the client (and ignore it) (warmup) Useless. 'warmup' of what exactly? The TCP MSS and everything else is already set by the

Re: [Spice-devel] [PATCH] qxl: fix guest cursor tracking

2011-10-19 Thread Gerd Hoffmann
On 10/18/11 18:58, Yonit Halperin wrote: (1) If the guest cursor command is empty, don't reload it after migration. (2) Cleaning the guest cursor when it is released by the spice server. In addition, explicitly reset the cursor in spice upon destroying the primary surface (was

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-19 Thread Yaniv Kaul
On 10/19/2011 01:42 PM, Frédéric Grelot wrote: That seems like a good idea. Note that if the first image is not compressed, we may have a similar problem with WAN accelerators. Also maybe it is better to always compress it. This random buffer was intended as a quick fix. In the long run, we

[Spice-devel] Spice client issues on Fedora14 Live.

2011-10-19 Thread Naga Mohan Pothula
Hi, I'm facing two strange problems with Spice client 0.9 on Fedora 14 Live CD which boot parameters are set to load Fed14 live into RAM to run faster. 1.) keyboard/Mouse doesn't function at logon screen when guest image is started from shutdown/restart       This issue happens with windows