Re: [Spice-devel] [PATCH 4/4] client: foreign-menu: pass "active" param when creating a ForeignMenu (#769020)

2011-12-20 Thread Alon Levy
On Tue, Dec 20, 2011 at 06:52:58PM +0200, Uri Lublin wrote: > The default stays the same -- false. > > A race could prevent setting ForeignMenu::_active correctly. > That happened when Application::on_app_activated was called before > _foriegn_menu was created. When foriegn_menu was created its >

Re: [Spice-devel] [PATCH 2/4] client: menu: make RedWindow::set_menu() return an error-code (#758260)

2011-12-20 Thread Alon Levy
On Tue, Dec 20, 2011 at 06:52:42PM +0200, Uri Lublin wrote: > RedWindow::set_menu() can fail (on Windows when in fullscreen mode). > For Windows spice-client, when in fullscreen mode, the system-menu > is NULL. > ACK both. > Returns 0 upon success, non-0 (currently only -1) upon failure. > --- >

Re: [Spice-devel] [PATCH 1/4] client controller/foreign_menu: use memmove instead of memcpy in readers

2011-12-20 Thread Alon Levy
On Tue, Dec 20, 2011 at 06:52:02PM +0200, Uri Lublin wrote: > When src/dst memory areas may overlap, it's safer to use memmove. ACK. > --- > client/controller.cpp |2 +- > client/foreign_menu.cpp |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/client/control

[Spice-devel] [PATCH 4/4] client: foreign-menu: pass "active" param when creating a ForeignMenu (#769020)

2011-12-20 Thread Uri Lublin
The default stays the same -- false. A race could prevent setting ForeignMenu::_active correctly. That happened when Application::on_app_activated was called before _foriegn_menu was created. When foriegn_menu was created its _active defaults to false, and that has not changed, until focus was tak

[Spice-devel] [PATCH 3/4] client: update menu if needed when exiting full-screen mode (#758260)

2011-12-20 Thread Uri Lublin
--- client/screen.cpp |7 ++- client/screen.h |1 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index 94f3bdc..0b3ba6f 100644 --- a/client/screen.cpp +++ b/client/screen.cpp @@ -100,6 +100,7 @@ RedScreen::RedScreen(Application&

[Spice-devel] [PATCH 2/4] client: menu: make RedWindow::set_menu() return an error-code (#758260)

2011-12-20 Thread Uri Lublin
RedWindow::set_menu() can fail (on Windows when in fullscreen mode). For Windows spice-client, when in fullscreen mode, the system-menu is NULL. Returns 0 upon success, non-0 (currently only -1) upon failure. --- client/red_window.h |2 +- client/windows/red_window.cpp | 14 ++

[Spice-devel] [PATCH 1/4] client controller/foreign_menu: use memmove instead of memcpy in readers

2011-12-20 Thread Uri Lublin
When src/dst memory areas may overlap, it's safer to use memmove. --- client/controller.cpp |2 +- client/foreign_menu.cpp |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/controller.cpp b/client/controller.cpp index e7c4b95..91c0021 100644 --- a/client/contro

Re: [Spice-devel] spice-gtk segfault

2011-12-20 Thread Christophe Fergeau
On Tue, Dec 20, 2011 at 04:05:46PM +0100, nicolas prochazka wrote: > Ok, > with gdb i can see that's no audio card in my laptop that segfault, > if I do --spice-disable-audio, no more segfault. Can you copy and paste this backtrace? This will pinpoint the place where to start looking for a fix fo

Re: [Spice-devel] spice-gtk segfault

2011-12-20 Thread nicolas prochazka
Ok, with gdb i can see that's no audio card in my laptop that segfault, if I do --spice-disable-audio, no more segfault. Regards, Nicolas. 2011/12/20 Christophe Fergeau : > Hey, > > On Tue, Dec 20, 2011 at 12:22:48PM +0100, nicolas prochazka wrote: >> Hello, >> I'm trying to use spicy client on

Re: [Spice-devel] spice-gtk segfault

2011-12-20 Thread Christophe Fergeau
Hey, On Tue, Dec 20, 2011 at 12:22:48PM +0100, nicolas prochazka wrote: > Hello, > I'm trying to use spicy client on small linux distribution ( tinycorelinux ) > After some work, i can compile spicy ( gtk2 ) and run it. > However when I 'm trying to connect, I obtain a segfault with : > > > (s

[Spice-devel] spice-gtk segfault

2011-12-20 Thread nicolas prochazka
Hello, I'm trying to use spicy client on small linux distribution ( tinycorelinux ) After some work, i can compile spicy ( gtk2 ) and run it. However when I 'm trying to connect, I obtain a segfault with : (spicy:2254): GSpice-CRITICAL **: spice_g_signal_connect_object: assertion `G_IS_OBJECT (

Re: [Spice-devel] keyboard and Mouse Fails....

2011-12-20 Thread David Jaša
Naga Mohan Pothula píše v Po 19. 12. 2011 v 10:13 -0800: > We can move mouse over the guest but the guest doesn't respond for > user actions like mouse click. I've seen something similar that was caused by agent. Keyboard worked fine so I used it to restart agent service and everything started wor