Re: [Spice-devel] [Qemu-devel] Seem thread Competition

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 10:13:50AM +0800, ZhouPeng wrote: Hi, I meet the err: # virsh dumpxml 63 error: internal error cannot parse json {timestamp: {seconds: 1323332828, microseco{timest35p:39}, econds:PICE_D 1CO3233TE828, Dmicrosec dsdata52}, : {ser: SPrCE_DISONNEC{ED, port: {serve :

[Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Uri Lublin
Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 --- client/screen.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index 0b3ba6f..a0dc0df 100644 --- a/client/screen.cpp +++ b/client/screen.cpp @@ -87,6 +87,7 @@

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 10:54:57AM +0200, Uri Lublin wrote: Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 ACK. --- client/screen.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index 0b3ba6f..a0dc0df 100644 ---

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Christophe Fergeau
What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something else? On Thu, Dec 22, 2011 at 10:54:57AM +0200, Uri Lublin wrote: Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 --- client/screen.cpp |2 +- 1 files

[Spice-devel] [PATCH] client: screen: fix typo _forec_update_timer

2011-12-22 Thread Uri Lublin
sed -i 's/_forec_update_timer/_force_update_timer/' screen.cpp screen.h --- client/screen.cpp | 10 +- client/screen.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index a0dc0df..dc33455 100644 --- a/client/screen.cpp

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Christophe Fergeau
On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote: On 12/22/2011 11:11 AM, Christophe Fergeau wrote: What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something else? The compiler warns about it. When the

Re: [Spice-devel] [PATCH] client: screen: fix typo _forec_update_timer

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 11:20:52AM +0200, Uri Lublin wrote: sed -i 's/_forec_update_timer/_force_update_timer/' screen.cpp screen.h ACK --- client/screen.cpp | 10 +- client/screen.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/screen.cpp

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote: On 12/22/2011 11:11 AM, Christophe Fergeau wrote: What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something else? The compiler warns about it. When the

Re: [Spice-devel] [PATCH] client: screen: fix typo _forec_update_timer

2011-12-22 Thread Christophe Fergeau
ACK On Thu, Dec 22, 2011 at 11:20:52AM +0200, Uri Lublin wrote: sed -i 's/_forec_update_timer/_force_update_timer/' screen.cpp screen.h --- client/screen.cpp | 10 +- client/screen.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/screen.cpp

Re: [Spice-devel] [Qemu-devel] Seem thread Competition

2011-12-22 Thread ZhouPeng
On Thu, Dec 22, 2011 at 4:42 PM, Alon Levy al...@redhat.com wrote: On Thu, Dec 22, 2011 at 10:13:50AM +0800, ZhouPeng wrote: Hi, I meet the err: # virsh dumpxml 63 error: internal error cannot parse json {timestamp: {seconds: 1323332828, microseco{timest35p:39}, econds:PICE_D 1CO3233TE828,

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Uri Lublin
On 12/22/2011 11:26 AM, Christophe Fergeau wrote: On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote: On 12/22/2011 11:11 AM, Christophe Fergeau wrote: What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something

Re: [Spice-devel] [Qemu-devel] Seem thread Competition

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 05:42:29PM +0800, ZhouPeng wrote: On Thu, Dec 22, 2011 at 4:42 PM, Alon Levy al...@redhat.com wrote: On Thu, Dec 22, 2011 at 10:13:50AM +0800, ZhouPeng wrote: Hi, I meet the err: # virsh dumpxml 63 error: internal error cannot parse json {timestamp: {seconds:

Re: [Spice-devel] [Qemu-devel] Seem thread Competition

2011-12-22 Thread Alon Levy
On Thu, Dec 22, 2011 at 10:00:18AM +, Alon Levy wrote: On Thu, Dec 22, 2011 at 05:42:29PM +0800, ZhouPeng wrote: On Thu, Dec 22, 2011 at 4:42 PM, Alon Levy al...@redhat.com wrote: On Thu, Dec 22, 2011 at 10:13:50AM +0800, ZhouPeng wrote: Hi, I meet the err: # virsh dumpxml

Re: [Spice-devel] [Qemu-devel] Seem thread Competition

2011-12-22 Thread ZhouPeng
On Thu, Dec 22, 2011 at 6:00 PM, Alon Levy al...@redhat.com wrote: On Thu, Dec 22, 2011 at 05:42:29PM +0800, ZhouPeng wrote: On Thu, Dec 22, 2011 at 4:42 PM, Alon Levy al...@redhat.com wrote: On Thu, Dec 22, 2011 at 10:13:50AM +0800, ZhouPeng wrote: Hi, I meet the err: # virsh

[Spice-devel] [PATCH spice] spicevmc: Set sockopt nodelay for usbredir channels

2011-12-22 Thread Hans de Goede
We want as little latency as possible with usb channels. Signed-off-by: Hans de goede hdego...@redhat.com --- server/spicevmc.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index b1a7d8d..70cfe0e 100644 ---

[Spice-devel] [PATCH spice-gtk] spice-channel: setsockopt TCP_NODELAY

2011-12-22 Thread Hans de Goede
spicec does this for all channels, and it seems like a good idea to do the same in spice-gtk. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/spice-channel.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c

Re: [Spice-devel] [PATCH spice] spicevmc: Set sockopt nodelay for usbredir channels

2011-12-22 Thread Yonit Halperin
On 12/22/2011 01:14 PM, Hans de Goede wrote: We want as little latency as possible with usb channels. Signed-off-by: Hans de goedehdego...@redhat.com --- server/spicevmc.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/server/spicevmc.c

Re: [Spice-devel] [Qemu-devel] Seem thread Competition

2011-12-22 Thread ZhouPeng
On Thu, Dec 22, 2011 at 6:53 PM, Alon Levy al...@redhat.com wrote: On Thu, Dec 22, 2011 at 10:00:18AM +, Alon Levy wrote: On Thu, Dec 22, 2011 at 05:42:29PM +0800, ZhouPeng wrote: On Thu, Dec 22, 2011 at 4:42 PM, Alon Levy al...@redhat.com wrote: On Thu, Dec 22, 2011 at 10:13:50AM

[Spice-devel] [PATCH] Fix build from git with srcdir != builddir

2011-12-22 Thread Christophe Fergeau
The --basedir argument to valac seems to be meant to help handling this case but it doesn't seem to work with f16 valac so I appended $(srcdir) to the vala source files. Build is still broken with --enable-vala during .vapi generation due to what look like a vala bug. ---

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: setsockopt TCP_NODELAY

2011-12-22 Thread Marc-André Lureau
ack - Mensaje original - spicec does this for all channels, and it seems like a good idea to do the same in spice-gtk. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/spice-channel.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git

Re: [Spice-devel] [PATCH] Fix build from git with srcdir != builddir

2011-12-22 Thread Marc-André Lureau
Hi - Mensaje original - The --basedir argument to valac seems to be meant to help handling this case but it doesn't seem to work with f16 valac so I appended $(srcdir) to the vala source files. Build is still broken with --enable-vala during .vapi generation due to what look like a