Hi,
On 05/03/2012 06:09 PM, Christophe Fergeau wrote:
On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote:
From: Arnon Gilboa
no strtok_r (reentrent) available, so use strtok instead.
Wouldn't it be safer to use strtok_s? Any application using threads and
strtok and libusbredirparser
Hi,
On 05/03/2012 06:24 PM, Christophe Fergeau wrote:
On Thu, May 03, 2012 at 06:04:38PM +0300, Uri Lublin wrote:
On Windows libusb_(attach|detach)_kernel_driver are not supported.
A libusb driver is already installed (device was successfully opened).
In that case just continue as if operation
Hi,
I'd like to compile a static version of qemu-kvm + spice.
However, I am missing correct options for that.
If I don't put "--static" option for the "./configure" stage, I have
no problem.
But, when I try with "--static", I get :
"ERROR
I've got a pure Javascript based client with which
I can control a few xterms, start and use gedit, and just generally
operate an Xspice server. It's still extremely limited; a few kinds of draws,
no
masks or clips, no authentication, and only quic images. It's slow,
and the mouse movement is co
Consolidate two separate chunks of library hunting that depend on the
same check.
Check if we're actually building the client before looking for
client only libraries.
Hide some of the final output if we're not building the client.
---
I think this should address the rest of the concerns about
th
On Thu, May 03, 2012 at 06:04:38PM +0300, Uri Lublin wrote:
> On Windows libusb_(attach|detach)_kernel_driver are not supported.
> A libusb driver is already installed (device was successfully opened).
> In that case just continue as if operation was successful.
Do we want to only do that check on
On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote:
> From: Arnon Gilboa
>
> no strtok_r (reentrent) available, so use strtok instead.
Wouldn't it be safer to use strtok_s? Any application using threads and
strtok and libusbredirparser could get issues with this change no?
>
> Modified
ACK
Christophe
On Thu, May 03, 2012 at 06:04:37PM +0300, Uri Lublin wrote:
> In libusb.h the following definition appears:
> typedef void (LIBUSB_CALL *libusb_transfer_cb_fn)(struct libusb_transfer
> *transfer);
>
> Added LIBUSB_CALL to the following functions:
> usbredirhost_iso_packet_c
What's wrong with the test client on Windows? The socket code?
ACK (another extra whitespace change though)
Christophe
On Thu, May 03, 2012 at 06:04:34PM +0300, Uri Lublin wrote:
> ---
> Makefile.am |5 -
> configure.ac | 14 ++
> 2 files changed, 18 insertions(+), 1 dele
There's an unrelated white space change in there, apart from this, ACK
Christophe
On Thu, May 03, 2012 at 06:04:35PM +0300, Uri Lublin wrote:
> On Windows (mingw), ERROR is already defined (to i0)
>
> This fixes the following compiler warning:
> warning: "ERROR" redefined [enabled by default]
ACK on this one, you could even copy what spice-gtk is doing which allows
to run autogen.sh outside of builddir:
srcdir=`dirname $0`
test -z "$srcdir" && srcdir=.
if [ -z "$NOCONFIGURE" ]; then
"$srcdir"/configure $@
fi
Christophe
On Thu, May 03, 2012 at 06:04:36PM +0300, Uri Lublin wrote:
Dunno about that one, why vim and not emacs headers? :)
I don't really care with having it in, it's just the kind of stuff I tend
to try to keep local.
But why not, ACK if no one is against it in the next few days.
Christophe
On Tue, Apr 24, 2012 at 12:21:25PM +0300, Alon Levy wrote:
> ---
> sr
This one disappears if we use -Wno-cast-qual
Christophe
On Tue, Apr 24, 2012 at 12:21:26PM +0300, Alon Levy wrote:
> ---
> src/qxl_ring.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/qxl_ring.c b/src/qxl_ring.c
> index 7a11fbb..d701791 100644
> ---
ACK
Christophe
On Tue, Apr 24, 2012 at 12:21:27PM +0300, Alon Levy wrote:
> "__attribute__((always_inline))" does not replace "inline" and they
> still need to be used together. This fixes "always_inline function
> might not be inlinable [-Wattributes]" warning in gcc 4.7
> ---
> src/murmurhash3
X.Org adds -Wcast-qual to its default WARNCFLAGS, but then it
doesn't use const in the API it exports, which leads to warnings
when trying to initialize some fields of the various DriverRec
structures with string literals.
---
configure.ac |1 +
1 file changed, 1 insertion(+)
diff --git a/con
On Thu, May 03, 2012 at 05:25:08PM +0200, Christophe Fergeau wrote:
> On Thu, May 03, 2012 at 11:00:08AM -0400, Nahum Shalman wrote:
> > consolidate two separate chunks of library hunting that depend on the
> > same check, and check if we're actually building the client.
> >
> > hide some of the f
On Thu, May 03, 2012 at 11:00:08AM -0400, Nahum Shalman wrote:
> consolidate two separate chunks of library hunting that depend on the
> same check, and check if we're actually building the client.
>
> hide some of the final output if we're not building the client
> ---
> configure.ac | 15
On Thu, May 03, 2012 at 05:36:05PM +0300, Alon Levy wrote:
> On Thu, May 03, 2012 at 04:28:26PM +0200, Christophe Fergeau wrote:
> > I'm still not a big fan of these, but I could not find satisfying fixes in
> > the Xorg drivers I looked at, so let's get these in, we can always revert
> > if we com
From: Arnon Gilboa
no strtok_r (reentrent) available, so use strtok instead.
Modified-by: Uri Lublin
---
usbredirparser/usbredirfilter.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/usbredirparser/usbredirfilter.c b/usbredirparser/usbredirfilter.c
in
On Windows libusb_(attach|detach)_kernel_driver are not supported.
A libusb driver is already installed (device was successfully opened).
In that case just continue as if operation was successful.
---
usbredirhost/usbredirhost.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff -
In libusb.h the following definition appears:
typedef void (LIBUSB_CALL *libusb_transfer_cb_fn)(struct libusb_transfer
*transfer);
Added LIBUSB_CALL to the following functions:
usbredirhost_iso_packet_complete
usbredirhost_interrupt_packet_complete
usbredirhost_control_pac
---
autogen.sh |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/autogen.sh b/autogen.sh
index 52083e5..568f718 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,4 +1,6 @@
#!/bin/sh
autoreconf -fi
-./configure $@
+if [ -z "$NOCONFIGURE" ]; then
+./configure $@
+fi
--
On Windows (mingw), ERROR is already defined (to i0)
This fixes the following compiler warning:
warning: "ERROR" redefined [enabled by default]
---
usbredirhost/usbredirhost.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/usbredirhost/usbredirhost.c b/usbredirhost/
---
Makefile.am |5 -
configure.ac | 14 ++
2 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9d392d5..6b77127 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,2 +1,5 @@
-SUBDIRS = usbredirparser usbredirhost usbredirserver usbre
This patch-set enables building usbredir for Windows, using mingw.
The autogen.sh is not required, and is just for convenience.
It makes it easier to build the same code for both linux
and windows (in different build-dirs).
Arnon Gilboa (1):
usbredirfilter: fix filter parsing for windows (mi
consolidate two separate chunks of library hunting that depend on the
same check, and check if we're actually building the client.
hide some of the final output if we're not building the client
---
configure.ac | 15 ++-
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a
On Thu, May 03, 2012 at 04:28:26PM +0200, Christophe Fergeau wrote:
> I'm still not a big fan of these, but I could not find satisfying fixes in
> the Xorg drivers I looked at, so let's get these in, we can always revert
> if we come with a better solution.
> Have you tried adding -Wno-cast-qual in
I'm still not a big fan of these, but I could not find satisfying fixes in
the Xorg drivers I looked at, so let's get these in, we can always revert
if we come with a better solution.
Have you tried adding -Wno-cast-qual instead of these patches?
Christophe
On Tue, Apr 24, 2012 at 12:21:22PM +030
On 05/03/2012 03:38 AM, Yonit Halperin wrote:
> Hi,
> On 05/02/2012 10:24 PM, Jeremy White wrote:
>> I had a puzzling bug where I could not establish a connection
>> with a spice server across an openvpn connection onto a Debian
>> stable box. It turns out that the network stack in question
>> app
It does not freed in spice-gtk-0.12.
Maybe you have forgotten to merge the code.
xufango
From: Marc-André Lureau
Date: 2012-05-03 00:00
To: xufango
CC: Yonit Halperin; Marc-André Lureau; Marian Krcmarik; spice-devel
Subject: Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak
Hi
On Sat,
On Wed, May 02, 2012 at 05:01:37PM +0300, Yonit Halperin wrote:
> ---
> server/red_worker.c | 27 ---
> 1 files changed, 16 insertions(+), 11 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 07782c8..09a9357 100644
> --- a/server/red_worker
On 2012-05-03 12:29, Christophe Fergeau wrote:
> Hey,
>
> On Thu, May 03, 2012 at 04:47:08AM +0200, Robert Gruber wrote:
>> Hello!
>>
>> How do I compile a spice server on linux x86_64 without any GUI/X
support ?
>>
>> I always get the follwing error when I do a ./configure like described in
>> the
Hey,
On Thu, May 03, 2012 at 04:47:08AM +0200, Robert Gruber wrote:
> Hello!
>
> How do I compile a spice server on linux x86_64 without any GUI/X support ?
>
> I always get the follwing error when I do a ./configure like described in
> the README file:
>
> ---
> checking for XRANDR... no
> con
Hello!
How do I compile a spice server on linux x86_64 without any GUI/X support ?
I always get the follwing error when I do a ./configure like described in
the README file:
---
checking for XRANDR... no
configure: error: Package requirements (xrandr) were not met:
No package 'xrandr' found
Co
Hi,
On 05/03/2012 10:25 AM, Peter Hatina wrote:
Hi,
can you, please, have a look at this? Due to script structure
(/usr/libexec/spice-xpi-client), we need to signal a process group
to correctly tear down spicec/remote-viewer. This should fix
rhbz#810583
Ah, I see this is caused by the piping
Hi,
On 05/02/2012 10:24 PM, Jeremy White wrote:
I had a puzzling bug where I could not establish a connection
with a spice server across an openvpn connection onto a Debian
stable box. It turns out that the network stack in question
apparently is very careful on non blocking sockets, and was
ret
Hi,
can you, please, have a look at this? Due to script structure
(/usr/libexec/spice-xpi-client), we need to signal a process group
to correctly tear down spicec/remote-viewer. This should fix
rhbz#810583
Thanks,
-Peter
---
SpiceXPI/src/plugin/plugin.cpp |4 +++-
1 files changed, 3 insert
37 matches
Mail list logo
