Re: [Spice-devel] shift+f11 can not exit fullscreen

2012-06-14 Thread David Jaša
flooding Controlled píše v Pá 15. 06. 2012 v 09:19 +0800: > Thanks for your reply. However, I do not understand how does the > virt-viewer work with spicy, I have generally review the source code > of spicy and virt-viewer , and find not answer. Could you give me > some docs about how do they work

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Ron
On Thu, Jun 14, 2012 at 08:55:59AM +0200, Gerd Hoffmann wrote: > Hi, > > >> I suspect there is no way around resampling support though. We'll need > >> it for compatibility reasons, so sound keeps working if only one side is > >> able to operate at 48 kHz. > > > > The ability to resample OTOH

Re: [Spice-devel] shift+f11 can not exit fullscreen

2012-06-14 Thread flooding Controlled
Thanks for your reply. However, I do not understand how does the virt-viewer work with spicy, I have generally review the source code of spicy and virt-viewer , and find not answer. Could you give me some docs about how do they work together ? thanks. 2012/6/14 David Jaša > Hi, > > flooding Con

Re: [Spice-devel] Further thoughts on the write polling in the xf86_spice_xql driver

2012-06-14 Thread Jeremy White
>> Okay; I unimaginatively decided that would be Hard. Wouldn't that break >> the ABI, and therefore be rejected unilaterally? I'm willing to try to >> craft a patch and submit it; but maybe I just need encouragement . > > I started looking at this, talked to Dave Airlie and he suggested to ask

[Spice-devel] RFC: spice-server default listen behaviour change

2012-06-14 Thread David Jaša
Hi, I learned few things about ipv6 lately. Most importantly about dual-socket that means that a process that opens ::0 automatically listens on both ipv4 _and_ ipv6 unless it sets IPV6_ONLY option of setsockopt() to 0. This is pretty important wrt dual-stack configurations because they can be im

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Michael Tokarev
14.06.2012 18:23, David Mansfield wrote: [] > As a user, being given the information and the option to disable is the best > case. A message saying "No compressed audio codec is available. Continuing > with audio enabled may degrade performance. Disable audio for this sesison?" I wonder which

Re: [Spice-devel] shift+f11 can not exit fullscreen

2012-06-14 Thread David Jaša
Hi, flooding Controlled píše v Út 12. 06. 2012 v 13:10 +0800: > Hi all: > I am now using spice-gtk-0.12 on a linux client, when I run > "spicy -h 127.0.0.1 -p 5900", it connected successfully, and I pressed > "shift + f11", spicy window turned to be fullscreen, but when I > pressed "shift + f

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread David Mansfield
On 06/14/2012 06:31 AM, Christophe Fergeau wrote: On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: However, that is imho a different issue than the celt051 support. A new release of spice client and server supporting opus does not magically make old servers and client disappe

Re: [Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

2012-06-14 Thread Hans de Goede
Hi, On 06/14/2012 02:43 PM, Marc-André Lureau wrote: Hi - Mensaje original - so why having a 1-1 relation with each spice session? We also need to undo the changes at some point in time, iow the desktop-integration objects lifetime needs to be coupled to *something*, and spice-sessio

Re: [Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice

2012-06-14 Thread Alon Levy
On Thu, Jun 14, 2012 at 08:28:24AM -0400, Marc-André Lureau wrote: > > > - Mensaje original - > > By adding spice-protocol to SUBDIRS configure and make will be called > > in it. > > > > Spotted by Marc-André. > > --- > > Makefile.am |2 +- > > 1 file changed, 1 insertion(+), 1 delet

Re: [Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

2012-06-14 Thread Marc-André Lureau
Hi - Mensaje original - > > so why having a 1-1 relation with each spice session? > > We also need to undo the changes at some point in time, iow the > desktop-integration objects > lifetime needs to be coupled to *something*, and spice-session seems > best for this. IE, > think usage in

Re: [Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

2012-06-14 Thread Hans de Goede
Hi, On 06/14/2012 11:28 AM, Marc-André Lureau wrote: Hi - Mensaje original - Looks reasonable to me, however, I don't see why it should be in spice-glib, since it's very much desktop related. Wouldn't it make more sense in spice-gtk? I actually put it in spice-gtk at first, but that

Re: [Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice

2012-06-14 Thread Marc-André Lureau
- Mensaje original - > By adding spice-protocol to SUBDIRS configure and make will be called > in it. > > Spotted by Marc-André. > --- > Makefile.am |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 28450b4..3b3c88d 100644 > -

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread David Jaša
Christophe Fergeau píše v Čt 14. 06. 2012 v 12:31 +0200: > On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > > However, that is imho a different issue than the celt051 support. A new > > release of spice client and server supporting opus does not magically > > make old servers an

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Gerd Hoffmann
Hi, > What I gather from this thread is that we don't want anyone to use the > fallback PCM code, which means we should deprecate it if that's really what > we want... Maybe the clients could be patched to stop advertising raw PCM > support? You can't, PCM is the baseline which isn't negotiated

[Spice-devel] [spice-common PATCH] Makefile.am: now that spice_codegen.py is used add *.pyc to ignored files in root

2012-06-14 Thread Alon Levy
--- Makefile.am |2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index 3b3c88d..79f7903 100644 --- a/Makefile.am +++ b/Makefile.am @@ -10,6 +10,8 @@ EXTRA_DIST = \ spice1.proto\ $(NULL) +DISTCLEANFILES

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Christophe Fergeau
On Thu, Jun 14, 2012 at 12:50:39PM +0200, Alexander Larsson wrote: > On Thu, 2012-06-14 at 12:31 +0200, Christophe Fergeau wrote: > > What I gather from this thread is that we don't want anyone to use the > > fallback PCM code, which means we should deprecate it if that's really what > > we want...

[Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice

2012-06-14 Thread Alon Levy
By adding spice-protocol to SUBDIRS configure and make will be called in it. Spotted by Marc-André. --- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 28450b4..3b3c88d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,7 @@ N

[Spice-devel] [spice-protocol PATCH] enums.h: update for smartcard updated spice.proto

2012-06-14 Thread Alon Levy
--- spice/enums.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index 802e1ee..d3a2141 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -320,6 +320,20 @@ typedef enum SpiceTunnelIpType { SPICE_TUNNEL_IP_TYPE_ENUM_END } SpiceTunnelIpT

[Spice-devel] [spice-common PATCH 3/3] updated spice-protocol for smartcard enums non conflict with libcacard

2012-06-14 Thread Alon Levy
--- spice-protocol |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-protocol b/spice-protocol index bf0daeb..6bae9fd 16 --- a/spice-protocol +++ b/spice-protocol @@ -1 +1 @@ -Subproject commit bf0daeb3a3c834133e781439f76b1c702470581b +Subproject commit 6bae9fde0316b

[Spice-devel] [spice-common PATCH 2/3] spice-protocol/spice/enums.h: rebuild from spice.proto

2012-06-14 Thread Alon Levy
This file was hand generated until now, resulting in the wierd situation where it is different for spice-gtk and spice-server even though they both use the same spice-common and spice-protocol (or at least close) versions. This patch generates the enums.h files from spice-common. While that file i

[Spice-devel] [spice-common PATCH 1/3] smartcard: build fixes for spice server

2012-06-14 Thread Alon Levy
Define different enums that have a SPICE_ prefix to not conflict with same value enums from libcacard/vsccard_common.h, and continue to use the same SPICE_MSG_SMARTCARD_DATA and SPICE_MSGC_SMARTCARD_DATA enum that is used by the server and clients (spice-gtk, spicec) alike. --- common/client_marsh

[Spice-devel] [spice-common PATCH 0/3] smartcard autogenerated sources fixes

2012-06-14 Thread Alon Levy
The enums.h file hasn't been built since the spice.proto smartcard messages additions. Additionally it turns out enums.h generation was broken. Fixing for now means not redefining enums defined in libcacard/vsc ard_common.h (VSC_ATR etc) and not renaming SPICE_MSG_SMARTCARD_DATA to SPICE_MSG_SMA

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Alexander Larsson
On Thu, 2012-06-14 at 12:31 +0200, Christophe Fergeau wrote: > On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > > However, that is imho a different issue than the celt051 support. A new > > release of spice client and server supporting opus does not magically > > make old server

Re: [Spice-devel] [PATCH] Compute totalPixmapSize using the same logic as in dix/pixmap.c, rather than hard coding 100.

2012-06-14 Thread Alon Levy
On Wed, Jun 13, 2012 at 05:04:12PM -0500, Jeremy White wrote: Looks good to me. > This was found while building with a modified X server; one with a PixmapRec > size of 224, not 64 :-/. > --- > src/qxl_driver.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/s

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Christophe Fergeau
On Thu, Jun 14, 2012 at 10:14:36AM +0200, Alexander Larsson wrote: > However, that is imho a different issue than the celt051 support. A new > release of spice client and server supporting opus does not magically > make old servers and client disappear, so it would still be the case > that e.g. deb

Re: [Spice-devel] [PATCH spice-gtk 1/3] spice-gtk-session: Only update usb "auto-connect" when doing "auto-usb-redir"

2012-06-14 Thread Christophe Fergeau
On Wed, Jun 13, 2012 at 07:07:21PM +0200, Hans de Goede wrote: > Only update the UsbDeviceManager's "auto-connect" property when > "auto-usb-redir" is set, otherwise leave it as is. This allows apps to > control UsbDeviceManager's "auto-connect" directly, without it getting reset > on every keyboar

Re: [Spice-devel] [spice-common PATCH] python_modules/ptypes.py/EnumBaseType.c_enumname: add missing return to fix broken enums generation

2012-06-14 Thread Alon Levy
On Thu, Jun 14, 2012 at 05:11:02AM -0400, Marc-André Lureau wrote: > I don't see exactly what it will fixed, perhaps you should include a small > example. But that looks like a typo and can't harm, ACK > ./spice_codegen.py --generate-enums spice.proto spice-protocol/spice/enums.h Produces a fil

Re: [Spice-devel] [PATCH v2 2/2] Release 0.11.0

2012-06-14 Thread Christophe Fergeau
On Tue, Jun 12, 2012 at 08:52:19AM -0400, Alon Levy wrote: > A second mistake, this was a result of -version-name and not libtool help > being incorrect. So SONAME is indeed current-age. New question: is > libspice-server.so.1.3.0 ><= 1.0.2 ? It should, even though we probably don't care ;) Chris

Re: [Spice-devel] [PATCH 2/2] Release 0.11.0

2012-06-14 Thread Christophe Fergeau
Hey, On Tue, Jun 12, 2012 at 03:01:54PM +0300, Alon Levy wrote: > But I thought it doesn't break existing users. If it does that's not > what I meant. I thought the important name was that before the .so, i.e. > libspice-server, and that the dynamic linker will look for .1 and then > if none found

Re: [Spice-devel] Join spice-devel@lists.freedesktop.org

2012-06-14 Thread Alon Levy
On Tue, Jun 12, 2012 at 06:02:45PM +0800, Xiang Hua wrote: > to get information about all things related to the Spice project. > > thanks. > > Hua in Beijing You need to send a request through mailman, here: http://lists.freedesktop.org/mailman/listinfo/spice-devel > _

Re: [Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

2012-06-14 Thread Marc-André Lureau
Hi - Mensaje original - > > Looks reasonable to me, however, I don't see why it should be in > > spice-glib, since it's very much desktop related. Wouldn't it make > > more sense in spice-gtk? > > I actually put it in spice-gtk at first, but that does not work very > well > because usb-

[Spice-devel] [PATCH] Menubar toggle option

2012-06-14 Thread Joel Reed
This very simple patch adds an option to toggle the menubar on spicy. Helps maximize vertical resolution capacity without going fullscreen. Please consider for inclusion. jr -- Joel W. Reed Managing Partner OpenArc, LLC o: 724.234.1215 c: 412.212.8418 diff --git a/gtk/spicy.c b/gtk/spicy.c inde

[Spice-devel] Join spice-devel@lists.freedesktop.org

2012-06-14 Thread Xiang Hua
to get information about all things related to the Spice project. thanks. Hua in Beijing ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-common PATCH] python_modules/ptypes.py/EnumBaseType.c_enumname: add missing return to fix broken enums generation

2012-06-14 Thread Marc-André Lureau
I don't see exactly what it will fixed, perhaps you should include a small example. But that looks like a typo and can't harm, ACK - Mensaje original - > --- > python_modules/ptypes.py |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/python_modules/ptypes.py b

[Spice-devel] [spice-common PATCH] python_modules/ptypes.py/EnumBaseType.c_enumname: add missing return to fix broken enums generation

2012-06-14 Thread Alon Levy
--- python_modules/ptypes.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 132ba99..d9fbfe2 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -234,7 +234,7 @@ class EnumBaseType(Type):

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-14 Thread Alexander Larsson
On Tue, 2012-06-12 at 16:33 +0200, Christophe Fergeau wrote: > On Tue, Jun 12, 2012 at 09:59:39AM -0400, Marc-André Lureau wrote: > > > > > > - Mensaje original - > > > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: > > > > As long as the bitstream is not frozen, we ca

Re: [Spice-devel] [PATCH spice-gtk 2/3] Add a desktop-integration helper class

2012-06-14 Thread Hans de Goede
Hi, On 06/14/2012 12:05 AM, Marc-André Lureau wrote: Hi On Wed, Jun 13, 2012 at 7:07 PM, Hans de Goede wrote: We need to integrate closely with the desktop environment of the user in several cases. Some examples are disabling auto-mounting when auto-usbredir is active (rhbz#812972), and disa