[Spice-devel] why getScanCode() will not work for keyboard input

2013-06-24 Thread i iordanov
Hi Marc-Andre, (And anybody else who wants to weigh in on this). After some research, reading and experimentation, here is what I've discovered. getScanCode() works only for physical devices (e.g. USB keyboards, bluetooth keyboards, or hardware device keyboards). The vast majority of input

Re: [Spice-devel] [Users] Cannot connect to VM via browser if engine was not in /etc/hosts

2013-06-24 Thread Itamar Heim
On 06/24/2013 10:37 AM, lof yer wrote: Is 'engine-config -s SSLEnabled=false' or special spice parameter? It should do the trick. 2013/6/24 Itamar Heim ih...@redhat.com mailto:ih...@redhat.com On 06/24/2013 03:10 AM, lofyer wrote: 于 2013/6/24 1:47, Itamar Heim 写道:

Re: [Spice-devel] [Engine-devel] SPICE Foreign Menu Using REST

2013-06-24 Thread Michal Skrivanek
On Jun 20, 2013, at 14:27 , Itamar Heim ih...@redhat.com wrote: On 06/20/2013 03:13 PM, Tomas Jelinek wrote: - Original Message - From: Itamar Heim ih...@redhat.com To: Christophe Fergeau cferg...@redhat.com Cc: Tomas Jelinek tjeli...@redhat.com, engine-devel

Re: [Spice-devel] [Engine-devel] SPICE Foreign Menu Using REST

2013-06-24 Thread Michal Skrivanek
On Jun 24, 2013, at 10:08 , Itamar Heim ih...@redhat.com wrote: On 06/24/2013 11:02 AM, Michal Skrivanek wrote: On Jun 20, 2013, at 14:27 , Itamar Heim ih...@redhat.com wrote: On 06/20/2013 03:13 PM, Tomas Jelinek wrote: - Original Message - From: Itamar Heim

Re: [Spice-devel] [Engine-devel] SPICE Foreign Menu Using REST

2013-06-24 Thread Itamar Heim
On 06/24/2013 11:02 AM, Michal Skrivanek wrote: On Jun 20, 2013, at 14:27 , Itamar Heim ih...@redhat.com wrote: On 06/20/2013 03:13 PM, Tomas Jelinek wrote: - Original Message - From: Itamar Heim ih...@redhat.com To: Christophe Fergeau cferg...@redhat.com Cc: Tomas Jelinek

[Spice-devel] [spice-gtk] automake: Disable portability warnings

2013-06-24 Thread Christophe Fergeau
When they are enabled, autogen.sh fails with: automake: warnings are treated as errors gtk-doc.make:77: warning: GTK_DOC_V_SETUP_$(V: non-POSIX recursive variable expansion doc/reference/Makefile.am:59: 'gtk-doc.make' included from here gtk-doc.make:78: warning:

Re: [Spice-devel] [spice-gtk] automake: Disable portability warnings

2013-06-24 Thread Daniel P. Berrange
On Mon, Jun 24, 2013 at 11:27:54AM +0200, Christophe Fergeau wrote: -Wportability used to be automatically disabled with automake = 1.12 when using silent rules, but this is no longer the case with automake 1.13 which is what fedora 19 uses:

[Spice-devel] Can we directly redir usb hub?

2013-06-24 Thread 邵鄭叡
Hi all, maybe I should post this message to [usbredir and qemu devel list] , but I just didnt find it :) By default, spice-gtk filters out 'usb hubs' from redir list, and only show 'non-hub non-interface' usb devs. But sometime, we want to just simply pass a usb-hub to guest , and dont care

Re: [Spice-devel] [Engine-devel] SPICE Foreign Menu Using REST

2013-06-24 Thread Christophe Fergeau
On Mon, Jun 24, 2013 at 10:02:29AM +0200, Michal Skrivanek wrote: I would agree as long as it is not hardcoded and can be change in some config file easily. We shouldn't wait for next RHEL release to do a little modification if possible. I think owning the menu in some form on RHEV-M side has

Re: [Spice-devel] [Users] Cannot connect to VM via browser if engine was not in /etc/hosts

2013-06-24 Thread David Jaša
Hi, So you're connecting via User Portal but then it doesn't work? If it doesn't, either you hit a bug or you've tweaked some value that affects things... In general, TLS shouldn't pose a problem because: 1) ovirt sets up its own CA that issues certificates for the hosts 2) the CA certificate

Re: [Spice-devel] Questions regarding Bug 62033 - Means to detect local-only

2013-06-24 Thread David Jaša
Hi Fedor, I'd personally prefer to: 1) monitor bandwidth and latency continuously - there's a long-standing RFE for it and IIRC Yonit has posted some proof-of-concept patches in recent months (as a part of her streamlining of video streams) 2) set the options on-the fly as the conditions allow

[Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

2013-06-24 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-main.c | 73 +++--- 1 file changed, 69 insertions(+), 4 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index b58af52..b9e0da2 100644 --- a/gtk/channel-main.c +++

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

2013-06-24 Thread Daniel P. Berrange
On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-main.c | 73 +++--- 1 file changed, 69 insertions(+), 4 deletions(-) IIUC, implicit in your patch here is that the

Re: [Spice-devel] Questions regarding Bug 62033 - Means to detect local-only

2013-06-24 Thread Fedor Lyakhov
Hi David, Thanks for your answer. Please see my comments below. On Mon, Jun 24, 2013 at 3:47 PM, David Jaša dj...@redhat.com wrote: Hi Fedor, I'd personally prefer to: 1) monitor bandwidth and latency continuously - there's a long-standing RFE for it and IIRC Yonit has posted some

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

2013-06-24 Thread Hans de Goede
Hi, On 06/24/2013 02:39 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-main.c | 73 +++--- 1 file changed, 69 insertions(+), 4

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

2013-06-24 Thread Daniel P. Berrange
On Mon, Jun 24, 2013 at 02:45:25PM +0200, Hans de Goede wrote: Hi, On 06/24/2013 02:39 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/channel-main.c | 73

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

2013-06-24 Thread Hans de Goede
Hi, On 06/24/2013 03:04 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:45:25PM +0200, Hans de Goede wrote: Hi, On 06/24/2013 02:39 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Convert text line-endings if necessary (rhbz#752350)

2013-06-24 Thread Daniel P. Berrange
On Mon, Jun 24, 2013 at 03:23:30PM +0200, Hans de Goede wrote: Hi, On 06/24/2013 03:04 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:45:25PM +0200, Hans de Goede wrote: Hi, On 06/24/2013 02:39 PM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de

Re: [Spice-devel] Questions regarding Bug 62033 - Means to detect local-only

2013-06-24 Thread Hans de Goede
Hi, On 06/24/2013 02:44 PM, Fedor Lyakhov wrote: Hi David, Thanks for your answer. Please see my comments below. On Mon, Jun 24, 2013 at 3:47 PM, David Jaša dj...@redhat.com mailto:dj...@redhat.com wrote: Hi Fedor, I'd personally prefer to: 1) monitor bandwidth and latency

Re: [Spice-devel] Questions regarding Bug 62033 - Means to detect local-only

2013-06-24 Thread Fedor Lyakhov
Hans, Thanks for the comments and clarifications! OK, I'll start with more simple solution of 'local/remote' detection first. As for gsettings - I see your point, this will solve the issue for Gnome3 as requested. But I think this is too limited - e.g. what if KDE5 wants this in future? On

Re: [Spice-devel] Questions regarding Bug 62033 - Means to detect local-only

2013-06-24 Thread Yonit Halperin
Hi, For the purpose of disabling guest desktop effects, we already have a spice-gtk option which we use for Windows guests, and can be used for Linux guests as well. The Linux agent should support VD_AGENT_DISPLAY_CONFIG for this. However, for local usage, we would also like to disable

Re: [Spice-devel] [qxl-win PATCH 2/2] display: fix deadlock when dbg_level = 15

2013-06-24 Thread Yonit Halperin
On 06/23/2013 06:30 AM, Uri Lublin wrote: On 06/21/2013 04:50 PM, Yonit Halperin wrote: DebugPrintV first locks print_sem, and then locks io_sem. async_io, locks io_sem. In ordr to avoid a deadlock, DebugPrintV MUSTN'T be called when io_sem is locked. Also notice, that locking io_sem during

Re: [Spice-devel] Questions regarding Bug 62033 - Means to detect local-only

2013-06-24 Thread Hans de Goede
Hi, On 06/24/2013 05:32 PM, Yonit Halperin wrote: Hi, For the purpose of disabling guest desktop effects, we already have a spice-gtk option which we use for Windows guests, and can be used for Linux guests as well. The Linux agent should support VD_AGENT_DISPLAY_CONFIG for this. However,

Re: [Spice-devel] Can we directly redir usb hub?

2013-06-24 Thread Hans de Goede
Hi, On 06/24/2013 11:40 AM, 邵鄭叡 wrote: Hi all, maybe I should post this message to [usbredir and qemu devel list] , but I just didnt find it :) By default, spice-gtk filters out 'usb hubs' from redir list, and only show 'non-hub non-interface' usb devs. But sometime, we want to just simply

[Spice-devel] [PATCH server 1/3] spice: silencing most of the ping/pong logging

2013-06-24 Thread Yonit Halperin
Those messages are too frequent and don't contribute much --- server/red_channel.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 5662041..c0b1781 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@

[Spice-devel] [PATCH server 3/3] red_worker: improve stream stats readability and ease of parsing

2013-06-24 Thread Yonit Halperin
also added start/end-bit-rate and avg-quality to the final stream stats. --- server/mjpeg_encoder.c | 1 - server/red_worker.c| 22 +++--- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c index 92aef27..04b244e

[Spice-devel] [PATCH spice-gtk 1/2] display: video stats logging - improve readability and ease of parsing

2013-06-24 Thread Yonit Halperin
--- gtk/channel-display.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index bc6fc08..07f6c1e 100644 --- a/gtk/channel-display.c +++ b/gtk/channel-display.c @@ -1511,6 +1511,7 @@ static void

[Spice-devel] [PATCH server 2/3] mjpeg_encoder: add mjpeg_encoder_get_stats

2013-06-24 Thread Yonit Halperin
--- server/mjpeg_encoder.c | 11 +++ server/mjpeg_encoder.h | 7 +++ 2 files changed, 18 insertions(+) diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c index 4460322..92aef27 100644 --- a/server/mjpeg_encoder.c +++ b/server/mjpeg_encoder.c @@ -169,6 +169,7 @@ struct

[Spice-devel] [PATCH spice-gtk 2/2] display: disabling adaptive video streaming via env var SPICE_DISABLE_ADAPTIVE_STREAMING

2013-06-24 Thread Yonit Halperin
spice-server supports adaptive video streaming only if the client publishes SPICE_DISPLAY_CAP_STREAM_REPORT. Disabling this feature is useful for debugging and performance comparison. --- gtk/channel-display.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff

Re: [Spice-devel] [PATCH server 1/3] spice: silencing most of the ping/pong logging

2013-06-24 Thread Hans de Goede
Looks good, ACK-series On 06/24/2013 09:38 PM, Yonit Halperin wrote: Those messages are too frequent and don't contribute much --- server/red_channel.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: video stats logging - improve readability and ease of parsing

2013-06-24 Thread Hans de Goede
Looks good, ACK series. On 06/24/2013 09:38 PM, Yonit Halperin wrote: --- gtk/channel-display.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index bc6fc08..07f6c1e 100644 --- a/gtk/channel-display.c +++