Re: [Spice-devel] [PATCH v3 vdagent-linux] vdagentd: support fake uinput

2013-09-03 Thread Hans de Goede
ACK. On 09/02/2013 11:09 PM, Alon Levy wrote: This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy al...@redhat.com ---

Re: [Spice-devel] multi monitor setup ?

2013-09-03 Thread Brad Campbell
On 30/08/13 21:36, Alexandre DERUMIER wrote: Hi, I'm looking for documentation about multi monitor setup, and I can't find it. How do it work ? Here's how I do it. #!/bin/sh qemu -enable-kvm\ -m 24576\ -rtc base=localtime\ -vga qxl\ -device qxl\ -net nic,model=virtio\ -net

[Spice-devel] [KEYVAL PATCH v1] add KEYVAL enums to protocol header definitions

2013-09-03 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer diet...@proxmox.com --- spice/enums.h|8 spice/protocol.h |1 + 2 files changed, 9 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index 8c731e9..e6adb5a 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -301,6 +301,13 @@ typedef enum

[Spice-devel] [KEYVAL PATCH v1] add push_keyval callback to SpiceKbdInterface

2013-09-03 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer diet...@proxmox.com --- server/inputs_channel.c | 20 server/spice.h |1 + 2 files changed, 21 insertions(+) diff --git a/server/inputs_channel.c b/server/inputs_channel.c index 931dac1..248ecae 100644 ---

[Spice-devel] [KEYVAL PATCH v1] protocol extension for UTF/KEYVAL input

2013-09-03 Thread Dietmar Maurer
Some SPICE applications want to use the keymap from the client side, and works directly with UTF input characters (for examply a terminal emulator). The current scancode values cannot be used for those applications. Unfortunately, UTF character set miss all special keyboard keys like

[Spice-devel] [KEYVAL PATCH v1] add SpiceMsgcKeyKeyval protocol message definition

2013-09-03 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer diet...@proxmox.com --- common/client_marshallers.h |1 + common/messages.h |5 + spice.proto | 10 ++ 3 files changed, 16 insertions(+) diff --git a/common/client_marshallers.h b/common/client_marshallers.h index

Re: [Spice-devel] [PATCH vdagent-linux 3/4] vdagentd: support virtio as uds for Xspice usage

2013-09-03 Thread Uri Lublin
Hi Alon, The socket should be closed if connect() fails. Please see below. Looks good otherwise. Thanks, Uri. Signed-off-by: Alon Levy al...@redhat.com --- src/vdagent-virtio-port.c | 53 +-- 1 file changed, 47 insertions(+), 6

[Spice-devel] FOSDEM'14

2013-09-03 Thread Fedor Lyakhov
Hello Spice developers, I'm planning to visit FOSDEM this year, hope to meet you in 'real life'. As I'm a newbie, there are few questions which bother me: 1. Do you know whether Virtualization devroom will be hosted at this FOSDEM as it was in 2013? Will any Spice-related topics be discussed

[Spice-devel] [PATCH vdagent-linux] vdagent-virtio-port: close socket on error

2013-09-03 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/vdagent-virtio-port.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index bdd22d9..bacfa42 100644 --- a/src/vdagent-virtio-port.c +++ b/src/vdagent-virtio-port.c @@ -116,6 +116,9 @@

Re: [Spice-devel] [PATCH vdagent-linux] vdagent-virtio-port: close socket on error

2013-09-03 Thread Hans de Goede
ACK. On 09/03/2013 12:07 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/vdagent-virtio-port.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index bdd22d9..bacfa42 100644 --- a/src/vdagent-virtio-port.c +++

Re: [Spice-devel] FOSDEM'14

2013-09-03 Thread Alon Levy
Hello Spice developers, I'm planning to visit FOSDEM this year, hope to meet you in 'real life'. As I'm a newbie, there are few questions which bother me: 1. Do you know whether Virtualization devroom will be hosted at this FOSDEM as it was in 2013? Will any Spice-related topics be

Re: [Spice-devel] [PATCH] server: bitmap_consistent: replace spice_error with spice_warning

2013-09-03 Thread Daniel P. Berrange
On Sun, Sep 01, 2013 at 09:43:17PM +0300, Uri Lublin wrote: bitmap_consistent should return true or false. Currently it aborts instead of returning false, due to spice_error. Replacing spice_error with spice_warning, provides information and returns false, as expected. This fixes Fedora