[Spice-devel] spice ssl live migration

2014-10-22 Thread yao xu
Hi all! I am using spice and ovirt(a old version). when I use remote-viewer with correct ssl certifacate to connect the vm , and then live migrate the vm to another host , remote-viewer is dead .I must reconnect the vm . Can I use remote-viewer continuous when the vm is migrating? How to

Re: [Spice-devel] win 7 terminal recognize usb as libusbx device when exiting usb redirect

2014-10-22 Thread Uri Lublin
On 10/22/2014 04:40 AM, 陈晴 wrote: hi, all: environment: terminal: win 7 guest: win 7 usb redirect: usb clerk (provided by Cody Chan) usb device: kinston data traveller 8G teclast 16G (use correctly) usb harddisk (use correctly) following

[Spice-devel] Fwd: a question about Xspice

2014-10-22 Thread Hans de Goede
Hi, Forwarding this to you guys from the xorg-devel list. Regards, Hans Forwarded Message Subject: a question about Xspice Date: Tue, 21 Oct 2014 17:30:54 +0800 (CST) From: cynthia cynthia_...@163.com To: xorg-de...@lists.x.org, x...@lists.x.org HI All, I am trying to

Re: [Spice-devel] Fwd: a question about Xspice

2014-10-22 Thread Alon Levy
On 10/22/2014 11:37 AM, Hans de Goede wrote: Hi, Forwarding this to you guys from the xorg-devel list. Regards, Hans Forwarded Message Subject: a question about Xspice Date: Tue, 21 Oct 2014 17:30:54 +0800 (CST) From: cynthia cynthia_...@163.com To:

Re: [Spice-devel] Fwd: a question about Xspice

2014-10-22 Thread Uri Lublin
On 10/22/2014 11:37 AM, Hans de Goede wrote: Hi, Forwarding this to you guys from the xorg-devel list. Regards, Hans Forwarded Message Subject: a question about Xspice Date: Tue, 21 Oct 2014 17:30:54 +0800 (CST) From: cynthia cynthia_...@163.com To:

Re: [Spice-devel] spice ssl live migration

2014-10-22 Thread David Jaša
Hi, On St, 2014-10-22 at 12:03 +0800, yao xu wrote: Hi all! I am using spice and ovirt(a old version). when I use remote-viewer with correct ssl certifacate to connect the vm , and then live migrate the vm to another host , The certificates for both hosts have to be issued by the

Re: [Spice-devel] [PATCH xf86-video-qxl v2] Revise the XSpice audio processing to avoid the use of pthreads.

2014-10-22 Thread Christophe Fergeau
Hey, There are a bunch of calloc/malloc throughout the patch with no check for a NULL return, would be nice to add that. This also adds inotify monitoring, do we need to add a check for it to configure.ac? (eg a check for sys/inotify.h) One small note below for a typo, looks good to me apart

[Spice-devel] [PATCH] drmmode: Fix compilation warning

2014-10-22 Thread Christophe Fergeau
One recent change introduced a gcc compilation warning: CC qxl_drmmode.lo qxl_drmmode.c: In function 'drmmode_set_mode_major': qxl_drmmode.c:251:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] CursorPtr cursor = xf86_config-cursor;

Re: [Spice-devel] [PATCH] drmmode: Fix compilation warning

2014-10-22 Thread Marc-André Lureau
ack, - Original Message - One recent change introduced a gcc compilation warning: CC qxl_drmmode.lo qxl_drmmode.c: In function 'drmmode_set_mode_major': qxl_drmmode.c:251:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]

Re: [Spice-devel] [PATCH] drmmode: Fix compilation warning

2014-10-22 Thread Christophe Fergeau
On Wed, Oct 22, 2014 at 10:45:47AM -0400, Marc-André Lureau wrote: ack, Fwiw, I don't think I have write access to qxl git repository (or maybe I'm having the same issue as the one you are having) Christophe pgpU5B67bD9OF.pgp Description: PGP signature

[Spice-devel] [spice-gtk] Fix SndCodec leak in playback_handle_start()

2014-10-22 Thread Christophe Fergeau
An audio SpiceChannel can get several times the 'start' message during its lifetime. If received multiple times (for example when rebooting a VM), this would lead to a SndCodec leak as reported by valgrind: ==7749== 27,036 (48 direct, 26,988 indirect) bytes in 1 blocks are definitely lost in

Re: [Spice-devel] [spice-gtk] Fix SndCodec leak in playback_handle_start()

2014-10-22 Thread Marc-André Lureau
ack - Original Message - An audio SpiceChannel can get several times the 'start' message during its lifetime. If received multiple times (for example when rebooting a VM), this would lead to a SndCodec leak as reported by valgrind: ==7749== 27,036 (48 direct, 26,988 indirect) bytes

Re: [Spice-devel] [PATCH xf86-video-qxl v2] Revise the XSpice audio processing to avoid the use of pthreads.

2014-10-22 Thread Jeremy White
On 10/22/2014 09:38 AM, Christophe Fergeau wrote: Hey, There are a bunch of calloc/malloc throughout the patch with no check for a NULL return, would be nice to add that. Hmm. I've seen this argued both ways. One side argues that if an allocation is never expected to fail, that it's best

Re: [Spice-devel] Fwd: a question about Xspice

2014-10-22 Thread cynthia
At 2014-10-22 19:26:20, Uri Lublin u...@redhat.com wrote: On 10/22/2014 11:37 AM, Hans de Goede wrote: Hi, Forwarding this to you guys from the xorg-devel list. Regards, Hans Forwarded Message Subject: a question about Xspice Date: Tue, 21 Oct 2014 17:30:54 +0800

Re: [Spice-devel] [PATCH xf86-video-qxl v2] Revise the XSpice audio processing to avoid the use of pthreads.

2014-10-22 Thread Jeremy White
Forgot to mention that there are more error situations in this function where it looks like data would be leaked. Sure, added a few more checks. v3 with configure checking, the typo fix, and those checks inbound shortly. Cheers, Jeremy ___

[Spice-devel] [PATCH xf86-video-qxl v3] Revise the XSpice audio processing to avoid the use of pthreads.

2014-10-22 Thread Jeremy White
The initial implementation used a separate thread to drive the audio playback channel. But if you have adaptive streaming turned on, you will eventually get a update_client_playback_latency message on the display channel (which in the Xspice case is being driven by the main, Xorg, thread). After