ACK.
On Tue, Oct 28, 2014 at 09:32:24PM +0100, Marc-André Lureau wrote:
---
vapi/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vapi/Makefile.am b/vapi/Makefile.am
index 568007d..46f06a0 100644
--- a/vapi/Makefile.am
+++ b/vapi/Makefile.am
@@ -17,6 +17,8 @@ EXTRA_DIST
On Tue, Oct 28, 2014 at 09:32:23PM +0100, Marc-André Lureau wrote:
---
vapi/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/vapi/Makefile.am b/vapi/Makefile.am
index e19aefc..568007d 100644
--- a/vapi/Makefile.am
+++ b/vapi/Makefile.am
@@ -11,7 +11,6 @@ dist_vapi_DATA =
On Tue, Oct 28, 2014 at 09:32:22PM +0100, Marc-André Lureau wrote:
Whenever the symbols files are modified, rebuild the library.
I'm confused about that one, aren't these symbol files supposed to be
updated automatically with 'make update-symbol-files' when needed?
Christophe
ACK.
On Tue, Oct 28, 2014 at 09:32:25PM +0100, Marc-André Lureau wrote:
---
vapi/Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vapi/Makefile.am b/vapi/Makefile.am
index 46f06a0..ad43d69 100644
--- a/vapi/Makefile.am
+++ b/vapi/Makefile.am
@@ -20,14
Hi
On Wed, Oct 29, 2014 at 10:07 AM, Christophe Fergeau cferg...@redhat.com
wrote:
On Tue, Oct 28, 2014 at 09:32:22PM +0100, Marc-André Lureau wrote:
Whenever the symbols files are modified, rebuild the library.
I'm confused about that one, aren't these symbol files supposed to be
updated
On Wed, Oct 29, 2014 at 11:12:32AM +0100, Marc-André Lureau wrote:
Hi
On Wed, Oct 29, 2014 at 10:07 AM, Christophe Fergeau cferg...@redhat.com
wrote:
On Tue, Oct 28, 2014 at 09:32:22PM +0100, Marc-André Lureau wrote:
Whenever the symbols files are modified, rebuild the library.
I'm
On Tue, Oct 28, 2014 at 09:32:22PM +0100, Marc-André Lureau wrote:
Whenever the symbols files are modified, rebuild the library.
---
gtk/Makefile.am | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index
commit d006db824d0afca22161945388fed5187cf29ee6
Author: Marc-Andr?? Lureau marcandre.lur...@redhat.com
Date: Tue Oct 28 21:11:20 2014 +0100
build-sys: add extra dependencies on symbols files
Whenever the symbols files are modified, rebuild the library.
Would be nice if you
On Wed, Oct 29, 2014 at 12:18 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Would be nice if you did not push unreviewed patches, I did not look at
the patch at all as the mixed in renaming made it harder to review.
Ok, pushed under the trival build fixes rule.
--
Marc-André Lureau
On Wed, Oct 29, 2014 at 12:25:49PM +0100, Marc-André Lureau wrote:
Ok, pushed under the trival build fixes rule.
Build was not broken, which is when this rule applies.
Christophe
pgpydUmTCa9J1.pgp
Description: PGP signature
___
Spice-devel mailing
On Wed, Oct 29, 2014 at 12:30 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Build was not broken, which is when this rule applies.
As a maintainer, I am not aware of such strict rule.
--
Marc-André Lureau
___
Spice-devel mailing list
On Wed, Oct 29, 2014 at 12:46 PM, Christophe Fergeau cferg...@redhat.com
wrote:
We can play that game for a while, but I'm not sure this is going to go
very far :) You initially sent the patches so I assume this means you
wanted a review. I spent some time on them, and indicated that they
I
On Wed, Oct 29, 2014 at 12:53:19PM +0100, Marc-André Lureau wrote:
On Wed, Oct 29, 2014 at 12:46 PM, Christophe Fergeau cferg...@redhat.com
wrote:
We can play that game for a while, but I'm not sure this is going to go
very far :) You initially sent the patches so I assume this means you
On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote:
- Original Message -
Message will be used by client for requesting an information about
a version of the agent running on the guest side.
---
v2:
- removed 'type' field from VDAgentInformation
-
- Mail original -
On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote:
- Original Message -
Message will be used by client for requesting an information about
a version of the agent running on the guest side.
---
v2:
- removed 'type' field
On Wed, 2014-10-29 at 09:48 -0400, Marc-André Lureau wrote:
- Mail original -
On Fri, Oct 24, 2014 at 10:44:33AM -0400, Marc-André Lureau wrote:
- Original Message -
Message will be used by client for requesting an information about
a version of the agent
On Wed, Oct 29, 2014 at 3:34 PM, Jonathon Jongsma jjong...@redhat.com
wrote:
I'm not sure that I'm a big fan of a free-form field. It would be nice
if it had at least *some* structure and you could expert certain
information to be there...
Then I would have a defined structured message in
It was only added to map-file.
---
gtk/spice-glib-sym-file | 1 +
1 file changed, 1 insertion(+)
diff --git a/gtk/spice-glib-sym-file b/gtk/spice-glib-sym-file
index 878dd12..a7a416d 100644
--- a/gtk/spice-glib-sym-file
+++ b/gtk/spice-glib-sym-file
@@ -59,6 +59,7 @@ spice_record_send_data
This symbol only exists when building with glib 2.26 and is only
referenced by a compat G_TYPE_ERROR macro only used at build time
but not declared in any exported header.
---
gtk/map-file | 1 -
1 file changed, 1 deletion(-)
diff --git a/gtk/map-file b/gtk/map-file
index 90f14f1..e421800
It's not meant to be exported as it's not listed in spice-gtk symbol map file.
---
gtk/spice-gtk-session-priv.h | 1 +
gtk/spice-gtk-session.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/spice-gtk-session-priv.h b/gtk/spice-gtk-session-priv.h
index
Some symbols were manually added to these files not in the right place
(non-alphabetical order). This causes spurious diffs when trying to
compare these files with the ones make update-symbol-files would
generate.
This commit syncs these file with the ones which are autogenerated to
spot more
Not fully sure about 3/5 to be honest, might be better to drop it for now.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Without that, it will fail to parse:
GType spice_uri_get_type(void) G_GNUC_CONST;
---
gtk/Makefile.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index 1430354..7bc5842 100644
--- a/gtk/Makefile.am
+++ b/gtk/Makefile.am
@@ -677,13
ack
- Mail original -
It was only added to map-file.
---
gtk/spice-glib-sym-file | 1 +
1 file changed, 1 insertion(+)
diff --git a/gtk/spice-glib-sym-file b/gtk/spice-glib-sym-file
index 878dd12..a7a416d 100644
--- a/gtk/spice-glib-sym-file
+++ b/gtk/spice-glib-sym-file
@@
ack
- Mail original -
It's not meant to be exported as it's not listed in spice-gtk symbol map
file.
---
gtk/spice-gtk-session-priv.h | 1 +
gtk/spice-gtk-session.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/spice-gtk-session-priv.h
ack
- Mail original -
Without that, it will fail to parse:
GType spice_uri_get_type(void) G_GNUC_CONST;
---
gtk/Makefile.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index 1430354..7bc5842 100644
---
iirc, spice-gtk widgets will fail to link on glib 2.22 without it.
- Mail original -
This symbol only exists when building with glib 2.26 and is only
referenced by a compat G_TYPE_ERROR macro only used at build time
but not declared in any exported header.
---
gtk/map-file | 1 -
On Wed, Oct 29, 2014 at 4:31 PM, Pavel Grunt pgr...@redhat.com wrote:
What do you think about using the message structure that was suggested in
v1 (with the type field specifying what type of information is provided) ?
Please detail how that would help: to me it is introducing an agent
Please detail how that would help: to me it is introducing an agent
message subtype, and I don't see the need, you can simply use the
agent message type (which is already a subtype of spice main
messages)
I wanted to use the type field to determine the type of information of the
text
This keeps an XSpice server from spin looping, which it will do if
data is presented, but num_send_tokens == 0.
Signed-off-by: Jeremy White jwh...@codeweavers.com
---
main.js |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main.js b/main.js
index 91f1963..e487551 100644
30 matches
Mail list logo
