Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-14 Thread Christophe Fergeau
On Thu, Nov 13, 2014 at 07:26:10PM +0100, Marc-André Lureau wrote: On Thu, Nov 13, 2014 at 6:38 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Thu, Nov 13, 2014 at 05:41:20PM +0100, Marc-André Lureau wrote: On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

2014-11-14 Thread Christophe Fergeau
On Thu, Nov 13, 2014 at 05:18:51PM +0100, Marc-André Lureau wrote: Hi On Thu, Nov 13, 2014 at 10:10 AM, Christophe Fergeau cferg...@redhat.com wrote: At first, I thought you meant that this function was no longer available at all, causing an ABI break. After reading the full patch, it

Re: [Spice-devel] Report Error in Link spice-guest-tools

2014-11-14 Thread Christophe Fergeau
Hey, On Thu, Nov 13, 2014 at 11:00:08PM -0600, Israel Peralta wrote: Hi I would like to report the problem in the link of the page and the download page in two cases it is imposible download the spice-guest-tools the download mark incomplete in all cases. Can you be more specific about

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-14 Thread Marc-André Lureau
On Fri, Nov 14, 2014 at 10:59 AM, Christophe Fergeau cferg...@redhat.com wrote: Hmm I only partially understood what your log meant, and tried to improve it, but it's very partial. I think it's better to be explicit about main context/coroutine context here, maybe something like During

[Spice-devel] qemu 2.2 crash on linux hvm domU (full backtrace included)

2014-11-14 Thread Fabio Fantoni
dom0 xen-unstable from staging git with x86/hvm: Extend HVM cpuid leaf with vcpu id and x86/hvm: Add per-vcpu evtchn upcalls patches, and qemu 2.2 from spice git (spice/next commit e779fa0a715530311e6f59fc8adb0f6eca914a89): https://github.com/Fantu/Xen/commits/rebase/m2r-staging Qemu crash on

[Spice-devel] [PATCH spice-gtk v4 2/3] Send keyboard description

2014-11-14 Thread Pavel Grunt
The keyboard description of the client will be sent to the guest when the connection is established. RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332 --- v4: - keyboard description for windows clients is based on GetLocaleInfo instead of parsing g_win32_getlocale v3: - wrong

[Spice-devel] [PATCH spice-gtk v4 1/3] Support for keyboard description message

2014-11-14 Thread Pavel Grunt
This commit introduces function for sending the message to the agent. RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332 --- v4: - updated spice-glib-sym-file v3: - added 'Since: 0.27' - added check for 'data' parameter - updated spice-gtk-sections.txt v2: -

[Spice-devel] [PATCH spice-gtk v4 3/3] spice-gtk-session: add auto-keyboard-sync property

2014-11-14 Thread Pavel Grunt
The property is used to enable sending client's keyboard description to the guest. --- gtk/spice-gtk-session.c | 28 1 file changed, 28 insertions(+) diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c index 60cf899..d955252 100644 ---

[Spice-devel] [PATCH spice] Remove guest side video time-stamping

2014-11-14 Thread Marc-André Lureau
The multimedia time is defined by the server side monotonic time [1], but the drawing time-stamp is done in guest side, so it requires synchronization between host and guest. This is expensive, when no audio is playing, there is a ~30x/sec wakeup to update the qxl device mmtime, and it requires

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-14 Thread Christophe Fergeau
On Fri, Nov 14, 2014 at 12:06:30PM +0100, Marc-André Lureau wrote: On Fri, Nov 14, 2014 at 10:59 AM, Christophe Fergeau cferg...@redhat.com wrote: Hmm I only partially understood what your log meant, and tried to improve it, but it's very partial. I think it's better to be explicit about

Re: [Spice-devel] [PATCH spice-gtk v2 06/19] migration: set connecting state before fd request

2014-11-14 Thread Marc-André Lureau
Following first review thread, comment is updated with During migration, the main channel coroutine initiating the process is waiting for connection completion of all channels. migrate_channel_event_cb() yields back to the main channel coroutine once all channels have completed connection, or it

Re: [Spice-devel] [PATCH spice-gtk v2 12/19] coroutine: reference object when signaling

2014-11-14 Thread Christophe Fergeau
On Fri, Nov 14, 2014 at 12:32:35AM +0100, Marc-André Lureau wrote: Before the signal is actually emitted, the channel may be released. Let's keep a reference to the object during the function time, to prevent the object from being destroyed before calling g_signal_emit() in main context.

Re: [Spice-devel] [PATCH spice-gtk v2 13/19] migration: don't check socket error

2014-11-14 Thread Christophe Fergeau
ACK patches 01 to 13 Christophe On Fri, Nov 14, 2014 at 12:32:36AM +0100, Marc-André Lureau wrote: During migration, the original socket is closed before the coroutine finishes, so it's not guaranteed that c-sock will still be set when the channel is in an error state in

Re: [Spice-devel] [PATCH spice-gtk v2 12/19] coroutine: reference object when signaling

2014-11-14 Thread Marc-André Lureau
- Original Message - On Fri, Nov 14, 2014 at 12:32:35AM +0100, Marc-André Lureau wrote: Before the signal is actually emitted, the channel may be released. Let's keep a reference to the object during the function time, to prevent the object from being destroyed before calling

Re: [Spice-devel] [PATCH spice-gtk v2 12/19] coroutine: reference object when signaling

2014-11-14 Thread Christophe Fergeau
On Fri, Nov 14, 2014 at 09:31:13AM -0500, Marc-André Lureau wrote: - Original Message - On Fri, Nov 14, 2014 at 12:32:35AM +0100, Marc-André Lureau wrote: Before the signal is actually emitted, the channel may be released. Let's keep a reference to the object during the

Re: [Spice-devel] [PATCH spice-gtk v2 12/19] coroutine: reference object when signaling

2014-11-14 Thread Marc-André Lureau
- Original Message - On Fri, Nov 14, 2014 at 09:31:13AM -0500, Marc-André Lureau wrote: - Original Message - On Fri, Nov 14, 2014 at 12:32:35AM +0100, Marc-André Lureau wrote: Before the signal is actually emitted, the channel may be released. Let's keep a