Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-30 Thread Christophe Fergeau
On Mon, Jun 29, 2015 at 06:59:26PM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Mon Jun 29 17:22:23 +0200 2015: On Mon, Jun 29, 2015 at 05:11:36PM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Mon Jun 29 17:01:23 +0200 2015:

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-06-30 Thread Jeremy White
It's pointless to post a patch that you know has problems with it (i.e. it's not even in proper kernel coding style), as it will never be reviewed or even looked at. Thanks for the reply, and I'm sorry for the clumsy ask. I would still appreciate feedback on two points: 1. Is the basic

Re: [Spice-devel] [win32-qxl PATCH v3] Add monitors_config escape to Windows QXL display driver.

2015-06-30 Thread Christophe Fergeau
On Thu, Jun 25, 2015 at 12:56:41PM +0200, Fabiano FidĂȘncio wrote: On Wed, Jun 24, 2015 at 8:29 PM, Sandy Stutsman sstut...@redhat.com wrote: Provides correct monitor locations when specified via the guest Screen Resolution applet.

[Spice-devel] USB redirection issues

2015-06-30 Thread Viacheslav Ivanov
Hello, we're using virt-viewer 0.5.7-8 to connect to VMs and found an issue that usb tokens are not always redirected to vm: they're always recognized by the host kernel on connect/disconnect events and properly handled by the pcscd daemon. Guest OS is RHEL 64. with SSO enabled. On connect to

[Spice-devel] [spice-common] m4: Add compat AS_VAR_APPEND for older autoconf

2015-06-30 Thread Christophe Fergeau
This causes failures on EL6 otherwise as autoconf is too old there. --- configure.ac | 4 m4/spice-deps.m4 | 5 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 3a8c0e5..4287f92 100644 --- a/configure.ac +++ b/configure.ac @@ -12,10

Re: [Spice-devel] [PATCH spice-gtk v3 0/3] Report the preferred compression method to server

2015-06-30 Thread Christophe Fergeau
On Mon, Jun 29, 2015 at 03:07:27PM +0200, Christophe Fergeau wrote: Hey, On Mon, Jun 01, 2015 at 04:48:45PM +0200, Javier Celaya wrote: This patch set allows the client to report its preferred image compression method to the server. It is read from command line and sent when the display

Re: [Spice-devel] [vd_agent PATCH V3] Add monitors_config driver escape.

2015-06-30 Thread Christophe Fergeau
On Mon, Jun 29, 2015 at 09:09:37AM -0400, Sandy Stutsman wrote: Works for me. I've now pushed this. Christophe pgpa80O_3__7D.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [PATCH] Make monitors config debug output more clear

2015-06-30 Thread Jonathon Jongsma
Indicate whether the monitors config debug output is from sending or receiving new monitors configuration. You can tell this by looking at which channel is involved (main vs display), but making it more explicit is helpful for glancing through logs. --- src/channel-display.c | 2 +-

Re: [Spice-devel] [PATCH 1/2] server: allows to set maximum monitors

2015-06-30 Thread Frediano Ziglio
On Fri, Jun 19, 2015 at 11:56:05AM +0100, Frediano Ziglio wrote: spice-server will attempt to limit number of monitors. Guest machine can send monitor list it accepts. Limiting the number sent by guest will limit the number of monitors client will try to enable. The guest usually see

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-30 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Tue Jun 30 09:30:42 +0200 2015: On Mon, Jun 29, 2015 at 06:59:26PM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Mon Jun 29 17:22:23 +0200 2015: On Mon, Jun 29, 2015 at 05:11:36PM +0200, Michal Suchanek wrote:

[Spice-devel] [PATCH 5/5] Add a usbredirtestserver.

2015-06-30 Thread Jeremy White
This server can create a large number of dummy usbredir test devices. This is particularly useful in testing the usbredir kernel module. Signed-off-by: Jeremy White jwh...@codeweavers.com --- Makefile.am | 2 +- configure.ac| 1 +

[Spice-devel] [PATCH 4/5] Add a connectkernel utility to support the usbredir kernel module.

2015-06-30 Thread Jeremy White
This utility will connect to a remote system running usbredirserver, and then write the socket to the sysfs attach point of usbredir, thereby injecting the remote device into the local kernel. Signed-off-by: Jeremy White jwh...@codeweavers.com --- Makefile.am | 2 +-

[Spice-devel] [PATCH 3/5] The kernel limits stack size to 2048; we can safely skip ahead a little more slowly and be kernel compatible.

2015-06-30 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- usbredirparser/usbredirparser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usbredirparser/usbredirparser.c b/usbredirparser/usbredirparser.c index 58f62c3..154d95b 100644 --- a/usbredirparser/usbredirparser.c +++

[Spice-devel] [PATCH 2/5] We cannot use abort() in the kernel.

2015-06-30 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- usbredirparser/usbredirparser.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/usbredirparser/usbredirparser.c b/usbredirparser/usbredirparser.c index 889ba55..58f62c3 100644 --- a/usbredirparser/usbredirparser.c

[Spice-devel] [PATCH 1/5] Make a set of changes to the parser code to enable it to compile inside the kernel tree.

2015-06-30 Thread Jeremy White
This would allow us to use the same code for the user space tools as we use for the kernel module. Signed-off-by: Jeremy White jwh...@codeweavers.com --- usbredirparser/strtok_r.c | 4 ++ usbredirparser/usbredirfilter.c | 55 +++-

[Spice-devel] [PATCH 0/5] RFC - Support patches for upcoming usbredir kernel module

2015-06-30 Thread Jeremy White
This set of patches to usbredir are intended to procede a PATCH RFC for the upcoming Linux usbredir kernel module. I wanted to post this set here, so I could reference them in that patch. Feel free to defer discussion of these patches until the kernel module patch rfc lands. Cheers, Jeremy

[Spice-devel] [RFC PATCH 0/1] RFC - Implement a usbredir kernel module

2015-06-30 Thread Jeremy White
The following patch proposes a new kernel module to provide an alternate protocol for transporting USB devices over a TCP/IP connection. This flows from a few conversations on the Spice devel mailing list.[1][2] I am relying heavily on the opinion of Hans de Goede, who believes that the usbredir