Re: [Spice-devel] [spice-gtk v1] clipboard: Fix crash by handling error

Hi - Original Message - > From: Victor Toso > > As manual states below, text could be NULL for different reasons and > we should handle that. I've included a debug message to help > identifying possible regressions in wayland. > > "The text parameter to callback

Re: [Spice-devel] [PATCH spice-server v3 1/3] Add CommonGraphicsChannelPrivate struct

Hi, On Fri, Oct 14, 2016 at 03:37:39PM +0100, Frediano Ziglio wrote: > From: Jonathon Jongsma > > Encapsulate private data for CommonGraphicsChannel and prepare for > GObject conversion. > --- > server/common-graphics-channel.c | 33 +++-- >

[Spice-devel] [spice-gtk v1] clipboard: Fix crash by handling error

From: Victor Toso As manual states below, text could be NULL for different reasons and we should handle that. I've included a debug message to help identifying possible regressions in wayland. "The text parameter to callback will contain the resulting text if the request

Re: [Spice-devel] [PATCH qxl-wddm-dod v2 2/2] Call "DxgkCbAcquirePostDisplayOwnership" when changing Power State to D0

> > Starting with Windows Display Driver Model (WDDM) 1.2, if the > DevicePowerState parameter is set to PowerDeviceD0, the display miniport > driver should call DxgkCbAcquirePostDisplayOwnership to query the > information about the display mode. > > This patch fixies this bug: >

Re: [Spice-devel] [PATCH qxl-wddm-dod v2 1/2] Fixing black-white screen in installation when qxl revision = 3

> > When qxl revision is 3, the vga driver is the one that is running. When > installing the driver the function VgaDevice::HWInit with displayInfo > structure that is zeroed out. The displayInfo should be initialized using > DxgkCbAcquirePostDisplayOwnership and thus it should be called before >

Re: [Spice-devel] usbredirparser: fix EAGAIN error in *_do_write()

> > Hello, > > I'd like to propose a bugfix for usbredirparser.c usbredirparser_do_write() > procedure, see below. > > > Issue description: > > usbredirparser_do_write() does not handle EAGAIN properly. > In case of large write parser->callb.write_func() returns 0 with > errno=EAGAIN. > >

Re: [Spice-devel] [spice-server] doc: Remove mention that qxl.guestdebug is Windows-only

> > The Linux QXL KMS driver also uses it. > --- > docs/manual/manual.txt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt > index 3340341..9d394b6 100644 > --- a/docs/manual/manual.txt > +++ b/docs/manual/manual.txt >

[Spice-devel] [spice-server] doc: Remove mention that qxl.guestdebug is Windows-only

The Linux QXL KMS driver also uses it. --- docs/manual/manual.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt index 3340341..9d394b6 100644 --- a/docs/manual/manual.txt +++ b/docs/manual/manual.txt @@ -1176,9 +1176,8 @@

[Spice-devel] usbredirparser: fix EAGAIN error in *_do_write()

Hello, I'd like to propose a bugfix for usbredirparser.c usbredirparser_do_write() procedure, see below. Issue description: usbredirparser_do_write() does not handle EAGAIN properly. In case of large write parser->callb.write_func() returns 0 with errno=EAGAIN. Then usbredirparser_do_write()

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

On Thu, 13 Oct 2016, Frediano Ziglio wrote: [...] > I discovered where the main lag came quite by "accident". To test > I used one small utility and this utility don't have a way to change > parameters (like bandwidth) so knowing how the tcp work I stopped > the utility and started again as fast

Re: [Spice-devel] [PATCH spice-server v3 1/3] Add CommonGraphicsChannelPrivate struct

> > From: Jonathon Jongsma > > Encapsulate private data for CommonGraphicsChannel and prepare for > GObject conversion. > --- > server/common-graphics-channel.c | 33 +++-- > server/common-graphics-channel.h | 14 ++ >

[Spice-devel] [PATCH spice-server v3 0/3] Convert RedChannel to GObject

Changes since v2: - merged some patches; - rebased on master. Changes sinced v1: - pushed ACKED bugfix patch to master and dropped from this series - dropped InputsChannelPrivate patch - Removed MainChannelPrivate struct and reduced that patch to simply encapsulate the data better - moved

[Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

From: Jonathon Jongsma Encapsulate MainChannel a bit better in preparation for proting to GObject. --- server/main-channel-client.c | 24 +++- server/main-channel.c| 15 +++ server/main-channel.h| 2 ++ 3 files changed, 28

Re: [Spice-devel] [PATCH spice] rcc: Make OutgoingHandler private

> > --- > server/red-channel-client-private.h | 12 > server/red-channel-client.c | 10 +- > server/red-channel-client.h | 11 --- > 3 files changed, 17 insertions(+), 16 deletions(-) > > diff --git a/server/red-channel-client-private.h >

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

Hi, On Thu, Oct 13, 2016 at 06:00:10PM +, Brad Wilson wrote: > So one thing I notice is that there is a multimedia audio device that > has a bad driver in the device manager... Can you elaborate in the issue you see/hear? Might be this one: https://bugzilla.redhat.com/show_bug.cgi?id=1203507

Re: [Spice-devel] [PATCH spice-gtk v2 0/4]Add more tests for the session's uri

Hi, On Wed, Oct 12, 2016 at 05:08:22PM +0200, Pavel Grunt wrote: > Hi, > > I plan to merge both uri parsers (one is in spice-session, one in spice-uri). > These patches add more to tests to avoid regressions. > > v2 per Victor review splits IPv6 tests and checks for expected warnings > v1:

[Spice-devel] [PATCH spice-server v2 7/8] Make compression image declarations more similar

Signed-off-by: Frediano Ziglio --- server/image-encoders.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/server/image-encoders.h b/server/image-encoders.h index 6542edd..6b4999e 100644 --- a/server/image-encoders.h +++ b/server/image-encoders.h

[Spice-devel] [PATCH spice-server v2 3/8] Remove warnings from reds_stat utility

Signed-off-by: Frediano Ziglio --- tools/reds_stat.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/reds_stat.c b/tools/reds_stat.c index 9aca1ad..3e966d4 100644 --- a/tools/reds_stat.c +++ b/tools/reds_stat.c @@ -24,6 +24,7 @@ #include

[Spice-devel] [PATCH spice-server v2 8/8] Do not declare image_encoders_compress_lz4 if LZ4 is not available

Signed-off-by: Frediano Ziglio --- server/image-encoders.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/image-encoders.h b/server/image-encoders.h index 6b4999e..a755bf3 100644 --- a/server/image-encoders.h +++ b/server/image-encoders.h @@ -202,8 +202,10 @@

[Spice-devel] [PATCH spice-server v2 2/8] Be consistent with opaque type

vdi_port_read_buf_release is registered passing data as RedVDIReadBuf*, not RedPipeItem*. Cast opaque to proper pointer type to avoid the assumption that first field of RedVDIReadBuf is a RedPipeItem. Signed-off-by: Frediano Ziglio --- server/reds.c | 3 ++- 1 file changed,

[Spice-devel] [PATCH spice-server v2 4/8] Add reds_stat to compiled software

Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- Makefile.am | 2 +- configure.ac | 1 + tools/Makefile.am | 19 +++ 3 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 tools/Makefile.am diff

[Spice-devel] [PATCH spice-server v2 5/8] Make QXLMessage handling safe

Signed-off-by: Frediano Ziglio --- server/memslot.c | 14 ++ server/memslot.h | 3 +++ server/red-parse-qxl.c | 11 +++ server/red-parse-qxl.h | 1 + server/red-worker.c| 3 +-- 5 files changed, 30 insertions(+), 2 deletions(-) diff

[Spice-devel] [PATCH spice-server v2 6/8] Reuse SPICE_N_ELEMENTS macro

Signed-off-by: Frediano Ziglio --- server/red-worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-worker.c b/server/red-worker.c index 1469f4a..2c9b697 100644 --- a/server/red-worker.c +++ b/server/red-worker.c @@ -407,11 +407,11 @@

[Spice-devel] [PATCH spice-server v2 0/8] Miscellaneous patches

Rebased on master. Frediano Ziglio (8): Remove red_pipe_add_verb family function Be consistent with opaque type Remove warnings from reds_stat utility Add reds_stat to compiled software Make QXLMessage handling safe Reuse SPICE_N_ELEMENTS macro Make compression image declarations

[Spice-devel] [PATCH spice-server v2 1/8] Remove red_pipe_add_verb family function

These functions were implementing the same stuff as empty messages functions provided by RedChannel so reuse them. The implementation seems a bit different but the result is the same. Specifically: - RedEmptyMsgPipeItem::msg is int while RedVerbItem::verb was uint16_t however this data goes

Re: [Spice-devel] [PATCH spice v2] reds: Define openssl lock only if needed

> > Silence a warning: > reds.c:150:25: warning: 'lock_cs' defined but not used [-Wunused-variable] > static pthread_mutex_t *lock_cs; > --- > server/reds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 8dff12d..79f9c9e

[Spice-devel] [PATCH spice v2] reds: Define openssl lock only if needed

Silence a warning: reds.c:150:25: warning: 'lock_cs' defined but not used [-Wunused-variable] static pthread_mutex_t *lock_cs; --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 8dff12d..79f9c9e 100644 ---

Re: [Spice-devel] [PATCH spice] reds: Define openssl lock only if needed

> > Silence a warning: > reds.c:150:25: warning: 'lock_cs' defined but not used [-Wunused-variable] > static pthread_mutex_t *lock_cs; > --- > server/reds.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/server/reds.c b/server/reds.c > index 8dff12d..c69a653 100644 > ---

[Spice-devel] [PATCH spice] reds: Define openssl lock only if needed

Silence a warning: reds.c:150:25: warning: 'lock_cs' defined but not used [-Wunused-variable] static pthread_mutex_t *lock_cs; --- server/reds.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/reds.c b/server/reds.c index 8dff12d..c69a653 100644 --- a/server/reds.c +++

[Spice-devel] [PATCH spice] rcc: Make OutgoingHandler private

--- server/red-channel-client-private.h | 12 server/red-channel-client.c | 10 +- server/red-channel-client.h | 11 --- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git a/server/red-channel-client-private.h

Re: [Spice-devel] [spice] server: Remove a redundant IncomingHandler typedef

On Fri, 2016-10-14 at 12:08 +0200, Francois Gouget wrote: > On Fri, 14 Oct 2016, Frediano Ziglio wrote: > [...] > > >  typedef struct RedChannel RedChannel; > > >  typedef struct RedClient RedClient; > > > -typedef struct IncomingHandler IncomingHandler; > > >   > > >  typedef struct

Re: [Spice-devel] [PATCH spice-server] fixup! Move CommonGraphicsChannel to a new file

ACK On Wed, 2016-10-12 at 11:52 +0100, Frediano Ziglio wrote: > Do not include red-worker.h if not necessary. > > Signed-off-by: Frediano Ziglio > --- >  server/common-graphics-channel.h | 2 +- >  server/cursor-channel.c  | 1 + >  server/cursor-channel.h  | 1

Re: [Spice-devel] [spice] server: Remove a redundant IncomingHandler typedef

On Fri, 14 Oct 2016, Frediano Ziglio wrote: [...] > > typedef struct RedChannel RedChannel; > > typedef struct RedClient RedClient; > > -typedef struct IncomingHandler IncomingHandler; > > > > typedef struct RedChannelClient RedChannelClient; > > typedef struct RedChannelClientClass

Re: [Spice-devel] [spice] server: Remove a redundant IncomingHandler typedef

> > This fixes a compilation error with gcc 4.4.7 on RHEL 6.8. > > Signed-off-by: Francois Gouget > --- > server/red-channel-client.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/server/red-channel-client.h b/server/red-channel-client.h > index

Re: [Spice-devel] [spice] server: Remove a redundant CursorChannelClient typedef

On Fri, 2016-10-14 at 11:28 +0200, Francois Gouget wrote: > CursorChannelClient is already defined in cursor-channel-client.h. > This fixes compilation errors with gcc 4.4.7 on RHEL 6.8. > > Signed-off-by: Francois Gouget Acked-by: Pavel Grunt > --- >

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

On vie, 2016-10-14 at 09:17 +0200, Sergio L. Pascual wrote: > On jue, 2016-10-13 at 13:30 +, Brad Wilson wrote: > > > > Using Virt-Viewer The Vm shows a little lag when typing (always > > takes > > a second to catch up when typing my password to log in and such).  > > In > > general pulling

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

On jue, 2016-10-13 at 13:30 +, Brad Wilson wrote: > Using Virt-Viewer The Vm shows a little lag when typing (always takes > a second to catch up when typing my password to log in and such).  In > general pulling up folders and  text heavy web pages is pretty snappy > and doesn’t tax the cpu or