Re: [Spice-devel] [PATCH] RedChannelClient: use Gobject properties

On Mon, 2016-11-07 at 12:16 -0500, Frediano Ziglio wrote: > > > > > > On Fri, Nov 04, 2016 at 11:19:22AM -0500, Jonathon Jongsma wrote: > > > > > > Use g_param_spec_object() instead of g_param_spec_pointer() for > > > the > > > 'client' and 'channel' properties now that these types are > > >

Re: [Spice-devel] [qxl] spiceqxl: Improve the Xspice and Xorg configuration option descriptions

> > On Mon, Oct 31, 2016 at 09:50:54PM +0100, Francois Gouget wrote: > > Group the options more logically and improve their descriptions. > > In the Xorg configuration, always show the default in the > > commented-out sample. > > > > Signed-off-by: Francois Gouget > >

Re: [Spice-devel] [qxl] spiceqxl: Improve the Xspice and Xorg configuration option descriptions

On Mon, Oct 31, 2016 at 09:50:54PM +0100, Francois Gouget wrote: > Group the options more logically and improve their descriptions. > In the Xorg configuration, always show the default in the > commented-out sample. > > Signed-off-by: Francois Gouget > --- >

Re: [Spice-devel] [vd_agent] vdagentd: Clean up and clarify the usage message

On Wed, Nov 02, 2016 at 04:38:05PM +0100, Francois Gouget wrote: > udsc is an internal library of sorts that's irrelevant to users. I've split this in 2 commits (the change which is described in the log + one with the cosmetic changes) and pushed this. Acked-by: Christophe Fergeau

Re: [Spice-devel] [vd_agent] vdagentd: Make the 'could not create server socket' message more helpful

Acked-by: Christophe Fergeau On Wed, Nov 02, 2016 at 04:36:40PM +0100, Francois Gouget wrote: > EADDRINUSE usually means the socket file was left behind after a crash. > > Signed-off-by: Francois Gouget > --- > src/vdagentd/vdagentd.c | 9

Re: [Spice-devel] [PATCH] RedChannelClient: use Gobject properties

> > On Fri, Nov 04, 2016 at 11:19:22AM -0500, Jonathon Jongsma wrote: > > Use g_param_spec_object() instead of g_param_spec_pointer() for the > > 'client' and 'channel' properties now that these types are GObjects. > > This improves refcounting and typesafety slightly. > > --- > >

Re: [Spice-devel] [PATCH] RedChannelClient: use Gobject properties

On Fri, Nov 04, 2016 at 11:19:22AM -0500, Jonathon Jongsma wrote: > Use g_param_spec_object() instead of g_param_spec_pointer() for the > 'client' and 'channel' properties now that these types are GObjects. > This improves refcounting and typesafety slightly. > --- > server/red-channel-client.c |

Re: [Spice-devel] [PATCH spice] spice-options-test: Convert to gtest to catch criticals

Acked-by: Christophe Fergeau On Thu, Nov 03, 2016 at 01:30:07PM +0100, Pavel Grunt wrote: > Fail on glib warnings instead of ignoring them > > Signed-off-by: Pavel Grunt > --- > server/tests/spice-options-test.c | 11 +-- > 1 file changed, 9

Re: [Spice-devel] [PATCH spice-server 3/3] Move InputsChannelClient and InputsChannelClient definition to C file

Duplicate InputsChannelClient in the short log? This also seems to be removing InputsChannelClientPrivate, it would be worth a mention in the log. Also, what is this bringing us in concrete terms? Ensuring internal users of InputsChannelClient can't try to inherit from it? Christophe On Mon, Nov

Re: [Spice-devel] [PATCH spice-server 1/3] Relax conversion to RedChannel

On Mon, Nov 07, 2016 at 11:13:21AM +, Frediano Ziglio wrote: > Now RED_CHANNEL is a function call so avoid to call multiple > time for the same conversion in the same functions. > This speed up and reduce code and also reduce source line > length. To be honest, these are not really

Re: [Spice-devel] [spice-server PATCH 8/8] red-record-qxl: child_output_setup: check fcntl return value

> > On 10/17/2016 01:08 PM, Frediano Ziglio wrote: > >> > >> Also replaced "continue" in while block with an empty > >> block (added curly braces). > >> > > > > I think you split this in 7/8. > > Right, I'll remove it. > > > > >> Found by coverity. > >> > >> Signed-off-by: Uri Lublin

Re: [Spice-devel] [spice-server PATCH 4/8] main-channel: getpeername/getsockname return early if no sockfd

> > On 10/17/2016 01:38 PM, Frediano Ziglio wrote: > >> > >> I'm not sure that needed as it seems getpeername/getsockname > >> accept int fd and return -1 for fd=-1 > >> > >> Signed-off-by: Uri Lublin > >> --- > >> server/main-channel.c | 16 ++-- > >> 1 file

Re: [Spice-devel] [qxl 4/5] build: Error out when enabling xspice with X.Org 1.19

Hi, On Fri, Nov 04, 2016 at 10:42:17AM -0500, Jeremy White wrote: > > On 10/28/2016 05:18 AM, Christophe Fergeau wrote: > > xspice needs to be updated to cope with some X.Org 1.19 API changes, > > better to make that explicit at configure time rather than letting > > people discover the hard way

[Spice-devel] [PATCH spice-server 0/3] Minor GObject follow ups

Basically optimizations. Frediano Ziglio (3): Relax conversion to RedChannel Relax conversion to RedChannelClient Move InputsChannelClient and InputsChannelClient definition to C file server/cursor-channel.c| 12 +++ server/dcc.c | 40

[Spice-devel] [PATCH spice-server 1/3] Relax conversion to RedChannel

Now RED_CHANNEL is a function call so avoid to call multiple time for the same conversion in the same functions. This speed up and reduce code and also reduce source line length. Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 12

[Spice-devel] [PATCH spice-server 2/3] Relax conversion to RedChannelClient

Now RED_CHANNEL_CLIENT is a function call so avoid to call multiple time for the same conversion in the same functions. This speed up and reduce code and also reduce source line length. Signed-off-by: Frediano Ziglio --- server/dcc.c | 40

[Spice-devel] [PATCH spice-server 3/3] Move InputsChannelClient and InputsChannelClient definition to C file

Signed-off-by: Frediano Ziglio --- server/inputs-channel-client.c | 28 +++- server/inputs-channel-client.h | 13 - 2 files changed, 15 insertions(+), 26 deletions(-) diff --git a/server/inputs-channel-client.c

Re: [Spice-devel] [PATCH v2] fixup! spicevmc: Change creation of RedCharDeviceSpiceVmc

> > --- > Changes in v2: > - pass 'channel' property to char device constructor > - assert that 'channel' device is non-null in char device set_property > - minor indentation fix > > server/spicevmc.c | 83 > --- > 1 file changed, 61

Re: [Spice-devel] spice-vdagent-win 0.8.0 release

On Mon, Nov 07, 2016 at 10:53:38AM +0100, Thorsten Kohfeldt wrote: > > Am 07.11.2016 um 10:21 schrieb Christophe Fergeau: > > On Mon, Nov 07, 2016 at 10:07:58AM +0100, Thorsten Kohfeldt wrote: > > > > > > BTW, > > > _all_ binaries' details state 'Version 0.5.1.0, copyright RH 2009'. > > > Here

Re: [Spice-devel] [vd_agent] udscs: Clarify the udscs_read_callback() documentation

On Wed, 2 Nov 2016, Jonathon Jongsma wrote: [...] > >  /* Callbacks with this type will be called when a complete message has been > > - * received. The callback may call udscs_destroy_connection, in which case > > - * *connp must be made NULL (which udscs_destroy_connection takes care of). > > +

Re: [Spice-devel] [PATCH qxl-wddm-dod] Update some file copyright statements

On Mon, Nov 07, 2016 at 04:40:11AM -0500, Frediano Ziglio wrote: > > > > > > Acked-by: Christophe Fergeau > > > > On Mon, Nov 07, 2016 at 09:29:44AM +, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > --- > > > qxldod/QxlDod.cpp |

Re: [Spice-devel] [PATCH qxl-wddm-dod] Update some file copyright statements

> > > Acked-by: Christophe Fergeau > > On Mon, Nov 07, 2016 at 09:29:44AM +, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > > qxldod/QxlDod.cpp | 2 +- > > qxldod/compat.cpp | 10 ++ > > qxldod/compat.h | 10

Re: [Spice-devel] [PATCH qxl-wddm-dod] Update some file copyright statements

Acked-by: Christophe Fergeau On Mon, Nov 07, 2016 at 09:29:44AM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > qxldod/QxlDod.cpp | 2 +- > qxldod/compat.cpp | 10 ++ > qxldod/compat.h | 10 ++ >

[Spice-devel] [PATCH qxl-wddm-dod] Update some file copyright statements

Signed-off-by: Frediano Ziglio --- qxldod/QxlDod.cpp | 2 +- qxldod/compat.cpp | 10 ++ qxldod/compat.h | 10 ++ qxldod/driver.cpp | 2 +- 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index

Re: [Spice-devel] spice-vdagent-win 0.8.0 release

On Mon, Nov 07, 2016 at 10:07:58AM +0100, Thorsten Kohfeldt wrote: > > Am 07.11.2016 um 09:10 schrieb Christophe Fergeau: > > On Fri, Nov 04, 2016 at 08:48:48PM +0100, Thorsten Kohfeldt wrote: > > > > Binary builds can be found at > > > >

Re: [Spice-devel] [drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged

On Mon, Nov 07, 2016 at 04:08:48AM -0500, Frediano Ziglio wrote: > > @@ -124,9 +157,18 @@ void qxl_display_read_client_monitors_config(struct > > qxl_device *qdev) > > { > > > > struct drm_device *dev = qdev->ddev; > > - while (qxl_display_copy_rom_client_monitors_config(qdev)) { > > +

Re: [Spice-devel] [drm/qxl v3 0/7] qxl: Various cleanups/fixes

On Mo, 2016-11-07 at 09:00 +0100, Christophe Fergeau wrote: > Hey, > > Same series as v2 except that I removed the use of camel case in patch 6/7. > Now it's only using an anonymous enum + int. Can you please not drop the "PATCH" from $subject? thanks, Gerd

Re: [Spice-devel] [drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged

> > When the QXL driver receives a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG > interrupt, > we currently always notify userspace that there was some hotplug event. > > However, gnome-shell/mutter is reacting to this event by attempting a > resolution change, which it does by issueing drmModeRmFB,

Re: [Spice-devel] [drm/qxl v3 5/7] qxl: Remove qxl_bo_init() return value

> > It's always returning 0, and it's always ignored. Missing the Signed-off-by. Acked-by: Frediano Ziglio You should add the Acked-by message when posting new versions of the patch series. Frediano > --- > drivers/gpu/drm/qxl/qxl_drv.h | 2 +- >

Re: [Spice-devel] [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

Hi, > I think we should try it an see, Ok, lets try. I'll go pick them up and prepare a pull with this and some virtio-gpu bits, Gerd ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] spice-vdagent-win 0.8.0 release

On Fri, Nov 04, 2016 at 08:48:48PM +0100, Thorsten Kohfeldt wrote: > > Binary builds can be found at > > https://copr.fedorainfracloud.org/coprs/teuf/spice-mingw/build/473299/ > > Nice offer, > but I'm a little confused by that plethora of choices: > > 3 target releases (F23, F24, rawhide), 2

[Spice-devel] [drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged

When the QXL driver receives a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG interrupt, we currently always notify userspace that there was some hotplug event. However, gnome-shell/mutter is reacting to this event by attempting a resolution change, which it does by issueing drmModeRmFB, drmModeAddFB, and

[Spice-devel] [drm/qxl v3 3/7] qxl: Add missing '\n' to qxl_io_log() call

The message has to be terminated by a newline as it's not going to get added automatically. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c

[Spice-devel] [drm/qxl v3 2/7] qxl: Remove unused prototype

qxl_crtc_set_from_monitors_config() is defined in qxl_drv.h but never implemented. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index

[Spice-devel] [drm/qxl v3 5/7] qxl: Remove qxl_bo_init() return value

It's always returning 0, and it's always ignored. --- drivers/gpu/drm/qxl/qxl_drv.h | 2 +- drivers/gpu/drm/qxl/qxl_gem.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index 5a4720a..feac7e6 100644 ---

[Spice-devel] [drm/qxl v3 7/7] qxl: Allow resolution which are not multiple of 8

The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that the resolutions we are going to present to user-space are going to be rounded down to a multiple of 8. In the QXL arbitrary resolution case, this is not useful. This commit forces the actual width/height that was requested by

[Spice-devel] [drm/qxl v3 0/7] qxl: Various cleanups/fixes

Hey, Same series as v2 except that I removed the use of camel case in patch 6/7. Now it's only using an anonymous enum + int. Christophe ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [drm/qxl v3 1/7] qxl: Mark some internal functions as static

They are not used outside of their respective source file Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_cmd.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 4 ++-- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-)

[Spice-devel] [drm/qxl v3 4/7] qxl: Call qxl_gem_{init,fini}

qdev->gem.objects was initialized directly in qxl_device_init() rather than going through qxl_gem_init(), and qxl_gem_fini() was never called. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff