[Spice-devel] How to config video and image compression?

I learned that video and image compression can be chosen server initiation from https://www.spice-space.org/spice-user-manual.html. How can I change the configuration for the compression ? I want to play 720p video smoothly in the guest(some loss or distortion does not matter). What is the best

Re: [Spice-devel] Windows drivers for virgl?

On Tue, 2017-02-21 at 12:41 +0200, Yan Vugenfirer wrote: > Hi Benrooz, > > I am adding Vadim to the thread. He is working on virtio-gpu for > Windows. > We do have some working prototype of virtio-gpu dod driver. I'm thinking about adding OpenGL Installable Client Driver as the next step. Then

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

Hi,    I'll go against the fix as I don't see any reason for the "assumption".     Let's split the question into 2 things, max monitor number and which monitor is enabled.      The max monitor number seems correct now, controlled by qemu together with qxl. And it's used to control the client

Re: [Spice-devel] [PATCH v4 6/6] qxl-wddm-dod: Preparation for VSync activation

> > Prepare all the procedures needed for VSync feature but > do not turn it on yet. Manual uncomment still required to > enable it. > Advanced users may enable VSync feature and report functional > problem with it. The driver is expected to pass all the formal > tests under HLK 1607 with device

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

On 02/22/2017 12:58 PM, Christophe Fergeau wrote: Hey, On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: The authentication type string is just for letting the user know what authentication is in use. Sorry, forgot to reply to this bit, I don't think saying "SASL" in this

[Spice-devel] [PATCH v4 6/6] qxl-wddm-dod: Preparation for VSync activation

Prepare all the procedures needed for VSync feature but do not turn it on yet. Manual uncomment still required to enable it. Advanced users may enable VSync feature and report functional problem with it. The driver is expected to pass all the formal tests under HLK 1607 with device rev.3 and rev.4

[Spice-devel] [spice-gtk v1 7/7] gtk-session: move variables to internal scope

From: Victor Toso Signed-off-by: Victor Toso --- src/spice-gtk-session.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index cd546d3..595b327 100644 ---

[Spice-devel] [spice-gtk v1 2/7] gtk-session: initialize array without memset

From: Victor Toso Signed-off-by: Victor Toso --- src/spice-gtk-session.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index 3c78e6a..bc47f6b 100644 ---

[Spice-devel] [spice-gtk v1 4/7] gtk-session: do an early check of clipboard grab

From: Victor Toso As we will not be doing anything in case clipboard is already grabbed Signed-off-by: Victor Toso --- src/spice-gtk-session.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git

[Spice-devel] [spice-gtk v1 6/7] gtk-session: better debug GdkAtoms that are parsed

From: Victor Toso By including what is discarded or not. To improve coherence, using prefix 'saving' and 'discarding' to both debug messages: > saving:'image/bmp' > discarding:'application/x-openoffice-bitmap;windows_formatname="Bitmap"' > saving:'image/png' >

[Spice-devel] [spice-gtk v1 5/7] gtk-session: move atom's debug

From: Victor Toso We already iterate in all n_atoms and get its name with gdk_atom_name(), let's move the debug there too; As spice_util_get_debug() uses g_once(), this should not impact performance or might improve it with one memory allocation less. While at it, move the

[Spice-devel] [spice-gtk v1 1/7] gtk-session: check if retrieving clipboard data failed

From: Victor Toso In case of failure, the GdkAtom *atoms will be set to NULL. Including this check to an early return. Signed-off-by: Victor Toso --- src/spice-gtk-session.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Spice-devel] [spice-gtk v1 3/7] gtk-session: use clear variable for array's size

From: Victor Toso There is no need to use an index variable to keep track of the number of VD_AGENT_CLIPBOARD types we are storing. Signed-off-by: Victor Toso --- src/spice-gtk-session.c | 17 +++-- 1 file changed, 11 insertions(+), 6

[Spice-devel] [spice-gtk v1 0/7] clipboard_get_targets() on spice-gtk-session.c

From: Victor Toso Hi, Minor changes that I was doing while playing with clipboard. The first one seems important the others might be somewhat an improvement or not. Let me know ;) Cheers, Victor Toso (7): gtk-session: check if retrieving clipboard data failed

[Spice-devel] [spice-gtk v1] gtk-session: reply agent's clipboard request on failure

From: Victor Toso We need to reply back to the agent all clipboard requests even in case of failure otherwise it will have a pending request. The following error message can be seen in afterwards, when client sends down some clipboard data: > clipboard: selection requests

Re: [Spice-devel] [PATCH v3 6/6] qxl-wddm-dod: Preparation for VSync activation

> > Prepare all the procedures needed for VSync feature but > do not turn it on yet. Manual uncomment still required to > enable it. > Advanced users may enable VSync feature and report functional > problem with it. The driver is expected to pass all the formal > tests under HLK 1607 with device

Re: [Spice-devel] [PATCH v3 5/6] qxl-wddm-dod: Timer-based VSync interrupt indication

> On Thu, Feb 16, 2017 at 5:54 PM, Frediano Ziglio < fzig...@redhat.com > > wrote: > > > > > > > In case the driver supports VSync control feature, it > > > > maintains timer for VSync interrupt indication. > > > > In further commits this timer will be started upon > > > > class driver

Re: [Spice-devel] [PATCH spice-server] Define a new interface for Qemu to pass EGL display

> > Hi > > - Original Message - > > The new interface pass directly the EGL display to make > > possible to extract texture data if necessary. > > Also allows to use the same device using hardware > > encoders. > > I would like to see how this is going to be used before amending it, but

Re: [Spice-devel] [PATCH spice-server] Define a new interface for Qemu to pass EGL display

Hi - Original Message - > The new interface pass directly the EGL display to make > possible to extract texture data if necessary. > Also allows to use the same device using hardware > encoders. I would like to see how this is going to be used before amending it, but a few questions

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

On Wed, Feb 22, 2017 at 11:47:10AM +0100, Christophe Fergeau wrote: > On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: > > Hi, > > > > > > On 02/21/2017 06:37 PM, Christophe Fergeau wrote: > > > On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: > > > > Remove handling

[Spice-devel] [PATCH spice-server] Define a new interface for Qemu to pass EGL display

The new interface pass directly the EGL display to make possible to extract texture data if necessary. Also allows to use the same device using hardware encoders. Signed-off-by: Frediano Ziglio --- server/red-qxl.c | 10 ++ server/spice-qxl.h | 3 +++

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

Hey, On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: > The authentication type string is just for letting the user know what > authentication is in use. Sorry, forgot to reply to this bit, I don't think saying "SASL" in this string is useful, this is going to be very cryptic to

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

> On 21 Feb 2017, at 16:28, Snir Sheriber wrote: > > Hi, > > > On 02/20/2017 07:00 PM, Christophe de Dinechin wrote: >>> On 19 Feb 2017, at 15:47, Snir Sheriber wrote: >>> >>> Remove handling with failures in the SASL authentication >>> process to

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: > Hi, > > > On 02/21/2017 06:37 PM, Christophe Fergeau wrote: > > On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: > > > Remove handling with failures in the SASL authentication > > > process to separate function > > >

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

Hi, On 02/21/2017 06:37 PM, Christophe Fergeau wrote: On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++- 1 file

[Spice-devel] [PATCH] smartcard: fix memory leak in vcard_apdu_new

In the error path, 'new_apdu->a_data' is not freed. This can be triggered by the guest continuely. Signed-off-by: Li Qiang --- src/card_7816.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/card_7816.c b/src/card_7816.c index b598ef9..0082504

Re: [Spice-devel] [spice-gtk v2 2/4] spice-channel: spice_channel_read_wire() improvements

Hi, On Tue, Feb 21, 2017 at 06:18:29PM +0100, Christophe Fergeau wrote: > On Fri, Feb 03, 2017 at 04:13:38PM +0100, Victor Toso wrote: > > From: Victor Toso > > > > * Removes the reread label by having while(TRUE); > > > > The label is being used after