Re: [Spice-devel] [PATCH 14/17] Create a class encapsulating the X11 display cursor capture

> On 20 Feb 2018, at 16:42, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> This class will need to be moved to a separate file in a later patch. >> This is done in two

Re: [Spice-devel] [PATCH v2 06/24] Replace inefficient C-style initialization with C++-style

> On Feb 23, 2018, at 8:20 AM, Frediano Ziglio wrote: > >>> >>> From: Christophe de Dinechin >>> >>> Signed-off-by: Christophe de Dinechin >>> --- >>> src/spice-streaming-agent.cpp | 4 +--- >>> 1 file changed, 1 insertion(+), 3

Re: [Spice-devel] [PATCH v2 06/24] Replace inefficient C-style initialization with C++-style

> > > > From: Christophe de Dinechin > > > > Signed-off-by: Christophe de Dinechin > > --- > > src/spice-streaming-agent.cpp | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH spice-streaming-agent v3] log_binary is really a boolean

> On Feb 23, 2018, at 8:07 AM, Frediano Ziglio wrote: > > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > Change since v3: > - change enum syntax. > > Change since v2: > - rebased. > > Change since

[Spice-devel] [PATCH spice-streaming-agent v3] log_binary is really a boolean

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- Change since v3: - change enum syntax. Change since v2: - rebased. Change since v1: - do not clash with possible short 'b' option. --- src/spice-streaming-agent.cpp | 13

Re: [Spice-devel] [RFC PATCH spice-streaming-agent 2/2] Implement handling of error messages from the server

> On 22 Feb 2018, at 15:11, Lukáš Hrázký wrote: > > Signed-off-by: Lukáš Hrázký > --- > src/spice-streaming-agent.cpp | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH spice-streaming-agent v2 1/2] Move reading stream messages into a function

On Thu, 2018-02-22 at 18:56 +0100, Christophe de Dinechin wrote: > > On 22 Feb 2018, at 18:41, Lukáš Hrázký wrote: > > > > Signed-off-by: Lukáš Hrázký > > --- > > src/spice-streaming-agent.cpp | 31 +-- > > 1 file changed, 21

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

On Thu, 2018-02-22 at 18:51 +0100, Christophe de Dinechin wrote: > > On 21 Feb 2018, at 10:45, Lukáš Hrázký wrote: > > > > On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote: > > > > On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: > > > > > >

Re: [Spice-devel] [PATCH spice-streaming-agent v2 1/2] Move reading stream messages into a function

> On 22 Feb 2018, at 18:41, Lukáš Hrázký wrote: > > Signed-off-by: Lukáš Hrázký > --- > src/spice-streaming-agent.cpp | 31 +-- > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

> On 21 Feb 2018, at 10:45, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote: >>> On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: >>> >>> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: From:

[Spice-devel] [PATCH spice-streaming-agent v2 1/2] Move reading stream messages into a function

Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index aeee5d3..20ac1f4 100644 ---

[Spice-devel] [PATCH spice-streaming-agent v2 0/2] handle error messages from the server

Changes since v1: - renamed read_message() to read_all() - read_all now does partial reads and handles EINT - resolved TODOs in second patch, icreased the message size, use sizeof(msg) instead of a constant Lukáš Hrázký (2): Move reading stream messages into a function Implement handling of

[Spice-devel] [PATCH spice-streaming-agent v2 2/2] Implement handling of error messages from the server

Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 20ac1f4..ab403f9 100644 --- a/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

[Indeed, I had not sent this reply, took time to check standard and compilers] > On 20 Feb 2018, at 12:31, Frediano Ziglio wrote: > >>> On 20 Feb 2018, at 10:39, Lukáš Hrázký wrote: >>> >>> On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin

Re: [Spice-devel] [RFC PATCH spice-streaming-agent 2/2] Implement handling of error messages from the server

> > Signed-off-by: Lukáš Hrázký > --- > src/spice-streaming-agent.cpp | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index b88225f..73baa48 100644 > ---

Re: [Spice-devel] [PATCH spice-streaming-agent 0/1] Adding gstreamer based plugin

> On Thu, Feb 22, 2018 at 06:20:50PM +0200, Snir Sheriber wrote: > > This is gstreamer based plugin for spice streaming agent. This plugin > > is considered experimental but can be very useful for testing purposes. > > > > Notes: > > *It is currently uses sw h264 encoding (using x264enc

Re: [Spice-devel] [PATCH spice-streaming-agent 0/1] Adding gstreamer based plugin

On Thu, Feb 22, 2018 at 06:20:50PM +0200, Snir Sheriber wrote: > This is gstreamer based plugin for spice streaming agent. This plugin > is considered experimental but can be very useful for testing purposes. > > Notes: > *It is currently uses sw h264 encoding (using x264enc plugin), may not >

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] Adding gstreamer based plugin

> > Gstreamer based plugin utilizing gstreamer elements to capture > screen from X, convert and encode into h264 stream using x264enc > gstreamer plugin. > Configure with --with-gst, will be built as a separate plugin. > > Signed-off-by: Snir Sheriber > Signed-off-by:

[Spice-devel] [PATCH spice-streaming-agent 0/1] Adding gstreamer based plugin

This is gstreamer based plugin for spice streaming agent. This plugin is considered experimental but can be very useful for testing purposes. Notes: *It is currently uses sw h264 encoding (using x264enc plugin), may not be good enough for streaming your desktop. *Checks and error handling can

[Spice-devel] [PATCH spice-streaming-agent 1/1] Adding gstreamer based plugin

Gstreamer based plugin utilizing gstreamer elements to capture screen from X, convert and encode into h264 stream using x264enc gstreamer plugin. Configure with --with-gst, will be built as a separate plugin. Signed-off-by: Snir Sheriber Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH spice-streaming-agent] log_binary is really a boolean

> > > On 22 Feb 2018, at 15:56, Frediano Ziglio wrote: > > > > From: Christophe de Dinechin > > > > Signed-off-by: Christophe de Dinechin > > --- > > Change since v2: > > - rebased. > > > > Change since v1: > > - do not clash

Re: [Spice-devel] [PATCH spice-streaming-agent] log_binary is really a boolean

> On 22 Feb 2018, at 15:56, Frediano Ziglio wrote: > > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > Change since v2: > - rebased. > > Change since v1: > - do not clash with possible short 'b'

Re: [Spice-devel] [RFC PATCH spice-streaming-agent 1/2] Move reading stream messages into a function

On Thu, 2018-02-22 at 09:34 -0500, Frediano Ziglio wrote: > > > > Signed-off-by: Lukáš Hrázký > > --- > > src/spice-streaming-agent.cpp | 22 -- > > 1 file changed, 12 insertions(+), 10 deletions(-) > > > > diff --git a/src/spice-streaming-agent.cpp

[Spice-devel] [PATCH spice-streaming-agent] log_binary is really a boolean

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- Change since v2: - rebased. Change since v1: - do not clash with possible short 'b' option. --- src/spice-streaming-agent.cpp | 12 1 file changed, 8 insertions(+), 4

Re: [Spice-devel] [PATCH v2 spice-streaming-agent] Allow to set plugins directory via command line

Hi, Pushed :/ , sorry we should have wait a bit more for more comments.. On 02/22/2018 04:14 PM, Christophe de Dinechin wrote: On 22 Feb 2018, at 14:15, Snir Sheriber wrote: Could be useful mainly for testing purposes, it allows to load plugins that aren't installed in

Re: [Spice-devel] [RFC PATCH spice-streaming-agent 1/2] Move reading stream messages into a function

> > Signed-off-by: Lukáš Hrázký > --- > src/spice-streaming-agent.cpp | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index aeee5d3..b88225f 100644 > ---

Re: [Spice-devel] [PATCH v2 spice-streaming-agent] Allow to set plugins directory via command line

> On 22 Feb 2018, at 14:15, Snir Sheriber wrote: > > Could be useful mainly for testing purposes, it allows to load > plugins that aren't installed in the default plugins folder. > To set different plugins directory use --plugins-dir= > > Signed-off-by: Snir Sheriber

[Spice-devel] [RFC PATCH spice-streaming-agent 1/2] Move reading stream messages into a function

Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index aeee5d3..b88225f 100644 ---

[Spice-devel] [RFC PATCH spice-streaming-agent 2/2] Implement handling of error messages from the server

Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index b88225f..73baa48 100644 ---

[Spice-devel] [RFC PATCH spice-streaming-agent 0/2] handle error messages from the server

Sending this as RFC as I'm unsure of some things, marked by TODO in the second patch. It's tested, although it's quite hard to test, hence my efforts to prepare a unittest for it, which still have to bear fruit :) Lukáš Hrázký (2): Move reading stream messages into a function Implement

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

> On 22 Feb 2018, at 14:12, Lukáš Hrázký wrote: > > Apart from what's below, I'm also thinking if it wouldn't be better to > leave this addition of exception classes for later and concentrate on > finishing what's already present in this big series. Adding more stuff > to

Re: [Spice-devel] [PATCH v2 spice-streaming-agent] Allow to set plugins directory via command line

> > Could be useful mainly for testing purposes, it allows to load > plugins that aren't installed in the default plugins folder. > To set different plugins directory use --plugins-dir= > > Signed-off-by: Snir Sheriber > --- > src/spice-streaming-agent.cpp | 14

[Spice-devel] [PATCH v2 spice-streaming-agent] Allow to set plugins directory via command line

Could be useful mainly for testing purposes, it allows to load plugins that aren't installed in the default plugins folder. To set different plugins directory use --plugins-dir= Signed-off-by: Snir Sheriber --- src/spice-streaming-agent.cpp | 14 -- 1 file

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

Apart from what's below, I'm also thinking if it wouldn't be better to leave this addition of exception classes for later and concentrate on finishing what's already present in this big series. Adding more stuff to it doesn't really speed things up :/ I think write_all() throwing a runtime_error

Re: [Spice-devel] [PATCH v2 18/24] Catch all std::exception derivatives (including std::bad_alloc, not a std::bad_alloc)

On Thu, 2018-02-22 at 11:01 +0100, Christophe de Dinechin wrote: > > On Feb 22, 2018, at 10:51 AM, Lukáš Hrázký wrote: > > > > On Thu, 2018-02-22 at 10:35 +0100, Christophe de Dinechin wrote: > > > > On Feb 22, 2018, at 10:23 AM, Lukáš Hrázký wrote: > > >

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

> On 22 Feb 2018, at 10:42, Lukáš Hrázký wrote: > > On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> This also introduces the spice::streaming_error::Error class, which we can >> reuse >> later as

Re: [Spice-devel] [PATCH spice-streaming-agent] Allow to set plugins directory via command line

> > Set different plugins directory using --plugins-dir= > --- > > Would be helpful, but not really critical > Can you add in the message how you would like to use? I would personally use for debugging/testing purposes. You miss the signed off. > src/spice-streaming-agent.cpp | 7 ++- >

Re: [Spice-devel] [PATCH spice-streaming-agent] Allow to set plugins directory via command line

> On 22 Feb 2018, at 11:55, Snir Sheriber wrote: > > Set different plugins directory using --plugins-dir= > --- > > Would be helpful, but not really critical > > src/spice-streaming-agent.cpp | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

[Spice-devel] [PATCH spice-streaming-agent] Allow to set plugins directory via command line

Set different plugins directory using --plugins-dir= --- Would be helpful, but not really critical src/spice-streaming-agent.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 267b76e..bfdd19a 100644

Re: [Spice-devel] [PATCH v2 18/24] Catch all std::exception derivatives (including std::bad_alloc, not a std::bad_alloc)

> On Feb 22, 2018, at 10:51 AM, Lukáš Hrázký wrote: > > On Thu, 2018-02-22 at 10:35 +0100, Christophe de Dinechin wrote: >>> On Feb 22, 2018, at 10:23 AM, Lukáš Hrázký wrote: >>> >>> On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote:

Re: [Spice-devel] [PATCH v2 18/24] Catch all std::exception derivatives (including std::bad_alloc, not a std::bad_alloc)

On Thu, 2018-02-22 at 10:35 +0100, Christophe de Dinechin wrote: > > On Feb 22, 2018, at 10:23 AM, Lukáš Hrázký wrote: > > > > On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > I also added a

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > This also introduces the spice::streaming_error::Error class, which we can > reuse > later as a base class for all agent-specific errors. This class provides a > formatted

Re: [Spice-devel] [PATCH v2 18/24] Catch all std::exception derivatives (including std::bad_alloc, not a std::bad_alloc)

> On Feb 22, 2018, at 10:23 AM, Lukáš Hrázký wrote: > > On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> I also added a catch-all clause for double plus extra safety >> >> Signed-off-by: Christophe

Re: [Spice-devel] [PATCH v2 18/24] Catch all std::exception derivatives (including std::bad_alloc, not a std::bad_alloc)

On Wed, 2018-02-21 at 18:46 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > I also added a catch-all clause for double plus extra safety > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 6 +-

Re: [Spice-devel] [PATCH v2 11/24] Move read, write and locking into the 'Stream' class

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 105 > +++--- > 1 file changed, 57 insertions(+), 48 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH v2 15/24] Create FrameLog class to abstract logging of frames

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 99 > ++- > 1 file changed, 60 insertions(+), 39 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH v2 16/24] Remove client_codecs global variable, moved inside the 'Stream' class

> > From: Christophe de Dinechin > > This is not a really nice abstraction at this point, but still a step in the > right way > This comment is weird. > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 16

Re: [Spice-devel] [PATCH v2 24/24] Rename 'Stream' to 'IOChannel'

> On 22 Feb 2018, at 09:29, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/concrete-agent.hpp| 4 +-- >> src/spice-streaming-agent.cpp | 64 >>

Re: [Spice-devel] [PATCH v2 21/24] Reformat 'if' statments according to style guide

> On 22 Feb 2018, at 09:27, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/spice-streaming-agent.cpp | 27 +-- >> 1 file changed, 17

Re: [Spice-devel] [PATCH v2 23/24] Rename 'streamfd' variable to 'stream', no longer a file descriptor

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH v2 24/24] Rename 'Stream' to 'IOChannel'

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/concrete-agent.hpp| 4 +-- > src/spice-streaming-agent.cpp | 64 > +-- > 2 files changed, 34 insertions(+), 34

Re: [Spice-devel] [PATCH v2 21/24] Reformat 'if' statments according to style guide

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 27 +-- > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH v2 08/24] Use C++ style for cursor message initialization instead of C style

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 47 > +-- > 1 file changed, 27 insertions(+), 20 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH v2 07/24] Get rid of C-style memset initializations, use C++ style aggregates

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 47 > ++- > 1 file changed, 28 insertions(+), 19 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH v2 06/24] Replace inefficient C-style initialization with C++-style

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH v2 03/24] Eliminate signed/unsigned warning

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/mjpeg-fallback.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp > index

Re: [Spice-devel] [PATCH v2 02/24] log_binary is really a boolean

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp

Re: [Spice-devel] [PATCH v2 04/24] Do not create std::string for constants

> > From: Christophe de Dinechin > > As per e-mail discussions (https://patchwork.freedesktop.org/patch/200629/), > using std::string for C-style string constants is against C++ good practices, > see >

Re: [Spice-devel] [PATCH v2 01/24] Add missing header

> From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin This was already acked by Lukash. It would be kind if you report it so other people don't spend time on the review again. Frediano > --- > src/concrete-agent.cpp | 1 + > 1

Re: [Spice-devel] [PATCH spice-server 0/3] Flush interface and TCP_CORK

ping > > ping > > more than 2 years old now > > > > > These patches try to add interface to support flush interface. > > This interface could help improving bandwidth usage reducing bytes > > sent through network. > > The TCP_CORK is one possible usage of the library which actually > >