Re: [Spice-devel] [PATCH spice-gtk v2] build-sys: Make git-version-gen work again with Meson

2019-01-28 Thread Frediano Ziglio
> > d0cbd9618f0b removed the ability to use git-version-gen to generate > proper version string. > Generate .tarball-version file in the distribution file to allow > building from tarball. > Do not use MESON_SOURCE_ROOT when calling git-version-gen command as > this won't be expanded. > Change

[Spice-devel] [PATCH spice-gtk v2] build-sys: Make git-version-gen work again with Meson

2019-01-28 Thread Frediano Ziglio
d0cbd9618f0b removed the ability to use git-version-gen to generate proper version string. Generate .tarball-version file in the distribution file to allow building from tarball. Do not use MESON_SOURCE_ROOT when calling git-version-gen command as this won't be expanded. Change directory in

Re: [Spice-devel] [PATCH spice-gtk] build-sys: Make git-version-gen work again with Meson

2019-01-28 Thread Frediano Ziglio
> On Wed, Jan 23, 2019 at 09:48:43AM +, Frediano Ziglio wrote: > > d0cbd9618f0b removed the ability to use git-version-gen to > > generate proper version string. > > Generate .tarball-version file in the distribution file to > > allow building from tarball. > > Do not use MESON_SOURCE_ROOT

[Spice-devel] [PATCH spice-server v2] image-encoders: Initialize Zlib lazily

2019-01-28 Thread Frediano Ziglio
Zlib structure take up more than 1MB and it is rarely used nowadays as it is not much effective. Initialise it only when necessary saving some memory in the normal case. Signed-off-by: Frediano Ziglio --- server/image-encoders.c | 19 +++ 1 file changed, 11 insertions(+), 8

Re: [Spice-devel] [PATCH] usbredirserver: Make compile under MacOS

2019-01-28 Thread Frediano Ziglio
> On Wed, Jan 23, 2019 at 10:09:25AM +, Frediano Ziglio wrote: > > This fixes Gitlab issue #9 > > (cfr https://gitlab.freedesktop.org/spice/usbredir/issues/9). > > > > Signed-off-by: Frediano Ziglio > > --- > > usbredirserver/usbredirserver.c | 7 +++ > > 1 file changed, 7 insertions(+)

Re: [Spice-devel] [spice-gtk v1 2/2] gtk-session: clipboard: add some more debugs

2019-01-28 Thread Jakub Janku
Hi, On Mon, Jan 28, 2019 at 1:23 PM Victor Toso wrote: > > From: Victor Toso > > To help track race conditions and bad/unexpected behavior in general. Awesome! I was planning on sending something similar too. > > Signed-off-by: Victor Toso > --- > src/spice-gtk-session.c | 24

Re: [Spice-devel] [PATCH] QXL interface: improve the spice_qxl_set_device_info documentation

2019-01-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Mon, 2019-01-28 at 11:14 +0100, Lukáš Hrázký wrote: > Instead of one unsupported example, present two real world examples. > > Signed-off-by: Lukáš Hrázký > --- > server/spice-qxl.h | 32 ++-- > 1 file changed, 22 insertions(+), 10

Re: [Spice-devel] [spice-gtk v1 1/2] gtk-session: clipboard: rename functions

2019-01-28 Thread Jakub Janku
Hi, On Mon, Jan 28, 2019 at 1:23 PM Victor Toso wrote: > > From: Victor Toso > > * Attaching the 'guest_' prefix for actions that were started from > guest agent, those renames are: > > clipboard_grab -> guest_clipboard_grab > clipboard_release -> guest_clipboard_release > clipboard_request

Re: [Spice-devel] [PATCH spice v4 2/6] Receive the GraphicsDeviceInfo message from the streaming agent

2019-01-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Mon, 2019-01-28 at 15:09 +0100, Lukáš Hrázký wrote: > Receives the GraphicsDeviceInfo message from the streaming agent and > stores the data in a list on the streaming device. > > Signed-off-by: Lukáš Hrázký > --- > server/display-limits.h| 3 ++ >

[Spice-devel] [PATCH spice-streaming-agent v4 4/6] Interface + implementation of getting device display info

2019-01-28 Thread Lukáš Hrázký
Adds an interface method to the FrameCapture class to get the device display info (device address and device display id) for each display of the graphics device that is captured. Also adds functions to the API implementing this functionality for X11 in variants with and without DRM (the non-DRM

[Spice-devel] [PATCH spice v4 2/6] Receive the GraphicsDeviceInfo message from the streaming agent

2019-01-28 Thread Lukáš Hrázký
Receives the GraphicsDeviceInfo message from the streaming agent and stores the data in a list on the streaming device. Signed-off-by: Lukáš Hrázký --- server/display-limits.h| 3 ++ server/red-qxl.c | 2 +- server/red-stream-device.c | 78 +-

[Spice-devel] [PATCH vd_agent v4 6/6] Receive the graphics_device_info message

2019-01-28 Thread Lukáš Hrázký
The graphics_device_info message contains the device display ID information (device address and device display ID). Stores the data in a hash table in vdagent. Signed-off-by: Lukáš Hrázký Acked-by: Jonathon Jongsma --- configure.ac | 2 +- src/vdagent/vdagent.c| 3 ++

[Spice-devel] [PATCH spice v4 1/6] Send the graphics device info to the vd_agent

2019-01-28 Thread Lukáš Hrázký
Sends the device address and device display IDs to the vdagent. The message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START message or when the graphics device info changes. Signed-off-by: Lukáš Hrázký Acked-by: Jonathon Jongsma --- configure.ac | 2 +- meson.build

[Spice-devel] [PATCH spice-streaming-agent v4 5/6] Send the GraphicsDeviceInfo to the server

2019-01-28 Thread Lukáš Hrázký
Adds serialization of the GraphicsDeviceInfo message and sends it to the server when it starts to stream. Signed-off-by: Lukáš Hrázký Reviewed-by: Jonathon Jongsma --- configure.ac | 2 +- src/spice-streaming-agent.cpp | 60 +-- 2 files

[Spice-devel] [PATCH v4 0/6] Monitor ID between host and guest

2019-01-28 Thread Lukáš Hrázký
Hello, this series introduces a new mechanism to identify monitors across the host and guest boundary, using the pair (device_address and device_display_id). device_address is a HW address of a graphics device (a PCI address to be specific, though other address domains can be used as well),

[Spice-devel] [PATCH spice v4 3/6] Send the graphics device info from streaming agent to the vd_agent

2019-01-28 Thread Lukáš Hrázký
Adds the graphics device info from the streaming device(s) to the VDAgentGraphicsDeviceInfo message sent to the vd_agent. Signed-off-by: Lukáš Hrázký Acked-by: Jonathon Jongsma --- server/red-stream-device.c | 18 +++ server/red-stream-device.h | 7 + server/reds.c |

[Spice-devel] [vdagent-linux] vdagent: Silently ignore missing spicevmc device

2019-01-28 Thread Christophe Fergeau
On most distros, spice-vdagent will be autostarted as part of the startup of the desktop environment session. This is done by spice-vdagent.desktop, which has no way of checking if we are in a virt environment with the needed devices present. Currently, if /dev/virtio-ports/com.redhat.spice.0 is

Re: [Spice-devel] [PATCH spice-gtk] build-sys: Make git-version-gen work again with Meson

2019-01-28 Thread Christophe Fergeau
On Wed, Jan 23, 2019 at 09:48:43AM +, Frediano Ziglio wrote: > d0cbd9618f0b removed the ability to use git-version-gen to > generate proper version string. > Generate .tarball-version file in the distribution file to > allow building from tarball. > Do not use MESON_SOURCE_ROOT calling

Re: [Spice-devel] [PATCH] usbredirserver: Make compile under MacOS

2019-01-28 Thread Christophe Fergeau
On Wed, Jan 23, 2019 at 10:09:25AM +, Frediano Ziglio wrote: > This fixes Gitlab issue #9 > (cfr https://gitlab.freedesktop.org/spice/usbredir/issues/9). > > Signed-off-by: Frediano Ziglio > --- > usbredirserver/usbredirserver.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [Spice-devel] [PATCH spice-server] image-encoders: Initialize Zlib lazily

2019-01-28 Thread Christophe Fergeau
On Wed, Jan 23, 2019 at 07:46:16PM +, Frediano Ziglio wrote: > Zlib structure take up more than 1MB and it is rarely used nowadays > as it is not much effective. > Initialise it only when necessary saving some memory in the normal > case. > > Signed-off-by: Frediano Ziglio > --- >

Re: [Spice-devel] [PATCH] qxl-wddm-dod: Load best know defaults for video mode at driver's start

2019-01-28 Thread Christophe Fergeau
Hey, On Fri, Jan 25, 2019 at 09:48:52AM +0200, Yuri Benditovich wrote: > Even if initial display resolution is not available at driver start, try > to find it in the registry. > Then the driver can prevent black screen > on uninstall/disable also when it was installed on UEFI machine after > the

[Spice-devel] [spice-gtk v1 1/2] gtk-session: clipboard: rename functions

2019-01-28 Thread Victor Toso
From: Victor Toso * Attaching the 'guest_' prefix for actions that were started from guest agent, those renames are: clipboard_grab -> guest_clipboard_grab clipboard_release -> guest_clipboard_release clipboard_request -> guest_clipboard_request_data clipboard_request_send_data ->

[Spice-devel] [spice-gtk v1 2/2] gtk-session: clipboard: add some more debugs

2019-01-28 Thread Victor Toso
From: Victor Toso To help track race conditions and bad/unexpected behavior in general. Signed-off-by: Victor Toso --- src/spice-gtk-session.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index

Re: [Spice-devel] [spice-gtk v1 2/2] Require GStreamer 1.10 and above

2019-01-28 Thread Christophe Fergeau
On Wed, Jan 23, 2019 at 10:30:21PM +0100, Victor Toso wrote: > From: Victor Toso > > Odd minor versions are for development version, which means that > checks on 1.9.x should be considered for development while normal > environments should be running the stable. > > Some timeline of stable

Re: [Spice-devel] [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place

2019-01-28 Thread Gerd Hoffmann
Hi, > > If the above explains things better to you I should probably replace the > > commit message with that. > > This is actually my first review of a driver that I'm not familiar with. > I'm not quite sure how much in depth understanding that is required to > put my ack on it. Usually I

Re: [Spice-devel] [PATCH v3 17/23] drm/qxl: use generic fbdev emulation

2019-01-28 Thread Noralf Trønnes
Den 28.01.2019 09.59, skrev Gerd Hoffmann: > On Fri, Jan 25, 2019 at 06:25:27PM +0100, Noralf Trønnes wrote: >> >> >> Den 18.01.2019 13.20, skrev Gerd Hoffmann: >>> Switch qxl over to the new generic fbdev emulation. >>> >>> Signed-off-by: Gerd Hoffmann >>> --- >>>

Re: [Spice-devel] [PATCH v3 10/23] drm/qxl: move qxl_primary_apply_cursor to correct place

2019-01-28 Thread Noralf Trønnes
Den 28.01.2019 09.10, skrev Gerd Hoffmann: >>> The cursor must be set again after creating the primary surface. >>> Also drop the error message. > >>> if (!bo->is_primary) { >>> - if (!same_shadow) >>> + if (!same_shadow) { >>>

[Spice-devel] [PATCH] QXL interface: improve the spice_qxl_set_device_info documentation

2019-01-28 Thread Lukáš Hrázký
Instead of one unsupported example, present two real world examples. Signed-off-by: Lukáš Hrázký --- server/spice-qxl.h | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/server/spice-qxl.h b/server/spice-qxl.h index e7af5e5e..2f47910b 100644

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-28 Thread Jakub Janku
Hi, I tried to fix this bug in a less radical way, but my patch unfortunately did not cover all the cases. I obtained some logs from James Harvey which make the situation clearer - it can be found here: https://termbin.com/40un So I'll try to explain what's happening: James uses KDE which has a

Re: [Spice-devel] [PATCH v3 17/23] drm/qxl: use generic fbdev emulation

2019-01-28 Thread Gerd Hoffmann
On Fri, Jan 25, 2019 at 06:25:27PM +0100, Noralf Trønnes wrote: > > > Den 18.01.2019 13.20, skrev Gerd Hoffmann: > > Switch qxl over to the new generic fbdev emulation. > > > > Signed-off-by: Gerd Hoffmann > > --- > > drivers/gpu/drm/qxl/qxl_display.c | 7 --- > >