[Spice-devel] [PATCH spice-common] build: Remove snd_codec.h from EXTRA_DIST

2019-03-12 Thread Frediano Ziglio
The file is already distributed as included in the source list. Signed-off-by: Frediano Ziglio --- common/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/common/Makefile.am b/common/Makefile.am index 3318009..622bf0b 100644 --- a/common/Makefile.am +++ b/common/Makefile.am @@

Re: [Spice-devel] [spice-gtk 13/13] win-usb-dev: remove unused code

2019-03-12 Thread Christophe Fergeau
Great :) Acked-by: Christophe Fergeau On Sun, Mar 10, 2019 at 04:46:12PM +0200, Yuri Benditovich wrote: > Remove unused code related to GUdevDevice. > > Signed-off-by: Yuri Benditovich > --- > src/win-usb-dev.c | 74 --- > src/win-usb-dev.h | 27

Re: [Spice-devel] [spice-gtk 12/13] usb-redir: use persistent libusb_device under Windows also

2019-03-12 Thread Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:11PM +0200, Yuri Benditovich wrote: > Unify SpiceUsbDeviceInfo for Linux and Windows by using > persistent libusb_device. This really needs to be more detailed and explain why this is no longer a valid concern: * On win32 we need to do this the hard and slow way, by

Re: [Spice-devel] [spice-gtk 11/13] win-usb-dev: report libusb_device via signal

2019-03-12 Thread Christophe Fergeau
Maybe "win-usb-dev: pass libusb_device in "uevent" signal" as a shortlog. On Sun, Mar 10, 2019 at 04:46:10PM +0200, Yuri Benditovich wrote: > Change the signal to report libusb_device instead of GUdevDevice > object. This simplifies the callback procedure in usb-dev-manager > and avoids

Re: [Spice-devel] [spice-gtk 10/13] win-usb-dev: maintain list of libusb devices

2019-03-12 Thread Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:09PM +0200, Yuri Benditovich wrote: > Change internal device list to maintain libusb devices > instead of GUdevDevice objects. Create temporary > GUdevDevice object only for indication to usb-dev-manager. > > Signed-off-by: Yuri Benditovich > --- >

Re: [Spice-devel] [spice-gtk 09/13] win-usb-dev: do not allocate memory for hub devices

2019-03-12 Thread Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:08PM +0200, Yuri Benditovich wrote: > When processing list of USB devices, avoid allocating memory > for devices which later will be skipped. Use existing libusb > struct first to check whether the device shall be excluded. I probably would reword the short log

Re: [Spice-devel] [spice-gtk 08/13] usb-redir: change signal prototype of win-usb-dev

2019-03-12 Thread Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:07PM +0200, Yuri Benditovich wrote: > Changing signal definition from (boxed-boxed) to (pointer,int). > There is no need for additional referencing of GUdevDevice > object before signal callback. I still feel it would be nicer to guarantee the GUdevDevice will stay

Re: [Spice-devel] [spice-gtk 07/13] usb-redir: discard cold-plug device list under Windows

2019-03-12 Thread Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:06PM +0200, Yuri Benditovich wrote: Maybe the shortlog would be clearer as "usb-redir: remove SpiceUsbDeviceManager::coldplug_list" > Discard the optimization of initial device enumeration. > Just after connection to 'udev' signal request to report "... to the

Re: [Spice-devel] [PATCH spice-common] ci: Remove dependencies from copr build

2019-03-12 Thread Snir Sheriber
Acked-by: Snir Sheriber On 3/12/19 12:26 PM, Frediano Ziglio wrote: ping Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) This patch also fixes the CI which currently is failing.

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-12 Thread Frediano Ziglio
> > On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote: > > ping > > > > > > > > RedClient was an opaque structure for RedCharDevice. > > > It started to be used when RedsState started to contain all > > > the global state. > > > Make it opaque again. > > It seems we don't put the

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-12 Thread Christophe Fergeau
On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote: > ping > > > > > RedClient was an opaque structure for RedCharDevice. > > It started to be used when RedsState started to contain all > > the global state. > > Make it opaque again. It seems we don't put the same meaning to

Re: [Spice-devel] [vdagent-win PATCH] Remove support for very old Fedora versions

2019-03-12 Thread Christophe Fergeau
Ah sure, Acked-by: Christophe Fergeau On Wed, Feb 27, 2019 at 10:02:37AM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > mingw-spice-vdagent.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mingw-spice-vdagent.spec.in

Re: [Spice-devel] [PATCH spice-common] ci: Remove dependencies from copr build

2019-03-12 Thread Frediano Ziglio
ping > > Signed-off-by: Frediano Ziglio > --- > .gitlab-ci.yml | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > This patch also fixes the CI which currently is failing. > https://gitlab.freedesktop.org/fziglio/spice-common/pipelines/19951 > > diff --git a/.gitlab-ci.yml

Re: [Spice-devel] [vdagent-win PATCH] Remove support for very old Fedora versions

2019-03-12 Thread Frediano Ziglio
ping > > Signed-off-by: Frediano Ziglio > --- > mingw-spice-vdagent.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mingw-spice-vdagent.spec.in b/mingw-spice-vdagent.spec.in > index d129a7b..5fa9b7a 100644 > --- a/mingw-spice-vdagent.spec.in > +++

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-12 Thread Frediano Ziglio
ping > > RedClient was an opaque structure for RedCharDevice. > It started to be used when RedsState started to contain all > the global state. > Make it opaque again. > > Signed-off-by: Frediano Ziglio > --- > server/char-device.c | 16 +++- > 1 file changed, 7 insertions(+), 9

Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

2019-03-12 Thread Hans de Goede
Hi, On 07-02-19 09:59, Thomas Zimmermann wrote: Almost all TTM-based drivers use the same values for the mmap-able range of BO addresses. Each driver therefore duplicates the DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not configurable by drivers. This patch set replaces

Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

2019-03-12 Thread Hans de Goede
Hi, On 11-03-19 17:51, Christian König wrote: Am 11.03.19 um 17:39 schrieb Hans de Goede: Hi, On 07-02-19 09:59, Thomas Zimmermann wrote: Almost all TTM-based drivers use the same values for the mmap-able range of BO addresses. Each driver therefore duplicates the DRM_FILE_PAGE_OFFSET

Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

2019-03-12 Thread Christian König
Am 11.03.19 um 17:39 schrieb Hans de Goede: Hi, On 07-02-19 09:59, Thomas Zimmermann wrote: Almost all TTM-based drivers use the same values for the mmap-able range of BO addresses. Each driver therefore duplicates the DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not

Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

2019-03-12 Thread Daniel Vetter
On Mon, Mar 11, 2019 at 05:51:39PM +0100, Christian König wrote: > Am 11.03.19 um 17:39 schrieb Hans de Goede: > > Hi, > > > > On 07-02-19 09:59, Thomas Zimmermann wrote: > > > Almost all TTM-based drivers use the same values for the mmap-able > > > range of BO addresses. Each driver therefore