Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] gst-plugin: Drop sstream and use dedicated functions instead

2019-06-26 Thread Frediano Ziglio
> > Signed-off-by: Snir Sheriber Can you explain why this is better? It's not clear from the code. > --- > src/gst-plugin.cpp | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp > index

[Spice-devel] [PATCH spice-streaming-agent 2/2] gst-plugin: Use autovideoconvert element for color space conversion

2019-06-26 Thread Snir Sheriber
When vaapi based encoder is used it's likely that also vaapi based conversion is available (using the vaapipostproc element). Moving to autovideoconvert will automatically choose a suitable convert element according to elements availability (e.g. in the vaapi case it would select vaapipostproc due

[Spice-devel] [PATCH spice-streaming-agent 1/2] gst-plugin: Drop sstream and use dedicated functions instead

2019-06-26 Thread Snir Sheriber
Signed-off-by: Snir Sheriber --- src/gst-plugin.cpp | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp index 9858beb..cf660eb 100644 --- a/src/gst-plugin.cpp +++ b/src/gst-plugin.cpp @@ -8,7 +8,6 @@

[Spice-devel] Spice, GStreamer and seccomp issue

2019-06-26 Thread Kevin Pouget
Hello, I share for information the problem and solution I encountered why trying to run spice-server gstreamer encoding on Fedora30: > warning: GStreamer: External plugin loader failed. This most likely means > that the plugin loader helper binary was not found or could not be run. You > might

Re: [Spice-devel] [spice v3] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-26 Thread Uri Lublin
On 6/25/19 7:35 PM, Francois Gouget wrote: On Tue, 25 Jun 2019, Frediano Ziglio wrote: [...] uint64_t foo = 1234; spice_debug("foo=%" PRId64, foo / NSEC_PER_SEC); [...] If you assume long long == 64 bit should not be a big problem although you can still have the warning. So, we

[Spice-devel] [PATCH spice-gtk] spice-channel: return if has_error is TRUE in spice_channel_write_msg

2019-06-26 Thread Jakub Janků
Avoid linearizing if the message isn't written out anyway (spice_channel_flush_wire checks() this condition as well). This also silences the following error: (spicy:32087): GSpice-CRITICAL **: 16:22:03.147: spice_session_get_read_only: assertion 'SPICE_IS_SESSION(self)' failed that can be

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Fix typo in comment

2019-06-26 Thread Jakub Janku
Sure, Acked-by: Jakub Janků On Tue, Jun 25, 2019 at 12:13 PM Frediano Ziglio wrote: > > explicitely -> explicitly > > Signed-off-by: Frediano Ziglio > --- > src/channel-main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-main.c b/src/channel-main.c >