Re: [Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning with Fedora 30

2019-07-01 Thread Frediano Ziglio
> > Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build > because of this error/warning: > > > gstreamer-encoder.c: In function 'set_video_bit_rate': > > gstreamer-encoder.c:518:17: error: taking the absolute value of unsigned > > type 'uint64_t' {aka 'long unsigned int'} has no

[Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning with Fedora 30

2019-07-01 Thread Kevin Pouget
Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build because of this error/warning: > gstreamer-encoder.c: In function 'set_video_bit_rate': > gstreamer-encoder.c:518:17: error: taking the absolute value of unsigned type > 'uint64_t' {aka 'long unsigned int'} has no effect

Re: [Spice-devel] [PATCH spice-gtk] webdav: don't buffer input from phodav

2019-07-01 Thread Jakub Janku
Hi, On Mon, Jul 1, 2019 at 1:02 PM Frediano Ziglio wrote: > > > > > The current approach with OutputQueue in webdav has several problems: > > > > * if the connection is slow, webdav keeps reading from phodav > > and pushing messages to the internal channel xmit_queue. > > This way, the queue can

Re: [Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning

2019-07-01 Thread Kevin Pouget
On Mon, Jul 1, 2019 at 2:29 PM Frediano Ziglio wrote: > > > > > this warning is failing my build, I assume it comes from a new version > > of the compiler catching the useless call to abs(). > > > > Yes, getting too with Fedora 30. > > Instead of "is failing my build" could you describe your

Re: [Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning

2019-07-01 Thread Kevin Pouget
On Mon, Jul 1, 2019 at 2:33 PM Christophe de Dinechin wrote: > > > Kevin Pouget writes: > > > this warning is failing my build, I assume it comes from a new version > > of the compiler catching the useless call to abs(). > > Is it useless, or is there a signed/unsigned mismatch? > > I suspect the

Re: [Spice-devel] [PATCH v3 spice-streaming-agent] drop sstream and use dedicated functions instead

2019-07-01 Thread Frediano Ziglio
> > Instead of manipulating a string and convert it to caps just > use dedicated functions instead > > Signed-off-by: Snir Sheriber > --- > Changes from v2: > -use g_free as a deleter > (exactly 100 characters width) > > --- > src/gst-plugin.cpp | 34 ++ > 1

Re: [Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning

2019-07-01 Thread Christophe de Dinechin
Kevin Pouget writes: > this warning is failing my build, I assume it comes from a new version > of the compiler catching the useless call to abs(). Is it useless, or is there a signed/unsigned mismatch? I suspect the intent is more something like: abs((int64) (bit_rate -

Re: [Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning

2019-07-01 Thread Frediano Ziglio
> > this warning is failing my build, I assume it comes from a new version > of the compiler catching the useless call to abs(). > Yes, getting too with Fedora 30. Instead of "is failing my build" could you describe your environment? Like "Compiling with gcc 13.4 under Fedora 34 "... > --- >

[Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning

2019-07-01 Thread Kevin Pouget
this warning is failing my build, I assume it comes from a new version of the compiler catching the useless call to abs(). --- > error: taking the absolute value of unsigned type 'uint64_t' > {aka 'long unsigned int'} has no effect [-Werror=absolute-value] --- server/gstreamer-encoder.c | 2 +-

[Spice-devel] [PATCH v3 spice-streaming-agent] drop sstream and use dedicated functions instead

2019-07-01 Thread Snir Sheriber
Instead of manipulating a string and convert it to caps just use dedicated functions instead Signed-off-by: Snir Sheriber --- Changes from v2: -use g_free as a deleter (exactly 100 characters width) --- src/gst-plugin.cpp | 34 ++ 1 file changed, 18

Re: [Spice-devel] [PATCH spice-gtk] webdav: don't buffer input from phodav

2019-07-01 Thread Frediano Ziglio
> > > > > The current approach with OutputQueue in webdav has several problems: > > > > * if the connection is slow, webdav keeps reading from phodav > > and pushing messages to the internal channel xmit_queue. > > This way, the queue can grow very quickly and the whole file > > that is being

Re: [Spice-devel] [PATCH spice-gtk] webdav: don't buffer input from phodav

2019-07-01 Thread Frediano Ziglio
> > The current approach with OutputQueue in webdav has several problems: > > * if the connection is slow, webdav keeps reading from phodav > and pushing messages to the internal channel xmit_queue. > This way, the queue can grow very quickly and the whole file > that is being transferred using

[Spice-devel] [PATCH spice-gtk] webdav: don't buffer input from phodav

2019-07-01 Thread Jakub Janků
The current approach with OutputQueue in webdav has several problems: * if the connection is slow, webdav keeps reading from phodav and pushing messages to the internal channel xmit_queue. This way, the queue can grow very quickly and the whole file that is being transferred using webdav

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-01 Thread Frediano Ziglio
> > On 5/13/19 12:45 PM, Frediano Ziglio wrote: > > Do not declare the structure as aligned. > > The start/end-packed.h headers affects only MingW or Microsoft > > compilers. > > They also define/undef SPICE_ATTR_PACKED which affects Linux. > May be: The start/end-packed.h headers affects

Re: [Spice-devel] [PATCH spice-gtk] Replace some missing "latency" terms

2019-07-01 Thread Snir Sheriber
Ack for both On 6/28/19 10:46 AM, Frediano Ziglio wrote: ping This follows up commit 887aedff41bdb89845e7cb349454a8dcbb515db4 "The video latency is in fact a margin". Signed-off-by: Frediano Ziglio --- src/channel-display-priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Spice-devel] [PATCH v1 09/33] drm/qxl: drop use of drmP.h

2019-07-01 Thread Gerd Hoffmann
On Sun, Jun 30, 2019 at 08:18:58AM +0200, Sam Ravnborg wrote: > Drop use of the deprecated drmP.h header file. > While touching the files divided includes in blocks, > and when needed sort the blocks. > Fix fallout. > > Signed-off-by: Sam Ravnborg > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: