Re: [Spice-devel] [PATCH 2/4] channel-display-gst: Add "byte-stream" as the stream format for h264

2023-09-15 Thread Victor Toso
Hi, On Fri, Sep 15, 2023 at 05:51:14PM +0100, Frediano Ziglio wrote: > Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy > ha scritto: > > > > Adding the string "stream-format=byte-stream" to decoder capabilities > > (dec_caps) for h264/h265 codecs stops Gstreamer from complaining > >

Re: [Spice-devel] [PATCH 2/2] gstreamer-encoder: Use a h/w based encoder with Intel GPUs if possible (v2)

2023-09-15 Thread Frediano Ziglio
Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy ha scritto: > > Once it is determined that an Intel GPU is available/active (after > looking into udev's database), we try to see if there is a h/w > based encoder (element) available (in Gstreamer's registry cache) > for the user selected

Re: [Spice-devel] [PATCH 3/4] channel-display-gst: Don't unref appsink and pipeline objects

2023-09-15 Thread Frediano Ziglio
Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy ha scritto: > > It looks like setting the Gst pipeline state to GST_STATE_NULL > would cause all the references on most of the objects associated > with the pipeline to be dropped; therefore, there is no need > to explicitly unref them

Re: [Spice-devel] [PATCH 1/4] channel-display-gst: Prefer playbin3 to playbin

2023-09-15 Thread Frediano Ziglio
Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy ha scritto: > > From: Jin Chung Teng > > If playbin3 is available (checked in Gstreamer registry), it > makes sense to prefer it given the major improvements and > features it offers including the capability to handle higher > bitrates. >

Re: [Spice-devel] [PATCH 2/4] channel-display-gst: Add "byte-stream" as the stream format for h264

2023-09-15 Thread Frediano Ziglio
Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy ha scritto: > > Adding the string "stream-format=byte-stream" to decoder capabilities > (dec_caps) for h264/h265 codecs stops Gstreamer from complaining > about missing stream format. > > Cc: Frediano Ziglio > Cc: Dongwon Kim > Cc: Jin

Re: [Spice-devel] [PATCH 1/4] channel-display-gst: Prefer playbin3 to playbin

2023-09-15 Thread Frediano Ziglio
Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy ha scritto: > > From: Jin Chung Teng > > If playbin3 is available (checked in Gstreamer registry), it > makes sense to prefer it given the major improvements and > features it offers including the capability to handle higher > bitrates. >

Re: [Spice-devel] [PATCH 1/2] gstreamer-encoder: Use NV12 as the default vpp conversion format

2023-09-15 Thread Frediano Ziglio
Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy ha scritto: > > From: Hazwan Arif Mazlan > > Using NV12 as the output format for the videoconvert element would > allow us to pair a s/w based encoder with a h/w based decoder for > decoding the stream as most h/w based decoders only

Re: [Spice-devel] [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers

2023-09-15 Thread Doug Anderson
Hi, On Fri, Sep 15, 2023 at 2:11 AM suijingfeng wrote: > > Hi, > > > On 2023/9/2 07:39, Douglas Anderson wrote: > > Based on grepping through the source code these drivers appear to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among other things, this means

Re: [Spice-devel] [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers

2023-09-15 Thread suijingfeng
Hi, On 2023/9/15 21:44, Doug Anderson wrote: Hi, On Fri, Sep 15, 2023 at 2:11 AM suijingfeng wrote: Hi, On 2023/9/2 07:39, Douglas Anderson wrote: Based on grepping through the source code these drivers appear to be missing a call to drm_atomic_helper_shutdown() at system shutdown time.

Re: [Spice-devel] [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers

2023-09-15 Thread suijingfeng
Hi, On 2023/9/2 07:39, Douglas Anderson wrote: Based on grepping through the source code these drivers appear to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system