Re: [Spice-devel] [PATCH spice-server] README: Update required protocol version

> On 28 Jul 2017, at 10:17, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Fri, Jul 28, 2017 at 09:30:18AM +0200, Christophe de Dinechin wrote: >>> >>>> >>>> For example, a lot of the streaming work requires a branched-off >>&g

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> On 28 Jul 2017, at 10:23, Frediano Ziglio wrote: > >>> >>> On 27 Jul 2017, at 17:08, Frediano Ziglio wrote: >>> >>> Try to sum up the initial problem was patches/series tracking >>> >>> So far there are 3 proposal >>> 1) PR/MR (GitLab/GitHub style)

[Spice-devel] [PATCH spice-gtk] Update submodules using the --merge option

From: Christophe de Dinechin <dinec...@redhat.com> By default, subdmodules will be checked out in detached state. This means that you may lose some work in progress. Using the --merge option will also ensure that if there are conflicts between your current submodule and the version refe

Re: [Spice-devel] [vdagent-win PATCH] Prevent possible future buffer overflow

> On 26 Jul 2017, at 09:21, Frediano Ziglio wrote: > > event_type should come only with specific values but > this in theory can change in the future. > To prevent overflows (just for logging) check value size > against lookup array. > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [vdagent-win PATCH v12 3/6] Write code to decode PNG format

> On 25 Jul 2017, at 20:01, Frediano Ziglio wrote: > >> >> On Mon, Jul 24, 2017 at 01:39:35PM +0100, Frediano Ziglio wrote: >>> +size_t PngCoder::convert_to_dib(uint8_t *out_buf, const uint8_t *data, >>> size_t size) >>> +{ >> [...] >>> +const unsigned int width =

Re: [Spice-devel] [vdagent-win PATCH v12 3/6] Write code to decode PNG format

> On 26 Jul 2017, at 09:58, Frediano Ziglio wrote: > > > On 25 Jul 2017, at 20:01, Frediano Ziglio > wrote: > > > On Mon, Jul 24, 2017 at 01:39:35PM +0100, Frediano Ziglio wrote: > +size_t PngCoder::convert_to_dib(uint8_t

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> On 25 Jul 2017, at 19:37, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Tue, Jul 25, 2017 at 02:26:36PM +0200, Christophe de Dinechin wrote: >>>>> As long as contributor keep pinging or resending his series, this is >>>>> already the case.

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 19 Jul 2017, at 11:21, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Wed, Jul 19, 2017 at 10:23:30AM +0200, Christophe de Dinechin wrote: >> >>> On 18 Jul 2017, at 17:28, Christophe Fergeau <cferg...@redhat.com> wrote: >>> >>&

[Spice-devel] [PATCH 1/3] Add check for macOS, disable ucontext on macOS (deprecated)

Subject: [PATCH 1/3] Add check for macOS, disable ucontext on macOS (deprecated) Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index ad5e6e9..a6ac2de

Re: [Spice-devel] [PATCH win-vdagent] Support file transfer for existing files

> On 27 Apr 2017, at 17:31, Pavel Grunt > wrote: > > On Thu, 2017-04-27 at 10:25 -0500, Jonathon Jongsma wrote: >> On Wed, 2017-04-26 at 17:50 -0400, Frediano Ziglio wrote: Previously, if the user attempted to transfer a file that had

[Spice-devel] [PATCH 0/3] macOS pre-enablement

This is a series of changes to enable macOS build of spice-gtk. This is not sufficient for it to work well on macOS Sierra yet, but at least it builds. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [PATCH 3/3] Use autoconf rule for epoxy/egl.h (not present on macOS)

Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac| 13 ++--- src/Makefile.am | 2 +- src/spice-widget-priv.h | 6 +++--- src/spice-widget.c | 27 ++- 4 files changed, 28 insertions(+), 20 deletions(-)

[Spice-devel] [PATCH 2/3] Fix unsatisfied symbol from export list if USE_USBREDIR is not set

Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- src/usb-device-manager.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 6e6a683..66f0eb5 100644 --- a/src/usb-device-manager.c +++ b/src/usb-

Re: [Spice-devel] [PATCH 1/3] Add check for macOS, disable ucontext on macOS (deprecated)

> On 28 Apr 2017, at 13:57, Daniel P. Berrange wrote: > > On Fri, Apr 28, 2017 at 07:48:01AM -0400, Marc-André Lureau wrote: >> Hi >> >> - Original Message - >>> Subject: [PATCH 1/3] Add check for macOS, disable ucontext on macOS >>> (deprecated) >>> >> >> It's

Re: [Spice-devel] [PATCH 3/3] Use autoconf rule for epoxy/egl.h (not present on macOS)

m interested. But I did not find it back when I wrote that patch. Christophe > >> >> - Original Message - >>> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> >>> --- >>> configure.ac| 13 ++--- >>> src

[Spice-devel] [PATCH 2/3 v2] Fix unsatisfied symbol from export list if USE_USBREDIR is not set

s exported in spice-glib-sym-file. Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- src/usb-device-manager.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 6e6a683..66f0eb5 100644 --- a/src/usb-device

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

> On 4 Aug 2017, at 13:44, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Fri, Aug 04, 2017 at 12:11:44PM +0200, Christophe de Dinechin wrote: >> >>> On 18 Jul 2017, at 16:48, Christophe Fergeau <cferg...@redhat.com> wrote: >>> >>>

Re: [Spice-devel] Getting patchwork to acknowledge acks?

> On 4 Aug 2017, at 14:03, Frediano Ziglio <fzig...@redhat.com> wrote: > >> >> Hi, >> >> On Fri, Aug 04, 2017 at 01:01:05PM +0200, Christophe de Dinechin wrote: >>>> It does not check if given patch was pushed, no. :( >>> >>&g

Re: [Spice-devel] Getting patchwork to acknowledge acks?

> On 4 Aug 2017, at 14:49, Victor Toso <victort...@redhat.com> wrote: > > On Fri, Aug 04, 2017 at 02:34:44PM +0200, Christophe de Dinechin wrote: >> >>> On 4 Aug 2017, at 14:03, Frediano Ziglio <fzig...@redhat.com> wrote: >>> >>>> >

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

at.com > <mailto:berra...@redhat.com>> wrote: > > On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin <dinec...@redhat.com > <mailto:dinec...@redhat.com>> > > Signed-off-by: Christophe de D

Re: [Spice-devel] [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

int *') increases required alignment from >>>> 1 >>>>to >>>>4 [-Werror,-Wcast-align] >>>> >>>> Adding an intermediate cast to (void *) silences the warning. >>>> >>>> Signed-off-by: Christophe de Dinec

[Spice-devel] [PATCH spice-gtk v2 2/4] Avoid warning about snprintf on non-Linux platforms

From: Christophe de Dinechin <dinec...@redhat.com> Without #include , calls to snprintf in the file cause a warning. The file is left aside on purpose, since src/usbutil.c may be compiled on Windows where this file does not exist. Signed-off-by: Christophe de Dinechin <dinec...@r

[Spice-devel] [PATCH spice-gtk v2 0/4] Another set of macOS pre-enablement patches

From: Christophe de Dinechin <dinec...@redhat.com> This patch set eliminates warnings detected by clang with respect to type alignments. Vittorio Toso had submitted something similar. In this version, I took into account comments by Christophe Fergeau regarding how to know which cast

[Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index 74b5811..ecab365 100644 --- a/configure.ac +++ b/

[Spice-devel] [PATCH spice-gtk v2 3/4] Remove warning about unused variable when building on macOS

From: Christophe de Dinechin <dinec...@redhat.com> On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPriv

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

> On 11 May 2017, at 12:56, Daniel P. Berrange <berra...@redhat.com> wrote: > > On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: >> From: Christophe de Dinechin <dinec...@redhat.com> >> >> Signed-off-by: Christophe de Dinechin <d

Re: [Spice-devel] [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

> On 11 May 2017, at 11:17, Frediano Ziglio wrote: > > ... > > > > g_array_set_size(c->remote_common_caps, num_common_caps); > for (i = 0; i < num_common_caps; i++, caps++) { > > > I cannot find these macros defined in spice-gtk. Where are they? > > spice-common. I

Re: [Spice-devel] [spice-server v2 5/6] Make RedCharDeviceWriteBuffer::refs private

> > On 28 Apr 2017, at 11:11, Christophe Fergeau wrote: > > Signed-off-by: Christophe Fergeau > --- > server/char-device.c | 11 ++- > server/char-device.h | 1 - > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git

[Spice-devel] [PATCH spice-gtk v2 1/4] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

Re: [Spice-devel] Windows 10 guest: 2D/3D Accel

es from (i.e. it may be in some Intel chipset and not in the GPU ;-) I believe that the general answer is “it depends”. Cheers, Christophe > > Thanks a lot! > > > > > > 2017-05-09 16:56 GMT+02:00 Christophe de Dinechin <cdupo...@redhat.com > <mailto:cdupo...

[Spice-devel] [PATCH 1/2] Style adjustment

Fixing a piece of code that does not match the style for the rest of the source files Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- common/sw_canvas.c | 96 +- 1 file changed, 45 insertions(+), 51 deletions(-) diff

[Spice-devel] [PATCH 0/2] Another set of macOS pre-enablement patches

instrumentation to detect the two cases. The casts that are supposed to be aligned will issue a warning if data is actually misaligned. The casts that are known to be misaligned can still be checked by setting environment variable SPICE_DEBUG_ALIGNMENT=1 Christophe de Dinechin (2): Style adjustment

[Spice-devel] [PATCH 2/2] Avoid clang warnings on casts with stricter alignment requirements

,-Wcast-align] Adding an intermediate cast to (void *) silences the warning. Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- common/canvas_base.c | 14 +- common/mem.c | 24 common/mem.h | 33 +++--

[Spice-devel] [PATCH spice-gtk 3/4] Remove warning about unused variable when building on macOS

On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPrivate *d = display->priv; Signed-off-by: Christophe de Dinec

[Spice-devel] [PATCH spice-gtk 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

(This was already sent in a previous series - For the moment, I need ucontext disabled to be able to build successfully on macOS) Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configur

[Spice-devel] [PATCH spice-gtk 2/4] Avoid warning about snprintf on non-Linux platforms

Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- src/usbutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usbutil.c b/src/usbutil.c index b68a2e1..6957b74 100644 --- a/src/usbutil.c +++ b/src/usbutil.c @@ -27,9 +27,9 @@ #include #ifdef USE_US

[Spice-devel] [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

,-Wcast-align] Adding an intermediate cast to (void *) silences the warning. Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- spice-common| 2 +- src/channel-cursor.c| 6 +++--- src/channel-display-mjpeg.c | 2 +- src/decode-glz-tmpl.c | 2 +- src

[Spice-devel] [PATCH spice-gtk 0/4] Another set of macOS pre-enablement patches

, reference to submodule udpated) Christophe de Dinechin (4): Avoid clang warnings on casts with stricter alignment requirements Avoid warning about snprintf on non-Linux platforms Remove warning about unused variable when building on macOS Add check for macOS, disable ucontext on macOS (deprecated

[Spice-devel] [PATCH v2 0/2] macOS enablement patches

From: Christophe de Dinechin <dinec...@redhat.com> This patch set eliminates warnings detected by clang with respect to type alignments. Vittorio Toso had submitted something similar. In this version, I took into account comments by Christophe Fergeau regarding how to know which cast

[Spice-devel] [PATCH v2 2/2] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

[Spice-devel] [PATCH v2 1/2] Style adjustment

From: Christophe de Dinechin <dinec...@redhat.com> Fixing a piece of code that does not match the style for the rest of the source files Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- common/sw_canvas.c | 96 +- 1

Re: [Spice-devel] [PATCH spice-gtk v2 2/4] Avoid warning about snprintf on non-Linux platforms

> On 16 May 2017, at 15:00, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Thu, May 11, 2017 at 12:47:06PM +0200, Christophe de Dinechin wrote: >> From: Christophe de Dinechin <dinec...@redhat.com> >> >> Without #include , calls to snprintf i

[Spice-devel] [PATCH spice-gtk v3 2/5] Avoid warning about snprintf on non-Linux platforms

From: Christophe de Dinechin <dinec...@redhat.com> Without #include , calls to snprintf in the file cause a warning. The file is left aside on purpose, since src/usbutil.c may be compiled on Windows where this file does not exist. Signed-off-by: Christophe de Dinechin <dinec...@r

[Spice-devel] [PATCH spice-gtk v3 0/5] macOS fixes for spicy

From: Christophe de Dinechin <dinec...@redhat.com> This patch set mostly eliminates warnings detected by clang with respect to type alignments. Vittorio Toso had submitted something similar. In this version, I took into account comments by Christophe Fergeau regarding how to know which cast

[Spice-devel] [PATCH spice-gtk v3 3/5] Remove warning about unused variable when building on macOS

From: Christophe de Dinechin <dinec...@redhat.com> On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPriv

[Spice-devel] [PATCH spice-gtk v3 5/5] Use SPICE_ALIGNED_CAST to silence warning with ucontext on macOS

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac| 3 ++- src/channel-cursor.c| 6 +++--- src/channel-display-mjpeg.c | 2 +- src/continuation.h | 6 -- src/decod

[Spice-devel] [PATCH spice-gtk v3 4/5] Add check for macOS, disable ucontext on macOS (deprecated)

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index 74b5811..ecab365 100644 --- a/configure.ac +++ b/

[Spice-devel] [PATCH spice-gtk v3 1/5] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

Re: [Spice-devel] [PATCH spice-gtk v3 1/5] Avoid clang warnings on casts with stricter alignment requirements

> On 17 May 2017, at 09:44, Frediano Ziglio <fzig...@redhat.com> wrote: > >> >> From: Christophe de Dinechin <dinec...@redhat.com> >> >> For example, something like this: >>uint8_t *p8; >>uint32_t *p32 = (uint32_t *) p8; >>

Re: [Spice-devel] [PATCH spice-gtk v3 3/5] Remove warning about unused variable when building on macOS

> On 17 May 2017, at 11:24, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Wed, May 17, 2017 at 03:47:48AM -0400, Frediano Ziglio wrote: >>> >>> From: Christophe de Dinechin <dinec...@redhat.com> >>> >>> On macOS, neither of the

[Spice-devel] [PATCH spice-gtk v4 0/4] Repair macOS builds for spice-gtk

From: Christophe de Dinechin <dinec...@redhat.com> This patch set contains various fixes that repair macOS builds for spice-gtk (and presumably clang builds as a side effect), notably: - Fixes for clang-specific warnings, notably on alignment - Addition of macOS detection in configure

[Spice-devel] [PATCH spice-gtk v4 4/4] Remove warning about unused variable when building on macOS

From: Christophe de Dinechin <dinec...@redhat.com> On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPriv

[Spice-devel] [PATCH spice-gtk v4 1/4] Add check for macOS

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index ff00d73..62acafc 100644 --- a/configure.ac +++ b/

[Spice-devel] [PATCH spice-gtk v4 3/4] Avoid warning about snprintf on non-Linux platforms

From: Christophe de Dinechin <dinec...@redhat.com> Without #include , calls to snprintf in the file cause a warning. The file is left aside on purpose, since src/usbutil.c may be compiled on Windows where this file does not exist. Signed-off-by: Christophe de Dinechin <dinec...@r

[Spice-devel] [PATCH spice-gtk v4 2/4] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

Re: [Spice-devel] [PATCH spice-gtk v2 1/4] Avoid clang warnings on casts with stricter alignment requirements

> On 16 May 2017, at 16:51, Christophe Fergeau <cferg...@redhat.com> wrote: > > Hey, > > On Thu, May 11, 2017 at 12:47:05PM +0200, Christophe de Dinechin wrote: >> From: Christophe de Dinechin <dinec...@redhat.com> >> >> For example, something like

Re: [Spice-devel] [PATCH spice-gtk v3 1/5] Avoid clang warnings on casts with stricter alignment requirements

> On 17 May 2017, at 11:55, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Wed, May 17, 2017 at 11:45:50AM +0200, Christophe de Dinechin wrote: >>> I'm really sure no architecture on hearth can do check and print in >>> a single machine instruction. >&

Re: [Spice-devel] [PATCH spice-gtk v3 1/5] Avoid clang warnings on casts with stricter alignment requirements

> On 17 May 2017, at 12:08, Frediano Ziglio <fzig...@redhat.com> wrote: > >> >> >>> On 17 May 2017, at 09:44, Frediano Ziglio <fzig...@redhat.com> wrote: >>> >>>> >>>> From: Christophe de Dinechin <dinec...@r

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

> On 12 May 2017, at 15:29, Frediano Ziglio <fzig...@redhat.com> wrote: > >>> >>> On 11 May 2017, at 12:56, Daniel P. Berrange <berra...@redhat.com> wrote: >>> >>> On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote:

Re: [Spice-devel] [PATCH 3/3] Use autoconf rule for epoxy/egl.h (not present on macOS)

ary updated) > > Ah it may be just epoxy/egl.h not availale on macos, my bad > >> >> - Original Message - >>> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> >>> --- >>> configure.ac| 13

Re: [Spice-devel] Windows 10 guest: 2D/3D Accel

Hi Oscar, For 3D acceleration in virtual machines, you need a multiplicity of components to cooperate: 1. The physical GPU needs to be supported by the host. 2. It needs to expose an API that the virtual machine software can access, e.g. OpenGL on Linux 3. The virtualisation software, e.g.

Re: [Spice-devel] [PATCH 3/3] Use autoconf rule for epoxy/egl.h (not present on macOS)

> On 9 May 2017, at 16:56, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Tue, May 09, 2017 at 04:22:34PM +0200, Christophe de Dinechin wrote: >> Thanks. I had not seen the leftover (void) d (this was to remove an >> unused-variable warnin

Re: [Spice-devel] Windows 10 guest: 2D/3D Accel

> On 9 May 2017, at 16:51, Christophe de Dinechin <cdupo...@redhat.com> wrote: > > Hi Oscar, > > > For 3D acceleration in virtual machines, you need a multiplicity of > components to cooperate: > > 1. The physical GPU needs to be supported by the host.

[Spice-devel] [PATCH spice-gtk v7 4/4] Address alignment warnings detected by clang

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- src/channel-cursor.c | 6 -- src/spice-channel.c | 14 -- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/channel-cursor.c b

[Spice-devel] [PATCH spice-gtk v7 2/4] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

[Spice-devel] [PATCH spice-gtk v7 1/4] Add check for macOS and macOS specific define to allow ucontext

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index ff00d73..62acafc 100644 --- a/configure.ac +++ b/

[Spice-devel] [PATCH spice-gtk v7 3/4] Remove warning about unused variable when building on macOS

From: Christophe de Dinechin <dinec...@redhat.com> On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPriv

[Spice-devel] [PATCH spice-gtk v7 0/4] Repair macOS builds for spice-gtk

From: Christophe de Dinechin <dinec...@redhat.com> This patch set contains various fixes that repair macOS builds for spice-gtk (and presumably clang builds as a side effect), notably: - Fixes for clang-specific warnings, notably on alignment - Addition of macOS detection in configure

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

> On 12 Jun 2017, at 10:19, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > Hi, > > This is a RFC series to clean-up Spice logging infrastructure to fully > rely on glib g_log & g_log_structured if available, and add logging > categories. It is

Re: [Spice-devel] RFC: Lightweight tracing mechanism

This is a response to Christophe, Marc André and Frediano, but it starts with a top-post for context. My intent should become clearer with actual examples. You can test the code and examples from the same location as before: https://github.com/c3d/spice-gtk/compare/master...c3d:traces and

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Some interesting stuff in there. Victor, do you have a repository / branch where I could fetch that (even if it’s stale)? Thanks Christophe > On 7 Jun 2017, at 17:39, Christophe Fergeau wrote: > > On Wed, Jun 07, 2017 at 11:30:24AM -0400, Marc-André Lureau wrote: >> Or

Re: [Spice-devel] [PATCH spice-gtk] Remove unnecessary debug check from SPICE_DEBUG

> > On 8 Jun 2017, at 23:17, Jonathon Jongsma wrote: > > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is > unnecessary since g_log() will already check whether the message will > actually be printed. The only benefit to calling this function from >

Re: [Spice-devel] [PATCH spice-gtk v8 0/4] Repair macOS builds for spice-gtk

r/local/lib -L/usr/local/Cellar/openssl/1.0.2j/lib" Christophe “the other one" > On 20 Jun 2017, at 15:35, Christophe Fergeau <cferg...@redhat.com> wrote: > > Hey, > > Fwiw I pushed these and the corresponding spice-common patches. > > Christophe > &

[Spice-devel] [PATCH v3 2/2] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

[Spice-devel] [PATCH v3 1/2] Style adjustment - Making code match surrounding style

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- common/mem.h | 3 +- common/sw_canvas.c | 131 ++--- 2 files changed, 64 insertions(+), 70 deletions(-) diff --

Re: [Spice-devel] [PATCH v2 2/2] Avoid clang warnings on casts with stricter alignment requirements

> On 23 May 2017, at 11:51, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Thu, May 18, 2017 at 03:24:41PM +0200, Christophe de Dinechin wrote: >>> >>>> @@ -140,6 +140,41 @@ size_t spice_strnlen(const char *str, size_t max_len); >>>

Re: [Spice-devel] [PATCH spice-server] gstreamer: Check if ORC library can work

> On 19 May 2017, at 13:23, Frediano Ziglio wrote: > > ORC lirabry is used internally by GStreamer to generate code > dynamically. > If ORC cannot allocate executable memory the failure cause > an abort(3) to be called. > This happens on some SELinux configuration that

Re: [Spice-devel] [PATCH v2 2/2] Avoid clang warnings on casts with stricter alignment requirements

> On 24 May 2017, at 10:09, Christophe Fergeau wrote: > > On Tue, May 23, 2017 at 12:55:13PM +0200, Victor Toso wrote: >>> >>> I only see -DNDEBUG being defined for cmake builds in rpm --showrc, and >>> none of my 250 spec files have a -DNDEBUG in them, so I would not

Re: [Spice-devel] [PATCH v2 2/2] Avoid clang warnings on casts with stricter alignment requirements

> On 24 May 2017, at 10:46, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Tue, May 23, 2017 at 07:05:18PM +0200, Christophe de Dinechin wrote: >>> , another alternative would be to have a --enable-alignment-debug, >> >> I tried that, but the proble

Re: [Spice-devel] [PATCH spice-gtk v2 3/4] Remove warning about unused variable when building on macOS

> On 16 May 2017, at 15:15, Frediano Ziglio <fzig...@redhat.com> wrote: > >> >> On Thu, May 11, 2017 at 12:47:07PM +0200, Christophe de Dinechin wrote: >>> From: Christophe de Dinechin <dinec...@redhat.com> >>> >>> On macOS, neithe

[Spice-devel] [PATCH spice-gtk v5 2/5] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

[Spice-devel] [PATCH spice-gtk v5 0/5] Repair macOS builds for spice-gtk

From: Christophe de Dinechin <dinec...@redhat.com> This patch set contains various fixes that repair macOS builds for spice-gtk (and presumably clang builds as a side effect), notably: - Fixes for clang-specific warnings, notably on alignment - Addition of macOS detection in configure

[Spice-devel] [PATCH spice-gtk v5 3/5] Avoid warning about snprintf on non-Linux platforms

From: Christophe de Dinechin <dinec...@redhat.com> Without #include , calls to snprintf in the file cause a warning. The file is left aside on purpose, since src/usbutil.c may be compiled on Windows where this file does not exist. Signed-off-by: Christophe de Dinechin <dinec...@r

[Spice-devel] [PATCH v4 0/3] macOS enablement patches

From: Christophe de Dinechin <dinec...@redhat.com> This patch set eliminates warnings detected by clang with respect to type alignments. Vittorio Toso had submitted something similar. In this version, I took into account comments by Christophe Fergeau regarding how to know which cast

[Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index ff00d73..62acafc 100644 --- a/configure.ac +++ b/

[Spice-devel] [PATCH spice-gtk v5 5/5] Add configure option --enable-alignment-checks

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 8 spice-common | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 62acafc..ca

[Spice-devel] [PATCH spice-gtk v5 4/5] Remove warning about unused variable when building on macOS

From: Christophe de Dinechin <dinec...@redhat.com> On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPriv

Re: [Spice-devel] [PATCH spice-gtk v5 3/5] Avoid warning about snprintf on non-Linux platforms

> On 30 May 2017, at 14:57, Frediano Ziglio <fzig...@redhat.com> wrote: > >> >> From: Christophe de Dinechin <dinec...@redhat.com> >> >> Without #include , calls to snprintf in the file >> cause a warning. The file is left aside on purpose, &

[Spice-devel] [PATCH v4 3/3] Add configure option for --enable-alignment-checks

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 8 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 6d9f378..efd7317 100644 --- a/configure.ac +++ b/configure

[Spice-devel] [PATCH v4 2/3] Put alignment checks under #ifdef SPICE_DEBUG_ALIGNMENT

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- common/mem.c | 3 +-- common/mem.h | 27 ++- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/common/mem.c b/common/mem.c i

[Spice-devel] [PATCH v4 1/3] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

Re: [Spice-devel] [PATCH spice-gtk v5 4/5] Remove warning about unused variable when building on macOS

> On 31 May 2017, at 10:22, Christophe Fergeau wrote: > > On Wed, May 31, 2017 at 04:15:27AM -0400, Frediano Ziglio wrote: >> >> It's true, on the other way all this patch is supposed to fix >> a warning considered error for -Werror. >> The other way is remove -Werror and

Re: [Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

gt; Christophe >> >>> >>> Frediano >>> >>>> >>>> Is this used by a patch in this series though? I'd rather we delay this >>>> until this gets used. >>>> >>>> Christophe >>>>

Re: [Spice-devel] [PATCH v4 2/3] Put alignment checks under #ifdef SPICE_DEBUG_ALIGNMENT

er. Christophe > > Christophe > > On Tue, May 30, 2017 at 02:51:50PM +0200, Christophe de Dinechin wrote: >> From: Christophe de Dinechin <dinec...@redhat.com> >> >> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> >> --- >> common/mem.c

[Spice-devel] Role of spice_logger

I’m looking at logging functions in log.c, and I wonder why we disable logging only at the spice_logger level. There is a test like this in spice_logger: if (glib_debug_level != 0) { if ((log_level & G_LOG_LEVEL_MASK) > glib_debug_level) return; // do not print anything

Re: [Spice-devel] [PATCH spice-gtk v5 2/5] Avoid clang warnings on casts with stricter alignment requirements

> On 30 May 2017, at 15:49, Frediano Ziglio <fzig...@redhat.com> wrote: > >> >> From: Christophe de Dinechin <dinec...@redhat.com> >> >> For example, something like this: >>uint8_t *p8; >>uint32_t *p32 = (uint32_t *) p8; >>

[Spice-devel] [PATCH spice-gtk v6 3/4] Remove warning about unused variable when building on macOS

From: Christophe de Dinechin <dinec...@redhat.com> On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPriv

[Spice-devel] [PATCH spice-gtk v6 1/4] Add check for macOS and macOS specific define to allow ucontext

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- configure.ac | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index ff00d73..62acafc 100644 --- a/configure.ac +++ b/

[Spice-devel] [PATCH spice-gtk v6 2/4] Avoid clang warnings on casts with stricter alignment requirements

From: Christophe de Dinechin <dinec...@redhat.com> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsign

[Spice-devel] [PATCH spice-gtk v6 4/4] Address alignment warnings detected by clang

From: Christophe de Dinechin <dinec...@redhat.com> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com> --- src/channel-cursor.c | 8 +--- src/spice-channel.c | 17 ++--- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/channel-cursor.c b

<    1   2   3   4   5   6   7   8   9   >