When uncapped x264enc can compress the frames beyond recognition in low
bitrate situation. Beyond the set limit the gains are modest and it is
better to drop frames to reduce the bit rate further.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
server/gstreamer-encoder
On Thu, 27 Oct 2016, Jonathon Jongsma wrote:
> On Thu, 2016-10-27 at 18:41 +0200, Francois Gouget wrote:
> > Deprecation warnings no longer cause compilation errors.
>
> Since when?
Right. That change comes from the last patch in the series. In fact if
this patch i
This gains us automatic support for whichever compilers GLib supports in
this macro when used in projects that use GLib.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
This can make sense if we consider GLib to be a platform similar to gcc,
MSVC: it just provides a G_X
The new policy is that deprecation warnings should not be disabled
globally or even per-file with SPICE_NO_DEPRECATED. Instead they should
either be fixed, or ignored locally with
G_GNUC_{BEGIN,END}_IGNORE_DEPRECATIONS.
Signed-off-by: Francois Gouget <fgou...@codeweavers.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
This is an alternative take on the previous patch: instead of reusing
the GLib macro it just duplicates its logic.
GLib approach
-
Pros: - Automatic support for whichever platforms GLib supports.
- Simple
On Thu, 27 Oct 2016, Francois Gouget wrote:
[...]
> Testing this you'll notice that reducing the available bandwidth results
> in freezes and recovery times that take a dozen second or more. This is
> because it's only after a sufficient backlog has been created (possibly
> a single
ould go on the commit message.
> I think you are right to limit the quantizer value and prefer to drop
> frames.
These considerations are all related to vp8enc (either on its own or
relative to x264enc) and are thus irrelevant to whether the quantifier
should be limited when using x264enc.
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
term
solution is.
But as for the other cases, either there's a suitable non-deprecated API
and we modify our implementation to use it; or we stick to the
deprecated APIs and add comments explaining why next to the
XXX_IGNORE_DEPRECATIONS statements.
--
Francois Gouget <fgou.
thread for most of the time.
So this patch configures the VP8 encoder to use all the CPU's physical
core, resulting in less wall clock time spent in encode_frame().
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
I am resubmitting this patch because I think the reasons for not
ap
t.subjectprefix configuration
> parameter. For example, I use the following configuration for spice-
> gtk:
>
> [format]
> subjectprefix = PATCH spice-gtk
>
> Acked-by: Jonathon Jongsma <jjong...@redhat.com>
Something wrong? It has not been pushed yet...
--
EADDRINUSE usually means the socket file was left behind after a crash.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/vdagentd/vdagentd.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/udscs.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/udscs.h b/src/udscs.h
index e13750c..d65630d 100644
--- a/src/udscs.h
+++ b/src/udscs.h
@@ -39,8 +39,9 @@ struct udscs_message_
udsc is an internal library of sorts that's irrelevant to users.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/vdagentd/vdagentd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
index 1
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/spiceqxl_io_port.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
index 165b8a9..6721d3f 100644
--- a/src/spiceqxl_io_port.c
+++ b/src/spiceqxl_io_port.c
@@
video decoder initialization fails since
no frame has been received yet at that point.
Also the server already needs to validate data sent by the client so
these values should not cause it any trouble.
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
The GTK+ compatibility code has been gathered in a single file long ago
and support for GTK+ 2 has been dropped anyway.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/spice-widget.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-wi
Its implementation is modeled after gtk_dialog_run() which still uses
these deprecated thread functions.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/spice-gtk-session.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/spice-gtk-session.c
Deprecation warnings no longer cause compilation errors.
Also they should either be fixed or ignored with
G_GNUC_{BEGIN,END}_IGNORE_DEPRECATIONS.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/Makefile.am | 1 -
src/spice-util.h | 12 +++-
2 files chan
GtkAction and lots of GtkUI APIs are deprecated.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/spicy.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/spicy.c b/src/spicy.c
index c502428..c4a6c7d 100644
--- a/src/spicy.c
+++ b/src/spicy.c
@@ -38,6
It has been deprecated for long enough.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/spice-audio-priv.h | 2 ++
src/spice-audio.h | 5 -
src/spice-session.c| 2 +-
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/spice-audio-priv.h b/src
/032995.html
Francois Gouget (10):
gtk: Remove an obsolete comment
vncdisplaykeymap: Remove obsolete GTK+ 2 compatibility macros
gtk: Ignore GLib's too-new warnings where we explicitly check its version
gdk: Ignore clipboard_get()'s deprecation warnings
audio: Remove spice_audio_new() from
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/vncdisplaykeymap.c | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/src/vncdisplaykeymap.c b/src/vncdisplaykeymap.c
index c50f9f7..d0c9739 100644
--- a/src/vncdisplaykeymap.c
+++
send stream reports all this is bypassed and
instead the streaming code performs its own primitive bit rate control
that can only adjust the frame rate.
So this patch removes the code duplication and lets the video encoders
do their job.
Signed-off-by: Francois Gouget <fgou...@codeweavers.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
server/gstreamer-encoder.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index 6afc7e4..f9cd3ca 100644
--- a/server/gstreamer-encoder.c
+++ b/
On Thu, 1 Sep 2016, Christophe Fergeau wrote:
> On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote:
> >
> > The following patch broke compilation of xf86-video-qxl:
> >
> > commit b41220b1441b8adea6db9a98e9da1b43a8f426bb
> > Author: Christophe Ferge
t settled on a bandwidth lower than what
is truly available, it will only try to increase bandwidth usage again
after a while and only quite progressively (at least for the GStreamer
backend, I don't really remember what the mjpeg one does in that case).
--
Francois G
On Mon, 17 Oct 2016, Francois Gouget wrote:
[...]
> > Imo this SPICE_NO_DEPRECATED is only meant to be used internally by
> > spice-gtk even if this is not really documented. I would not consider it
> > breakage if this was removed, or changed in incompatible ways.
> &g
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
spice/vd_agent.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/spice/vd_agent.h b/spice/vd_agent.h
index 445b458..c49f596 100644
--- a/spice/vd_agent.h
+++ b/spice/vd_agent.h
@@ -180,6 +180,12 @
SmartCardChannelClient is already defined in smartcard.h which
is included in the smartcard-channel-client.h header.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
This patch series is nice and really does help.
I would add this patch to it.
server/smartcard-channel-client
On Thu, 1 Dec 2016, Christophe Fergeau wrote:
> On Thu, Dec 01, 2016 at 04:27:36AM +0100, Francois Gouget wrote:
> > On Wed, 23 Nov 2016, Christophe Fergeau wrote:
> >
> > > On Wed, Nov 23, 2016 at 07:09:28AM +0100, Francois Gouget wrote:
> > > > For Spice-g
d others not.
Yes. It turns out that the help message for --help is hardcoded and
start with a lowercase and does not have a trailing period. So I
standardized on that to match.
> How is the end result of --help ?
I'll include it in v2.
--
Francois Gouget <fgou...@codewe
gt; +'video_codecs', 'vdagent_enabled', 'vdagent_virtio_path',
> > +'vdagent_uinput_path', 'vdagent_uid', 'vdagent_gid']
> >
>
> I'd drop this last hunk.
Ok.
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Group the options more logically and improve their descriptions.
Add the missing help strings for Xspice --help and standardize the
messages to start with a lowercase and not end with a period.
In the Xorg configuration, always show the default in the
commented-out sample.
Signed-off-by: Francois
are reinstated.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
Is this what you had in mind?
spice/macros.h | 46 +-
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/spice/macros.h b/spice/macros.h
index 1f8a5c8..29eaf10
should be set as last
> argument. e.g: encoder:codec:rank
>
> Video codecs will now be ordered by rank.
Why do you need a rank?
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
h
On Tue, 13 Dec 2016, Victor Toso wrote:
> Hi,
>
> Thanks again for your feedback.
>
> On Tue, Dec 13, 2016 at 08:06:50PM +0100, Francois Gouget wrote:
> > So your complexity objection is about the format in which to send the
> > client's codec preferences to t
le capabilities for the client.
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
disabled
-> the server prefers h264, vp8, spice:mjpeg in that order
2-) client advertises support for vp8, mjpeg, h264
-> the server picks h264
So the only thing that ranks allow is to be able to not express a
preference between several codecs. I just don't see the point of that.
--
state for upstream inclusion. As a start spicevideosink is a GStreamer
0.10 video sink so it works on RHEL 6 :-(
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
are reinstated.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
I think v2 would have resulted in all warnings recommending using
G_GNUC_CONST so I added a name parameter:
+#define SPICE_ATTRIBUTE_DEPRECATED(attribute) __attribute__((attribute,
warning("deprecated, use -DSPICE
imum_frame_size(encoder) +
> get_average_frame_size(encoder);
> uint32_t send_time = MSEC_PER_SEC * size * 8 / encoder->bit_rate;
>
> /* Also factor in the network latency with a margin for jitter. */
>
536870 bytes seems really large for a single frame but being prepared
for tha
Frediano Ziglio <fzig...@redhat.com>
> ---
Acked-by: Francois Gouget <fgou...@codeweavers.com>
> server/gstreamer-encoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> index b9b1a56..e28ab0
On Thu, 1 Dec 2016, Christophe Fergeau wrote:
> On Thu, Dec 01, 2016 at 05:19:33AM +0100, Francois Gouget wrote:
> > udscs_server_fill_fds() should accept being passed a NULL pointer.
>
> I would reword the commit log a bit, like "udscs_server_fill_fds() is
> dereferenci
Document what happens whenever passing a NULL server or connection
pointer is allowed.
Make it clear that only pathname Unix domain sockets are supported.
Also document when no_types and the type_to_string array are used
and what for.
Signed-off-by: Francois Gouget <fgou...@codeweavers.
On Wed, 23 Nov 2016, Christophe Fergeau wrote:
> On Wed, Nov 23, 2016 at 07:09:28AM +0100, Francois Gouget wrote:
> > For Spice-gtk most deprecation issues come from changes outside Spice
> > (GLib) and thus should not be treated as errors to not break
> > compilation for
Note that the *_IGNORE_DEPRECATIONS macros are treated as separate
statements by the compiler so they need to be put in a proper code block
where appropriate.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/spice-widget.c | 27 ++-
1 file chang
schedule_frame() would always think a frame
was being displayed and thus would not schedule any more frames
resulting in a video freeze.
display_frame() now takes the queues mutex before resetting timer_id
eliminating the race.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
--
\
> $(GTHREAD_CFLAGS) \
> -DSPICE_DISABLE_DEPRECATED \
> + -Wno-deprecated-declarations\
> $(NULL)
Acked-by: Francois Gouget <fgou...@codeweavers.com>
Makes sense.
I'll let you commit and pu
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
README | 2 +-
README.xspice | 2 +-
src/spiceccid/spice.pcsc.conf.template | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/README b/README
index 5
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/mspace.c| 8
src/qxl_mem.c | 2 +-
src/spiceqxl_display.c | 2 +-
src/spiceqxl_io_port.c | 2 +-
src/spiceqxl_main_loop.c| 2 +-
src/spiceqxl_spice_server.c | 2 +-
src/uxa
messages leading to their creation /
destruction.
Francois Gouget (3):
streaming: Remove the display_stream dependency on SpiceMsgIn messages
streaming: Remove the video decoder's dependency on SpiceMsgIn
messages
streaming: Separate the network code from the display_stream
management
This makes it easier to reuse display_streams for other types of
video streams should the need arise.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/channel-display.c | 110 --
1 file changed, 62 insertions(+), 48 del
Code-wise this improves the separation between networking and the video
decoding.
It also makes it easier to reuse the latter should the client one day
receive video streams through other messages.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/channel-display-priv.
Code-wise this improves the separation between networking and the video
decoding.
It also makes it easier to reuse the latter should the client one day
receive video streams through other messages.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/channel-display-gst.c
On Thu, 6 Apr 2017, Francois Gouget wrote:
> Currently the video decoders are directly passed network messages which
> ties them pretty closely to the network code. Should the protocol switch
> to a new type of messages the video decoding code will need to be
> updated
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/channel-display-gst.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index c4190b2d..7e0ddde4 100644
--- a/src/channel-display-gst.c
+++
but not patch 3, please apply the first two so the next round has
fewer patches.
Francois Gouget (5):
streaming: Document the GStreamer decoding process
streaming: Move SpiceMsgIn parsing to display_handle_stream_create()
streaming: Rename SpiceFrame to SpiceGstFrame in the GStreamer
This regroups all the parsing in one place and makes the rest of the
display_stream code independent from the network messaging details.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/channel-display-priv.h | 7 +++
src/channel-display.c
On Tue, 4 Apr 2017, Jonathon Jongsma wrote:
> Acked-by: Jonathon Jongsma <jjong...@redhat.com>
Could you or someone else please commit this patch?
> On Tue, 2017-04-04 at 17:02 +0200, Francois Gouget wrote:
> > Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
&
On Tue, 4 Apr 2017, Jonathon Jongsma wrote:
> Acked-by: Jonathon Jongsma <jjong...@redhat.com>
Could you or someone else please commit this patch?
> On Tue, 2017-04-04 at 17:00 +0200, Francois Gouget wrote:
> > Signed-off-by: Francois Gouget <fgou...@codeweavers.com
This improves the separation between networking and the video decoding
components.
It also makes it easier to reuse the latter should the client one day
receive video streams through other messages.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/channel-display-gst.c
This emphasizes that this structure is specific to the GStreamer
decoder.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
I also removed the underscore in the SpiceFrame struct. It's not used
anywhere else so this has no impact. This name could probably be removed
alto
This makes it easier to reuse display_streams for other types of
video streams should the need arise.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/channel-display.c | 110 --
1 file changed, 62 insertions(+), 48 del
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
data/spice-vdagent.1.in | 2 +-
src/vdagent/file-xfers.c | 4 ++--
src/vdagent/x11-randr.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/data/spice-vdagent.1.in b/data/spice-vdagent.1.in
index f8547d4..5
Use the official case for Xfce.
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/vdagent/vdagent.c | 2 +-
src/vdagent/x11-priv.h | 2 +-
src/vdagent/x11-randr.c | 6 +++---
src/vdagent/x11.c | 10 +-
4 files changed, 10 insertions(+), 10 deletions(-)
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
Note: I don't have commit access.
README | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/README b/README
index 0cd42d0..2eefbc4 100644
--- a/README
+++ b/README
@@ -20,12 +20,12 @@ Features:
* Aut
contributors.
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
if British English is the standard in Spice.
https://en.oxforddictionaries.com/definition/non-existent
But as far as I can tell the form with a space and the -ing ending is
not valid at all.
--
Francois Gouget <fgou...@codeweavers.com>
__
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/udscs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/udscs.h b/src/udscs.h
index 6160568..7b6bff0 100644
--- a/src/udscs.h
+++ b/src/udscs.h
@@ -53,7 +53,7 @@ typedef void (*udscs_read_callback)(
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
data/spice-vdagentd.1.in | 2 +-
src/vdagentd/console-kit.c | 2 +-
src/vdagentd/vdagentd.c| 4 ++--
src/vdagentd/virtio-port.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/data/spice-vdagentd.1.in
Signed-off-by: Francois Gouget <fgou...@codeweavers.com>
---
src/vdagentd/console-kit.c | 2 +-
src/vdagentd/vdagentd.c| 2 +-
src/vdagentd/virtio-port.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/vdagentd/console-kit.c b/src/vdagentd/console-kit.c
eue and
calls stream_display_frame() right on time.
9) display_frame() then frees the SpiceMetaFrame and the SpiceFrame and
decompressed frame with it.
So as I was saying earlier the compressed frame is freed in step 4 and
SpiceGstFrame, SpiceFrame and GstSample in step 9, many milliseconds
later.
ed to pass texture directly to VAAPI).
Interesting. Does it need the same type of GstVideoMeta data or some
other type of metadata?
Did you get the pipeline to work with VAAPI?
--
Francois Gouget <fgou...@codeweavers.com>
___
Spi
variant, and we can revise how this all works and
> make this optional when/if the code you alude to gets public :)
Sure. That totally works for me!
--
Francois Gouget <fgou...@codeweavers.com>
___
Spice-devel mailing list
to.
(And I apologize for the delay, my Internet connection broke down last
week and then I was away for the extended week-end)
--
Francois Gouget <fgou...@codeweavers.com> commit 6a3bd17fa881c3d95c3c3e923161137e147660b6
Author: Francois Gouget <fgou...@codeweavers.com&
. There is also a plain virgl branch but that one seems even
older.
https://cgit.freedesktop.org/~fziglio/qemu/log/?h=virgl-spice
This one would not be needed for Xspice but I may use it for
reference.
And there has been no Virgl work on the Xspice side of things, right?
--
Francois Gouget
Based on a patch by Frediano Ziglio.
Signed-off-by: Francois Gouget
---
server/red-qxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index 0dd26b22c..789817f69 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -791,7 +791,7
Signed-off-by: Francois Gouget
---
server/dcc.c | 2 +-
server/display-channel.c | 16
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index ae7b4380f..a05b6e59e 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -579,7 +579,7
dcc_create_surface() already returns immediately if dcc is NULL.
Signed-off-by: Francois Gouget
---
server/dcc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index a05b6e59e..b6cd6b3f9 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -303,8
Signed-off-by: Francois Gouget
---
server/video-stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/video-stream.c b/server/video-stream.c
index 197950984..ba1a5adf2 100644
--- a/server/video-stream.c
+++ b/server/video-stream.c
@@ -675,7 +675,7 @@ static void
We send mm_time adjustments to the client whenever there is no audio
playback. There is no audio playback on startup. Therefore
mm_time_enabled must be true on startup. QED.
Signed-off-by: Francois Gouget
---
server/reds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/reds.c b
On Thu, 11 Apr 2019, Victor Toso wrote:
> Hi,
>
> On Wed, Apr 10, 2019 at 11:25:17AM +0200, Francois Gouget wrote:
> > We send mm_time adjustments to the client whenever there is no audio
> > playback. There is no audio playback on startup. Therefore
> > mm_time_enab
This reduces code duplication and passing the MJpegEncoder object
makes it possible to modify the playback calculation without adding
more arguments.
Signed-off-by: Francois Gouget
---
server/mjpeg-encoder.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions
The source framerate is as important as the resolution when trying to
understand if the system should be fast enough to encode the video
stream in real time.
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server
Signed-off-by: Francois Gouget
---
server/mjpeg-encoder.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c
index b373e8b71..1400519bb 100644
--- a/server/mjpeg-encoder.c
+++ b/server/mjpeg-encoder.c
@@ -38,7 +38,6 @@ static const int
It makes no sense to expect average frame sizes anywhere close to 2GB.
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index e319eea22..6130781da 100644
adjusting the client mm_time whenever playing a silent
video (or full desktop stream) when no sound has been played before
such as when using Xspice, booting an OS with no startup or login
jingle, or possibly when migrating a VM (per commit 1c154ea5ecc3).
Signed-off-by: Francois Gouget
---
server
This way all the minimum delay calculation is in one place and this
makes gstreamer's implementation closer to the mjpeg one.
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/gstreamer-encoder.c b/server
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 81 ---
1 file changed, 42 insertions(+), 39 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index c756f916..50f29060 100644
--- a/src/channel-display-gst.c
+++ b
Take into account changes made in 8835e757922c, 8c2101254051 and
possibly other other commits.
Add MAX_DECODED_FRAMES to define how many decoded frames GStreamer
should queue.
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 63 +++
1 file
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 91ece0fa..c756f916 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -278,7 +278,7
or more
frame intervals.
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index fc338dff..b8f0c2ee 100644
--- a/src/channel-display-gst.c
+++ b/src/channel
as the decoded frame is
available.
Note that even so the decoding time may be overestimated as the frame
may have been waiting for a while in encoded form for a spot to be freed
in the GStreamer pipeline's sink queue.
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 105
This constant fits in a regular 32 bit signed integer so it does not
need the suffix.
It is also not used in expressions that may overflow.
Signed-off-by: Francois Gouget
---
v2: No changes.
v1: https://lists.freedesktop.org/archives/spice-devel/2019-May/049193.html
server/utils.h | 2 +-
1
On Wed, 12 Jun 2019, Snir Sheriber wrote:
> Hi,
>
> On 6/11/19 9:42 PM, Francois Gouget wrote:
> > schedule_frame() only pulls frames out of GStreamer's pipeline once all
> > previous decoded frames have been displayed. Thus when the video delay
>
>
> IIRC we use
the appropriate casts in those locations. This makes it clearer
that these operations are 64 bit.
Signed-off-by: Francois Gouget
---
v2: Cast COMMON_CLIENT_TIMEOUT to an int64_t instead of an uint64_t.
v1: https://lists.freedesktop.org/archives/spice-devel/2019-May/049193.html
server/common
the appropriate casts in those locations. This makes it clearer
that these operations are 64 bit.
Signed-off-by: Francois Gouget
---
v3: Turned all the timeout constants with casts to int64_t.
server/common-graphics-channel.h | 2 +-
server/dcc.h | 2 +-
server/gstreamer
On Fri, 14 Jun 2019, Frediano Ziglio wrote:
> >
> > Signed-off-by: Francois Gouget
>
> Considering that the field is public and that code will get
> slower and bigger at least would be good to describe the reason
> why you consider it better.
Consistency mostly. This
nd I occasionally had the
"rendering too late" trace which did not seem right.
> > Also reverse the inequality to make it easier to understand.
>
> That's relative but I don't mind ;)
Sure but it looks more like "frame->time >= now" so I like it better.
I'
to understand.
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 858e8aeb..91ece0fa 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
701 - 800 of 848 matches
Mail list logo
