Hi,
Looks good, ACK.
Regards,
Hans
On 11/21/2012 08:42 PM, Yonit Halperin wrote:
red_wait_outgoing_item only waits till the currently outgoing msg is
completely sent.
red_wait_outgoing_items does the same for multi-clients. handle_dev_stop
erroneously called
red_wait_outgoing_items,
Hi,
Looks good, ACK.
Regards,
Hans
On 11/21/2012 08:42 PM, Yonit Halperin wrote:
Previously, there was no check for the size of the message received from
the client, and all messages were read into a buffer of size 1024.
However, migration data can be bigger than 1024. In such cases, memory
Hi,
Looks good, ACK.
Regards,
Hans
On 11/21/2012 08:53 PM, Yonit Halperin wrote:
rhbz#862352
---
server/char_device.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/server/char_device.c b/server/char_device.c
index ac2632d..141ec88 100644
---
Hi,
Looks good, ACK.
Regards,
Hans
On 11/21/2012 08:42 PM, Yonit Halperin wrote:
---
server/reds.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 98c8706..b99d01f 100644
--- a/server/reds.c
+++
Hi,
On 11/22/2012 11:58 AM, Marc-André Lureau wrote:
Hi
- Mensaje original -
+/* Send monitor config to currently active agent */
+udscs_write(active_session_conn, VDAGENTD_MONITORS_CONFIG, 0,
0,
+(uint8_t *)mon_config, size);
/* Acknowledge reception
Hi,
ACK, but please fix a small whitespace problem before pushing (see comment
below)
On 11/22/2012 04:08 PM, Marc-André Lureau wrote:
The agent creates a unique mode vdagent-N per output, that is deleted
when the custom resolution is changed. In order to be deleted, it
can't be the current
be better to just not race at all, I know that cannot be completely avoided.
But lets at least fix the agents racing amongst themselves. The attached patch
(untested)
Regards,
Hans
From a5352d7afeda615f370cebcbd68bded6840e6753 Mon Sep 17 00:00:00 2001
From: Hans de Goede hdego...@redhat.com
Date
Hi,
On 11/20/2012 11:41 PM, Klaus Hochlehnert wrote:
Hi,
I was wondering if it’s possible to auto connect already plugged-in USB devices
when virt-viewer starts?
We’re using an Ubuntu-client with virt-viewer and SPICE and this client has
permanently a card reader plugged in.
With the
Hi,
First of all many many thanks for working on this. For a first version these
patches look very good!
Second sorry for being a bit late with this reply I started composing it a
week ago, and then other stuff got in the way. In the mean time you've had
some other replies so some of the things
ACK.
On 11/04/2012 12:37 PM, Alon Levy wrote:
---
common/lz.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/common/lz.c b/common/lz.c
index 3d77aed..aca3a16 100644
--- a/common/lz.c
+++ b/common/lz.c
@@ -521,8 +521,9 @@ int lz_encode(LzContext *lz, LzImageType
Hi,
On 10/10/2012 06:13 PM, Marc-André Lureau wrote:
- Mensaje original -
Hi,
I've just been editing some text files inside a vm (coding
on the linux agent), and the new keypress delay is very noticable,
and quite annoying.
I don't share this experience. I wonder in which typing
Hi,
On 10/22/2012 12:02 PM, Arnon Gilboa wrote:
Alon Levy wrote:
We could also use the existing SPICE_CLIENT_AGENT_DATA message, extending the
ports to include an additional client port, keeping it compatible with multiple
clients in the future. But otoh I like that your suggestion is
Looks good,
ACK series
On 10/19/2012 07:28 PM, Marc-André Lureau wrote:
It turns out the acceleration code didn't work, because we didn't set
it to the default values. Then we need to restore it back. Eventually,
it would be nicer to inhibit gnome-settings-daemon to apply devices
ghanges, and
Hi,
On 10/18/2012 08:45 PM, Marc-André Lureau wrote:
It turns out the acceleration code didn't work, because we didn't set
it to the default values. Then we need to restore it back. Eventually,
it would be nicer to inhibit gnome-settings-daemon to apply devices
ghanges, and restore settings
Hi,
On 10/19/2012 12:05 PM, Christophe Fergeau wrote:
On Fri, Oct 19, 2012 at 11:49:51AM +0200, Hans de Goede wrote:
Hi,
On 10/18/2012 08:45 PM, Marc-André Lureau wrote:
It turns out the acceleration code didn't work, because we didn't set
it to the default values. Then we need to restore
ACK.
On 10/18/2012 02:19 PM, Marc-André Lureau wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=834513
---
gtk/spice-session.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 28ebe8a..526d05b 100644
---
Hi,
On 10/18/2012 11:57 AM, sarfaraz ahmed wrote:
Thanks for the reply. spice-gtk package has been successfully built for Fedora
18 release. Can i installed this package and its dependencies on existing
fedora arm release Fedora17GA? Or will it require backporting ? Can i compile
libraries
/virt-viewer functionality in f18 arm port for raspberry pi?
I don't know exactly where the arm repository is, but it is available :)
The people in #fedora-arm on the freenode irc server should be able
to help you further.
Regards,
Hans
Hans de Goede hdego...@redhat.com wrote:
Hi,
On 10/18
it is better to just
make spice-gtk not send these in the first place, which is what this patch
does.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/channel-inputs.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/gtk/channel-inputs.c b/gtk/channel
-by: Hans de Goede hdego...@redhat.com
---
server/inputs_channel.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/server/inputs_channel.c b/server/inputs_channel.c
index bf5c22e..1a64e2d 100644
--- a/server/inputs_channel.c
+++ b/server/inputs_channel.c
@@ -309,6 +309,7
Looks good, ACK.
On 10/16/2012 01:10 PM, Marc-André Lureau wrote:
The color conversion only happened during invalidate, but we also
need to apply it when the image is created in the first place.
This solves initial screen being black after connection to agent-less
guest with 16b colour depth:
Hi,
On 10/12/2012 04:03 PM, 李彪 wrote:
hi,
we are using spicy to share the USB devices between thin client and VM in
Server.
however, it shows that
- the menu of spicy can show more than 5 detected USB devices
- if enable more than 5 USB devices, spicy will prompt the error of out of
Ack series.
On 10/15/2012 06:17 PM, Marc-André Lureau wrote:
Fix keymaps to correctly handle the quote key.
https://bugzilla.redhat.com/show_bug.cgi?id=856317
---
gtk/keymaps.csv | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/keymaps.csv b/gtk/keymaps.csv
index
ACK.
On 10/15/2012 06:43 PM, Marc-André Lureau wrote:
This lead to out of bound array access
---
gtk/vncdisplaykeymap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gtk/vncdisplaykeymap.c b/gtk/vncdisplaykeymap.c
index a6ef38c..bf79f9b 100644
---
Hi,
ACK without the gprint change. Note I expect the new g_return_if_fail
to trigger under Linux, as I'm seeing lots of scancode 0 messages
in dmesg for Linux guests, which will now turn into triggering
the g_return_if_fail I expect. I had looking into this on my
todo, so if you don't see them
For commandline backward compatibility with older spice-gtk versions.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 85c9e55..6ee9b07 100644
--- a/gtk/spice-option.c
Hi,
On 10/10/2012 06:51 PM, Marc-André Lureau wrote:
snip
TBH I would prefer to just go for a clean break rather then doing some
compat
stuff. Is that ok with you?
I consider changing command line argument of --spice-* a break. I also
favour the regular deprecation solution that teuf
For commandline backward compatibility with older spice-gtk versions.
Changes in v2:
-warn about spice-usbredir-filter being deprecated when it gets used
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-option.c | 13 +
1 file changed, 13 insertions(+)
diff --git
-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-option.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 85c9e55..25f78ab 100644
--- a/gtk/spice-option.c
+++ b/gtk/spice-option.c
@@ -102,6 +102,16 @@ static gboolean
Hi,
I've just been editing some text files inside a vm (coding
on the linux agent), and the new keypress delay is very noticable,
and quite annoying.
Therefor I would like to suggest to disable it by default.
Opinions ? Better ideas ?
Regards,
Hans
Hi,
I had already seen your bug-report:
https://bugs.freedesktop.org/show_bug.cgi?id=55619
And I will reply there *when I've time to look into this*,
please be patient.
Regards,
Hans
On 10/06/2012 10:56 AM, 周伟 wrote:
spice-gtk version spice-gtk-0.11
usb-redir version 0.4.3
server ubuntu
ACK.
On 10/04/2012 07:15 PM, Christophe Fergeau wrote:
---
gtk/spice-glib-sym-file | 1 +
1 file changed, 1 insertion(+)
diff --git a/gtk/spice-glib-sym-file b/gtk/spice-glib-sym-file
index 2c7c33a..82955f0 100644
--- a/gtk/spice-glib-sym-file
+++ b/gtk/spice-glib-sym-file
@@ -22,6 +22,7 @@
Hi,
Looks good now, ack.
Regards,
Hans
On 10/01/2012 12:29 PM, Christophe Fergeau wrote:
From rh bug #804187:
« The redirection dialog can feel a bit strange when there is no device to
redirect.
It could be useful to provide a help message indicating that there is no
device to redirect
Hi,
On 09/28/2012 08:48 PM, Christophe Fergeau wrote:
On Fri, Sep 28, 2012 at 08:08:19PM +0200, Hans de Goede wrote:
Sorry to be a PITA, but I'm not really happy with making it a local variable,
that
makes the code more complicated (IMHO), for saving just 4 bytes of ram. Likely
the
extra
Hi,
On 09/28/2012 09:43 PM, Christophe Fergeau wrote:
On Fri, Sep 28, 2012 at 08:13:45PM +0200, Hans de Goede wrote:
Here is v2 of my previous 2 patches, new in this version is that the
channel state now also gets updated before calling channel_reset in the
disconnect path. This fixes a NULL
Hi,
On 09/28/2012 09:18 PM, Christophe Fergeau wrote:
On Fri, Sep 21, 2012 at 05:32:21PM +0200, Hans de Goede wrote:
The spice-usbredir-filter cmdline option was not chosen well, as it does
not indicate what it filters. Now that we are also getting a filter for
selecting already plugged
Hi,
On 09/28/2012 12:56 PM, Christophe Fergeau wrote:
From rh bug #804187:
« The redirection dialog can feel a bit strange when there is no device to
redirect.
It could be useful to provide a help message indicating that there is no
device to redirect yet, and that the user can insert a USB
Here is v2 of my previous 2 patches, new in this version is that the
channel state now also gets updated before calling channel_reset in the
disconnect path. This fixes a NULL deref in channel-usbredir on client
exit / close.
Regards,
Hans
___
This way functions called from the channel_reset function can rely
on state acurately reflecting the state. This is necessary to stop
channel-usbredir's reset callback from trying to send the initial
hello message while the channel is no longer in a connected state.
Signed-off-by: Hans de Goede
This is necesary to be able to use the usbredir channel after a
non seamless migration.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/channel-usbredir.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/gtk/channel-usbredir.c b/gtk/channel
-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-session.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 68d1594..28ebe8a 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -1388,15 +1388,17 @@ void
This is necesary to be able to use the usbredir channel after a
non seamless migration.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/channel-usbredir.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/gtk/channel-usbredir.c b/gtk/channel
Hi,
On 09/27/2012 06:01 PM, Christophe Fergeau wrote:
From rh bug #804187:
« The redirection dialog can feel a bit strange when there is no device to
redirect.
It could be useful to provide a help message indicating that there is no
device to redirect yet, and that the user can insert a USB
Hi,
On 09/26/2012 11:58 AM, 李彪 wrote:
All:
I have successfully connect usb printer from my spice-gtk client (ubuntu 10.04
32bit) to the VM(WinXP) in server.
the vm can find usb printer and driver is installed (EPSON LQ-630k).
however, the printer in VM always report error when we try to
.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
configure.ac | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index c7367cc..7c59575 100644
--- a/configure.ac
+++ b/configure.ac
@@ -349,10 +349,17 @@ AC_ARG_ENABLE([usbredir],
if test
Hi,
On 09/25/2012 03:05 PM, Christophe Fergeau wrote:
Hey,
On Tue, Sep 25, 2012 at 01:02:09PM +0200, Hans de Goede wrote:
The usbredir 0.5 release introduced the new API for 64 bit packet ids, but
it kept the libusbredirparser.pc name as is, meaning that older versions of
qemu will still have
Hi,
Thanks, looks good, so I've added it to git master. Notice though that
spicy is merely a little spice-gtk test-client, and our prefered spice-client
is remote-viewer (which is part of virt-viewer).
Regards,
Hans
On 09/24/2012 09:27 AM, Dunrong Huang wrote:
CopyToGuest and CopyToGuest
Hi,
On 09/24/2012 10:19 AM, Dunrong Huang wrote:
Hi, thanks for your reply.
2012/9/24 Hans de Goede hdego...@redhat.com:
Hi,
Thanks, looks good, so I've added it to git master. Notice though that
spicy is merely a little spice-gtk test-client, and our prefered
spice-client
is remote
.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-option.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 715e84a..1333766 100644
--- a/gtk/spice-option.c
+++ b/gtk/spice-option.c
@@ -32,7 +32,7 @@ static char
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-option.c | 9 +
gtk/usb-device-manager.c | 46 ++
2 files changed, 55 insertions(+)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 1333766..85c9e55 100644
This is necessary for redirect-on-connect
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/usb-device-manager.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 5ed76a1..d0fa8dc 100644
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/usb-device-manager.c | 46 ++
1 file changed, 46 insertions(+)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index d0fa8dc..bde9c45 100644
--- a/gtk/usb-device-manager.c
+++ b
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/usb-device-manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index bde9c45..630dfe8 100644
--- a/gtk/usb-device-manager.c
+++ b/gtk/usb-device-manager.c
Hi,
On 09/20/2012 11:53 AM, Christophe Fergeau wrote:
Unescaping the whole URI and then parsing it is dangerous as
the unescaping may (for example) add some extra '/' in the URI
which are not part of a path. It's better to do the unescaping later
once the URI has been split in separate
Hi,
On 09/20/2012 12:34 PM, Christophe Fergeau wrote:
On Thu, Sep 20, 2012 at 12:03:12PM +0200, Hans de Goede wrote:
Hi,
On 09/20/2012 11:53 AM, Christophe Fergeau wrote:
Unescaping the whole URI and then parsing it is dangerous as
the unescaping may (for example) add some extra
Hi,
I've just spend the last 1.5 days tracking down some weird latency issues
which were showing up when testing spice usb-redir over a network connection
(rather then over loopback).
I managed to trace it to a simple read() call on the socket for the
(unencrypted) usb-redir channel taking up
Hi All,
I'm happy to announce usbredir-0.5.1
usbredir-0.5.1 19 September 2012
-usbredirparser:
-usbredirparser_has_data_to_write now returns the write queue depth, instead
of only 0 or 1
-usbredirhost:
-usbredirhost_has_data_to_write now returns the write
Hi,
On 09/12/2012 08:09 PM, Alon Levy wrote:
If the guest supports client monitors config we pass it the
VDAgentMonitorsConfig message via the
QXLInterface::client_monitors_config api instead of via the vdagent.
---
server/agent-msg-filter.c | 8 +++
server/agent-msg-filter.h | 1 +
Hi,
On 09/12/2012 10:24 AM, Alon Levy wrote:
On 09/11/12 17:32, Alon Levy wrote:
Hi,
On 09/11/2012 04:35 PM, Alon Levy wrote:
So far we have used the agent to notify the guest of a request to
change
the monitors configurations (heads) on the qxl device. This patch
introduces
a new interrupt
Hi,
On 09/12/2012 03:13 PM, Alon Levy wrote:
So far we have used the agent to notify the guest of a request to change
the monitors configurations (heads) on the qxl device. This patch introduces
a new interrupt and new fields in the qxl rom to notify the guest about
a new request, similarly to
Hi,
On 09/12/2012 03:13 PM, Alon Levy wrote:
So far we have used the agent to notify the guest of a request to change
the monitors configurations (heads) on the qxl device. This patch introduces
a new interrupt and new fields in the qxl rom to notify the guest about
a new request, similarly to
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
---
server/red_dispatcher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index 69d4f0a..3a4229e 100644
--- a/server/red_dispatcher.c
+++ b/server/red_dispatcher.c
@@ -91,7
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
For qxl client_monitors_config support.
---
spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-common b/spice-common
index f67bcd0..31c5fc1 16
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
Used to implement guest monitor configuration change similarly to real
hardware in conjunction with the new qemu interrupt
QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. client_monitors_config is also
used to probe the support by the interface. If it is not
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
Adds two functions:
- red_dispatcher_use_client_monitors_config:
check that QXLInterface supports client_monitors_config and that it's
functional.
- red_dispatcher_client_monitors_config:
send the client monitors configuration to the
Hi,
On 09/12/2012 03:13 PM, Alon Levy wrote:
If the guest supports client monitors config we pass it the
VDAgentMonitorsConfig message via the
QXLInterface::client_monitors_config api instead of via the vdagent.
---
server/agent-msg-filter.c | 8 ++
server/agent-msg-filter.h | 1 +
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
---
server/tests/basic_event_loop.c| 2 +-
server/tests/test_display_base.c | 46 ++
server/tests/test_display_base.h | 1 +
server/tests/test_display_no_ssl.c | 1 +
4 files changed, 49
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
Added api:
QXL interface (3.2)
client_monitors_config
---
configure.ac | 6 +++---
server/spice.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1c57110..0545af6 100644
---
ACK!
On 09/11/2012 02:14 PM, Christophe Fergeau wrote:
From: Peter Robinson pbrobin...@gmail.com
The following patch enables it to build on ARM platforms that support
atomics. Tested on an armv7hl on an ARMv7 device running Fedora 18. Using
firefox connecting to a RHEV-M instance I could
Hi,
On 09/11/2012 04:35 PM, Alon Levy wrote:
So far we have used the agent to notify the guest of a request to change
the monitors configurations (heads) on the qxl device. This patch introduces
a new interrupt and new fields in the qxl rom to notify the guest about
a new request, similarly to
Hi,
$Subject says it all really, I'm not sure if this is already taken into
account, but in multi-client mode, each capabilities bit should only be
one if all clients support it. Likewise we should not report a disconnect
if only a client goes away, and we still have others connected, or a
Looks good, ack.
On 09/07/2012 04:07 PM, Christophe Fergeau wrote:
The 'size' argument to this macro (defined in
spice-protocol/spice/vd_agent.h) is the number of 32 bit elements
available in its first argument. In channel-main.c it's used
most of the time with
Hi,
On 09/07/2012 06:09 PM, Søren Sandmann Pedersen wrote:
client/display_channel.cpp |1 +
server/red_worker.c| 31 +++
server/spice.h |5 -
3 files changed, 36 insertions(+), 1 deletion(-)
New commits:
commit
Hi,
On 09/04/2012 06:25 PM, Alon Levy wrote:
The bit calculation was wrong for all the paletted types by a factor of
between 8 and 1 (SPICE_BITMAP_FMT_{1,4,8}BIT_PLT_{LE,BE})
---
server/red_parse_qxl.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
Hi,
On 09/03/2012 08:59 PM, Eduardo Elias Camponez wrote:
Hi,
I am having problem to use usb-redirection with an usb-serial converter.
It works for the host (Linux).
Although the guest (Win7) is able to see it and it seems to been
redirected it does not work.
For starters make sure you've a
Looks good, aCK.
On 09/03/2012 06:24 PM, Alon Levy wrote:
Just checks stride vs width times bpp.
This fixes a potential abort on guest generated bad images in
glz_encoder.
Other files touched to move some consts to red_common, they are
static so no problem to be defined in both red_worker.c
Hi All,
I'm happy to announce version 0.12.0 of the spice
guest agent for Linux:
spice-vdagent-0.12.0
* Full multi-monitor and arbritary resolution support, this requires a new
enough xorg-x11-drv-qxl driver, as well as a new enough host
* systemd service support, using
Hi,
On 08/27/2012 12:09 PM, Alon Levy wrote:
On Mon, Aug 27, 2012 at 11:20:09AM +0200, Hans de Goede wrote:
Hi,
So I've been playing around with this more, and except for the issues
when going fullscreen with multiple monitors (the one where the 2 windows end up
on the same monitor), things
Hi,
On 08/27/2012 09:36 AM, Marc-André Lureau wrote:
On Sun, Aug 26, 2012 at 5:29 PM, Hans de Goede hdego...@redhat.com wrote:
Hi,
On 08/26/2012 03:48 PM, Hans de Goede wrote:
Hi,
As part of integrating the spice-vdagent xrandr patches
(done, as there were many other patches pending, so
Hi,
So I've been playing around with this more, and except for the issues
when going fullscreen with multiple monitors (the one where the 2 windows end up
on the same monitor), things look good.
There are some issues with the agent which need some looking into though IMHO:
1) Sometimes
Hi,
On 08/26/2012 03:48 PM, Hans de Goede wrote:
Hi,
As part of integrating the spice-vdagent xrandr patches
(done, as there were many other patches pending, so fixes
can just be applied on top), I've been testing the new
xrandr multi-mon / arbitrary resolution support.
With single monitor
Hi,
On 08/26/2012 03:48 PM, Hans de Goede wrote:
Hi,
As part of integrating the spice-vdagent xrandr patches
(done, as there were many other patches pending, so fixes
can just be applied on top), I've been testing the new
xrandr multi-mon / arbitrary resolution support.
With single monitor
Series looks good, ack.
On 08/24/2012 02:59 AM, Søren Sandmann Pedersen wrote:
ssia
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Series looks good, ack.
On 08/24/2012 03:00 AM, Søren Sandmann Pedersen wrote:
ssia
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi,
Series looks good, except for patch 3, you need to
add the equivalent of this spice-gtk change
--- a/gtk/channel-display.c
+++ b/gtk/channel-display.c
@@ -681,6 +681,7 @@ static void
spice_display_channel_reset_capabilities(SpiceChannel *channel)
{
Series looks good, ack series.
On 08/24/2012 03:02 AM, Søren Sandmann Pedersen wrote:
ssia
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi,
On 08/17/2012 05:07 AM, Jackson wrote:
ctrl endpoint request request_type value index length [data]
And what's the main action and purpose of this cmd?
If you need to ask that then usbredirtestclient is not for you,
usbredirtestclient
is a test tool for developers, and any developer
Looks good, ack.
On 08/15/2012 09:59 PM, Marc-André Lureau wrote:
Factor out the keyboard scancode manipulation function, to be reusable
by newer code.
---
gtk/channel-inputs.c | 22 --
gtk/spice-util-priv.h |1 +
gtk/spice-util.c | 21 +
One small remark below, not sure if it is worth fixing though, ack either way.
On 08/15/2012 09:59 PM, Marc-André Lureau wrote:
If the server is capable of SPICE_INPUTS_CAP_SCANCODE, then we send
can send a single message with key press and release, to avoid
unwanted guest side key repeatition
ACK.
On 08/15/2012 09:59 PM, Marc-André Lureau wrote:
- use a more explicit SendKeyType enum
- if the key is a modifier key, we don't want to delay press event
---
gtk/spice-widget.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git
ACK.
On 08/15/2012 09:59 PM, Marc-André Lureau wrote:
The delay before the press event is sent to the server if the key is
kept pressed. If the key is released within that time, that delay is
ignored and a single key-press-release event will be sent.
---
gtk/spice-widget-priv.h |1 +
Hi,
On 08/15/2012 09:59 PM, Marc-André Lureau wrote:
Until now, Spice clients only sent seperate key events for press and
release. But this may result in unwanted key repeatition from guest VM
side. It seems OSes have various implementation. While MS Windows rely
on hardware key repeats (which
Looks good now, ack series.
On 08/16/2012 05:35 PM, Marc-André Lureau wrote:
Factor out the keyboard scancode manipulation function, to be reusable
by newer code.
---
gtk/channel-inputs.c | 22 --
gtk/spice-util-priv.h |1 +
gtk/spice-util.c | 21
Hans de Goede hdego...@redhat.com
Hi,
On 07/31/2012 11:11 AM, nicolas prochazka wrote:
Hello,
I'm using spice-gtk ( ver 0.12) with a lot of diferrents hardware (
cpu, network card ... ) and video streaming is often good.
But with this one ( HP t610 , with amd T56N processsor ) video
streaming
Hi,
On 08/09/2012 05:15 AM, Jackson wrote:
Yes, in the second case qemu is the tcp client, and the ip and port number
are that of the usbredirserver process which is acting as the usbredir-host.
that means I have to know the IP address to describe the qemu cmdline before a
spice-client
Hi,
On 08/08/2012 05:12 AM, Jackson wrote:
examples of the 2
on the qemu cmdline are:
-chardev spicevmc,name=usbredir,id=usbredirchardev1 -device usb-
redir,chardev=usbredirchardev1
-chardev socket,host=192.168.1.9,port=4000,id=usbredirchardev2 -device usb-
redir,chardev=usbredirchardev2
Hi,
On 08/04/2012 02:15 PM, Jackson wrote:
Erm, no qemu implements a usbredir-guest in the form of the usb-redir
qemu device. This qemu device uses a chardev to talk to the usbredir-host,
one way to do this is through a spice channel to a spice-gtk using client,
the other way is using a
Hi,
On 08/03/2012 07:29 AM, Jackson wrote:
Not that comlicated, there is just a wrapper of usbredir flow
constructed by the spice channel:num 9.
You can view spicy-gtk as the usbredir client and the qemu/spice-server
as the usbredirsever.
But in usb-redirection-protocol.txt and readme.txt,
ACK,
Note I believe it is fine to push such trivial fixes without a patch.
On 07/30/2012 05:48 PM, Uri Lublin wrote:
Found-by: Nicolas Prochazka prochazka.nico...@gmail.com
---
gtk/spice-widget-x11.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Hi,
On 07/31/2012 11:11 AM, nicolas prochazka wrote:
Hello,
I'm using spice-gtk ( ver 0.12) with a lot of diferrents hardware (
cpu, network card ... ) and video streaming is often good.
But with this one ( HP t610 , with amd T56N processsor ) video
streaming is not working.
Theses tests have
401 - 500 of 1408 matches
Mail list logo
