ACK.
On 07/29/2012 11:54 AM, Alon Levy wrote:
---
server/red_worker.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/server/red_worker.c b/server/red_worker.c
index 9009462..eb21208 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -4589,6 +4589,12 @@ static void
Hi,
On 07/25/2012 03:36 PM, flooding Controlled wrote:
Hi:
I am puzzled by some functions calling in the function :
spice_usb_device_manager_initable_init
At this block:
/* Do coldplug (detection of already connected devices) */
libusb_get_device_list(priv-context,
**:
virt_viewer_session_spice_display_monitors:
assertion `monitors-len = monitors_max' failed
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/channel-display.c |1 +
1 file changed, 1 insertion(+)
diff --git a/gtk/channel-display.c b/gtk/channel-display.c
index 72d2c12..4ed3bbb 100644
--- a/gtk/channel-display.c
mouse mode. Note that this makes the inhibit-keyboard-grab
name of the property no longer really cover what it does, but allas it is
part of our ABI...
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-widget.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
libusbredirhost prefixes all its messages with usbredirhhost ...: , which
is useful when logging to stderr, but not so much when showing the error
to the user in an error dialog, so remove the usbredirhost error: prefix
when we store the message in a GError.
Signed-off-by: Hans de Goede hdego
Hi,
On 07/24/2012 02:22 PM, flooding Controlled wrote:
Hi:
The code '''
* @rule1|@rule2|@rule3
*
* The default setting filters out HID (class 0x03) USB devices from auto
* connect and auto connects anything else. Note the explicit allow rule at
* the end, this
Hi,
On 07/24/2012 03:50 PM, flooding Controlled wrote:
Yes , I am on Linux client. And I attach the log as you mentioned above.
Hmm, looking at the log it seems that you're running your linux client
inside a vmware vm ??
Regards,
Hans
___
Hi,
On 07/24/2012 03:56 PM, flooding Controlled wrote:
Yes! Can you tell me how to reflect the rule value to the log I attatch ?
So have you redirect the printer to the vmware-vm ? Otherwise things don't
work also stacking redirection on redirection is going to be really
hard to debug ... Can
Hi,
On 07/24/2012 04:03 PM, flooding Controlled wrote:
Oh~~ I am sorry that in my company we have to use vms... Though I think that a
real machine is more perfect...
I catch a new part of log with my USB plugin in .
Bus 001 Device 003: ID 154b:6001 PNY
Device Descriptor:
bLength
Hi,
On 07/24/2012 04:25 PM, flooding Controlled wrote:
Hi:
I catch a log from my guys's real PC. And it seems that the device Bus 001
Device 035: ID 0557:2407 ATEN International Co., Ltd
is filtered by the default rule I mentioned above. Can you tell me how the rule
match now ? Thanks a
Hi,
Series looks good, only remark I have is that with 6/6
you're not passing in interface information, that really is
not a good idea, since for almost all devices if you want to filter
on usb classes (which you usually do) the interesting bits are in
the interface info.
Now it might be that
Hi,
On 07/12/2012 04:07 PM, Uri Lublin wrote:
For Windows client, when connecting a device to the guest, if a libusb
device (libdev) does not exist, cleanup and forget about that device.
Most likely, the device was plugged out at driver installation
time, and its remove-device event was
Hi All,
I'm going on vacation for a week starting tomorrow, and I will *not*
be reading email, etc. during that time.
Regards,
Hans
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
Hi,
Series looks good, ack series.
Regards,
Hans
On 07/11/2012 02:45 PM, Marc-André Lureau wrote:
Simplify a little bit the portability by looking up usb.ids file
under g_get_system_data_dirs(). This is how most resources are
found under other OS, looking up files under various places,
Hi,
Series looks good, ack series.
Regards,
Hans
On 07/11/2012 01:41 PM, Alon Levy wrote:
---
server/red_worker.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index c492443..ac9baf2
Good one, ACK.
On 07/11/2012 11:50 AM, Uri Lublin wrote:
If a device that is asked to be shared with the guest, is unplugged out
of the machine before being redirected, then let the user know that
usbredir of that device failed (and cleanup nicely).
For Windows client, the time between request
Hi,
On 07/08/2012 06:12 AM, Lv Basen wrote:
HI all:
I have setup a box running spicy with usb redirection, when pulg-in
a usb mass storage device( 200GB ) in the box,
It shoud spend 60 seconds, then we can found the usb device in virtual machine
os.
I enabled the debug
Hi,
On 07/05/2012 10:43 PM, Uri Lublin wrote:
For Windows, it's better not to keep references for libusb_devices
that are not used.
So instead of makeing SpiceUsbDevice a box for a libusb_device
it is going to be a box for a SpiceUsbDeviceInfo.
---
gtk/usb-device-manager.c | 145
Hi,
Looking at the next patch in the series, I've one more remark on this one:
On 07/05/2012 10:43 PM, Uri Lublin wrote:
+static SpiceUsbDeviceInfo *spice_usb_device_set_info(libusb_device *libdev)
+{
+SpiceUsbDeviceInfo *info;
+struct libusb_device_descriptor desc;
+int errcode;
+
Hi,
On 07/05/2012 10:43 PM, Uri Lublin wrote:
Note that this change may affect performance a bit, as sometimes there is
a need to find the libusb_device or the SpiceUsbDevice. Likely it's negligible.
---
gtk/channel-usbredir.c|2 +-
gtk/usb-device-manager-priv.h | 10 ++-
Hi,
On 07/05/2012 10:43 PM, Uri Lublin wrote:
- Added win-usb-driver-install.[ch]
- Added win-usb-clerk.h
Operation (on Windows, spice-gtk point of view):
- After some sanity checks, just before redir'ing a USB device
a libusb driver needs to be installed (before libusb can open the device)
Hi,
I've reviewed all of the patches, I've comments to a few of them, see my
individual replies to them. Overall the patchset looks good. Although I
hope in the future we can get hotplug support at the libusb level,
and hopefully more or less revert to the old situation where
libusb_device ==
ACk, +100 !
On 07/05/2012 11:38 AM, Alon Levy wrote:
Replaced mostly with spice_debug, but spice_warning spice_error as
well where appropriate.
---
server/red_worker.c | 182 +--
1 file changed, 91 insertions(+), 91 deletions(-)
diff --git
ACK
On 07/03/2012 09:32 PM, Yonit Halperin wrote:
The original definition is in spice.h
---
server/char_device.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/server/char_device.h b/server/char_device.h
index 4a70075..ef8ce3a 100644
--- a/server/char_device.h
+++
mouse mode. Note that this makes the inhibit-keyboard-grab
name of the property no longer really cover what it does, but allas it is
part of our ABI...
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-widget.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Hi,
On 07/04/2012 02:00 PM, Marc-André Lureau wrote:
Hi
On Wed, Jul 4, 2012 at 9:07 AM, Hans de Goede hdego...@redhat.com wrote:
This patch also releases the mouse grab on keyboard-grab-inhibit, fixing
the policykit dialog not showing (and thus usb redir not working) when
running with server
Series looks good to me, ack series!
Regards,
Hans
On 07/03/2012 01:33 PM, Yonit Halperin wrote:
Changes from v1:
Fixes for the comments Hans and Alon made. Mainly for patch 3:
* use do_flow_control flag, instead of ~0 for infinite tokens
* avoid code duplication in
Looks good, ack.
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
---
server/smartcard.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/smartcard.c b/server/smartcard.c
index 8ded142..cb6b40b 100644
--- a/server/smartcard.c
+++ b/server/smartcard.c
@@ -107,7
Looks good, ack.
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
---
server/smartcard.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/smartcard.c b/server/smartcard.c
index cb6b40b..fcf210f 100644
--- a/server/smartcard.c
+++ b/server/smartcard.c
@@ -535,7
Hi,
Overall looks good, 2 comments:
1) When not using flow-control you set the tokens to max_uint32, and
assume that is enough, but with uwb-2 isoc traffic you can get upto
8000 packets / sec. Which translates to running out of tokens in
approx 145 hours. So if someone leaves a spice-client
Ack.
On 07/02/2012 12:59 PM, Alon Levy wrote:
Includes using the same spice.proto as spice-gtk now, with smartcard
fixes, more verbose output when SSL verification fails, and some
warnings fixes. shortlog:
Alon Levy (6):
python_modules/ptypes.py/EnumBaseType.c_enumname: add missing
Looks good, ack.
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
- Allow sending tokens to a specific client.
- Do not ignore tokens that are sent from the client to the server.
The tokens support for multiple clients and for server side tokens
is still broken in reds. It will be fixed in
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
This code is never called, it was relevant for seamless migration.
Most of the data that needs to be migrated was moved to
SpiceCharDeviceState. When we implement seamless migration,
we will have routines in
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
---
server/main_channel.c | 52 +++---
server/main_channel.h |4 +-
server/reds.c | 296 +++--
3 files changed, 228 insertions(+), 124 deletions(-)
Hi,
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
This is an intermediate patch. The next patch will actually
push the buffer to the device, instead of copying it.
---
server/main_channel.c | 10 +-
server/reds.c | 33 +
server/reds.h
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
---
server/reds.c | 255 ++---
1 files changed, 44 insertions(+), 211 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 5d78d58..58ca354 100644
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
This patch and the following one do not introduce tokening to the
spicevmc channel. But this can be done easily later, by setting the appropriate
variables in SpiceCharDeviceState (after adding
the appropriate
Hi,
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
With SpiceCharDeviceState, spicevmc now supports partial writes,
and storing data that is received from the client after the device is
stopped, instead of attempting to write it to the guest.
---
server/spicevmc.c | 49
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
This patch and the following one do not introduce tokening to the smartcard
channel. But this can be done easily later, by setting the appropriate
variables in SpiceCharDeviceState (after adding the appropriate
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
The lifetime of the channel is not necessarily correlated to the life
time of the device. In the next patch, we need to keep a reference
to SpiceCharDeviceWriteBuffer, which might be in use even if the
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
With SpiceCharDeviceState, the smartcard code now supports partial writes,
and storing data that is received from the client after the device is
stopped, instead of attempting to write it to the guest.
---
Looks good, ack.
Regards,
Hans
On 06/27/2012 05:16 PM, Yonit Halperin wrote:
In addition, I also removed the no longer used wakeup callback
---
server/char_device.c | 21 +
server/char_device.h | 26 --
server/reds.c|8
Hi,
Series looks good, ack series.
Regards,
Hans
On 06/30/2012 03:02 AM, Marc-André Lureau wrote:
---
client/Makefile.am |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/client/Makefile.am b/client/Makefile.am
index ba3ce76..814c32f 100644
---
Good one, ack.
Regards,
Hans
On 06/28/2012 10:06 AM, Yonit Halperin wrote:
Add the given tokens instead of overriding the existing ones.
---
gtk/channel-main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index
Hi,
On 06/28/2012 01:54 AM, Jackson wrote:
I use spicy to connect to a VM supporting usb redirection, but there are some
problems with usb webcam.
Plug in the webcam with usb redirection and then, I open the webcam application
(ex: skype or amcap); however, the VM only shows the first view and
the
focus out of the other windows.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-gtk-session.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index 130cbc9..1d8c888 100644
--- a/gtk/spice-gtk
To better reflect what then function does, also rename the tracking variable
inside spice-gtk-session to match.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-gtk-session-priv.h |2 +-
gtk/spice-gtk-session.c | 16
gtk/spice-widget.c |4
-*- */
+/*
+ Copyright (C) 2012 Red Hat, Inc.
+
+ Red Hat Authors:
+ Hans de Goede hdego...@redhat.com
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version
Inhibit automounting when usb-autoredirection is active.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-gtk-session-priv.h |2 +-
gtk/spice-gtk-session.c | 23 ++-
gtk/spice-widget.c |4 ++--
3 files changed, 25 insertions(+), 4
it is
redirecting to allow the policykit dialog to show, we can use that to
inhibit usb-autoredir setting changes.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-widget.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/gtk/spice-widget.c
Hi,
On 06/26/2012 11:42 AM, Marc-André Lureau wrote:
On Tue, Jun 26, 2012 at 10:32 AM, Hans de Goede hdego...@redhat.com wrote:
+void spice_gtk_session_request_auto_usbredir(SpiceGtkSession *self,
gboolean state)
You need to fix the naming
Hi All,
Here is v4 of my automount inhibit patchset, history:
v1: Initial release, toggling automount preference settings
v2: Rewrite to use a proper inhibit interface added to gnome-session
v3: Rewrite to get rid of the toplevel window id lists
v4: Fix rename patch bodge-up
Use
Only update the UsbDeviceManager's auto-connect property when
auto-usb-redir is set, otherwise leave it as is. This allows apps to
control UsbDeviceManager's auto-connect directly, without it getting reset
on every keyboard focus change.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk
the
focus out of the other window.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-gtk-session.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index 130cbc9..1d8c888 100644
--- a/gtk/spice-gtk
To better reflect what then function does, also rename the tracking variable
inside spice-gtk-session to match.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-gtk-session-priv.h |2 +-
gtk/spice-gtk-session.c | 16
gtk/spice-widget.c |4
-*- */
+/*
+ Copyright (C) 2012 Red Hat, Inc.
+
+ Red Hat Authors:
+ Hans de Goede hdego...@redhat.com
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version
Inhibit automounting when usb-autoredirection is active.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-gtk-session.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index 1df63f5
it is
redirecting to allow the policykit dialog to show, we can use that to
inhibit usb-autoredir setting changes.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-widget.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/gtk/spice-widget.c
:48 PM, Hans de Goede hdego...@redhat.com wrote:
Hi All,
Here is v4 of my automount inhibit patchset, history:
v1: Initial release, toggling automount preference settings
v2: Rewrite to use a proper inhibit interface added to gnome-session
v3: Rewrite to get rid of the toplevel window id lists
v4
Hi,
On 06/24/2012 02:07 AM, Marc-André Lureau wrote:
Hi
On Sun, Jun 24, 2012 at 1:39 AM, Hans de Goede hdego...@redhat.com wrote:
it can be simplified, resulting in simpler API and less code.
No it cannot, using a hidden window for this is just plain wrong! One is
supposed to use real
Hi,
On 06/22/2012 05:41 PM, Marc-André Lureau wrote:
snip
Just because many people use hash-tables for something does not make
them the
right choice, I looked at using hash-tables first, before I choose to
use
GData and I found GData to be a better match.
Right, but if nobody does something
Hi,
Here are bugs with patches for the necessary non spice-gtk bits:
https://bugzilla.gnome.org/show_bug.cgi?id=678595
https://bugzilla.gnome.org/show_bug.cgi?id=678597
Regards,
Hans
On 06/21/2012 10:09 PM, Hans de Goede wrote:
Hi All,
Here is a new version of the automount inhibit
Hi,
Thanks for the comments.
On 06/22/2012 11:06 AM, Marc-André Lureau wrote:
Hi
On Thu, Jun 21, 2012 at 10:09 PM, Hans de Goede hdego...@redhat.com wrote:
+
+AC_ARG_ENABLE([dbus],
+ AS_HELP_STRING([--enable-dbus=@:@auto/yes/no@:@],
+ [Enable dbus support for desktop
Hi All,
Here is a new version of the automount inhibit patchset, based on discussions
with David Zeuthen, this is now modelled after the screensaver and other
inhibits in gnome which now a days all live in gnome-session.
This also needs some small gnome-shell changes, which I still need to
Only update the UsbDeviceManager's auto-connect property when
auto-usb-redir is set, otherwise leave it as is. This allows apps to
control UsbDeviceManager's auto-connect directly, without it getting reset
on every keyboard focus change.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk
-*- */
+/*
+ Copyright (C) 2012 Red Hat, Inc.
+
+ Red Hat Authors:
+ Hans de Goede hdego...@redhat.com
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version
for one window arrives before the
focus out of the other windows.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-gtk-session-priv.h |5 ++--
gtk/spice-gtk-session.c | 55 ++
gtk/spice-widget.c | 23
it is
redirecting to allow the policykit dialog to show, we can use that to
inhibit usb-autoredir setting changes.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spice-widget.c |9 +
1 file changed, 9 insertions(+)
diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index
Hi,
On 06/14/2012 04:19 PM, Hans de Goede wrote:
Hi,
On 06/14/2012 02:43 PM, Marc-André Lureau wrote:
Hi
- Mensaje original -
so why having a 1-1 relation with each spice session?
We also need to undo the changes at some point in time, iow the
desktop-integration objects
lifetime
Hi,
On 06/15/2012 10:02 AM, Hans de Goede wrote:
Hi,
On 06/14/2012 04:19 PM, Hans de Goede wrote:
Hi,
On 06/14/2012 02:43 PM, Marc-André Lureau wrote:
Hi
- Mensaje original -
so why having a 1-1 relation with each spice session?
We also need to undo the changes at some point
Hi,
On 06/14/2012 11:28 AM, Marc-André Lureau wrote:
Hi
- Mensaje original -
Looks reasonable to me, however, I don't see why it should be in
spice-glib, since it's very much desktop related. Wouldn't it make
more sense in spice-gtk?
I actually put it in spice-gtk at first, but
Only update the UsbDeviceManager's auto-connect property when
auto-usb-redir is set, otherwise leave it as is. This allows apps to
control UsbDeviceManager's auto-connect directly, without it getting reset
on every keyboard focus change.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk
automounting under Gnome-2 is in the
pipeline.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
configure.ac | 20 +
gtk/Makefile.am |2 +
gtk/desktop-integration.c | 196 +
gtk/desktop-integration.h | 64
Signed-off-by: Hans de Goede hdego...@redhat.com
---
doc/reference/spice-gtk-sections.txt |2 +
gtk/map-file |2 +
gtk/usb-device-manager.c | 130 --
gtk/usb-device-manager.h |5 ++
4 files changed, 132
Hi,
On 06/11/2012 04:45 PM, Jeremy White wrote:
Forgive me if this is FAQ'd elsewhere, but I did not find it in a short
hunt, and I'm curious.
Documentation is not our strong point, help with that is greatly
appreciated :)
Who has commit access to the main trees,
For all the repositories
Hi,
On 06/10/2012 04:44 PM, Alon Levy wrote:
snip
Obligatory migration data:
-
(1) agent/spicevmc/smartcard write buffer. i.e., data that reached the server
after savevm, and thus was not written to the device.
Currently, spicevmc and smartcard do not have write
Ack.
On 06/06/2012 03:07 PM, Alon Levy wrote:
Fix copied from libvirt, commit by Eric Blake.
glibc 2.15 (on Fedora 17) coupled with explicit disabling of
optimization during development dies a painful death:
/usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires
compiling
Hi,
On 06/04/2012 01:17 PM, David Jaša wrote:
Hans de Goede píše v Pá 01. 06. 2012 v 20:45 +0200:
More importantly then the incentive pro did it this way argument though,
is that it is a safe default from security pov. These filter strings are
used in more then one place:
IIRC, they were
The USB device selection applies immediately, so the dialog should be using
'Close' instead of 'OK' for its primary button.
This patch syncs spicy with virt-viewer wrt the USB device selection dialog.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
gtk/spicy.c |2 +-
spice-common
Hi,
On 05/30/2012 12:48 PM, nicolas prochazka wrote:
Hi,
1 - Yes i've first tried without any debug, same effect.
2 - I also tried with qemu-kvm 1.1 rc3 and with your
qemu-kvm-1.0-usbredir branch , same effect
Bummer, I assume you've tried it with real (non virtualized) windows too,
and
Hi,
On 05/29/2012 05:01 PM, nicolas prochazka wrote:
Hello,
I'm trying to use this usb device :
http://www.ingenico.com/en/products/payment_terminals/healthcare/twin30-plus_fm0cqjcy.html
under windows guest, this usb device is mounting but not recognized
it's seems to be a special usb device ,
Hi,
On 05/28/2012 10:29 AM, Uri Lublin wrote:
On 05/24/2012 05:59 PM, Hans de Goede wrote:
Hi,
On 05/24/2012 04:40 PM, Uri Lublin wrote:
Out of v1 patch-set, all patches but one (patch 6) got acked.
This patch-set contains a single patch, which is another solution
for strtok_r missing
Hi,
On 05/24/2012 04:40 PM, Uri Lublin wrote:
mingw imlpements neigther strtok_r nor strtok_s.
So here is a simple implementation of strtok_r (for windows).
It assumes the delimiter is a single character, which is
good enough for usbredirfilter.
If we're going to do this I would prefer to do
Hans,
Oh, nice cleanup! ACK!
Regards,
Hans
On 05/26/2012 03:00 AM, Marc-André Lureau wrote:
The Windows client was getting in the way of guest copy-paste,
because when the guest was taking the clipboard grab, the agent
notifies the client, it takes the grab too, and in return
receives
Hi,
On 05/24/2012 04:40 PM, Uri Lublin wrote:
Out of v1 patch-set, all patches but one (patch 6) got acked.
This patch-set contains a single patch, which is another solution
for strtok_r missing in mingw. It's a simple implementation of
strtok_r.
Also I added a test program.
Possibly I'm
Looks good, ack.
On 05/20/2012 06:34 PM, Uri Lublin wrote:
This fixes the following compilation error:
channel-usbredir.c: In function 'spice_usbredir_channel_connect_device_async':
channel-usbredir.c:313:9: error: jump skips variable initialization
[-Werror=jump-misses-init]
---
Hi,
What Marc-André said :)
Regards,
Hans
On 05/20/2012 06:34 PM, Uri Lublin wrote:
For windows GUDEV is not required
- GUDEV is alwasy checked as part of USBREDIR, and fails
if USBREDIR but no GUDEV on non-windows.
- Added GUDEV env-variables in gtk/Makefile.am
---
configure.ac|
Hi,
First of all again what MArc-André said, and also:
snip
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 14b60c9..2b6ce28 100644
--- a/gtk/usb-device-manager.c
+++ b/gtk/usb-device-manager.c
@@ -28,7 +28,14 @@
#ifdef USE_USBREDIR
#includeerrno.h
Hi,
Comments inline.
On 05/20/2012 06:34 PM, Uri Lublin wrote:
- Added win-usb-driver-install.[ch]
- Added usbclerk.h
Operation (on Windows, spice-gtk point of view):
- After some sanity checks, just before redir'ing a USB device
a libusb driver needs to be installed (before libusb can
Looks good, ack.
On 05/22/2012 02:03 PM, Marc-André Lureau wrote:
The main channel can change when we are reconnecting to the server,
for example, when querying the password to the user. From there,
the old main channel is destroyed, but we don't track properly the
new main channel.
This fix
Hi,
Why not simply memset the struct to 0 before initializing its fields,
that should make valgrind happy and is a good idea in general (as it
puts 0 rather then random crap in fields which you forget to init).
Regards,
Hans
On 05/22/2012 04:27 PM, Alon Levy wrote:
The hole remains
Looks good, ACK.
On 05/21/2012 05:28 PM, Marc-André Lureau wrote:
ping
On Thu, May 17, 2012 at 2:46 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
If no cert-subject or pubkey is provided, we should unset the corresponding
flags.
---
gtk/spice-session.c |8 ++--
Looks good, ACK.
On 05/21/2012 05:28 PM, Marc-André Lureau wrote:
ping
On Thu, May 17, 2012 at 2:45 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
Even if they are not public functions, those conditions can be reached
in a invalid state.
---
common/ssl_verify.c |5 +
1
Looks good, ACK series.
Regards,
Hans
On 05/18/2012 03:28 PM, Marc-André Lureau wrote:
If the last key pressed from the grab sequence is a modifier
key, let send it to the guest too.
This solves the issue of default grab-sequence being ctrl+alt
and preventing ctrl+alt+del from working.
---
Hi,
On 05/18/2012 02:57 AM, Charles.Tsai-蔡清海-研究發展部 wrote:
Hi Hans,
Thank you for your suggestion. I tried your Qemu code. But I found my
qemu script which is only coded with simple qemu command options.
Before using your Qemu code, my VM could be launched by running the
Hi,
On 05/17/2012 11:42 PM, Marc-André Lureau wrote:
The remote may want to use that same key sequence,
so we better send it through, even if it matches
the ungrab key combination.
I'm not sure about this, if the grab-sequence is
getting in the way, maybe we need a different
grab-sequence?
Hi,
On 05/18/2012 01:21 PM, Marc-André Lureau wrote:
- Mensaje original -
Hi,
On 05/17/2012 11:42 PM, Marc-André Lureau wrote:
The remote may want to use that same key sequence,
so we better send it through, even if it matches
the ungrab key combination.
I'm not sure about this,
Hi,
On 05/18/2012 02:15 PM, Marc-André Lureau wrote:
Hi
Agreed, for modifiers, but what if the key binding
is changed to shift+F12 as rhev does? Then I'm not sure
sending the key events to the guest is desirable ...
what if we make this configurable, and default to
non-passthrough? that
Hi,
On 05/17/2012 08:44 AM, Charles.Tsai-蔡清海-研究發展部 wrote:
Hi Alon,
We decide to get the latest stable build for Qemu as our code base.
However there are many public repositories for Qemu available.
Which repository do you recommend for Qemu so that we can get latest
code
Hi,
On 05/09/2012 04:11 PM, Nerijus Baliunas wrote:
Hello,
What is the best option for USB support in ovirt Windows guests now?
I see there are quite a lot of recent patches in this area.
That depends mostly on which OS you're running on the client, if
you're running Linux clients I would
501 - 600 of 1408 matches
Mail list logo
