[Spice-devel] [PATCH spice-gtk 4/7] egl: only swap buffers on x11

Gtk does it for us already with GtkGlArea. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c index fff2831..210b834 100644 --- a/src

[Spice-devel] [PATCH spice-gtk 2/7] channel: check if channel has a session

)' failed Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-channel.c b/src/spice-channel.c index 35a2cae..c555f75 100644 --- a/src/spice-channel.c +++ b/src/spice-channel.c @@ -

[Spice-devel] [PATCH spice-gtk 1/7] util: remove STATIC_MUTEX macros

They are no longer needed since 0a9ec4ec0. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-usbredir.c | 10 +- src/spice-channel-priv.h | 2 +- src/spice-channel.c | 28 ++-- src/spice-util-priv.h| 6 -- 4

[Spice-devel] [PATCH spice] spice-migration.h: un-deprecate set_seamless_migration()

This function was wrongly marked as deprecated in commit b41220b1441b8. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/spice-migration.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/spice-migration.h b/server/spice-migration.h index 9

Re: [Spice-devel] [PATCH spice-common v2 2/2] Remove GDI canvas

Then we can probably close https://bugs.freedesktop.org/show_bug.cgi?id=90872 as wontfix. - Original Message - > Only spicec was using it - removed by spice server commit: > 1876971442ef808b5dcdaa5dc12df617f2179cb5 > --- > common/Makefile.am |2 - > common/canvas_base.c | 37 - >

Re: [Spice-devel] [PATCH 10/14] Mark unused public API methods/code as deprecated

UC_DEPRECATED; >> >> int spice_server_is_server_mouse(SpiceServer *s); >> >> @@ -123,6 +125,6 @@ void spice_server_set_uuid(SpiceServer *s, const uint8_t >> uuid[16]); >> void spice_server_vm_start(SpiceServer *s); >> void spice_server_vm_stop(SpiceServer *s); >> >> -int spice_server_get_num_clients(SpiceServer *s); >> +int spice_server_get_num_clients(SpiceServer *s) G_GNUC_DEPRECATED; >> >> #endif /* SPICE_SERVER_H_ */ > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCHv2 spice-gtk 0/3] Switching mouse mode

Hi, This is a resent of a previous series, see description in the first patch. Thanks! Marc-André Lureau (3): gtk: add spice_main_request_mouse_mode() main: do not always request client mouse mode spicy: add toggle mouse mode menu doc/reference/spice-gtk-sections.txt | 1 + src/channel

[Spice-devel] [PATCHv2 spice-gtk 3/3] spicy: add toggle mouse mode menu

From: Marc-André Lureau <marcandre.lur...@redhat.com> This is just for testing, the UI could be different in better clients. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- src/spicy.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/s

[Spice-devel] [PATCHv2 spice-gtk 2/3] main: do not always request client mouse mode

From: Marc-André Lureau <marcandre.lur...@redhat.com> Whenever the mouse mode changed on the server, spice-gtk was requesting client mode. Instead keep the last requested mode and request it whenever it's possible. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com&

[Spice-devel] [PATCHv2 spice-gtk 1/3] gtk: add spice_main_request_mouse_mode()

From: Marc-André Lureau <marcandre.lur...@redhat.com> Send a SpiceMsgcMainMouseModeRequest message to request a mouse mode. This allows to switch between client/absolute and server/relative mouse modes. This is necessary for some applications that require pointer re-positioning, which we

Re: [Spice-devel] [PATCH spice-gtk 1/4] gtk: add spice_main_request_mouse_mode()

on server mode. This is not directly related to this series. Furthermore, spice-gtk is a testing UI. I don't think we need to change this behaviour. > Can you rebase and send the patches again? I will. thanks -- Marc-André Lureau ___ Spice-devel mailin

Re: [Spice-devel] [PATCH spice-gtk 1/4] gtk: add spice_main_request_mouse_mode()

ck mouse, also vmmouse is redundant with the tablet we use), so I will send a patch to qemu to disable it by default when spice is used and error when enabled. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

Hi - Original Message - > Hi Marc-André, > > On Tue, 2016-05-03 at 20:15 +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt <pgr...@redhat.com> wrote: > > > This patches introduces and uses a spic

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

de, > missmatch between client's and guest's keyboard layout. Is this a guest configuration issue? How are you going to expose this property to the user? It would look bad to add some weird tweaks like that to the UI. -- Marc-André Lureau ___ Spice-devel

Re: [Spice-devel] [PATCH spice-gtk] gtk: fix server-mode mouse

On Tue, May 3, 2016 at 7:36 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > +gtk_container_add(GTK_CONTAINER(display), d->stack); better with GTK_WIDGET() to avoid the warning, fixed -- Marc-André Lureau ___ Spice-devel

[Spice-devel] [PATCH spice-gtk] gtk: fix server-mode mouse

things worse. Making the widget an eventbox solves the grab issue. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94764 Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-priv.h | 5 +++-- src/spice-widget.c | 24 +--- 2 files c

Re: [Spice-devel] How to modify spice version?

Hi - Original Message - > >> 1) We should have specified --fallback in AC_INIT line > > > > Why "should we"? even autoconf.git (the source of the script) isn't using > > it. > > > > http://git.savannah.gnu.org/cgit/autoconf.git/tree/configure.ac > > > > Well, the fact that they are

Re: [Spice-devel] [spice-server 1/2] build-sys: Drop unneeded python check

ack - Original Message - > spice-gtk does not use python, the spice-common submodule needs it, but > it has its own python check through the use of AM_PATH_PYTHON > --- > configure.ac | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index

Re: [Spice-devel] [spice-gtk 1/2] build-sys: Delete pygtk2-related files

ack - Original Message - > They are no longer needed since 0917002c which dropped pygtk2 support > --- > m4/check_python.m4| 46 > src/Makefile.am | 2 - > src/spice-client-gtk-module.c | 45 --- > src/spice-client-gtk.override | 171 >

Re: [Spice-devel] [PATCH 0/3] Fixes to git-version-gen

On Mon, May 2, 2016 at 2:33 PM, Eduardo Lima (Etrunko) <etru...@redhat.com> wrote: > See previous thread "How to modify spice version" replied there, --fallback is the wrong the solution to me. -- Marc-André Lureau ___ Spice-devel

Re: [Spice-devel] How to modify spice version?

implement some fallback method in git-version-gen. Yes, tags must be present. > > > So, as far as I understand, there are two issues. > > 1) We should have specified --fallback in AC_INIT line Why "should we"? even autoconf.git (the source of the script) isn't using it. http://git.savannah.gnu.org/cgit/autoconf.git/tree/configure.ac -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH v2 11/12] spice: add & use qemu_spice_gl_monitor_config

Hi Gerd On Fri, Feb 19, 2016 at 1:32 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi > > On Fri, Feb 19, 2016 at 10:14 AM, Gerd Hoffmann <kra...@redhat.com> wrote: >> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> >> --- >> i

Re: [Spice-devel] [spice-gtk PATCH v3] Usbredir: enable lz4 compression

Hi - Original Message - > Compressed message type is CompressedData which contains compression > type (1 byte) followed by the uncompressed data size (4 bytes) followed > by the compressed data size (4 bytes) followed by the compressed data > > If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4

Re: [Spice-devel] [vdagent-linux v1] Bump glib to 2.38

Hi - Original Message - > 2.38 is the version that we are using in spice-gtk since: > 8693e7d3f7de1ff102082212fa6e35fb1a252ef7 > > This is also removing glib-compat header as it isn't used anymore. What does spice-gtk has to do with vdagent here? It may still be worth to keep

Re: [Spice-devel] [PATCH spice-gtk] Do not call spice_egl_cursor_set when egl is disabled

top/toolkits these days. However, egl may not be available on some systems (?). > Pavel > > On Thu, 2016-04-07 at 09:16 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > > > > Fix memory leaks of cursor: > >

Re: [Spice-devel] [PATCH spice-gtk] Do not call spice_egl_cursor_set when egl is disabled

Hi - Original Message - > Fix memory leaks of cursor: > > 240 bytes in 1 blocks are possibly lost in loss record 10,786 of 12,521 >at 0x4C2FA60: calloc (vg_replace_malloc.c:711) >by 0x3700F861: ralloc_size (ralloc.c:113) >by 0x36FD2D68: UnknownInlinedFun (list.h:83) >by

Re: [Spice-devel] [PATCH spice-gtk] widget-egl: Define label only if can be used

ack - Original Message - > The label can be used only with GDK_WINDOWING_WAYLAND > > Silence -Wunused-label > --- > src/spice-widget-egl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c > index 51bb5c5..c54d9f6 100644 > ---

Re: [Spice-devel] [PATCH spice-gtk] doc: Remove dropped functions

ack - Original Message - > Dropped in 70a00b8fcc2ca85d3601f6ac4895f906f9032e77 > --- > doc/reference/spice-gtk-sections.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/doc/reference/spice-gtk-sections.txt > b/doc/reference/spice-gtk-sections.txt > index a108386..8947893

Re: [Spice-devel] [PATCH] egl: fix leak when display is unrealize

Hi - Original Message - > Hi, > > On Tue, Mar 29, 2016 at 09:55:53AM -0400, Marc-André Lureau wrote: > > ack (that makes me wonder if we should have a global EGLDisplay instead of > > each widget). > > Single EGLDisplay would work with multi-monitor? It do

Re: [Spice-devel] [PATCH] egl: fix leak when display is unrealize

ack (that makes me wonder if we should have a global EGLDisplay instead of each widget). - Original Message - > eglTerminate should be called on unrealize. This not yet fix all the > leaks but reduces it significantly from 318kb to 74kb as definitely lost > and around 1mb to 8kb as

Re: [Spice-devel] [PATCH spice-gtk] widget: Use parentheses around ternary conditional

> * state here. If 'resize-guest' is false, we can assume that the > -- > 2.7.4 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH v3 6/9] egl: check and update scanout after egl init

Once the egl/GL context are initialized, check if there is a scanout to associate to display widget. This solves races when scanout update is happening before the egl/GL context is ready. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 6 ++

[Spice-devel] [PATCH v3 9/9] widget: modify update-area to not require primary surface

If egl display is enabled, use GL scanout geometry to check intersection with the monitor area. This solves displaying GL display without software canvas (currently d->area is empty and gl drawing fails) Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel G

[Spice-devel] [PATCH v3 5/9] widget: make gl-scanout and update-monitor-area privately exported

The following changes will call these functions from spice-widget-egl.c Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --- src/spice-widget-priv.h | 3 +++ src/spice-widget.c | 17 +++-- 2 files changed, 1

[Spice-devel] [PATCH v3 4/9] display: return NULL in spice_display_get_gl_scanout()

If there is no valid scanout, return NULL. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --- src/channel-display.c | 4 ++-- src/spice-widget.c| 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/chann

[Spice-devel] [PATCH v3 8/9] main: don't update display timer for unchanged config

unchanged. This fixes monitor autoconfig with virgl (when the display is regularly updated). It also solves/avoids problems with a guest running on wayland when the "resize-guest" property is TRUE. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1266484 Signed-off-by: Marc-An

[Spice-devel] [PATCH v3 3/9] widget: enable egl before updating scanout

The GLArea is realized lazily, when it is made visible in set_egl_enabled(). The egl context is initialized once the GLArea is realized. Enable egl before updating the scanout. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --

[Spice-devel] [PATCH v3 2/9] egl: check context is ready

Add a new GL status field to check if the GL context is ready. This helps debugging races where GL is called before the context is ready. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --- src/spice-widget-egl.c | 10 -

[Spice-devel] [PATCH v3 0/9] Various GL fixes

patch to enable egl before updating scanout - fix wayland display Marc-André Lureau (9): widget: remove superflous WIN32 check egl: check context is ready widget: enable egl before updating scanout display: return NULL in spice_display_get_gl_scanout() widget: make gl-scanout and update-m

[Spice-devel] [PATCH v3 1/9] widget: remove superflous WIN32 check

The egl call is already inside a X11 conditional block. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --- src/spice-widget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c i

Re: [Spice-devel] [PATCH spice-gtk v2 9/8] main: don't update display timer for unchanged config

t to investigate it further before we apply this fix? I'd apply now, as it fixes 2 existing problems ;) thanks -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk v2 4/8] display: return NULL in spice_display_get_gl_scanout()

On Thu, Mar 24, 2016 at 12:39 AM, Marc-André Lureau <mlur...@redhat.com> wrote: >> When / how it can happen ? Looking at gl_scanout() there is g_return if >> scanout == NULL, if NULL is a valid/expected return value then that >> g_return should be changed. > >

Re: [Spice-devel] [PATCH spice-gtk v2 4/8] display: return NULL in spice_display_get_gl_scanout()

Hi - Original Message - > Hi Marc-André, > > On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > > If there is no valid scanout, return NULL. > > When / how it can happen ? Looking at gl_scanout() there is g_return if > scanout == NULL, if NULL is a val

Re: [Spice-devel] [PATCH spice-gtk v2 6/8] egl: check and update scanout after egl init

Hi - Original Message - > Hi, > > On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > > Once the egl/GL context are initialized, check if there is a scanout > > to > > associate to display widget. This solves races when scanout update is > > ha

Re: [Spice-devel] [PATCH spice-gtk v2 8/8] widget: modify update-area to not require primary surface

Hi - Original Message - > Hi, > > as we discussed, I prefer this patch to go in after 9/8 to avoid some > incorrect resizes Ok > > On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > > If egl display is enabled, use GL scanout geometry t

[Spice-devel] [PATCH spice-gtk v2 9/8] main: don't update display timer for unchanged config

unchanged. This fixes monitor autoconfig with virgl (when the display is regularly updated). Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-main.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/src/channel-ma

Re: [Spice-devel] [PATCH spice-gtk] spicy: Remove configure-event callback

ack - Original Message - > It is a leftover - see "Remove GnomeRR code" > commit 30986505ba6041c293c38cb4b7f4b618a59f4716 > --- > src/spicy.c | 18 -- > 1 file changed, 18 deletions(-) > > diff --git a/src/spicy.c b/src/spicy.c > index 6ca014b..ca9db84 100644 > ---

[Spice-devel] [PATCH v2 spice-gtk 2/2] widget: use allocation instead of window size

Since spice-gtk 57df040cc, the SpiceDisplay no longer forces its own window. Get allocation instead of window size. This fixes a "top border" issue in spicy with gtk+ >= 3.19.8. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/Makefile.am | 1

[Spice-devel] [PATCH v2 spice-gtk 1/2] widget: offset draw updates by widget allocation if necessary

a function applying offset if necessary. This solves drawing glitches and perceived slowness with spice-gtk git and gtk+ >= 3.19.8. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --- src/spice-widget.c | 31 +

Re: [Spice-devel] [PATCH spice-gtk 2/2] widget: use allocation instead of window size

Hi - Original Message - > Hi, > > This fixes the "top border" in spicy. > > considering how the allocation is used I would prefer some helper > function to get the width and height. > I will replace it with gtk_widget_get_allocated_{width,height} (don't know how I missed it)

Re: [Spice-devel] [spice-gtk v3] vmcstream, gtask: Do idle ourself instead of leaving it to GTask's heuristic

ack - Original Message - > Seems that GTask heuristic only makes sense in a non-coroutine case. > After opening a bug[0] on spice-gtk and a few discussions in the mailing > list, seems that is completely fine for coroutine code to deal with the > idle explicitly. > > Signed-off-by:

Re: [Spice-devel] [spice-gtk v2] vmcstream, gtask: Do idle ourself as GTask's return gets messed up

Hi - Original Message - > Seems that our coroutines can mess up with GTask's return, ending up > in an early return from g_task_return_now() instead of doing a return > in idle. > As I still don't know if the bug is on spice-gtk or on GTask itself, > I've opened a bug[0] in spice-gtk's

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Do idle ourself as GTask's return gets messed up

Hi - Original Message - > Seems that our coroutines can mess up with GTask's return, ending up > in an early return from g_task_return_now() instead of doing a return > in idle. > As I still don't know if the bug is on spice-gtk or on GTask itself, > I've opened a bug[0] in spice-gtk's

[Spice-devel] [PATCH spice-gtk 1/2] widget: offset draw updates by widget allocation if necessary

a function applying offset if necessary. This solves drawing glitches with spice-gtk git and gtk+ >= 3.19.8. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff

Re: [Spice-devel] [PATCH spice-gtk] Include gdk/gdkwayland.h anytime GDK_WINDOWING_WAYLAND is defined.

gt; #include > > #include > -#if GTK_CHECK_VERSION(3,16,0) > +#ifdef GDK_WINDOWING_WAYLAND > #include > #endif > > -- > 2.1.4 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesk

Re: [Spice-devel] [PATCH v3 2/2] Lower gtk+ requirement to 3.10

Hi - Original Message - > Hi, > > > diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c > > index 1b3cd07..a9bea52 100644 > > --- a/src/spice-widget-egl.c > > +++ b/src/spice-widget-egl.c > > @@ -29,7 +29,9 @@ > > #include > > > > #include > > +#if

[Spice-devel] [PATCH spice-gtk v2 6/8] egl: check and update scanout after egl init

Once the egl/GL context are initialized, check if there is a scanout to associate to display widget. This solves races when scanout update is happening before the egl/GL context is ready. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 5 +

[Spice-devel] [PATCH spice-gtk v2 5/8] widget: make gl-scanout and update-monitor-area privately exported

The following changes will call these functions from spice-widget-egl.c Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-priv.h | 3 +++ src/spice-widget.c | 17 +++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src

[Spice-devel] [PATCH spice-gtk v2 4/8] display: return NULL in spice_display_get_gl_scanout()

If there is no valid scanout, return NULL. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index 2c54df7..90d155e 100644 --- a/src/c

[Spice-devel] [PATCH spice-gtk v2 8/8] widget: modify update-area to not require primary surface

If egl display is enabled, use GL scanout geometry to check intersection with the monitor area. This solves displaying GL display without software canvas. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 41 -

[Spice-devel] [PATCH spice-gtk v2 1/8] widget: remove superflous WIN32 check

The egl call is already inside a X11 conditional block. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index e329809..c8bb72c 100644 --- a/src/spice-widget.c

[Spice-devel] [PATCH spice-gtk v2 7/8] widget: update d->ready based on scanout image available

d->ready is updated based on monitor area & canvas. In case of GL rendering, update it based on monitor area & scanout and add check before drawing update. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 6 ++ src/spice-widget.c

[Spice-devel] [PATCH spice-gtk v2 0/8] Various GL fixes

The following series fixes GL-only display (when there is no 2d primary canvas at all). A few cleanups also fix Wayland display. v1->v2: - fix mingw build - add a patch to enable egl before updating scanout - fix wayland display Marc-André Lureau (8): widget: remove superflous WIN32 ch

[Spice-devel] [PATCH spice-gtk v2 3/8] widget: enable egl before updating scanout

The GLArea is realized lazily, when it is made visible in set_egl_enabled(). The egl context is initialized once the GLArea is realized. Enable egl before updating the scanout. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 6 +++--- 1 file chan

[Spice-devel] [PATCH spice-gtk v2 2/8] egl: check context is ready

Add a new GL status field to check if the GL context is ready. This helps debugging races where GL is called before the context is ready. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 10 -- src/spice-widget-priv.h | 1 + src/spice-wi

[Spice-devel] [PATCH spice-gtk 7/7] widget: modify update-area to not require primary surface

If egl display is enabled, use GL scanout geometry to check intersection with the monitor area. This solves displaying GL display without software canvas. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 35 ++- 1 file c

[Spice-devel] [PATCH spice-gtk 1/7] widget: remove superflous WIN32 check

The egl call is already inside a X11 conditional block. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index e329809..c8bb72c 100644 --- a/src/spice-widget.c

[Spice-devel] [PATCH spice] worker: remove check for canvas during cursor connect

We want the cursor to be initialized even if there is no canvas, especially when using a GL scanout. This solves some client warnings when using qemu with GL scanout-only (patches under review on qemu ML). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- server/d

[Spice-devel] [PATCH spice-gtk 5/7] egl: check and update scanout after egl init

Once the egl/GL context are initialized, check if there is a scanout to associate to display widget. This solves races when scanout update is happening before the egl/GL context is ready. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 5 +

[Spice-devel] [PATCH spice-gtk 3/7] display: return NULL in spice_display_get_gl_scanout()

If there is no valid scanout, return NULL. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index 2c54df7..90d155e 100644 --- a/src/c

[Spice-devel] [PATCH spice-gtk 4/7] widget: make gl-scanout and update-monitor-area privately exported

The following changes will call these functions from spice-widget-egl.c Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-priv.h | 3 +++ src/spice-widget.c | 17 +++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src

[Spice-devel] [PATCH spice-gtk 6/7] widget: update d->ready based on scanout image available

d->ready is updated based on monitor area & canvas. In case of GL rendering, update it based on monitor area & scanout and add check before drawing update. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 4 +++- src/spice-widget.c

[Spice-devel] [PATCH spice-gtk 2/7] egl: check context is ready

Add a new GL status field to check if the GL context is ready. This helps debugging races where GL is called before the context is ready. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 7 ++- src/spice-widget-priv.h | 1 + src/spice-wi

Re: [Spice-devel] [spice-gtk] mingw: Fix build failure due to epoxy/egl.h header

- Original Message - > On Mon, Mar 21, 2016 at 3:04 PM, Marc-André Lureau <mlur...@redhat.com> > wrote: > > Hi > > > > - Original Message - > >> epoxy/egl.h header is not provided by mingw-epoxy package. > >> Let's avoid egl usage

Re: [Spice-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

Hi On Mon, Mar 21, 2016 at 11:24 AM, Gerd Hoffmann <kra...@redhat.com> wrote: > On Fr, 2016-03-18 at 14:45 +0100, Marc-André Lureau wrote: >> Hi >> >> On Fri, Mar 18, 2016 at 2:17 PM, Gerd Hoffmann <kra...@redhat.com> wrote: >> > Ping Marc? Any comment

Re: [Spice-devel] [spice-gtk] mingw: Fix build failure due to epoxy/egl.h header

Hi - Original Message - > epoxy/egl.h header is not provided by mingw-epoxy package. > Let's avoid egl usage when building using mingw then. > > Signed-off-by: Fabiano Fidêncio > --- > configure.ac| 1 - > src/Makefile.am | 2 ++ >

Re: [Spice-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

Hi On Fri, Mar 18, 2016 at 2:17 PM, Gerd Hoffmann <kra...@redhat.com> wrote: > Ping Marc? Any comment on this? Could you send a rebased series, for the patches that lead to the issue? I assume "render DisplaySurface via opengl" patch? --

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

Hi - Original Message - > > gtkglarea and found out that it just worked. And since recent gtk+ is > > required for wayland, depending on gtkglarea sounds like the best move > > forward anyway. But anyone, feel free to fix gl support on wayland > > with gtk 3.10. > > 3.10 + wayland isn't

[Spice-devel] [PATCH spice-gtk] build-sys: fix 'Only can be included directly' warning

Tests should be allowed to include directly private headers. Set __SPICE_CLIENT_H_INSIDE__ where necessary or include spice-client.h where possible. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- tests/session.c | 4 +--- tests/util.c| 1 + 2 files changed, 2 inse

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

Hi - Original Message - > > If need be, we could lower gtk3 requirement to 3.10 (droping wayland > > support in this case). Afaik, 3.16 is going to make it in rhel7 as > > part of regular desktop rebase. > > I think we should continue to support older 3.x versions for a while. I just

[Spice-devel] [PATCH v3 1/2] build-sys: remove epoxy from pc requires

libepoxy doesn't need to figure in spice-gtk pkg-config requires, it's a private dependency. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6983b6b..0

[Spice-devel] [PATCH v3 0/2] Lower gtk+ requirement

In order to build spice-gtk on current rhel7. (in general, spice-gtk is a GNOME desktop library and should thus be allowed to follow the GNOME schedule and require recent gtk+, but for various reasons, it helps to keep building on rhel7 too when possible) Marc-André Lureau (2): build-sys

[Spice-devel] [PATCH v3 2/2] Lower gtk+ requirement to 3.10

Make GtkGlArea optional allows to lower gtk+ requirement to 3.10 (required for GtkStack). However, gl display is unsupported on wayland with gtk+ < 3.16. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 4 ++-- src/spice-widget-egl.c | 2 ++

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

Hi - Original Message - > On Fr, 2016-03-11 at 21:50 +0100, Marc-André Lureau wrote: > > 3.16 is the minimal version for GtkGLArea widget, used in following > > patches. > > > - 3.0) GTK_REQUIRED=2.91.3 > > + 3.0) GTK_REQUIRED=3.16 > > That puts th

Re: [Spice-devel] [spice-common v3] use specific subdomains for better filtering

| 34 +++--- > src/usb-device-manager.c | 64 +-- > src/usb-device-widget.c| 7 +- > src/usbutil.c | 4 +- > src/vmcstream.c| 14 +-- > src/vncdisplaykeymap.c | 46

Re: [Spice-devel] [PATCH v2 10/10] gtk: add GtkGLArea

On Mon, Mar 14, 2016 at 9:22 AM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > On Fri, Mar 11, 2016 at 9:50 PM, Marc-André Lureau > <marcandre.lur...@gmail.com> wrote: >> GtkGLArea is the proper modern way to have opengl in an gtk+ >> application. Unfortunatel

Re: [Spice-devel] [PATCH v2 09/10] gtk: use GtkStack

n imagine other display widgets to show text etc.. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH v2 07/10] gtk: drop deprecated stuff from spice-gtk

Breaking ABI is a good time to remove deprecated code. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 71 -- src/spice-widget.h | 7 -- 2 files changed, 78 deletions(-) diff --git a/src

[Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

3.16 is the minimal version for GtkGLArea widget, used in following patches. Drop conditionnal epoxy, as it is now also required by gtk+. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac| 29 ++--- src/Makefile.am

[Spice-devel] [PATCH v2 06/10] Drop GTK+ 2.0

Not so many systems require gtk+ 2.0 these days, let's move on. This drops the old python bindings (non-gir based), and the unsteady/experimental gtk2-only XShm support. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- Makefile.am| 2 +- config

[Spice-devel] [PATCH v2 10/10] gtk: add GtkGLArea

, such as the wayland one. This brings wayland support for local gl to spice-gtk. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 9 ++ src/spice-widget-priv.h | 1 + src/spice-widget.c | 79 --

[Spice-devel] [PATCH v2 04/10] gtk: move SpiceUsbDeviceWidget

Do not leak internals of SpiceUsbDeviceWidget in public headers. This makes also the class final, which let us extend more easily without fear of breaking ABI. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/usb-device-widget.c | 16 src/usb-device-wi

[Spice-devel] [PATCH v2 05/10] gtk: move SpiceGrabSequence

Do not leak internals of SpiceGrabSequence in public headers. This makes also the class final, which let us extend more easily without fear of breaking ABI. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/Makefile.am | 1 + src/spice-grabsequence-priv.

[Spice-devel] [PATCH v2 03/10] gtk: move gtk session

Do not leak internals of SpiceGtkSession in our headers. This makes also the class final, which let us extend more easily without fear of breaking ABI. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-gtk-session-priv.h | 13 + src/spice-gtk-ses

[Spice-devel] [PATCH v2 09/10] gtk: use GtkStack

Move the GtkDrawingArea in a GtkStack, so other widgets can be switched to for the display. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-priv.h | 4 +-- src/spice-widget.c | 69 - 2 files chang

[Spice-devel] [PATCH v2 01/10] build-sys: bump spice-gtk current version info

The following patches need to break the ABI (in particular the parent of the SpiceDisplay widget). Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 6

[Spice-devel] [PATCH v2 02/10] gtk: make SpiceDisplay private

Do not leak internals of SpiceDisplay in our headers. This makes also the class final, which let us extend more easily without fear of breaking ABI. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-priv.h | 15 +++ src/spice-widget.h

[Spice-devel] [PATCH v2 00/10] Drop gtk2, use GtkGlArea if possible

now useless shmid field in display_surface - fix year comment Marc-André Lureau (10): build-sys: bump spice-gtk current version info gtk: make SpiceDisplay private gtk: move gtk session gtk: move SpiceUsbDeviceWidget gtk: move SpiceGrabSequence Drop GTK+ 2.0 gtk: drop deprecated stuff f

[Spice-devel] ANNOUNCE: spice-gtk v0.31 released

sha1sum: 949d99191fae7c5f4e54a303384616ce2c40162f spice-gtk-0.31.tar.bz2 -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCHv3 spice-gtk] build-sys: fix make check when polkit not available

Hi - Original Message - > Hmm, that initial empty noinst_PROGRAMS looks a bit like a mistake. Perhaps > add > a $(NULL) to that to make it explicit? It's fairly idiomatic to initialize variables with empty. $(NULL) is mainly use to help with sorted-lines and trailing \ (for the last

<    3   4   5   6   7   8   9   10   11   12   >