[Spice-devel] [PATCHv3 spice-gtk] build-sys: fix make check when polkit not available

acl-helper needs polkit (and unix atm) to build. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- tests/Makefile.am | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 24d45c9..c1d95c1 100644 --- a

[Spice-devel] [PATCH spice-gtk] build-sys: fix make check when polkit not available

acl-helper needs polkit (and unix atm) to build. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- tests/Makefile.am | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 24d45c9..3348b35 100644 --- a

[Spice-devel] [PATCH spice-gtk] build-sys: fix make check on win32

acl-helper test is unix-only. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- tests/Makefile.am | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 24d45c9..ccf14bc 100644 --- a/tests/Makefile.am +++ b

[Spice-devel] [PATCH spice-gtk 1/2] session: use debug message for optionnal key value

This fixes make check failing because of recent spice-common logging switch to glib. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-session.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-session.c b/src/spice-session.c index a

[Spice-devel] [PATCH spice-gtk 2/2] logging: use more idiomatic spice-gtk logging

spice-gtk uses SPICE_DEBUG for debug lines (for now), and prefer direct glib glog/g_warning. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/channel-main.c | 8 src/spice-audio.c | 2 +- src/spice-channel.c | 8 src/spice-pulse.c | 4 ++-- src

Re: [Spice-devel] [PATCH spice-gtk v2 5/6] usb-acl-helper: add env var for specifying acl helper binary

Hi - Original Message - > On Fri, 2016-03-11 at 10:26 +0100, Christophe Fergeau wrote: > > On Thu, Mar 10, 2016 at 11:17:16AM -0600, Jonathon Jongsma wrote: > > > This allows us to execute a custom mock acl helper binary for testing > > > purposes. > > > --- > > > src/usb-acl-helper.c |

[Spice-devel] ANNOUNCE: spice-protocol release 0.12.11

-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-common] Remove 2 unused vfuncs from client_marshallers.h

___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-gtk] Prepare for v0.31 release

Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- NEWS | 18 ++ src/usb-device-manager.c | 2 ++ 2 files changed, 20 insertions(+) diff --git a/NEWS b/NEWS index 86f2a8c..0cb5359 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,21 @@

[Spice-devel] [PATCH spice] Update spice-common

Pick codegen build fix (codegen is back in spice-common, see related commits & discussion thread) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index fd9ba7

[Spice-devel] [PATCH spice-gtk] Update spice-common submodule

Pick codegen build fix Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index b61f43f..00db440 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subp

[Spice-devel] [PATCH spice-protocol] NEWS: update for 0.12.11 release

From: Marc-André Lureau <marcandre.lur...@gmail.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index a342d38..4f500e2 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,10 @@ +Major change

Re: [Spice-devel] [PATCH 0/6] protocol: add back codegen & proto files

Hi - Original Message - > Series looks good to me > > Christophe Thanks, for the protocol, it didn't change from the RFC "remove codegen". I assume I can push the series and the protcol remove then? cheers ___ Spice-devel mailing list

[Spice-devel] [PATCH 4/6] proto: Rename image_compress to image_compression

bility issues. (cherry picked from spice-protocol commit e857cd9a378cdf56805b64284491a12af93a7cbf) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- spice.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice.proto b/spice.proto index 4ea1263..db

Re: [Spice-devel] [PATCH 0/6] protocol: add back codegen & proto files

Hi On Thu, Mar 10, 2016 at 4:07 PM, Marc-André Lureau <marcandre.lur...@redhat.com> wrote: > As discussed in the "RFC: add back codegen" series, add back the > codegen. The codegen is tight to spice-common code, they need to be > in sync, or build will break. > > r

[Spice-devel] [PATCH 5/6] proto: Use proper type for preferred_compression field

From: Christophe Fergeau <cferg...@redhat.com> No need to use an uint8 typed member, we can directly use the appropriate enum8 type here, which makes everything more explicit. (cherry picked from spice-protocol commit 8a3def14e35039753097094ba356e85e8fc2d128) Signed-off-by: Marc-André

[Spice-devel] [PATCH 6/6] protocol: add unix GL scanout messages

wn "gl-only" channel in the future, or support for other streaming methods, but this protocol change should be enough for basic virgl or other gpu-accelerated support) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Acked-by: Frediano Ziglio <fzig...@redhat.com>

[Spice-devel] [PATCH 3/6] codegen: simplify FdType

From: Marc-André Lureau <marcandre.lur...@gmail.com> This patch is a left-over from the fd passing commit 267391c8fd as suggested by Frediano Ziglio during review. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Frediano Ziglio <fzig...@redhat.com> (

[Spice-devel] [PATCH 2/6] protocol: learn to describe fd passing in messages

c), the receiver side expects an extra byte anyway. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Acked-by: Frediano Ziglio <fzig...@redhat.com> (cherry-picked from spice-protocol commit 267391c8fd7c90c067b3e4845ff0227a2580e2e2) Signed-off-by: Marc-André Lureau

[Spice-devel] [PATCH 0/6] protocol: add back codegen & proto files

t install codegen Christophe Fergeau (2): proto: Rename image_compress to image_compression proto: Use proper type for preferred_compression field Marc-Andre Lureau (2): protocol: learn to describe fd passing in messages protocol: add unix GL scanout messages Marc-André Lureau (2): Rev

[Spice-devel] [PATCH spice-common] test-logging: unset G_MESSAGES_DEBUG

This test is sensitive to G_MESSAGES_DEBUG variable. Make it insensitive by unsetting the environment variable. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- tests/test-logging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-logging.c b/tests/test-log

Re: [Spice-devel] [PATCH spice-common] RFC: add back codegen

Hi - Original Message - > On Wed, Mar 09, 2016 at 03:02:53PM +0100, Marc-André Lureau wrote: > > > Longer term, I think it should be possible to autogenerate > > > common/messages.h > > > and common/client_marshallers.h as well, which hopefully would avoi

Re: [Spice-devel] [PATCH spice-gtk 0/3] Add basic tests for usb-acl-helper

Hi - Original Message - > On Wed, 2016-03-09 at 16:02 +0100, Fabiano Fidêncio wrote: > > Marc-André, > > > > On Tue, Mar 8, 2016 at 11:33 PM, Marc-André Lureau <mlur...@redhat.com> > > wrote: > > > Hi > > > > > > - Ori

Re: [Spice-devel] [PATCH spice-gtk 0/3] Add basic tests for usb-acl-helper

hi On Wed, Mar 9, 2016 at 4:02 PM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > And then we would have to setup the env-var when running make check? :-\ I'd expect it to be set in the test with setenv(). -- Marc-André Lureau ___ Sp

Re: [Spice-devel] [PATCH spice-common] RFC: add back codegen

Hi On Wed, Mar 9, 2016 at 2:12 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > Hey, > Thanks for the reply, I was chomping at the bit! I can't wait for releases. > On Fri, Feb 26, 2016 at 06:37:59PM +0100, Marc-André Lureau wrote: >> codegen generated code depends

Re: [Spice-devel] [PATCH spice-gtk 0/3] Add basic tests for usb-acl-helper

Hi - Original Message - > This just adds a few basic tests to verify that we handle the usb-acl helper > properly. The first patch is actually a bugfix for an issue that was > discovered > while writing the tests. > > The second patch provides some infrastructure for the tests. I'm not

[Spice-devel] [PATCH spice] Fix dcc_start() regression

in red_channel_client_push (rcc=0x7fffda6a7010) #at red-channel.c:1365 #6 0x7fffec1a387e in dcc_push_monitors_config (dcc=0x7fffda6a7010) #at dcc.c:563 #7 0x7fffec1a3489 in dcc_start (dcc=0x7fffda6a7010) at dcc.c:475 Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.

Re: [Spice-devel] Gstreamer, RHEL 7, OpenGL and stripes

Hi - Original Message - > It sounds like somebody agreed with the patch but then > loosed interest in it. > > Why didn't you removed patches 5 and 6 and defined/used a > DRM_API_HANDLE_TYPE_SHMID > instead of WINSYS_HANDLE_TYPE_SHMID and post again? Looks like was the only > "big"

Re: [Spice-devel] Gstreamer, RHEL 7, OpenGL and stripes

Hi - Original Message - > upstream afaik. Another attempt I had, at least for fixing gnome3 & > llvmpipe, use XShm: > https://lists.freedesktop.org/archives/mesa-dev/2015-June/085860.html fwiw, I think the last iteration was

Re: [Spice-devel] Gstreamer, RHEL 7, OpenGL and stripes

Hi - Original Message - > Hi, > yesterday/today I attempted to test the gstreamer patches. > My approach was mainly as "user", install and see how does it work. > > I installed Francois patches for spice-protocol and spice-server > (not clients so I tested with mjpeg). > The initial

Re: [Spice-devel] [PATCH spice-common] RFC: add back codegen

tophe >> who >> moved codegen to protocol. >> > > Agreed with the idea. Didn't check a lot the patch. > Thanks, Christophe, could you look at it? This is breaking builds and preventing releases. -- Marc-André Lureau ___

[Spice-devel] [PATCH libcacard 1/2] nss: report error on invalid db= argument

The db argument must end with " or \n. Found thanks to clang scan-build. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reported-by: Miroslav Rezanina <mreza...@redhat.com> --- src/vcard_emul_nss.c | 4 1 file changed, 4 insertions(+) diff --git a/src/v

[Spice-devel] [PATCH libcacard 2/2] vscclient: help scan-build

scan-build gives a false-positive error because it gets confused that optarg may be NULL. Help him by adding an assert. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reported-by: Miroslav Rezanina <mreza...@redhat.com> --- src/vscclient.c | 2 ++ 1 file changed,

Re: [Spice-devel] [PATCH] Add utility to help redirecting output from remote-viewer/virt-viewer

+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > + * > + * Usage: > + * This wrapper allows to redirect output even if your application > + * tries to redirect its output to console. > + * > + * For instance you can use from console with a syntax like >

Re: [Spice-devel] [PATCH] Add utility to help redirecting output from remote-viewer/virt-viewer

* > + * Usage: > + * This wrapper allows to redirect output even if your application > + * tries to redirect its output to console. > + * > + * For instance you can use from console with a syntax like > + * > + * output-redirect-wrapper remote-viewer.exe --debug > log.txt

Re: [Spice-devel] [phodav PATCH 1/2 v2] spice-webdavd: Automount shared folder on Windows

- Original Message - > Hi > > On Thu, Feb 25, 2016 at 4:21 PM, Marc-André Lureau < > marcandre.lur...@gmail.com > wrote: > > > Hi > > On Thu, Feb 25, 2016 at 3:19 PM, Lukas Venhoda < lvenh...@redhat.com > wrote: > > +static vo

Re: [Spice-devel] [phodav PATCH 1/2 v2] spice-webdavd: Automount shared folder on Windows

dding and calling map_drive, I think you should implement the function to check if there is already a mapping. > +#endif > + >g_socket_service_start (socket_service); > >cancel = g_cancellable_new (); > @@ -775,6 +852,10 @@ run_service (void) >g_main_l

Re: [Spice-devel] [phodav PATCH 4/4] spice-webdavd: Option to run without service on Windows

Hi On Thu, Feb 25, 2016 at 3:34 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > I would use || instead of &&, so using DEBUG=1 is enough (the > --no-service is mostly for development doc purposes, not really useful > in practice). Sorry I read it wrong, th

Re: [Spice-devel] [phodav PATCH 4/4] spice-webdavd: Option to run without service on Windows

e || instead of &&, so using DEBUG=1 is enough (the --no-service is mostly for development doc purposes, not really useful in practice). > -- > 2.5.0 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > htt

Re: [Spice-devel] [PATCH] spice-gtk: Fix the signedness of a couple of mm-time traces

ack - Original Message - > Signed-off-by: Francois Gouget > --- > src/channel-playback.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/channel-playback.c b/src/channel-playback.c > index a124cbb..c97afd8 100644 > ---

Re: [Spice-devel] mm-time handling is broken

Hi - Original Message - > > spice-gtk updates the mm-time based on the audio playback channel and > then uses it to compute the video delay of the video streams if any. > > More precisely whenever spice_playback_channel_set_delay() is called it > takes the mm-time of the last audio

Re: [Spice-devel] [RFC PATCH spice-protocol] codegen: Filter not defined messages from protocol

t;) > > if options.includes: > +filter_protocol_messages(proto, options.includes) > for i in options.includes: > writer.header.writeln('#include <%s>' % i) > writer.writeln('#include <%s>' % i) > -- > 2.5.0 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH v2 06/12] spice: add unblock timer

Hi On Fri, Feb 19, 2016 at 10:14 AM, Gerd Hoffmann <kra...@redhat.com> wrote: > Pure debug aid, print a warning in case unblocking > doesn't happen within one second. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- Reviewed-by: Marc-André Lureau &

Re: [Spice-devel] [PATCH v2 11/12] spice: add & use qemu_spice_gl_monitor_config

ions(+) > Could eventually be squashed with "add opengl/virgl/dmabuf support" patch Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h > index dd9cf6f..f9388c2 100644 > --- a/includ

Re: [Spice-devel] [PATCH v2 01/12] spice: init dcl before registering qxl interface

t; Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [Qemu-devel] [PATCH 5/8] spice: add opengl/virgl/dmabuf support

e = QEMU_OPT_BOOL, >> +#endif >> }, > > How introspectible is this? Does QMP 'query-command-line-options' cope > will with showing 'gl' as an option only for the qemu binaries where the > #ifdef succeeded? { "execute": "query-command

Re: [Spice-devel] [PATCH 1/8] configure: add dma-buf support detection.

ONFIG_GTKABI=$gtkabi" >> $config_host_mak >echo "GTK_CFLAGS=$gtk_cflags" >> $config_host_mak > + echo "GTK_LIBS=$gtk_libs" >> $config_host_mak This could be seperated >if test "$gtk_gl" = "yes" ; then > echo "

Re: [Spice-devel] [PATCH 2/8] egl-helpers: add functions for render nodes and dma-buf passing

+ NULL); > +if (!image) { > +return -1; > + } > + > +eglExportDMABUFImageQueryMESA(qemu_egl_display, image, fourcc, > + _planes, NULL); > +if (num_planes != 1) { > +eglDestroyImageKHR(qe

Re: [Spice-devel] [PATCH 3/8] console: track gl_block state in QemuConsole

code paths make use > of this. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org h

Re: [Spice-devel] [PATCH 5/8] spice: add opengl/virgl/dmabuf support

rmat = qemu_pixman_check_format, > +.dpy_refresh = display_refresh, > +.dpy_mouse_set= display_mouse_set, > +.dpy_cursor_define= display_mouse_define, > + > +.dpy_gl_ctx_create = qemu_spice_gl_create_context, > +.dpy_gl_ctx_destroy = qemu_egl_destroy_context, > +.dpy

Re: [Spice-devel] [PATCH 0/8] spice: add opengl/virgl/dmabuf support

opengl/virgl/dmabuf support > spice: tweak debug messages. > spice/gl: render DisplaySurface via opengl > spice/gl: create dummy primary surface (RfC) > > Marc-André Lureau (1): > spice: reset cursor on resize > Please reorder so that "track gl_block state" is

Re: [Spice-devel] [PATCH 0/9] Drop gtk2, use GtkGlArea if possible

Hi On Tue, Feb 16, 2016 at 5:50 PM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > Marc-André, > > On Tue, Feb 16, 2016 at 3:49 PM, Marc-André Lureau > <marcandre.lur...@gmail.com> wrote: >> Using GtkGlArea is the proper way of doing opengl with gtk+ and sol

Re: [Spice-devel] [PATCH 5/9] Drop GTK+ 2.0

Hi On Tue, Feb 16, 2016 at 5:39 PM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > On Tue, Feb 16, 2016 at 3:49 PM, Marc-André Lureau > <marcandre.lur...@gmail.com> wrote: >> Not so many systems require gtk+ 2.0 these days, let's move on. >> >> This drops th

Re: [Spice-devel] [PATCH 4/9] gtk: move SpiceGrabSequence

Hi On Tue, Feb 16, 2016 at 5:26 PM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > On Tue, Feb 16, 2016 at 3:49 PM, Marc-André Lureau > <marcandre.lur...@gmail.com> wrote: >> Do not leak internals of SpiceGrabSequence in our headers. This makes >> also the class f

Re: [Spice-devel] [PATCH 3/9] gtk: move gtk session

Hi On Tue, Feb 16, 2016 at 5:26 PM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > Why do you need to change the UsbDeviceWidget as well? > This change should be in a different patch, IMHO. Makes sense, moving it out. -- Marc-André Lureau _

[Spice-devel] [PATCH 1/9] build-sys: bump spice-gtk current version info

The following patches need to break the ABI (in particular the parent of the SpiceDisplay widget). Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 6

[Spice-devel] [PATCH 5/9] Drop GTK+ 2.0

Not so many systems require gtk+ 2.0 these days, let's move on. This drops the old python bindings (non-gir based), and the unsteady/experimental gtk2-only XShm support. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- Makefile.am| 2 +- config

[Spice-devel] [PATCH 0/9] Drop gtk2, use GtkGlArea if possible

and every application will need to handle the change. It seems better to avoid that by keeping the API but breaking our ABI. While at it, clean up a bunch of deprecated API and hide some ABI details away. Marc-André Lureau (9): build-sys: bump spice-gtk current version info gtk: make SpiceDisplay

[Spice-devel] [PATCH 4/9] gtk: move SpiceGrabSequence

Do not leak internals of SpiceGrabSequence in our headers. This makes also the class final, which let us extend more easily without fear of breaking ABI. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/Makefile.am | 1 + src/spice-grabsequence-priv.

[Spice-devel] [PATCH 9/9] gtk: add GtkGLArea

, such as the wayland one. This brings wayland support for local gl to spice-gtk. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-egl.c | 9 ++ src/spice-widget-priv.h | 1 + src/spice-widget.c | 79 --

[Spice-devel] [PATCH 2/9] gtk: make SpiceDisplay private

Do not leak internals of SpiceDisplay in our headers. This makes also the class final, which let us extend more easily without fear of breaking ABI. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-priv.h | 15 +++ src/spice-widget.h

[Spice-devel] [PATCH 8/9] gtk: use GtkStack

Move the GtkDrawingArea in a GtkStack, so other widgets can be switched to for the display. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget-priv.h | 4 +-- src/spice-widget.c | 69 - 2 files chang

[Spice-devel] [PATCH 7/9] gtk: require gtk+ 3.16

3.16 is the minimal version for GtkGLArea widget, used in following patches. Drop conditionnal epoxy, as it is now also required by gtk+. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac| 29 ++--- src/Makefile.am

[Spice-devel] [PATCH 3/9] gtk: move gtk session

Do not leak internals of SpiceGtkSession in our headers. This makes also the class final, which let us extend more easily without fear of breaking ABI. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-gtk-session-priv.h | 13 + src/spice-gtk-ses

[Spice-devel] [PATCH 6/9] gtk: drop deprecated stuff from spice-gtk

Breaking ABI is a good time to remove deprecated code. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-widget.c | 71 -- src/spice-widget.h | 7 -- 2 files changed, 78 deletions(-) diff --git a/src

Re: [Spice-devel] [PATCH spice-gtk] gtk: add spice-widget GL scanout support

Hi - Original Message - > Hi, > > with gtk2: > spice-widget-egl.c: In function ‘spice_egl_init’: > spice-widget-egl.c:203:9: error: implicit declaration of function > ‘GDK_IS_X11_DISPLAY’ [-Werror=implicit-function-declaration] >  if (GDK_IS_X11_DISPLAY(gdk_dpy)) { >  ^ >

[Spice-devel] [PATCH spice-gtk] gtk: add spice-widget GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with bare-egl doesn't seem trivial). Using GtkGLArea is left for a future series, since SpiceDisplay

Re: [Spice-devel] [PATCH v4 5/5] gtk: add spice-widget GL scanout support

Hi On Sat, Feb 13, 2016 at 12:00 PM, Victor Toso <li...@victortoso.com> wrote: > Hi, > > On Fri, Feb 05, 2016 at 12:36:52AM +0100, Marc-André Lureau wrote: >> From: Marc-André Lureau <mlur...@redhat.com> >> >> Hook to spice-glib events to show the GL scano

Re: [Spice-devel] [PATCH v4 4/5] glib: add local GL scanout support

o not finish any. We may want to add a condition (timeout, buffer/cmd limit etc) to drop the spice client. This will be done most likely in server and/or qemu. This is an area that needs investigation.. -- Marc-André Lureau ___ Spice-devel mailing list

Re: [Spice-devel] [PATCH v3 5/9] Add new spice-gl stubs API

should never have to in the first place. This is how most of glib libraries/applications are written. Since qemu relies on glib, they have the same contract with glib libraries, although internally they most often use abort() pre-conditions (as spice server by default). -- Marc-André

[Spice-devel] [PATCH v4 6/6] Handle GL_DRAW_DONE

When a client is done with drawing and sends SPICE_MSGC_DISPLAY_GL_DRAW_DONE, or when it ends, update the number of async counts. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> [reduce critical message to a warning; do not reset gl_draw_ongoing - Frediano Ziglio] Sign

[Spice-devel] [PATCH v4 3/6] Handle GL_SCANOUT messages

Go through dispatcher and marshall scanout message. Since the marshaller and the QXL state are manipulated from different threads, add a mutex to protect the current scanout. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc-send.c

[Spice-devel] [PATCH v4 2/6] Add new spice-gl stubs API

, and the pending async. A scanout can't be updated if there are pending draw atm. Discarding outdated draws is left as a future improvement to allow updating the scanout without waiting for draw async to be done. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> [make QXL function name

[Spice-devel] [PATCH v4 0/6] Add OpenGL scanout drawing

of fd check before sending msgfd v1->v2: - rebase - change libtest.la for libtest.a - add a few tests cleanup patches Marc-André Lureau (6): red-channel: return number of created pipe items Add new spice-gl stubs API Handle GL_SCANOUT messages Send current GL scanout to new client

[Spice-devel] [PATCH v4 5/6] Handle GL_DRAW messages

Create an async, and marshall the GL_DRAW message. Count number of clients, and wait until gl_draw_async_count is 0 to complete the async. The count is going to be updated in the following patch when the client is done with the draw. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.

[Spice-devel] [PATCH v4 4/6] Send current GL scanout to new client

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/server/dcc.c b/server/dcc.c index eb63ce6..58ae55c 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -445,6 +445,7 @@ void dcc_start(DisplayChannel

[Spice-devel] [PATCH v4 1/6] red-channel: return number of created pipe items

This is useful in the following patches to count the number of replies to wait for. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-channel.c | 19 +-- server/red-channel.h | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff

Re: [Spice-devel] [PATCH v3 8/9] Handle GL_DRAW messages

struct AsyncCommand *async = qxl->st->gl_draw_async; qxl->st->gl_draw_async = NULL; +red_dispatcher_async_complete(qxl->st->dispatcher, async); } -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists

Re: [Spice-devel] [PATCH] make QXL function names more coherent

> #endif /* SPICE_QXL_H_ */ > diff --git a/server/spice-server.syms b/server/spice-server.syms > index db7d973..7987d51 100644 > --- a/server/spice-server.syms > +++ b/server/spice-server.syms > @@ -170,6 +170,6 @@ global: > > SPICE_SERVER_0.13.1 { > global: >

Re: [Spice-devel] [PATCH 0/4] Miscellaneous patches for local Virgil support

devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH v4 2/5] Add spice_channel_unix_read_fd()

From: Marc-André Lureau <marcandre.lur...@redhat.com> Utility function used in the messages with socket ancillary fd. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- src/spice-channel-priv.h | 3 +++ src/spice-channel

[Spice-devel] [PATCH v4 5/5] gtk: add spice-widget GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with bare-egl doesn't seem trivial). Using GtkGLArea is left for a future series, since SpiceDisplay

[Spice-devel] [PATCH v4 4/5] glib: add local GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Add spice-glib support for gl scanout messages. A note about SpiceGlScanout: it is struct with scanout details, registered as a boxed type, with associated gl-scanout property. That way, it doesn't need a seperate signal for change notifi

[Spice-devel] [PATCH v4 3/5] build-sys: check for epoxy-egl support

From: Marc-André Lureau <marcandre.lur...@redhat.com> The following code requires epoxy with egl support. Check for pkg-config and egl headers. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- configure.ac | 25 + 1 file changed, 25 inserti

[Spice-devel] [PATCH v4 0/5] Add OpenGL scanout drawing

boxed scanout property and const getter in commit details - some indent fixes v1->v2: - add some error handling code, fix gl objects leaks - improve egl code to be compatible with future wayland series - misc spellings Marc-André Lureau (5): build-sys: bump to spice-protocol 0.12

[Spice-devel] [PATCH v4 1/5] build-sys: bump to spice-protocol 0.12.11

Needed for GL messages Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 38db8b5..0beec7c 100644 --- a/configure.ac +++ b/configure.ac @@ -70,7

Re: [Spice-devel] [PATCH v3 0/5] Add OpenGL scanout drawing

oops, something went wrong with the rebase, I'll resend. On Fri, Feb 5, 2016 at 12:29 AM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > The following series implements the x11 client-side support for > local-only shared OpenGL scanout rendering. > > The implement

[Spice-devel] [PATCH v3 5/5] gtk: add spice-widget GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with bare-egl doesn't seem trivial). Using GtkGLArea is left for a future series, since SpiceDisplay

[Spice-devel] [PATCH v3 4/5] glib: add local GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Add spice-glib support for gl scanout messages. A note about SpiceGlScanout: it is struct with scanout details, registered as a boxed type, with associated gl-scanout property. That way, it doesn't need a seperate signal for change notifi

[Spice-devel] [PATCH v3 3/5] build-sys: check for epoxy-egl support

From: Marc-André Lureau <marcandre.lur...@redhat.com> The following code requires epoxy with egl support. Check for pkg-config and egl headers. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- configure.ac | 25 + 1 file changed, 25 inserti

[Spice-devel] [PATCH v3 1/5] build-sys: bump to spice-protocol 0.12.11

Needed for GL messages Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 38db8b5..0beec7c 100644 --- a/configure.ac +++ b/configure.ac @@ -70,7

[Spice-devel] [PATCH v3 2/5] Add spice_channel_unix_read_fd()

From: Marc-André Lureau <marcandre.lur...@redhat.com> Utility function used in the messages with socket ancillary fd. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- src/spice-channel-priv.h | 3 +++ src/spice-channel

[Spice-devel] [PATCH v3 0/5] Add OpenGL scanout drawing

nst getter in commit details - some indent fixes v1->v2: - add some error handling code, fix gl objects leaks - improve egl code to be compatible with future wayland series - misc spellings Marc-André Lureau (5): build-sys: bump to spice-protocol 0.12.11 Add spice_channel_unix_read_fd()

Re: [Spice-devel] spice udp support

Hi - Original Message - > On Mi, 2016-02-03 at 13:27 +0900, Sunny Shin wrote: > > I heard that iptv uses udp multicast, so I thought that performance > > might be better if we use udp for video streaming. > > spice != tv. No multicast here. Oh, and udp/multicast doesn't improve >

Re: [Spice-devel] red-channel: send marshaller message fd (regression)

Hi - Original Message - > > This patch, which has now been committed as 8b14dc11, breaks Xspice. > With it I get the following error on startup: > > (process:25109): Spice-CRITICAL **: reds-stream.c:271:reds_stream_send_msgfd: > condition `reds_stream_is_plain_unix(stream)' failed > >

Re: [Spice-devel] [PATCH] tests: add explanation for test_qxl_pasring_SOURCES

Hi - Original Message - > > > > Hi > > > > On Fri, Jan 22, 2016 at 12:36 PM, Marc-André Lureau > > <marcandre.lur...@gmail.com> wrote: > > > Hi > > > > > > On Tue, Jan 19, 2016 at 11:41 AM, Frediano Ziglio <fzig...@redha

Re: [Spice-devel] [PATCH] tests: add explanation for test_qxl_pasring_SOURCES

Hi On Fri, Jan 22, 2016 at 12:36 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Jan 19, 2016 at 11:41 AM, Frediano Ziglio <fzig...@redhat.com> wrote: >> Instead of using libserver.a to include necessary functions we include >> singl

Re: [Spice-devel] [PATCH] marshaller: fix uninitialized field usage

ack - Original Message - > has_fd was not initialized. > > Signed-off-by: Frediano Ziglio > --- > common/marshaller.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/marshaller.c b/common/marshaller.c > index cffc641..00a7123 100644 > ---

Re: [Spice-devel] [PATCH v2 2/8] gtk: replace configure-event for size-allocate

Hi - Original Message - > Hi, > > On Mon, Jan 11, 2016 at 01:40:40PM +0100, Marc-André Lureau wrote: > > For size-allocate, it's simpler to connect to the signal rather than > > override the default signal handler since there is no automatic chaining > >

Re: [Spice-devel] [PATCH v2 2/8] gtk: replace configure-event for size-allocate

- Original Message - > Hi > > - Original Message - > > Hi, > > > > On Mon, Jan 11, 2016 at 01:40:40PM +0100, Marc-André Lureau wrote: > > > For size-allocate, it's simpler to connect to the signal rather than > > > override the defau

<    4   5   6   7   8   9   10   11   12   13   >