Re: [Spice-devel] [PATCH v2 0/8] Add OpenGL scanout drawing

ping On Mon, Jan 11, 2016 at 1:40 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > The following series implements the x11 client-side support for > local-only shared OpenGL scanout rendering. > > The implementation doesn't rely on gtkglarea since: > - it's qui

Re: [Spice-devel] [PATCH spice-common] marshaller: track if add_fd() was given -1

Hi - Original Message - > > > > In some cases, it might be worth to be able to send a message with a -1 > > fd, has the protocol permits. Change add_fd/get_fd in order to track > > if the caller wanted to send -1. > > > > Signed-off-by: Marc-Andr

Re: [Spice-devel] [PATCH server v2 05/13] red-channel: send marshaller message fd

Hi - Original Message - > > > > Hi > > > > On Fri, Jan 15, 2016 at 11:44 AM, Frediano Ziglio <fzig...@redhat.com> > > wrote: > > >> > > >> From: Marc-André Lureau <mlur...@redhat.com> > > >> > > >>

Re: [Spice-devel] [PATCH] tests: add explanation for test_qxl_pasring_SOURCES

code does not depend > +# on extra files. > test_qxl_parsing_SOURCES = \ What's the point of doing that? anyway, if it matters for some reason, I'll drop my cleanup patch. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH server v2 00/13] Add OpenGL scanout drawing

Hi On Thu, Jan 14, 2016 at 10:01 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > See the related protocol changes for message details. > > 2 new functions are exported: > - spice_gl_scanout() to specify the current scanout. The server will > then own the g

[Spice-devel] [PATCH spice-common] marshaller: track if add_fd() was given -1

In some cases, it might be worth to be able to send a message with a -1 fd, has the protocol permits. Change add_fd/get_fd in order to track if the caller wanted to send -1. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- common/marshaller.c | 23 +++

[Spice-devel] [PATCH v3 3/9] red-channel: send marshaller message fd

From: Marc-André Lureau <mlur...@redhat.com> Send the fd associated to the last message sent. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-channel.c | 14 ++ spice-common | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-)

[Spice-devel] [PATCH v3 1/9] tests: link test-qxl-parsing with libserver

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/tests/Makefile.am | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index fea2181..2161023 100644 --- a/server/tests/Makefile.am +++ b/server

[Spice-devel] [PATCH v3 4/9] red-channel: return number of created pipe items

This is useful in the following patches to count the number of replies to wait for. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-channel.c | 19 +-- server/red-channel.h | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff

[Spice-devel] [PATCH v3 5/9] Add new spice-gl stubs API

, and the pending async. A scanout can't be updated if there are pending draw atm. Discarding outdated draws is left as a future improvement to allow updating the scanout without waiting for draw async to be done. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-dispat

[Spice-devel] [PATCH v3 0/9] Add OpenGL scanout drawing

;v3: (after Frediano review) - rebase - change syms version to SPICE_SERVER_0.13.1 - remove PIPE_ITEM helper - do not allow new scanout while a draw is pending - get rid of fd check before sending msgfd v1->v2: - rebase - change libtest.la for libtest.a - add a few tests cleanup patches Marc

[Spice-devel] [PATCH v3 7/9] Send current GL scanout to new client

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/server/dcc.c b/server/dcc.c index eb63ce6..58ae55c 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -445,6 +445,7 @@ void dcc_start(DisplayChannel

[Spice-devel] [PATCH v3 9/9] Handle GL_DRAW_DONE

When a client is done with drawing and sends SPICE_MSGC_DISPLAY_GL_DRAW_DONE, or when it ends, update the number of async counts. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc.c | 21 + server/display-channel.c | 8

[Spice-devel] [PATCH v3 2/9] tests: make sure that the default rule builds all tests

The default rule being "all", it builds noinst_PROGRAMS but not check_PROGRAMS. Let's build all the tests by default. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/tests/Makefile.am | 18 -- 1 file changed, 8 insertions(+), 10 deletion

[Spice-devel] [PATCH v3 8/9] Handle GL_DRAW messages

Create an async, and marshall the GL_DRAW message. Count number of clients, and wait until gl_draw_async_count is 0 to complete the async. The count is going to be updated in the following patch when the client is done with the draw. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.

[Spice-devel] [PATCH v3 6/9] Handle GL_SCANOUT messages

Go through dispatcher and marshall scanout message. Since the marshaller and the QXL state are manipulated from different threads, add a mutex to protect the current scanout. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc-send.c

Re: [Spice-devel] [PATCH server v2 09/13] Add new spice-gl stubs API

e() > > > > Two new fields are also added to QXLState, in order to save the current > > scanout, and the pending async. > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > > --- > > server/red-dispatcher.c | 34 ++

Re: [Spice-devel] [PATCH server v2 10/13] Handle GL_SCANOUT messages

Hi - Original Message - > > > > Go through dispatcher and marshall scanout message. Since the marshaller > > and the QXL state are manipulated from different threads, add a mutex to > > protect the current scanout. > > > > Signed-off-by: Marc-Andr

Re: [Spice-devel] [PATCH server v2 11/13] Send current GL scanout to new client

Hi - Original Message - > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > > --- > > server/dcc.c | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/server/dcc.c b/server/dcc.c > >

Re: [Spice-devel] [PATCH server v2 10/13] Handle GL_SCANOUT messages

Hi On Fri, Jan 22, 2016 at 4:04 PM, Marc-André Lureau <mlur...@redhat.com> wrote: > Yes, that's a valid concern. In practice, nothing terribly wrong happens > since opengl accepts any texture coordinates, and the rendering depends on > various parameters (wrap, clamp etc) &g

Re: [Spice-devel] [PATCH server v2 11/13] Send current GL scanout to new client

mpler to keep the current scanout state on the QXLInstance. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH 2/2] usb-device-widget: Add counter of free channels

Hi - Original Message - > On Wed, 2016-01-20 at 10:11 +0100, Fabiano Fidêncio wrote: > > On Wed, Jan 20, 2016 at 9:59 AM, Victor Toso wrote: > > > Hi, > > > > > > On Tue, Jan 19, 2016 at 10:36:38PM +0100, Fabiano Fidêncio wrote: > > > > As the message showed when

Re: [Spice-devel] RFC: drop spice-gtk gtk+ 2.0 support

Hi - Original Message - > On Mon, Dec 21, 2015 at 4:54 PM, Marc-André Lureau > <marcandre.lur...@gmail.com> wrote: > > Hi, > > > > With virt-viewer now dropping gtk 2.0, I don't know anyone left using > > the spice-gtk with gtk+ 2.0. Thus I'd like to

Re: [Spice-devel] [PATCH 14/14] Add strings for translation

ack - Original Message - > While doing the work to use GTask isntead of GSimpleAsyncResult I've > noticed a few error strings that were not marked to be translated. > I am not exactly sure if it was intentional or not, but I do believe > that our error messages should be translated. > ---

Re: [Spice-devel] [PATCH] Remove GSLice usage

Hi - Original Message - > It's being slowly deprecated im glib > https://bugzilla.gnome.org/show_bug.cgi?id=754687 > --- > src/channel-display.c | 6 +++--- > src/channel-smartcard.c | 4 ++-- > src/spice-channel-cache.h | 8 > src/spice-channel.c | 8 >

Re: [Spice-devel] [PATCH server v2 05/13] red-channel: send marshaller message fd

Hi On Fri, Jan 15, 2016 at 11:44 AM, Frediano Ziglio <fzig...@redhat.com> wrote: >> >> From: Marc-André Lureau <mlur...@redhat.com> >> >> Send the fd associated to the last message sent. >> >> Even if the fd is invalid, the sendfd msg is appende

Re: [Spice-devel] [PATCH server v2 03/13] tests: make sure all tests are built on default rule

don't mind changing the text, but I really don't understand yours ;) >> Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> >> --- >> server/tests/Makefile.am | 15 +++ >> 1 file changed, 7 insertions(+), 8 deletions(-) >> >> diff --git

Re: [Spice-devel] [PATCH server v2 06/13] channel: document pipes_create_batch() function

Hi On Fri, Jan 15, 2016 at 11:46 AM, Frediano Ziglio <fzig...@redhat.com> wrote: >> >> Rename callback to pipe_add, and document the arguments. >> >> Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> >> --- >> server/red-channe

Re: [Spice-devel] [PATCH server v2 03/13] tests: make sure all tests are built on default rule

lay_no_ssl \ > > >> test_display_streaming \ > > >> @@ -47,14 +53,7 @@ noinst_PROGRAMS = \ > > >> test_vdagent\ > > >> test_display_width_strid

Re: [Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

Hi - Original Message - > On Thu, Jan 14, 2016 at 08:23:01AM -0500, Marc-André Lureau wrote: > > > In this case, this protocol addition is local-only, and has only been > > > tested by few people, which does not make me very comfortable with > > > setting

Re: [Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

Hi - Original Message - > On Thu, Jan 14, 2016 at 10:33:04AM -0500, Marc-André Lureau wrote: > > This is just arbitrary numbers. What I know is this works well for the > > last year, and I don't expect it to need changes soon. > > This is not really what I'm asking.

Re: [Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

Hi - Original Message - > Hey, > > On Thu, Jan 14, 2016 at 07:00:45AM -0500, Frediano Ziglio wrote: > > > > I don't get what you are proposing. > > There are actually 2 .proto file. Version 1 and version 2. Should we add > > a version 3? How to add just another .proto for a single

[Spice-devel] [PATCH spice-gtk] build-sys: silence vala deprecated function usage warnings

This silence usage of deprecated glib declarations from vala generated code. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/controller/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/controller/Makefile.am b/src/controller/Makefile.am index 0

Re: [Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

we have unstable cycles again in spice-server, could we do the same for spice-protocol? -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH server v2 00/13] Add OpenGL scanout drawing

;v2: - rebase - change libtest.la for libtest.a - add a few tests cleanup patches Marc-André Lureau (13): build-sys: build a noinst libtest.a to link to tests: link test-qxl-parsing with libserver tests: make sure all tests are built on default rule stream-test: add batch test red-chan

[Spice-devel] [PATCH server v2 01/13] build-sys: build a noinst libtest.a to link to

Group the test utility in a library, to avoid repeating the same sources. In this case, automake already figues out what the source of the programs to build is. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/tests/Makefile.a

[Spice-devel] [PATCH server v2 02/13] tests: link test-qxl-parsing with libserver

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/tests/Makefile.am | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index 8caff04..15196f9 100644 --- a/server/tests/Makefile.am +++ b/server

[Spice-devel] [PATCH server v2 03/13] tests: make sure all tests are built on default rule

We should have all or none, I don't see the point of having just some of them. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/tests/Makefile.am | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/server/tests/Makefile.am b/server

[Spice-devel] [PATCH server v2 06/13] channel: document pipes_create_batch() function

Rename callback to pipe_add, and document the arguments. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-channel.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index b33c91d..7

[Spice-devel] [PATCH server v2 05/13] red-channel: send marshaller message fd

From: Marc-André Lureau <mlur...@redhat.com> Send the fd associated to the last message sent. Even if the fd is invalid, the sendfd msg is appended to the protocol, for 2 reasons: - trying to send an invalid fd does not have to close the connection (it would with an invalid fd)

[Spice-devel] [PATCH server v2 07/13] channel: do not call pipe_add with null items

If the creator was not able to produce the item, no need to call pipe_add(). Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-channel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 7

[Spice-devel] [PATCH server v2 04/13] stream-test: add batch test

Check that two consecutive msgfd are read back from two different reads. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/tests/stream-test.c | 16 1 file changed, 16 insertions(+) diff --git a/server/tests/stream-test.c b/server/tests/stream-

[Spice-devel] [PATCH server v2 09/13] Add new spice-gl stubs API

, and the pending async. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-dispatcher.c | 34 ++ server/reds.c| 1 + server/reds.h| 2 ++ server/spice-qxl.h | 11 +++ server/spice-server.syms | 6 +++

[Spice-devel] [PATCH server v2 12/13] Handle GL_DRAW messages

Create an async, and marshall the GL_DRAW message. Count number of clients, and wait until gl_draw_async_count is 0 to complete the async. The count is going to be updated in the following patch when the client is done with the draw. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.

[Spice-devel] [PATCH server v2 11/13] Send current GL scanout to new client

Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/server/dcc.c b/server/dcc.c index 3161375..193d630 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -445,6 +445,7 @@ void dcc_start(DisplayChannel

[Spice-devel] [PATCH server v2 08/13] red-channel: return number of created pipe items

This is useful in the following patches to count the number of replies to wait for. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/red-channel.c | 19 +-- server/red-channel.h | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff

[Spice-devel] [PATCH server v2 10/13] Handle GL_SCANOUT messages

Go through dispatcher and marshall scanout message. Since the marshaller and the QXL state are manipulated from different threads, add a mutex to protect the current scanout. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc-send.c

[Spice-devel] [PATCH server v2 13/13] Handle GL_DRAW_DONE

When a client is done with drawing and sends SPICE_MSGC_DISPLAY_GL_DRAW_DONE, or when it ends, update the number of async counts. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- server/dcc.c | 21 + server/display-channel.c | 8

[Spice-devel] [PATCH spice-protocol] codegen: simplify FdType

This patch is a left-over from the fd passing commit 267391c8fd as suggested by Frediano Ziglio during review. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- python_modules/ptypes.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/python_m

Re: [Spice-devel] [PATCH v3 4/4] worker: use glib main loop

Hi - Original Message - > On Wed, Jan 13, 2016 at 11:39:09AM +, Frediano Ziglio wrote: > > Use the glib mainloop instead of writing our own. The glib loop is both > > cleaner to use and is more extensible. It is also very mature and > > reduces the maintenance burden on the spice

Re: [Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

Hi On Mon, Jan 4, 2016 at 1:11 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi > > Anything else needed to get acks? ping -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.

Re: [Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

Hi - Original Message - > Hey, > > On Wed, Jan 13, 2016 at 06:54:56AM -0500, Frediano Ziglio wrote: > > > > > > > > Hi > > > > > > On Mon, Jan 4, 2016 at 1:11 PM, Marc-André Lureau > > > <marcandre.lur...@gmail.com>

[Spice-devel] [PATCH v2 8/8] gtk: add spice-widget GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with bare-egl doesn't seem trivial). Using GtkGLArea is left for a future series, since SpiceDisplay

[Spice-devel] [PATCH v2 1/8] channel-main: remove unused header rect.h

From: Victor Toso <victort...@redhat.com> It was included in be8ff99571478deb5c8d116134f65ed2b788dbd3 but with no use. Acked-by: Marc-André Lureau <mlur...@redhat.com> --- src/channel-main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/channel-main.c b/src/channel-main.c i

[Spice-devel] [PATCH v2 6/8] build-sys: check for epoxy-egl support

From: Marc-André Lureau <marcandre.lur...@redhat.com> The following code requires epoxy with egl support. Check for pkg-config and egl headers. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- configure.ac | 25 + 1 file changed, 25 inserti

[Spice-devel] [PATCH v2 4/8] build-sys: bump to spice-protocol 0.12.11

Needed for GL messages Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 38db8b5..0beec7c 100644 --- a/configure.ac +++ b/configure.ac @@ -70,7

[Spice-devel] [PATCH v2 3/8] Update spice-common

Update needed for GL messages Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index c3f2d21..62d4a0d 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subp

[Spice-devel] [PATCH v2 5/8] Add spice_channel_unix_read_fd()

From: Marc-André Lureau <marcandre.lur...@redhat.com> Utility function used in the messages with socket ancillary fd. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- src/spice-channel-priv.h | 3 +++ src/spice-channel

[Spice-devel] [PATCH v2 7/8] glib: add local GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Add spice-glib support for gl scanout messages. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- doc/reference/spice-gtk-sections.txt | 1 + src/channel-display.c| 169

[Spice-devel] [PATCH v2 0/8] Add OpenGL scanout drawing

suggest to do first a release with gtk2/x11/egl support before deprecating gtk2 and bumping gtk requirements. v1->v2: - add some error handling code, fix gl objects leaks - improve egl code to be compatible with future wayland series - misc spellings Marc-André Lureau (7): gtk: replace config

[Spice-devel] [PATCH v2 2/8] gtk: replace configure-event for size-allocate

For size-allocate, it's simpler to connect to the signal rather than override the default signal handler since there is no automatic chaining to parent handler otherwise. Doing this removes the need to have a window. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src

Re: [Spice-devel] [PATCH v2 0/8] Add OpenGL scanout drawing

rove egl code to be compatible with future wayland series > - misc spellings > > Marc-André Lureau (7): > gtk: replace configure-event for size-allocate > Update spice-common > build-sys: bump to spice-protocol 0.12.11 > Add spice_channel_unix_read_fd() > build-sys

Re: [Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

Hi Anything else needed to get acks? On Tue, Dec 22, 2015 at 4:08 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > v3->v4: > - add drm_dma_buf prefix to some fields (Frediano Ziglio) > - explicit in commit message that sending a message with no fd (or >inv

[Spice-devel] [PATCH spice-gtk 6/7] glib: add local GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Add spice-glib support for gl scanout messages. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- doc/reference/spice-gtk-sections.txt | 1 + src/channel-display.c| 169

[Spice-devel] [PATCH spice-gtk 7/7] gtk: add spice-widget GL scanout support

From: Marc-André Lureau <mlur...@redhat.com> Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with egl doesn't seem trivial). Using GtkGlArea is also left for the future, since SpiceDisplay

[Spice-devel] [PATCH spice-gtk 3/7] build-sys: bump to spice-protocol 0.12.11

Needed for GL messages Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 38db8b5..0beec7c 100644 --- a/configure.ac +++ b/configure.ac @@ -70,7

[Spice-devel] [PATCH spice-gtk 2/7] Update spice-common

Update needed for GL messages --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index c3f2d21..62d4a0d 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit c3f2d217af40fa1da2cb42c69ca4a89fd8e7ef03 +Subproject

[Spice-devel] [PATCH spice-gtk 0/7] Add OpenGL scanout drawing

been working for a while (except on wayland) and is a good step before gtkglarea (bringing hopefully wayland support). Marc-André Lureau (7): gtk: replace configure-event for size-allocate Update spice-common build-sys: bump to spice-protocol 0.12.11 Add spice_channel_unix_read_fd() build

[Spice-devel] [PATCH spice-gtk 1/7] gtk: replace configure-event for size-allocate

This remove the need to have a window. For size-allocate, it's simpler to connect to the signal rather than override the default signal handler since there is no automatic chaining to parent handler otherwise. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- src/spice-wi

[Spice-devel] [PATCH spice-gtk 5/7] build-sys: check for epoxy-egl support

From: Marc-André Lureau <marcandre.lur...@redhat.com> The following code requires epoxy with egl support. Check for pkg-config and egl headers. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- configure.ac | 25 + 1 file changed, 25 inserti

[Spice-devel] [PATCH spice-gtk 4/7] Add spice_channel_unix_read_fd()

From: Marc-André Lureau <marcandre.lur...@redhat.com> Utility function used in the messages with socket ancillary fd. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- src/spice-channel-priv.h | 3 +++ src/spice-channel

Re: [Spice-devel] [PATCH spice-gtk 7/7] gtk: add spice-widget GL scanout support

Hi I realize there are still a few missing cleanups here and there. Please do not review thoroughly, consider it as wip. thanks On Mon, Jan 4, 2016 at 3:46 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > From: Marc-André Lureau <mlur...@redhat.com> > > Hook

Re: [Spice-devel] [spice-gtk PATCH] channel-main: remove unused header rect.h

ack - Original Message - > It was included in be8ff99571478deb5c8d116134f65ed2b788dbd3 but with no > use. > --- > src/channel-main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/channel-main.c b/src/channel-main.c > index 1dd52a6..77a96a3 100644 > --- a/src/channel-main.c

[Spice-devel] [PATCH v4 1/2] protocol: learn to describe fd passing in messages

f-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- python_modules/demarshal.py| 4 python_modules/ptypes.py | 9 + python_modules/spice_parser.py | 3 ++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/python_modules/demarshal.py b/python_modu

[Spice-devel] [PATCH v4 0/2] protocol: add gl scanout support

o require a draw_done reply - use exisiting MonitorConfig to identify monitor position in the scanout Marc-André Lureau (2): protocol: learn to describe fd passing in messages protocol: add unix GL scanout messages python_modules/demarshal.py| 4 python_modules/ptypes.py

[Spice-devel] [PATCH v4 2/2] protocol: add unix GL scanout messages

for other streaming methods, but this protocol change should be enough for basic virgl or other gpu-accelerated support) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- spice.proto | 26 +- spice/enums.h| 9 + spice/protocol.h | 1 +

Re: [Spice-devel] [PATCH v4 1/2] protocol: learn to describe fd passing in messages

> > > > Even if there is no fd to send (or if the fd is invalid etc), the > > receiver side expects an extra byte anyway. > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > python_modules/demarshal.py| 4 &g

Re: [Spice-devel] [PATCH] replay: better help for -s option

ack - Original Message - > -s accepts an option to delay command queueing. > > Signed-off-by: Frediano Ziglio > --- > server/tests/replay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/tests/replay.c b/server/tests/replay.c >

Re: [Spice-devel] [PATCH spice-common 1/2] marshaller: learn to describe fd passing in messages

Hi Frediano, I copied you reply from older thread here: On Mon, Dec 21, 2015 at 5:21 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > hi > > On Wed, Dec 16, 2015 at 12:27 AM, Marc-André Lureau > <marcandre.lur...@gmail.com> wrote: >> The marshaller can't

Re: [Spice-devel] [PATCH spice-protocol] Add unix GL scanout messages

ther words, if the last message received is a GL draw > > the display should switch to the GL display, if it's a 2d draw message > > the display should be switched to the client 2d canvas. > > > > (there will probably be a stipped-down "gl-only" channel in the futu

Re: [Spice-devel] [PATCH spice-protocol 1/2] marshaller: learn to describe fd passing in messages

On Tue, Nov 17, 2015 at 7:11 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Add a new type, "unix_fd", used to describe file descriptor sharing via > socket ancillary data (these messages are local only). > > The marshaller/demarshaller can't serializ

[Spice-devel] [PATCH spice-protocol] Add unix GL scanout messages

for other streaming methods, but this protocol change should be enough for basic virgl or other gpu-accelerated support) Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- v2->v3: - change flags8 for flags32 (Frediano Ziglio) spice.proto | 25 +

Re: [Spice-devel] [PATCH spice-common 1/2] marshaller: learn to describe fd passing in messages

hi On Wed, Dec 16, 2015 at 12:27 AM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > The marshaller can't serialize fd in memory stream. Instead, append the > fd to the marshaller structure. The marshaller user is responsible for > sending the fd when the message is sent.

Re: [Spice-devel] [PATCH 8/9] worker: make sure we dispatch after releasing items

Hi - Original Message - > Did you try increasing client latency or decreasing bandwidth? > I think replay utility could be useful for these tests (didn't try). Yes, it would give more reliable output with replay (same input). Also keep in mind that the behaviour depends a lot on how

[Spice-devel] RFC: drop spice-gtk gtk+ 2.0 support

Hi, With virt-viewer now dropping gtk 2.0, I don't know anyone left using the spice-gtk with gtk+ 2.0. Thus I'd like to propose that the next spice-gtk release be the last with 2.0 support. Comments? -- Marc-André Lureau ___ Spice-devel mailing list

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add unix GL scanout messages

Hi - Original Message - > > > > If you create a "primary" surface with surface_create, that's > > basically all you need to start displaying. It could quite easily > > learn to take a shm fd while keeping the rest of the Spice > > qxl/2od/canvas semantic. > > But then you still stream

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add unix GL scanout messages

Hi - Original Message - > On Fr, 2015-12-18 at 03:47 -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > > > > > > If you create a "primary" surface with surface_create, that's > > > >

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add unix GL scanout messages

Hi - Original Message - > > > Which VGA? Workflow is quite different on qxl and anything else. > > > With qxl we'll go send the guests qxl render commands over to the > > > client, and the client renders it. On the qemu/server side there is no > > > rendered primary surface, unless

Re: [Spice-devel] [PATCH v2 3/3] worker: use glib main loop

- Original Message - > From: Marc-André Lureau <marcandre.lur...@gmail.com> > > Use the glib mainloop instead of writing our own. The glib loop is both > cleaner to use and is more extensible. It is also very mature and > reduces the maintenance burden on the spic

Re: [Spice-devel] [PATCH v2 0/3] Event loop improves

gle place to maintain it indeed) -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add unix GL scanout messages

Hi - Original Message - > On Do, 2015-12-17 at 06:34 -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > > What happen with multiple monitors? Is it just not supported or a > > > > single > > > >

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add unix GL scanout messages

Hi - Original Message - > On Do, 2015-12-17 at 10:53 -0500, Marc-André Lureau wrote: > > Hi > > > > > > How whould that be compatible with the spice MonitorConfig messages? I > > > > don't think it's necessary, and it could easily be added lat

Re: [Spice-devel] [PATCH 8/9] worker: make sure we dispatch after releasing items

Hi - Original Message - > On Wed, 2015-12-16 at 18:16 -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > I actually think that was it. The worker thread may currently block because > > the client is too slow. But then, when w

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add unix GL scanout messages

canvas. However, I would simply introduce a different message (or extend an existing surface message) >> (there will probably be a stipped-down "gl-only" channel in the future, >> or support for other streaming methods, but this protocol change should >> be enough for basic virgl

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add unix GL scanout messages

Hi - Original Message - > > What happen with multiple monitors? Is it just not supported or a single > > scan-out is used for multiple monitors? Would be sensible to add the number > > of the scan-out to support multiple monitors? > > Yes, I think we should add a scanout number here.

Re: [Spice-devel] [PATCH 8/9] worker: make sure we dispatch after releasing items

Hi - Original Message - > > > It seems that "watch" is related to watches on non-Dispatcher fds, and > "dispatch" is related to the watch on the Dispatcher fd. > > Items can be released in the "display" stage when we try to queue pipe items > when the client is not connected (see

Re: [Spice-devel] [PATCH spice 14/18] Add new spice-gl stubs API

e() > > > > Two new fields are also added to QXLState, in order to save the current > > scanout, and the pending async. > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > > --- > > server/red-dispatcher.c | 34 ++

Re: [Spice-devel] [PATCH spice 12/18] Declare AsyncCommand in red-common

gt; The reasoning looks a bit weak to me. Why? I just wanted to store the current gl-draw AsyncCommand in QXLState. > > Frediano > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > > --- > > server/red-common.h | 2 ++ > > server/red

Re: [Spice-devel] [PATCH spice 12/18] Declare AsyncCommand in red-common

; > > like for dispatcher Correct, that seems to be a common practice in Spice server code. I'll change the series to use that instead then. However, it would be nice to consider having the common typedefs in common imho. It doesn't make sense to me that in some header you can use &quo

Re: [Spice-devel] [PATCH spice 02/18] build-sys: build a utility libserver.la

Hi - Original Message - > On Wed, Dec 16, 2015 at 12:49:16AM +0100, Marc-André Lureau wrote: > > This allow tests programs to link with statically built library to access > > all symbols > > configure.ac now has LT_INIT([disable-static]), will static libraries

<    5   6   7   8   9   10   11   12   13   14   >