[Spice-devel] [PATCH] drm/qxl: Complete exception handling in qxl_device_init()

2019-11-07 Thread Markus Elfring
From: Markus Elfring Date: Thu, 7 Nov 2019 18:05:08 +0100 A coccicheck run provided information like the following. drivers/gpu/drm/qxl/qxl_kms.c:295:1-7: ERROR: missing iounmap; ioremap on line 178 and execution via conditional on line 185 Generated by: scripts/coccinelle/free/iounmap.cocci

Re: [PATCH] drm/qxl: fix null pointer dereference in qxl_add_mode

2024-06-30 Thread Markus Elfring
> In qxl_add_mode(), the return value of drm_cvt_mode() is assigned to mode, > which will lead to a possible NULL pointer dereference on failure of > drm_cvt_mode(). Add a check to avoid npd. 1. Can a wording approach (like the following) be a better change description? A null pointer is store