in
future, there won't be necessary to poll every 2 sec. to check spicec
status.
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
>From 30f5a4d57ceabdafde3ff1331662e8163d173e65 Mon Sep 17 00:00:00 2001
From: Peter Hatina
Date: Thu, 25 Aug 2011 11:43:37 +0200
Subjec
localhost tesing based on spice-x test page.
-Original Message-
Hi,
On 08/25/2011 11:51 AM, Peter Hatina wrote:
> Hello guys,
>
> I did some changes in spice-xpi. Now the plugin is capable to call
> JavaScript function "OnDisconnected(ErrCode)" which makes our User
Hi,
as Marc-Andre has decided to drop log4cpp, I would like to at least
revert the part of the message format. The reason is simple, Spice-QA
guys are developing a test framework, which uses the log4cpp format we had.
Opinions?
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
surprised.
glog is missing the "modified" method name, which is added by the patch.
QA guys rely especially on the method name.
I am not against dropping log4cpp.
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On 03/13/2012 01:26 PM, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Mar 13, 2012 at 12:29:01PM +0100, Peter Hatina wrote:
>> Hi,
>>
>> as Marc-Andre has decided to drop log4cpp, I would like to at
>> least revert the part of the message format. The reaso
, as it tends to break very easily...
>
Why not? Simply, in custom handler I can not get __PRETTY_FUNCTION__ to
the caller. It's substituted by the handler function name.
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
___
Spice
t; --
>> Marc-André Lureau
>> _______
>> Spice-devel mailing list
>> Spice-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
Ack, if there is no log file placed in ~/.spicec, the directory is
useless from spice-xpi point of view.
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
tle);
>> +size_t found = -2;
>> +while ((found = title.find("%", found + 2)) != std::string::npos)
>> +title.replace(found, 1, "%%");
>> +LOG_DEBUG(title);
>> return stringCopy(m_title);
>> }
>
> Hmm, I think I understand why you did this, because we use C
> printf-like g_log functions in the end, but we can't add use
> LOG_DEBUG("%s", title) sadly.
>
Yes, exactly!
> Maybe the g_log functions should be called like g_debug("%s", msg)
> instead, since they are not doing the formating anyway?
>
> thanks!
>
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi,
can you have a look at this, before I can push it to FDO git?
>From fef8de569a7268bed272105649941b9dac5f4f98 Mon Sep 17 00:00:00 2001
From: Peter Hatina
Date: Mon, 2 Apr 2012 12:11:20 +0200
Subject: [PATCH 1/4] remove unused class member
---
SpiceXPI/src/plugin/plugin.h |1 -
1 fi
Hi,
On 04/02/2012 01:41 PM, Hans de Goede wrote:
> Hi,
>
> I assumed you've tested things still compile and work after this?
>
> If so ack.
>
> Regards,
>
> Hans
Yes. Btw, the member m_fIPC was not used at all.
>
>
> On 04/02/2012 12:30 PM, Peter
Hi,
can you do a review for me?
>From 18f6fcabe35be03fe88f1a08b79e22ef505bbacd Mon Sep 17 00:00:00 2001
From: Peter Hatina
Date: Tue, 3 Apr 2012 13:35:55 +0200
Subject: [PATCH] Validate port values
---
SpiceXPI/src/plugin/plugin.cpp | 29 +++--
1 files changed,
---
SpiceXPI/src/plugin/plugin.cpp | 32 ++--
1 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index de7afd0..19f7716 100644
--- a/SpiceXPI/src/plugin/plugin.cpp
+++ b/SpiceXPI/src/plugin/p
we really want to proceed if any of the value is incorrect? I would say no.
You mean, when there is one of the values valid and the other invalid?
That's what I was asking on #spice. I do not know, if spicec/virt-viewer
can work only with secure port. With
Hi,
On 04/03/2012 04:40 PM, Marc-André Lureau wrote:
>
>
> - Mensaje original -
>> On Tue, Apr 03, 2012 at 03:56:12PM +0200, Peter Hatina wrote:
>>> On 04/03/2012 03:39 PM, Marc-André Lureau wrote:
>>>>
>>>>
>>>> - Mensaje
Log port value, if it is invalid only.
---
SpiceXPI/src/plugin/plugin.cpp | 32 ++--
1 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index de7afd0..c211395 100644
--- a/SpiceXPI/src/plugi
eXPI/src/plugin/plugin.h
> @@ -180,7 +180,7 @@ private:
> void SendInit();
> void SendMsg(uint32_t id);
> void SendValue(uint32_t id, uint32_t value);
> -void SendStr(uint32_t id, const char *str);
> +void SendStr(uint32_t id, s
LOG_ERROR("invalid port: " << m_port);
>
> I would return too in this case, we were given invalid values.
As I have understood, we can continue with one valid port.
>
>> +if (sport < -1)
>> +LOG_ERROR("invalid secure p
Done.
---
SpiceXPI/src/plugin/plugin.cpp | 37 +++--
1 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index de7afd0..2e013d7 100644
--- a/SpiceXPI/src/plugin/plugin.cpp
+++ b/SpiceXPI/
Hi all,
I am glad to announce the first public free open source software release
of the spice-xpi. To download the source tarballs, visit the page
http://www.spice-space.org/download.html
Peter Hatina
___
Spice-devel mailing list
Spice-devel
gt; +while ((found = m_ssl_channels.find(name, found)) !=
> std::string::npos) {
> +m_ssl_channels.replace(found, strlen(name), name+1);
> +}
> +}
> +/* Backward Compatibility: End */
> }
>
> //* attribute string TrustStore;
Hi,
can you, please, have a look at this? Due to script structure
(/usr/libexec/spice-xpi-client), we need to signal a process group
to correctly tear down spicec/remote-viewer. This should fix
rhbz#810583
Thanks,
-Peter
---
SpiceXPI/src/plugin/plugin.cpp |4 +++-
1 files changed, 3 insert
for a simple plugin.
Please, have a look at this and give me your opinions. If we are OK,
I would like to push this to the spice-xpi (fdo) repo.
Footnote: there is a simple makefile included for local try. It will
be replaced by the build system used by spice-xpi project.
Cheers,
Peter Hatina
EME
On 06/27/2012 04:40 PM, Marc-André Lureau wrote:
> Hi
>
> - Mensaje original -
>> On Wed, Jun 27, 2012 at 02:00:48PM +0200, Peter Hatina wrote:
>>> Hi,
>>>
>>> David Jasa gave me an input to create some tool for automatic
>>> generation
Hi,
when finishing test page generator, I noticed, that
there are 2 attributes missing in the IDL file. I would
like to push this, are you ok with those two?
Cheers
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
---
SpiceXPI/src/plugin/nsISpicec.idl |4 +++-
1 file changed
x27;d add a comment at the beginning of the autogenerated page
> saying that it's autogenerated from idl using the generator
> found in spice-xpi and that it shouldn't be modified by hand.
Will be fixed.
>
> Christophe
...
--
Peter Hatina
EMEA ENG-Desktop Development
Red H
Hi,
I am rising spice-xpi version and also supported
versions of firefox.
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
---
SpiceXPI/src/install.rdf |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/src/install.rdf b/SpiceXPI/src/install.rdf
Hi,
On 07/09/2012 05:01 PM, Alon Levy wrote:
> On Mon, Jul 09, 2012 at 03:25:54PM +0200, Peter Hatina wrote:
>> Hi,
>>
>> I am rising spice-xpi version and also supported
> Raising.
>
> Ack.
>
> I sure hope there is a saner way then chasing the ever increas
Hi,
I fixed copy+paste typo with help option.
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
---
generator/options.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generator/options.cpp b/generator/options.cpp
index 86ea867..723ca7e 100644
--- a
Changed binary name.
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
---
generator/Makefile.am |2 +-
generator/options.cpp |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/generator/Makefile.am b/generator/Makefile.am
index b6a01f2..ce7f42c 100644
Added an info, that the test page has been autogenerated and should
not be modified.
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
---
generator/generator.cpp |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/generator/generator.cpp b/generator
Added some rules to make test.html by the generator.
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
---
data/Makefile.am | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/data/Makefile.am b/data/Makefile.am
index b47e0c0..cf2687b 100644
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/10/2012 10:58 AM, Christophe Fergeau wrote:
> On Mon, Jul 09, 2012 at 06:01:13PM +0300, Alon Levy wrote:
>> On Mon, Jul 09, 2012 at 03:25:54PM +0200, Peter Hatina wrote:
>>> Hi,
>>>
>>> I am rising
Another try.
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
---
generator/Makefile.am |2 +-
generator/options.cpp |6 --
generator/options.h |1 +
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/generator/Makefile.am b/generator/Makefile.am
index
Updated global Makefile.am and also data/Makefile.am to generate
test.html.
---
Makefile.am |3 ++-
data/Makefile.am | 13 +++--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index db8e4ea..e154048 100644
--- a/Makefile.am
+++ b/Makef
endValue(CONTROLLER_FULL_SCREEN,
(m_fullscreen == PR_TRUE ? CONTROLLER_SET_FULL_SCREEN : 0) |
(m_admin_console == PR_FALSE ? CONTROLLER_AUTO_DISPLAY_RES
: 0));
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
__
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
On 07/11/2012 01:41 PM, Christophe Fergeau wrote:
> On Wed, Jul 11, 2012 at 01:03:28PM +0200, Peter Hatina wrote:
>> Hi,
>>
>> I had a request to validate TCP port values in spice-xpi, so does
>> this make sense for y
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/11/2012 02:03 PM, Uri Lublin wrote:
> On 07/11/2012 02:03 PM, Peter Hatina wrote:
>> Hi,
>>
>> I had a request to validate TCP port values in spice-xpi, so does
>> this make sense for you?
>>
>> M
(m_fullscreen == PR_TRUE ? CONTROLLER_SET_FULL_SCREEN : 0) |
(m_admin_console == PR_FALSE ? CONTROLLER_AUTO_DISPLAY_RES
: 0));
--
Peter Hatina
EMEA ENG-Desktop Development
Red Hat Czech, Brno
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
name.c_str(), &buf))
+usleep(10);
+
struct sockaddr_un remote;
remote.sun_family = AF_UNIX;
if (m_name.length() + 1 > sizeof(remote.sun_path))
--
Peter Hatina
EMEA ENG-Base Operating Systems
Red Hat Czech, Brno
___
Spice-d
hile (stat(m_name.c_str(), &buf) && timeout--)
+usleep(10);
+
struct sockaddr_un remote;
remote.sun_family = AF_UNIX;
if (m_name.length() + 1 > sizeof(remote.sun_path))
--
Peter Hatina
EMEA ENG-Base Operating Sy
Hello folks,
I would like to ask you all: Do you have any feature/improvement in
mind, that can be added to spice-xpi plugin? Maybe, it is the time, when
the plugin can have it's minor version bumped up.
Thank you.
--
Peter Hatina
EMEA ENG-Base Operating Systems
Red Hat Czech,
Hi,
I would like to inform you, that we have a new release of spice-xpi
plugin for NPAPI-based browsers. Current version is available at
www.spice-space.org or in git repo. There are also packages built for
Fedora 18 and rawhide.
--
Peter Hatina
EMEA ENG-Base Operating Systems
Red Hat Czech
unlink(fake_this->m_foreign_file.c_str());
fake_this->m_trust_store_file.clear();
+fake_this->m_foreign_file.clear();
return NULL;
}
--
Peter Hatina
EMEA ENG-Base Operating Systems
Red Hat Czech, Brno
___
Spice-devel mailin
Hi,
of course, it is not. That's why I put there a rhbz link.
On 04/09/2013 02:20 PM, Christophe Fergeau wrote:
> On Tue, Apr 09, 2013 at 12:16:38PM +0200, Peter Hatina wrote:
>> Hi,
>>
>> this should fix
>> https://bugzilla.redhat.com/show_bug.cgi?id=882339
Hi,
I made a few modifications to XPI's test page generator. Most of them are
related to javascript casting. I also modified autotools, so the generator
binary is *not* installed, when compiled.
Cheers
Peter Hatina (6):
add parseInt() and parseFloat() into Generator::generateConnec
eturn true;
+}
+
+return false;
+}
diff --git a/generator/generator.h b/generator/generator.h
index 0a9bd3f..3dfde3a 100644
--- a/generator/generator.h
+++ b/generator/generator.h
@@ -47,6 +47,7 @@ private:
static std::string attributeToHtmlElement(const Attribute &attr);
static
r.cpp
@@ -251,7 +251,7 @@ std::string Generator::attributeToHtmlElement(const
Attribute &attr)
std::string id = lowerString(attr.getIdentifier());
if (id == "truststore") {
ss << "";
} else {
--
Peter Hatina
ENG Server Experience, Sy
Toggled\").checked ?\n"
<< "
document.getElementById(\"SetLanguageStringssection\").value : \"\";\n"
--
Peter Hatina
ENG Server Experience, System Management
Red Hat Czech, Brno
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
BUILD_GENERATOR
-bin_PROGRAMS= spice-xpi-generator
+noinst_PROGRAMS = spice-xpi-generator
spice_xpi_generator_SOURCES = \
attribute.h \
generator.cpp \
--
Peter Hatina
ENG Server Experience, System Management
Red Hat Czech, Brno
ed.SetLanguageStrings(section, lang);\n"
<< "log(\"Language Strings set to '\" + section + \"' '\" +
lang + \"'\");\n}\n\n"
- << "function setUsbFilter()\n{\n"
+ << "
uot;')\""
- << (methodEnabled(*itm, *itp) ? "checked" : "")
+ << (methodEnabled(*itm, *itp) ? " checked" : "")
<< "/>\n" <<
splitIdentifier(itm->getIdentifier())
51 matches
Mail list logo
