[Spice-devel] [PATCH] Grab keyboard based on session focus

When using multiple monitors moving mouse between monitors releases keyboard grab. Reproduce bug -Open multiple monitors remote-viewer session -Click on one of the monitors to get focus & keyboard-grab -Move mouse to another monitor and try any keyboard command (do not click) At this point all

[Spice-devel] [PATCH] fix spelling mistakes in comments (reseting to resetting & dummym to dummy)

--- server/glz_encoder_dictionary.c | 2 +- server/red_channel.c| 4 ++-- server/red_worker.c | 2 +- server/reds.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/glz_encoder_dictionary.c b/server/glz_encoder_dictionary.c

[Spice-devel] [spice-gtk PATCH v4] Grab keyboard based on session focus

When using multiple monitors moving mouse between monitors releases keyboard grab. Reproduce bug -Open multiple monitors remote-viewer session -Click on one of the monitors to get focus & keyboard-grab -Move mouse to another monitor and try any keyboard command (do not click) At this point all

[Spice-devel] [spice-gtk PATCH v5] Grab keyboard based on session focus.

When using multiple monitors moving mouse between monitors releases keyboard grab. Reproduce bug -Open multiple monitors remote-viewer session -Click on one of the monitors to get focus & keyboard-grab -Move mouse to another monitor and try keyboard command (do not click) At this point all

[Spice-devel] [spice-gtk PATCH v3] Grab keyboard based on session focus

When using multiple monitors moving mouse between monitors releases keyboard grab. Reproduce bug -Open multiple monitors remote-viewer session -Click on one of the monitors to get focus & keyboard-grab -Move mouse to another monitor and try any keyboard command (do not click) At this point all

[Spice-devel] [PATCH v7 server] LZ4 compression is now available at the Spicevmc channel

ata_size > COMPRESS_THRESHOLD && !AF_LOCAL data will be sent compressed otherwise data will be sent uncompressed (also if compression has failed) Update the required protocol to 0.12.12 Signed-off-by: Frediano Ziglio <fzig...@redhat.com> Signed-off-by: Snir Sheriber <ssher...@redhat.com&g

[Spice-devel] [PATCH v7 spice-protocol] LZ4 compression is now available at the Spicevmc channel

ref to add the compressed data Signed-off-by: Snir Sheriber <ssher...@redhat.com> --- spice/enums.h| 9 + spice/protocol.h | 4 2 files changed, 13 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index c6e9840..1d0c2db 100644 --- a/spice/enums.h +++ b/spice/enums.h

[Spice-devel] [PATCH v7 spice-common 3/3] Add LZ4 data compression and use it in spicevmc channel

com> Signed-off-by: Snir Sheriber <ssher...@redhat.com> --- common/client_marshallers.h | 1 + common/messages.h | 7 +++ configure.ac| 2 +- spice.proto | 24 4 files changed, 33 insertions(+), 1 deletion(-) diff --

[Spice-devel] [PATCH v7 spice-common 1/3] add a check for negate cases on enumerations

From: Frediano Ziglio --- python_modules/ptypes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 74f3e55..1f4e068 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -686,6 +686,7 @@ class

[Spice-devel] [PATCH v7 spice-common 2/3] extend a comment for type attributes

From: Frediano Ziglio Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 1f4e068..f4a09f7 100644 ---

[Spice-devel] [PATCH v7] LZ4 Usbredir compression

This is all the parts of the usbredir lz4 compression with the latest fixes changes from v6 -squashed with previous commits & with the proposed changes by Frediano -more info inside the commit msgs -minor fixes -- 2.5.5 ___ Spice-devel mailing list

[Spice-devel] [PATCH server 7/7] Update the required protocol to 0.12.12

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index c743875..856833b 100644 --- a/configure.ac +++ b/configure.ac @@ -98,7 +98,7 @@ AS_IF([test x"$have_smartcard" = "xyes"], [ AS_VAR_APPEND([SPICE_REQUIRES], [" libcacard >=

[Spice-devel] [PATCH spice-gtk 0/4] Usbredir LZ4 compression v6

This is all the parts of the usbredir lz4 compression with the latest fixes and according to the proposed changes by Frediano Snir Sheriber (4): Usbredir: enable lz4 compression Compatibility with the improved lz4 protocol Avoid from sending data that is not compressible with LZ4 Update

[Spice-devel] [PATCH server 2/7] style, indentation and casts

From: Frediano Ziglio --- server/spicevmc.c | 85 --- 1 file changed, 44 insertions(+), 41 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index be924df..f2b3be3 100644 --- a/server/spicevmc.c +++

[Spice-devel] [PATCH spice-common 4/5] extend a comment for type attributes

From: Frediano Ziglio Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 1f4e068..f4a09f7 100644 ---

[Spice-devel] [PATCH server 5/7] spicevmc: do not use recv_device_from_client_buf sending compressed data

From: Frediano Ziglio Allocate buffer directly from RedCharDevice. This avoids to attach a buffer to SpiceVmsState just for detaching in the same function. RedCharDevice already use pooling on RedCharDeviceWriteBuffer. Signed-off-by: Frediano Ziglio ---

[Spice-devel] [PATCH spice-common 1/5] Add LZ4 data compression and used it in spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data --- common/client_marshallers.h | 1 + common/messages.h | 7 +++

[Spice-devel] [PATCH spice-gtk 1/4] Usbredir: enable lz4 compression

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [PATCH server 6/7] spicevmc: handle any possible future compression sending compressed data

From: Frediano Ziglio Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index 28ea8e9..19ce4c6 100644 ---

[Spice-devel] [PATCH spice-gtk 4/4] Update required spice-protocol to 0.12.12

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7f29c66..c44b9b7 100644 --- a/configure.ac +++ b/configure.ac @@ -69,7 +69,7 @@ AC_CHECK_LIBM AC_SUBST(LIBM) AC_CONFIG_SUBDIRS([spice-common])

[Spice-devel] [PATCH spice-gtk 2/4] Compatibility with the improved lz4 protocol

--- src/channel-usbredir.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index 2a7282c..f09b0bf 100644 --- a/src/channel-usbredir.c +++ b/src/channel-usbredir.c @@ -642,20 +642,15 @@ static

[Spice-devel] [PATCH spice-common 5/5] Update required spice-protocol to 0.12.12

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f8ff024..c3ad5a4 100644 --- a/configure.ac +++ b/configure.ac @@ -28,7 +28,7 @@ AM_PROG_CC_C_O SPICE_CHECK_SYSDEPS # Checks for libraries -PKG_CHECK_MODULES([PROTOCOL],

[Spice-devel] [PATCH spice-gtk 3/4] Avoid from sending data that is not compressible with LZ4

--- src/channel-usbredir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index f09b0bf..0b1cd47 100644 --- a/src/channel-usbredir.c +++ b/src/channel-usbredir.c @@ -677,7 +677,7 @@ static int

[Spice-devel] [PATCH spice-common 3/5] add a check for negate cases on enumerations

From: Frediano Ziglio Not supported by code so trigger an error to avoid invalid uses Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py

[Spice-devel] [PATCH server 3/7] spicevmc: do not bound compression on bound length

From: Frediano Ziglio This avoid that on full buffers compression is not attempted Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c

[Spice-devel] [PATCH server 4/7] spicevmc: avoid to send data not compressible with LZ4

From: Frediano Ziglio Send uncompressed instead. Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index dce0dc6..d7ef5ba 100644 ---

[Spice-devel] [PATCH spice-common 2/5] fix wrong assert check

From: Frediano Ziglio The assert were never triggered as always True Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py

[Spice-devel] [PATCH protocol] LZ4 compression is now available at the Spicevmc channel

-New message type for compressed messages has been added to the protocol -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added --- spice/enums.h| 10 ++ spice/protocol.h | 4 2 files changed, 14 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index

Re: [Spice-devel] [PATCH v7 spice-gtk] Usbredir: enable lz4 compression

Hi, On 06/27/2016 04:44 PM, Victor Toso wrote: Hi, On Sun, Jun 26, 2016 at 04:44:42PM +0300, Snir Sheriber wrote: Hi, On 06/24/2016 06:57 PM, Victor Toso wrote: Hi, On Mon, Jun 13, 2016 at 07:54:34PM +0300, Snir Sheriber wrote: Compressed message type is CompressedData which contains

Re: [Spice-devel] [PATCH v7 spice-gtk] Usbredir: enable lz4 compression

Hi, On 06/24/2016 06:57 PM, Victor Toso wrote: Hi, On Mon, Jun 13, 2016 at 07:54:34PM +0300, Snir Sheriber wrote: Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes-exists only if data was compressed) followed

[Spice-devel] [spice-gtk PATCH v2] Usbredir: enable lz4 compression

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [PATCH] usbredir_handle_msg: rename data to err_data

To better reflect what this variable is used for and change the declare location such that it will be declared only if it should --- src/channel-usbredir.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index

[Spice-devel] [spice-gtk PATCH] Usbredir: enable lz4 compression

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [spice-protocol PATCH] LZ4 compression is now available at the Spicevmc channel

-New message type for compressed messages has been added to the protocol -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added --- spice/enums.h| 10 ++ spice/protocol.h | 4 2 files changed, 14 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index

[Spice-devel] [spice-common PATCH] Add LZ4 data compression and used it in spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data --- common/client_marshallers.h | 1 + common/messages.h | 7 +++

[Spice-devel] [server PATCH] LZ4 compression is now available at the Spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [server PATCH v2] LZ4 compression is now available at the Spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [spice-common PATCH v3] Add LZ4 data compression and used it in spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data --- common/client_marshallers.h | 1 + common/messages.h | 7 +++

[Spice-devel] [server PATCH v3] LZ4 compression is now available at the Spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [protocol PATCH v3] LZ4 compression is now available at the Spicevmc channel

-New message type for compressed messages has been added to the protocol -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added --- spice/enums.h| 10 ++ spice/protocol.h | 4 2 files changed, 14 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index

[Spice-devel] [spice-gtk PATCH v3] Usbredir: enable lz4 compression

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

Re: [Spice-devel] [PATCH 5/6] spicevmc: do not use recv_device_from_client_buf sending compressed data

Hi, On 05/17/2016 01:04 PM, Frediano Ziglio wrote: Allocate buffer directly from RedCharDevice. This avoids to attach a buffer to SpiceVmsState just for detaching in the same function. RedCharDevice already use pooling on RedCharDeviceWriteBuffer. Signed-off-by: Frediano Ziglio

[Spice-devel] [PATCH spice-gtk 0/4] Compatibility with proposed LZ4 extensions

Client compatibility with proposed LZ4 extensions by Frediano on top of lz4 v4 patch and some additional minor fixes were added Snir Sheriber (4): Usbredir: enable lz4 compression Compatibility with the improved lz4 protocol Avoid from sending data that is not compressible with LZ4 Change

[Spice-devel] [PATCH spice-gtk 1/4] Usbredir: enable lz4 compression

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [PATCH spice-gtk 3/4] Avoid from sending data that is not compressible with LZ4

--- src/channel-usbredir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index 20e0066..ddd0d1b 100644 --- a/src/channel-usbredir.c +++ b/src/channel-usbredir.c @@ -677,7 +677,7 @@ static int

[Spice-devel] [PATCH spice-gtk 4/4] Change uint32_t to int32_t

--- src/channel-usbredir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index ddd0d1b..a6cbfe0 100644 --- a/src/channel-usbredir.c +++ b/src/channel-usbredir.c @@ -796,7 +796,7 @@ static void

[Spice-devel] [PATCH spice-gtk 2/4] Compatibility with the improved lz4 protocol

--- src/channel-usbredir.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index 3e2951d..20e0066 100644 --- a/src/channel-usbredir.c +++ b/src/channel-usbredir.c @@ -642,20 +642,15 @@ static

Re: [Spice-devel] [spice-protocol PATCH v4] LZ4 compression is now available at the Spicevmc channel

Hey, On 05/10/2016 01:23 PM, Victor Toso wrote: Hi, On Thu, May 05, 2016 at 02:43:33PM +0300, Snir Sheriber wrote: -New message type for compressed messages has been added to the protocol -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added Let's keep the commit messages under 72

Re: [Spice-devel] [spice-common PATCH v4] Add LZ4 data compression and used it in spicevmc channel

32PM +0300, Snir Sheriber wrote: Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data --- common/client_marshallers.h | 1 + common/

Re: [Spice-devel] [server PATCH v3] LZ4 compression is now available at the Spicevmc channel

Hey, On 04/30/2016 12:32 PM, Victor Toso wrote: Hey, On Wed, Apr 27, 2016 at 07:03:21PM +0300, Snir Sheriber wrote: Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes

[Spice-devel] [PATCH server] Using already exists function instead of SPICE_CONTAINEROF

Using spicevmc_red_channel_client_get_state(rcc) (which already exists) instead of SPICE_CONTAINEROF(rcc->channel, SpiceVmcState, channel). --- server/spicevmc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index

[Spice-devel] [spice-gtk PATCH v4] Usbredir: enable lz4 compression

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [server PATCH v4] LZ4 compression is now available at the Spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available && data_size >

[Spice-devel] [spice-common PATCH v4] Add LZ4 data compression and used it in spicevmc channel

Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data --- common/client_marshallers.h | 1 + common/messages.h | 7 +++

[Spice-devel] [spice-protocol PATCH v4] LZ4 compression is now available at the Spicevmc channel

-New message type for compressed messages has been added to the protocol -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added --- spice/enums.h| 10 ++ spice/protocol.h | 4 2 files changed, 14 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index

[Spice-devel] [PATCH server] coverity: avoid double free (82258)

Assign qxl to NULL if red_replay_data_chunks_free(which also free qxl) is being called --- server/red-replay-qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c index 281bc7a..09e79b8 100644 --- a/server/red-replay-qxl.c +++

[Spice-devel] [PATCH server] coverity: avoid resource leak (82248)

free data(SpiceChunks) in case of an error --- server/red-parse-qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c index 18b7ea6..915056a 100644 --- a/server/red-parse-qxl.c +++ b/server/red-parse-qxl.c @@ -378,6 +378,7 @@ static SpiceChunks

Re: [Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

Hi, On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau While reviewing lz4 patch, I found that there are potential leaks. This is untested, fyi. It would be nice if someone could confirm with running ASAN for example. Thanks for

Re: [Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

unning ASAN for example. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Snir Sheriber <ssher...@redhat.com> --- src/channel-usbredir.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbred

[Spice-devel] [PATCH] User-Manual: mention webdav is disabled by default

--- docs/manual/manual.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt index 5b31b3d..bb9006a 100644 --- a/docs/manual/manual.txt +++ b/docs/manual/manual.txt @@ -843,9 +843,10 @@ Folder sharing == The

Re: [Spice-devel] [PATCH] User-Manual: mention webdav is disabled by default

Hi, On 08/02/2016 11:38 AM, Uri Lublin wrote: On 08/02/2016 10:45 AM, Pavel Grunt wrote: Hi Snir, On Mon, 2016-08-01 at 18:49 +0300, Snir Sheriber wrote: --- docs/manual/manual.txt | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/manual/manual.txt b/docs

Re: [Spice-devel] [PATCH v2] Usbredir: Avoid compression of isochronous devices

Hi, On 07/11/2016 07:44 PM, Marc-André Lureau wrote: Hi Snir On Mon, Jul 11, 2016 at 6:33 PM, Snir Sheriber <ssher...@redhat.com> wrote: Device is considered isochronous if one of its endpoints is defined as isochronous transfer, in that case data transfer over the usbredir c

[Spice-devel] [PATCH 2/2] Usbredir: Avoid compression of isochronous devices

Device is considered isochronous if one of its endpoints is defined as isochronous transfer, in that case data transfer over the usbredir channel will not be compressed Signed-off-by: Snir Sheriber <ssher...@redhat.com> --- src/channel-usbredir.c| 9 + src/usb-device-m

[Spice-devel] [PATCH 0/2][PATCH v8 spice-gtk] Usbredir: enable lz4 compression

Differences from v7: -Build fail was fixed (%d was used instead of %u in spice_warning) -Rebase -Avoid compression of isochronous devices Snir Sheriber (2): Usbredir: enable lz4 compression Usbredir: Avoid compression of isochronous devices configure.ac | 2 +- src

[Spice-devel] [PATCH v2] Usbredir: Avoid compression of isochronous devices

Device is considered isochronous if one of its endpoints is defined as isochronous transfer, in that case data transfer over the usbredir channel will not be compressed E.g. Camera/mic device will usually be recognised as isochronous while storage devices won't Signed-off-by: Snir Sheriber

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

Hi, On 02/20/2017 07:00 PM, Christophe de Dinechin wrote: On 19 Feb 2017, at 15:47, Snir Sheriber <ssher...@redhat.com> wrote: Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++-

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

Hi, On 02/21/2017 06:37 PM, Christophe Fergeau wrote: On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++- 1 file

[Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/src/spice-channel.c b/src/spice-channel.c index af67931..cbf1291 100644

[Spice-devel] [PATCH v2 spice-gtk 0/2] Handle failed spice authentication

that way) Snir Sheriber (2): authentication: Handle failed SASL authentication separately authentication: Handle failed spice authentication src/spice-channel.c | 52 +++- 1 file changed, 31 insertions(+), 21 deletions(-) -- 2.9.3

Re: [Spice-devel] [PATCH] Don't close all but one display during reboot.

Hi, On 01/31/2017 10:24 PM, Jonathon Jongsma wrote: When a guest is rebooted, the QXL driver gets unloaded at some point in the reboot process. When the driver is unloaded, the spice server sets a single flag to FALSE: RedWorker::driver_cap_monitors_config. This flag indicates whether the

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

On 02/22/2017 12:58 PM, Christophe Fergeau wrote: Hey, On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: The authentication type string is just for letting the user know what authentication is in use. Sorry, forgot to reply to this bit, I don't think saying "

Re: [Spice-devel] [PATCH 1/2] authentication: Handle failed SASL authentication separately

Hi, On 02/14/2017 06:42 PM, Christophe Fergeau wrote: On Mon, Feb 13, 2017 at 03:49:44PM +0200, Snir Sheriber wrote: Remove handling with failures in the SASL authentication process to separate function and display the error message as reported by the SASL client (could also display SASL

Re: [Spice-devel] [PATCH 1/2] authentication: Handle failed SASL authentication separately

geau wrote: On Wed, Feb 15, 2017 at 02:56:36PM +0200, Snir Sheriber wrote: Hi, yes, the idea is to present errors which are generated on the sasl server side, in the err window on the user/sasl-client side (only errors- without sasl_ok, continue , interact) by sending the error number to the client

[Spice-devel] [PATCH 0/2] Handle failed authentication

for display of sasl authentication msgs that will be presented according to the sasl server error number which would be sent to the client Snir Sheriber (2): authentication: Handle failed SASL authentication separately authentication: Handle failed spice authentication src/spice-channel.c | 48

[Spice-devel] [PATCH 1/2] authentication: Handle failed SASL authentication separately

Remove handling with failures in the SASL authentication process to separate function and display the error message as reported by the SASL client (could also display SASL server error message if error number was sent to the client) --- src/spice-channel.c | 42

[Spice-devel] [PATCH 2/2] authentication: Handle failed spice authentication

Changing the name of the function that now handles failures in the spice authentication process separately from the sasl authentication failures and display more suitable error message. Resolves: rhbz#1365736 --- src/spice-channel.c | 10 +- 1 file changed, 5 insertions(+), 5

[Spice-devel] [PATCH v2 2/2] autotools: compile gst-test only if gstreamer is available

Needed in order to avoid compilation error when gstreamer is unavailable --- server/tests/Makefile.am | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index f696f9f..af0bd20 100644 --- a/server/tests/Makefile.am +++

[Spice-devel] [PATCH v2 1/2] autotools: Add automake conditional for gstreamer

Adding conditional for having gstreamer_0_10 or gstreamer_1_0 (and also a preprocessor symbol), removing the previous conditionals and update relevant ifdefs with the newly defined changes --- configure.ac | 7 +-- server/Makefile.am | 8 +---

[Spice-devel] [PATCH v3 1/2] autotools: Add automake conditional for gstreamer

Adding conditional for having gstreamer_0_10 or gstreamer_1_0, removing the previous conditionals and update relevant ifdefs with the newly defined conditional --- configure.ac | 3 +-- server/Makefile.am | 8 +--- server/reds.c | 4

[Spice-devel] [PATCH 1/3] autotools: Add automake conditional for gstreamer

Adding conditional for having gstreamer_0_10 or gstreamer_1_0 --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index a78b4ec..f95239b 100644 --- a/configure.ac +++ b/configure.ac @@ -101,6 +101,7 @@ if test "x$enable_gstreamer" != "xno" && test

[Spice-devel] [PATCH 0/3]autotools: Some gstreamer related minor build fixes

Autotools fixes related to gstreamer, basically adding am conditional and avoiding compilation error when gstreamer is unavailable Snir Sheriber (3): autotools: Add automake conditional for gstreamer autotools: compile gst-test only if gstreamer is available Update ifdefs for gstreamer

[Spice-devel] [PATCH 3/3] Update ifdefs for gstreamer availability

Using ifdefs with the recently defined conditional for having gstreamer_0_10 or gstreamer_1_0 --- server/Makefile.am | 8 +--- server/reds.c | 4 ++-- server/tests/test-codecs-parsing.c | 4 ++-- server/video-encoder.h | 2 +- 4 files changed,

[Spice-devel] [PATCH 2/3] autotools: compile gst-test only if gstreamer is available

Needed in order to avoid compilation error when gstreamer is unavailable --- server/tests/Makefile.am | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index f696f9f..55ace5b 100644 --- a/server/tests/Makefile.am +++

[Spice-devel] [RFC] Adding compression to the webdav folder sharing

(not sure if these are the right places to do so). Another thing is that the code is almost the same as in the usbredir,so it may be better to implement it for both channels somewhere else (spice-channel? suggestions? ) Thanks, Snir. Snir Sheriber (1): Adding compression to the webdav folder

[Spice-devel] [RFC] Adding compression to the webdav folder sharing

Adding lz4 compression same as in spicevmc channel. Compression will be enabled only if LZ4 is in use && socket is not AF_LOCAL type (local) && data size is under threshold && host has lz4 compression capability. -handling compressed msgs is implemented in src/channel-webdav.c -compression of

Re: [Spice-devel] [client] spicy: Spicy uses GTK+ and must link with it

Hi On 02/24/2017 01:23 PM, Francois Gouget wrote: This avoids having the linker complain that gtk_toggle_action_get_type() or some other GTK+ API is undefined. Does this function is in use somewhere ? grep didn't find it and it works for me.. Snir. Signed-off-by: Francois Gouget

Re: [Spice-devel] Multi-head Spice

Hi, On 02/28/2017 09:58 AM, Christophe Fergeau wrote: On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote: I tried to setup a multi-head guest, but I’m having trouble getting multiple displays to work correctly

Re: [Spice-devel] Multi-head Spice

On 02/28/2017 11:41 AM, Christophe de Dinechin wrote: On 28 Feb 2017, at 08:58, Christophe Fergeau > wrote: On Mon, Feb 27, 2017 at 04:18:12PM -0600, Jonathon Jongsma wrote: On Mon, 2017-02-27 at 17:53 +0100, Christophe de Dinechin wrote:

[Spice-devel] [spice-gtk PATCH v3 2/2] authentication: Handle failed spice authentication

Changing the name of the failures handling function (spice and sasl authentication failures are now treated separately) and display more suitable spice authentication failure error message. Resolves: rhbz#1365736 --- src/spice-channel.c | 10 +- 1 file changed, 5 insertions(+), 5

[Spice-devel] [spice-gtk PATCH v3 1/2] authentication: Handle failed SASL authentication separately

Move SASL authentication failures handling to a separate function. Multiple error messages asking for username\password were removed because they are not necessarily the reason for the failure (avoiding similar issue as in rhbz#1365736). Letting the user know about required username\password

[Spice-devel] [spice-gtk PATCH v3 0/2] Handle failed spice authentication

Differences from v2: -more informative commit messages -removing authentication type from error messages -rebase Snir Sheriber (2): authentication: Handle failed SASL authentication separately authentication: Handle failed spice authentication src/spice-channel.c | 50

Re: [Spice-devel] [PATCH spice-gtk] RFC: Update NEWS for 0.33 release

Hi On 10/06/2016 11:38 AM, Pavel Grunt wrote: ACK On Thu, 2016-10-06 at 11:47 +0400,marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- NEWS | 16 1 file changed, 16

[Spice-devel] [spice-gtk PATCH v3] Avoid compression of isochronous devices

Device is considered isochronous if one of its endpoints is defined as isochronous transfer, in that case data transfer over the usbredir channel will not be compressed (it is assumed that there is a strong correlation between isochronous devices and devices which their data is usually compressed)

[Spice-devel] [spice-gtk PATCH v3]Avoid compression of isochronous devices

Similar to v2 but rebased and adding the rational behind this idea to commit message Snir Sheriber (1): Avoid compression of isochronous devices src/channel-usbredir.c| 9 + src/usb-device-manager-priv.h | 1 + src/usb-device-manager.c | 34

Re: [Spice-devel] Now available: x11spice utility

Hi, I've tried your x11spice utility , works well! We were thinking about doing something similar for Wayland, have you thought how it can be done under Wayland? basically the main difference is getting the post-compositor-buffer/damages, isn't it? Any comments or suggestions are welcomed

[Spice-devel] [PATCH v3] tests: Fix compilation error

Fix compilation error due to -Werror=maybe-uninitialized: CC test-display-base.o test-display-base.c: In function 'do_wakeup': test-display-base.c:579:13: error: 'update' may be used uninitialized... push_command(>ext); Signed-off-by: Snir Sheriber <ssher...@redh

[Spice-devel] [PATCH v4] tests: Fix compilation error

Fix compilation error due to -Werror=maybe-uninitialized: CC test-display-base.o test-display-base.c: In function 'do_wakeup': test-display-base.c:579:13: error: 'update' may be used uninitialized... push_command(>ext); Signed-off-by: Snir Sheriber <ssher...@redh

[Spice-devel] [PATCH] tests: Fix compilation error

Fix compilation error due to -Werror=maybe-uninitialized: CC test-display-base.o test-display-base.c: In function 'do_wakeup': test-display-base.c:579:13: error: 'update' may be used uninitialized... push_command(>ext); Signed-off-by: Snir Sheriber <ssher...@redh

Re: [Spice-devel] Seamless Spice building

Hi, I'm not sure if spice-common has also changed, but if not- it may work with the upstream. You could try it by changing the spice-common sub-module url in the spice-gtk/.git/config file to: git://anongit.freedesktop.org/spice/spice-common Snir. On 12/18/2016 12:01 AM,

[Spice-devel] [PATCH spice-space-pages] usbredir documentation

--- page/UsbRedir.rst | 137 -- 1 file changed, 132 insertions(+), 5 deletions(-) diff --git a/page/UsbRedir.rst b/page/UsbRedir.rst index 958a086..00c8fbe 100644 --- a/page/UsbRedir.rst +++ b/page/UsbRedir.rst @@ -1,8 +1,6 @@ usbredir

  1   2   3   4   5   >