---
gtk/glib-compat.c | 27 +++
gtk/glib-compat.h |5 +
gtk/spice-channel.c |1 +
3 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/gtk/glib-compat.c b/gtk/glib-compat.c
index 7bb906c..5f2e29e 100644
--- a/gtk/glib-compat.c
+++ b/gtk/glib-com
---
gtk/channel-port.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gtk/channel-port.c b/gtk/channel-port.c
index e1f61d2..1d6eef2 100644
--- a/gtk/channel-port.c
+++ b/gtk/channel-port.c
@@ -19,6 +19,7 @@
#include "spice-common.h"
#include "spice-channel-priv.h"
#in
On 11/27/2012 04:53 PM, Arnon Gilboa wrote:
Ack series.
Lots of lines removed.
Asynchronous IO with completion functions instead of using events.
and more.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailm
On 11/25/2012 05:14 PM, Arnon Gilboa wrote:
The problem on XP was failing to terminate agent running on session>0,
since during agent process creation, a handle was not set, so it was NULL.
Therefore, the new agent created (at the session we switched to) was unable
to open vitio-serial which was
On 11/27/2012 11:16 AM, Arnon Gilboa wrote:
Currently, a SetClipboardData failure is followed by useless wait for timeout
(VD_CLIPBOARD_TIMEOUT_MS)
---
vdagent/vdagent.cpp | 30 --
1 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/vdagent/vdagent.cp
On 12/09/2012 11:42 AM, Arnon Gilboa wrote:
---
Makefile.am |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9b73def..3bd66aa 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -31,13 +31,7 @@ vdagent_SOURCES =\
Fixes the following build warning (but does not really check write return
value):
spicy.c: In function ‘port_data’:
spicy.c:1711:10: error: ignoring return value of ‘write’, declared with
attribute warn_unused_result [-Werror=unused-result]
Reported by Yaniv Kaul
---
Alternatively, if we reall
replaced with spice_error where abort is wanted.
---
server/red_worker.c | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 530562b..1ac439b 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@
On 12/13/2012 03:54 PM, Uri Lublin wrote:
replaced with spice_error where abort is wanted.
Note, that I did not change all spice_critical to spice_error.
For example for lz/quic/glz _usr_error functions I kept it as
spice_critical.
(I'm not sure about that move as there is a comme
feel about this ?
The first patch adds some 'return's upon error.
The second patch changes the default.
Uri Lublin (2):
common: prepare for not aborting on spice_critical
common: log: make error level the default abort level
common/gdi_canvas.c |3 +++
common/log.c|
diff --git a/common/gdi_canvas.c b/common/gdi_canvas.c
index deb7649..05edf68 100644
--- a/common/gdi_canvas.c
+++ b/common/gdi_canvas.c
@@ -354,6 +354,7 @@ static void set_path(GdiCanvas *canvas, SpicePath *s)
if (!LineTo(canvas->dc, (int)fix_to_double(point->x),
Instead of current abort level default which is critical level.
The spice_return_if_fail and spice_return_val_if_fail macros
log with critical level upon failure. This currently aborts
the program.
Instead it's better to log an error message and let the application
continue running.
diff --git a/
On 12/18/2012 12:56 PM, Hans de Goede wrote:
This patch adds a --hotkeys cmdline option to spicec, to allow using the
existing mechanism to override the default hotkeys from the cmdline.
I know spicec is a dead end, but I've a customer which is stuck with it for
now, and who needs this functiona
Reported-by: Michal Luscon
Found by a Coverity scan:
in handle_dev_start -
Checking "worker->display_channel" implies that "worker->display_channel"
might be NULL.
Passing "worker" to function "guest_set_client_capabilities"
in guest_set_client_capabilities -
Dire
On 12/18/2012 06:00 PM, javaon wrote:
configure process was ok, but failed to make. The below is the error
messages on screen:
make[4]: Entering directory `/usr/local/src/spice-gtk-0.14/gtk'
CCLD spicy
/usr/local/src/spice-gtk-0.14/gtk/.libs/libspice-client-glib-2.0.so:
undefined reference
On 12/21/2012 12:28 PM, Christophe Fergeau wrote:
vdlog.cpp has an #ifdef check for OLDMSVC to choose between using
swprintf or swprintf_s. Since vdcommon.h provides a compat #define
for swprintf_s when OLDMSVC is check, it's better to use this one.
---
common/vdlog.cpp | 5 +
1 file chang
On 12/21/2012 12:28 PM, Christophe Fergeau wrote:
Aliasing _ftime_s to _ftime when OLDMSVCRT is defined makes it
possible to remove the timestamp-less implementation of LOG()
while still getting a binary working on Windows XP. I've tested
this with a MinGW build, hopefully this won't break VC++ b
and confuse both the server and
the client.
Uri Lublin (5):
qxl_driver: remove unused enum ROPDescriptor
qxl_pre_init: fix calculation of available video memory
qxl_driver: check_crtc: handle qxl->crtcs == NULL
qxl_driver: simplify calling qxl_update_monitors_config
qxl_
---
src/qxl_driver.c | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index e2d08c7..e289c70 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1034,21 +1034,6 @@ qxl_switch_mode (SWITCH_MODE_ARGS_DECL)
return qx
Don't forget to substract monitors_config area.
Memory map of qxl RAM looks something like the following:
-
| |
| Surface0 Area |
| |
-
| |
| |
| Video Pages |
|
---
src/qxl_driver.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 1a253d2..d8abb7b 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1040,6 +1040,10 @@ check_crtc (qxl_screen_t *qxl)
int i, count = 0;
xf86Crt
Simplify by calling check_crtc from within qxl_update_monitors_config,
instead of calling check_crtc before every call to
qxl_update_monitors_config.
---
src/qxl_driver.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index d8abb7
Resolves: rhbz#883578
Call qxl_allocate_monitors_config upon memory-remap such
that qxl->monitors_config points to the start of
monitors_config segment in qxl RAM memory.
Currently after memory remap, it's possible that monitors_config
memory and video-memory (or graphics) overlap, which means
th
On 01/21/2013 04:16 PM, Yonit Halperin wrote:
On 01/17/2013 09:26 AM, Uri Lublin wrote:
Resolves: rhbz#883578
Call qxl_allocate_monitors_config upon memory-remap such
that qxl->monitors_config points to the start of
monitors_config segment in qxl RAM memory.
Currently after memory remap, i
On 01/21/2013 04:16 PM, Yonit Halperin wrote:
Hi,
On 01/17/2013 09:26 AM, Uri Lublin wrote:
Resolves: rhbz#883578
Call qxl_allocate_monitors_config upon memory-remap such
that qxl->monitors_config points to the start of
monitors_config segment in qxl RAM memory.
Currently after memory re
[CC'ing Arnon]
On 02/02/2013 05:30 PM, Hans de Goede wrote:
VDAgentMouseState contains a display_id and expects coordinates in multi-mon
mode to be relative to the origin of the monitor specified by the display_id.
The agent will then adjust the mouse coordinates for the position of the
monitor
On 02/04/2013 04:02 PM, Hans de Goede wrote:
Hi,
On 02/04/2013 02:52 PM, Uri Lublin wrote:
[CC'ing Arnon]
On 02/02/2013 05:30 PM, Hans de Goede wrote:
VDAgentMouseState contains a display_id and expects coordinates in
multi-mon
mode to be relative to the origin of the monitor specifi
MAPVK_VK_TO_VSC is defined in the file:
/mingw/include/winuser.h
In older mingw-headers the definition of MAPVK_VK_TO_VSC is
defined only -- #if _WIN32_WINNT >= 0x0601
---
gtk/spice-widget.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-widget.c b/gtk/sp
On 02/19/2013 12:35 PM, Marc-André Lureau wrote:
There is no need to copy files, we have the lib already, and we can
linking statically.
---
Makefile.am | 4 +-
configure.ac | 5 +-
stdint.h | 256 --
usbclerk.vcproj |
On 02/19/2013 12:35 PM, Marc-André Lureau wrote:
There is no need to copy files, we have the lib already, and we can
linking statically.
---
usbclerk.vcproj | 40 -
diff --git a/usbclerk.vcproj b/usbclerk.vcproj
index dc59ad5..b692737 100644
--- a/usbclerk.vcproj
+++ b/usbclerk.vcpr
On 02/19/2013 12:35 PM, Marc-André Lureau wrote:
---
Makefile.am | 4 ++--
usbclerk.cpp | 59
usbclerktest.cpp | 16 +++
vdlog.cpp| 2 +-
vdlog.h | 2 +-
5 files changed, 42 insertions(+), 41
On 02/19/2013 04:21 PM, Marc-André Lureau wrote:
- Mensaje original -
Doesn't this break the Visual Studio build ?
I prefer that enabling mingw- build would not break Visual Studio
build.
The patch summaries explain that I suggest it supports only MinGW build
upstream.
If there is
On 03/03/2013 09:25 AM, Amos Benari wrote:
Hi Amos,
Thanks a lot for your work on adding spice support in TheForeman !
http://theforeman.org/ (and thanks Ohad too)
As for this patch, please see one comment inline.
- Forwarded Message -
From: "Amos Benari"
To: spice-devel@lists.freedes
It seems that device_address is not consistent and port_number is for Windows.
For example the device_address may change when the WinUSB driver is
installed.
This seems to happen more for Win7 clients.
USB devices are being redir'ed by their bus_number and device_address.
When the device_address b
On 03/07/2013 11:02 AM, Hans de Goede wrote:
Hi,
On 03/07/2013 12:27 AM, Uri Lublin wrote:
It seems that device_address is not consistent and port_number is for
Windows.
For example the device_address may change when the WinUSB driver is
installed.
This seems to happen more for Win7 clients
On 03/14/2013 02:10 PM, bigclouds wrote:
spicec -h HOST -p 5900 -s 5901 --ca-file file.pem
warning:fialed to connect : connection refused(111)
Connection refused.
The qemu-kvm output (spice-server part) may contain a clue.
Also you probably need to provide a password and a host-subject.
On 03/21/2013 06:23 PM, Jeremy White wrote:
Silences a gcc warning (-Wattributes).
Signed-off-by: Jeremy White
---
src/murmurhash3.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/murmurhash3.c b/src/murmurhash3.c
index afb7d7d..0df34a7 100644
--- a/src/mur
eady
not supported, since Windows installs USB drivers for specific devices
based on their vid:pid
Uri Lublin (9):
win-usb-dev: make VID and PID available via get_property (Windows)
win-usb-dev: compare vid:pid instead of bus.addr (Windows)
usb-device-manager: constify spice_usb_device_ge
---
gtk/win-usb-dev.c | 8
1 file changed, 8 insertions(+)
diff --git a/gtk/win-usb-dev.c b/gtk/win-usb-dev.c
index c188807..0bccc7c 100644
--- a/gtk/win-usb-dev.c
+++ b/gtk/win-usb-dev.c
@@ -60,6 +60,8 @@ struct _GUdevDeviceInfo {
gchar sclass[4];
gchar sbus[4];
gchar sad
It seems that sometimes, on Win7 clients, bus.addr is changing
when WinUSB driver is being installed (e.g. 4.1 -> 4.2).
So compare vid:pid instead.
---
gtk/win-usb-dev.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/gtk/win-usb-dev.c b/gtk/win-usb-dev.c
index 0b
---
gtk/usb-device-manager-priv.h | 8
gtk/usb-device-manager.c | 16
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/gtk/usb-device-manager-priv.h b/gtk/usb-device-manager-priv.h
index 51a38df..b6fa9c9 100644
--- a/gtk/usb-device-manager-priv.h
+++
Instead of comparing directly against
In preparation of comparing against vid:pid for Windows clients.
---
gtk/usb-device-manager.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 4421c48..d58fb72 100644
Instead of comparing directly against .
In preparation of comparing against vid:pid for Windows clients.
---
gtk/usb-device-manager.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index d58fb72..b4320af 10
To be reused later.
Also implemented a get_device_descriptor function (in case it will be
needed in the future).
---
gtk/usb-device-manager.c | 58 +++-
1 file changed, 48 insertions(+), 10 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-d
When comparing spice_usb_device with a libusb_device on Windows clients,
use vid:pid instead of bus.address
It seems that a device bus.address may change when WinUSB driver
is being installed.
---
gtk/usb-device-manager.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/
rhbz#842816
Sometimes bus.address of a USB device changes upon WinUSB driver installation
for that device. This makes bus.address not a good identifier to use when
running on Windows machines.
Instead this patch makes usb-device-manager, when running on a Windows client,
identify devices by their
On Windows clients now USB devices are identified by their vid:pid
(sometimes these values are being held by variables "bus" and "addr")
Change log messages accordingly.
---
gtk/usb-device-manager.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/gtk/usb-devic
On 03/25/2013 12:17 PM, Hans de Goede wrote:
Hi,
Hi Hans,
Thanks for reviewing.
On 03/25/2013 11:01 AM, Uri Lublin wrote:
rhbz#842816
It seems that sometimes a USB device's bus.address is changing after
installation of WinUSB driver for that device.
So instead use vid:pid whic
On 03/27/2013 06:13 PM, Hans de Goede wrote:
Hi,
On 03/27/2013 04:33 PM, Uri Lublin wrote:
On 03/25/2013 12:17 PM, Hans de Goede wrote:
Hi,
Hi Hans,
Thanks for reviewing.
On 03/25/2013 11:01 AM, Uri Lublin wrote:
rhbz#842816
It seems that sometimes a USB device's bus.addre
On 03/27/2013 06:49 PM, Hans de Goede wrote:
Hi,
As discussed as a solution for this *for now*, this series looks good,
ACK series.
One remark, which can be fixed with an add on patch, or added to patch 9,
around line 734 (in unpatches sources), in
spice_usb_device_manager_add_dev,
there is
On 04/03/2013 07:51 PM, Ignazio Cassano wrote:
Hi all, I do not know if this is the correct emailing list to ask about my
problem, any case I am very interested to know about spice-xpi .
I created a java script for launching the spice-xpi plugin but I'd like to know
what TrustStore parameter must
On 04/10/2013 10:58 AM, Christophe Fergeau wrote:
barrier.h is no longer used anywhere
---
spice/Makefile.am | 1 -
spice/barrier.h | 55 ---
spice/qxl_dev.h | 1 -
3 files changed, 57 deletions(-)
delete mode 100644 spice/barrier.h
Hi Marc-Andre,
Looks good, with two comments:
On 04/09/2013 10:02 PM, Marc-André Lureau wrote:
Following discussion on the ML:
http://lists.freedesktop.org/archives/spice-devel/2013-April/012953.html
---
README | 2 +-
gtk/Makefile.am | 12 ++--
gtk/snappy.c| 178 --
On 04/26/2013 02:41 PM, Itamar Heim wrote:
On 04/25/2013 07:50 PM, Ryan Wilkinson wrote:
Can't seem to get an answer as to if usb pass-through is supported from
a Windows IE 8 or 9 client over Spice??
iirc, yes.
adding spice-devel though
Spice usbredir works on Windows clients, with some l
rhbz#958051
It may be that a _displays entry will be NULL.
I encountered it when running with multiple QXL devices, for one of
which the driver failed to load since it was "out of resources"
Iterations over _displays should handle that case.
I found three such iterations, and fixed them in this p
On 05/03/2013 01:57 AM, Marc-André Lureau wrote:
Hi
On Tue, Apr 30, 2013 at 12:10 PM, Uri Lublin <mailto:u...@redhat.com>> wrote:
if (display_count) {
There is at least one more use you forgot, and that caused still a crash
if (min_x || min_y) {
On 05/03/2013 02:03 AM, Marc-André Lureau wrote:
So when this happens (even if the agent is fixed to not crash), then
we get randomly loaded drivers assigned to channels
A guest monitor 3 might end up on display channel 4 if for example,
driver failed to load for card associated to display cha
On 04/24/2013 07:24 PM, Frank Fraijo wrote:
I have RH Desktop Virt 6.4 running on a physical server. I'm able to get spice
running on it with no issue. At my local windowsXP work station, I've
installed the latest Virtviewer ( spice windows download ).
I'm not able to connect. I've tried s
rhbz#958051
It may be that a _displays entry will be NULL.
I encountered it when running with multiple QXL devices, for one of
which the driver failed to load since it was "out of resources".
Iterations over _displays should handle that case.
We found four such iterations, and fixed them in this
On 05/09/2013 05:26 PM, Marc-André Lureau wrote:
Looking at remaining usage, shouldn't it protect against delete mode in
DesktopLayout::clean_displays() too?
Thanks for reviewing again.
Calling delete NULL is safe.
Some think that it's better not to test for NULL when calling delete.
Others c
On 05/12/2013 12:34 PM, agil...@redhat.com wrote:
it's ok. pushed.
Thanks.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On 05/13/2013 02:12 PM, Christophe Fergeau wrote:
Hi,
I'm not sure anyone answered that, so here's my take on this ;)
On Mon, Apr 22, 2013 at 02:50:13AM -0400, John/Amy Frye wrote:
Dear Spice Developers:
When I run spicec to connect securely to a virtual machine, it exits
leaving me only with
On 05/18/2013 08:01 PM, Ryan Wilkinson wrote:
I'm trying to get usb pass-through working for Windows IE clients.
Where can I get the usbclerk service install as mentioned in this email??
On Sun, Apr 28, 2013 at 1:23 AM, Uri Lublin <mailto:u...@redhat.com>> wrote:
On 04/26
On 06/04/2013 05:19 PM, Christophe Fergeau wrote:
When parsing an URI, spice_uri_parse currently first looks up for
'/' to detect the 'path' part of the URI
(http://foo.example.com/some/path) and then the query part (starting
with '&' is looked up).
However, this does not work as expected when th
On 06/05/2013 11:23 AM, Christophe Fergeau wrote:
On Wed, Jun 05, 2013 at 11:15:47AM +0300, Uri Lublin wrote:
On 06/04/2013 05:19 PM, Christophe Fergeau wrote:
When parsing an URI, spice_uri_parse currently first looks up for
'/' to detect the 'path' part of the URI
(ht
On 06/05/2013 03:21 PM, Christophe Fergeau wrote:
On Wed, Jun 05, 2013 at 01:07:16PM +0300, Uri Lublin wrote:
In your example, query is "my_param=/some/path" and path points
to "/some/path" within query. Some may find it confusing, and it does not
follow URI syntax where pat
On 06/05/2013 07:08 PM, Uri Lublin wrote:
On 06/05/2013 03:21 PM, Christophe Fergeau wrote:
On Wed, Jun 05, 2013 at 01:07:16PM +0300, Uri Lublin wrote:
In your example, query is "my_param=/some/path" and path points
to "/some/path" within query. Some may find it confusi
It may happen (not sure how) that a single device appears
twice in the list of USB devices. Only one entry has information
for the currently installed device/driver.
If that happens, currently we just pick the first one, which
may be an invalid entry that says a nont-WinUSB (e.g. USBSTOR)
is the d
On 06/15/2013 12:07 AM, Tomáš Chaloupka wrote:
Hello,
I'm trying to use my wacom tablet on virtualized W7 over spice usb redir.
Tried it on Fedora18 (virt-viewer-0.5.4), usb redirection worked fine,
driver was installed and device is working well.
Only problem with this setup is that the table
On 06/16/2013 11:39 AM, Ivan Krutskikh wrote:
Hi
Hi Ivan,
I like spice protocol a lot and want to integrate it into Kiwi/LTSP
project in order to have hybrid terminal server/ VDI solution with
diskless client machines.
But there are some things, that I need to clear out first:
1) In orde
On 06/21/2013 04:50 PM, Yonit Halperin wrote:
DebugPrintV first locks print_sem, and then locks io_sem.
async_io, locks io_sem.
In ordr to avoid a deadlock, DebugPrintV MUSTN'T be called when
io_sem is locked.
Also notice, that locking io_sem during DebugPrintV limits our ability
to use the log_
On 06/25/2013 12:01 AM, Yonit Halperin wrote:
DebugPrintV first locks print_sem, and then locks io_sem.
async_io, locks io_sem.
In ordr to avoid a deadlock, DebugPrintV MUSTN'T be called when
io_sem is locked.
I also moved the locking of io_sem, so that reading pdev->use_async
will also be protec
On 07/04/2013 06:10 AM, Edgar wrote:
Hi all,
I want to implement 4K TV mointor support on spice client with max
resolution of 4096x2160.
but now the QXL driver only support max resolution of
2560x1600.(windows guest VM's resolution ranged from 800x600 to 2560x1600)
please advise me how to achie
On 07/05/2013 06:25 PM, Yonit Halperin wrote:
rhbz#968050
In contrast to Microsoft Msdn documentation, the iUniq of a SURFOBJ doesn't
always change when the surface changes. However, it seems that the
iUniq of the associated color_trans (XLATEOBJ) changes, while its
flXlate=XO_TRIVIAL. Since we
On 07/05/2013 03:45 PM, David Gibson wrote:
On Fri, Jul 05, 2013 at 08:35:21AM -0400, Yonit Halperin wrote:
Ack. Thanks! We have recently associated this problem with some
opened bugs we have. I believe Uri is working on a patch for a
similar fix to the red_pipes.* routines in red_worker.
https
oduced.
If people prefer, I can reorder the patches such that generic macro is
introduced in the first patch, and the other patches to use it.
Last, the FOREACH macros can be used outside of red_worker.c.
Maybe in the future we can move it to an h-file and use it e.g. in red_worker.c
Uri Lublin (8
RCC_FOREACH may be dangerous
The following patches replace FOREACH loops with a SAFE version.
Using unsafe loops may cause spice-server to abort (assert fails).
Specifically a read/write fail in those loops, may cause the client
to disconnect, removing the node currently iterated, which cause spic
The only thing that is needed is to get the channel out of the worker.
---
server/red_worker.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index a7f8d79..8503d16 100644
--- a/server/red_worker.c
+++ b/server/red_worke
Specifically, the loop in red_pipes_add_draw can cause spice to abort.
In red_worker.c (WORKER_FOREACH_DCC):
red_pipes_add_drawable
red_pipe_add_drawable
red_handle_drawable_surfaces_client_synced
red_push_surface_image
red_channel_client_push
red_channel_
---
server/red_worker.c | 11 ++-
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 0599a0e..ffd278c 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1146,13 +1146,6 @@ static inline uint64_t red_now(void);
---
server/red_worker.c | 20 +++-
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index ffd278c..72e5ea5 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1139,12 +1139,14 @@ static inline uint64_t red_now(vo
Introduce SAFE_FOREACH macro
Make other safe iterators use SAFE_FOREACH
---
server/red_worker.c | 64 ++
1 files changed, 28 insertions(+), 36 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 1f239c5..7351064 100644
--- a
Even though it is not used, it's better to make it safe (or remove it).
---
server/red_worker.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 72e5ea5..1f239c5 100644
--- a/server/red_worker.c
+++ b/server/red_wor
This was originally intended to fix the problem fixed by
commit 53488f0275d6c8a121af49f7ac817d09ce68090d.
What is left are FOREACH loops that are at less risk and maybe safe (no
read/write or disconnect/destroy are called from within them).
---
server/red_channel.c |8
1 files change
On 07/01/2013 05:35 AM, letterdove wrote:
Dear Mr/Miss,
I am experiencing spice-client software virtviewer for sevral
months.Here is my idea of it
that I found usbredir capcability of the virtviewer is unavailable on
Microsoft Windows. I've noticed
that the virtviewer developers dedicated to
On 07/08/2013 01:57 PM, Christophe Fergeau wrote:
On Mon, Jul 08, 2013 at 01:32:29PM +0300, Uri Lublin wrote:
Introduce SAFE_FOREACH macro
Make other safe iterators use SAFE_FOREACH
There's already a RING_FOREACH_SAFE() macro in spice-common/ring.h, could
it be useful here?
Hi Chris
On 07/08/2013 06:42 PM, Yonit Halperin wrote:
Hi,
On 07/08/2013 06:32 AM, Uri Lublin wrote:
RCC_FOREACH may be dangerous
The following patches replace FOREACH loops with a SAFE version.
Using unsafe loops may cause spice-server to abort (assert fails).
Specifically a read/write fail in those
When surface_id == 0, primary is used.
Otherwise (currently 1), secondary is used.
Also, remove unused test_width and test_height.
Since commit caea7699434c20dceef8fc79d21b8eeb663fbf53,
test->width and test->height are used.
---
server/tests/test_display_base.c |7 ++-
1 files changed, 2
Earlier in this function, test->target_surface is set to 1, which
is the only allowed non-primary surface currently.
If surface parameters are given (and specifically data is checked)
they are being used, otherwise a default surface is used.
Earlier in this function, "command" is set to a non-NUL
optind points to the next argument to parse.
---
server/tests/test_display_base.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index cf3990f..a4fdae9 100644
--- a/server/tests/test_display_base.c
+++ b
Otherwise, the test exits after the first iteration over all tests,
on the second attempt to create an already created surface.
---
server/tests/test_display_width_stride.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/server/tests/test_display_width_stride.c
b/
---
server/tests/test_empty_success.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/server/tests/test_empty_success.c
b/server/tests/test_empty_success.c
index ccabe6b..0176a52 100644
--- a/server/tests/test_empty_success.c
+++ b/server/tests/test_empty_success
---
server/tests/test_display_base.c | 25 +++--
1 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index a4fdae9..3312b11 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_di
---
spice-protocol |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/spice-protocol b/spice-protocol
index 7be0e88..784407f 16
--- a/spice-protocol
+++ b/spice-protocol
@@ -1 +1 @@
-Subproject commit 7be0e88e7e03a956b364cc847aad11b96ed47273
+Subproject commit 784407f248
On 07/14/2013 12:19 PM, Alon Levy wrote:
On Tue, 2013-07-09 at 19:15 +0300, Uri Lublin wrote:
ACK, just one comment that is nice to fix before pushing.
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index a4fdae9..3312b11 100644
--- a/server/tests
On 07/16/2013 06:09 AM, stonefly128 wrote:
Dear spice development team:
I'm asking for help on the spice when using two monitors in kvm
virtual machines. This is my test environment:A redhat 6.2 x64_64
server with kvm;one virtual machine using windows xp sp3 OS with two
qxl graphics cards, the
---
server/red_parse_qxl.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
index 65781e7..7d4d4a1 100644
--- a/server/red_parse_qxl.c
+++ b/server/red_parse_qxl.c
@@ -490,12 +490,8 @@ static SpiceImage *red_get_image(RedMe
---
server/char_device.h | 2 +-
server/reds.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/char_device.h b/server/char_device.h
index 99bdb2e..c17a40d 100644
--- a/server/char_device.h
+++ b/server/char_device.h
@@ -138,7 +138,7 @@ int spice_char_device_sta
---
server/char_device.c| 1 +
server/spice_timer_queue.c | 1 +
server/tests/test_vdagent.c | 2 +-
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/server/char_device.c b/server/char_device.c
index 721bd8d..792ab9c 100644
--- a/server/char_device.c
+++ b/server/char_device.
---
server/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/Makefile.am b/server/Makefile.am
index 7a52b17..d351dae 100644
--- a/server/Makefile.am
+++ b/server/Makefile.am
@@ -135,4 +135,4 @@ EXTRA_DIST =\
BUILT_SOURCE
901 - 1000 of 1198 matches
Mail list logo
