Re: [Spice-devel] [PATCH spice-gtk 1/2] Change the setting of the images cache size and the glz window size

2012-01-22 Thread Yonit Halperin
Thanks, will send a corrected version. Yonit. On 01/18/2012 04:41 PM, Alon Levy wrote: On Mon, Jan 16, 2012 at 06:15:08PM +0200, Yonit Halperin wrote: Set the default sizes to be the same as in the old linux spice client. cache_size=20M pixels (instead of 32M), window_size=8M pixels for a 64MB

[Spice-devel] [PATCH spice-gtk v2 1/2] Change the setting of the images cache size and the glz window size

2012-01-22 Thread Yonit Halperin
Set the default sizes to be the same as in the old linux spice client. cache_size=20M pixels (instead of 32M), window_size=8M pixels for a 64MB dev ram (instead of 16M pixels). --- gtk/channel-display-priv.h |2 - gtk/channel-display.c | 22 +++--- gtk/channel-main.c |1

[Spice-devel] [PATCH spice-gtk v2 2/2] Add command line options for setting the cache size and the glz window size

2012-01-22 Thread Yonit Halperin
This options will help us tune and find the optimal values. --- gtk/spice-option.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gtk/spice-option.c b/gtk/spice-option.c index 394a07d..d466f94 100644 --- a/gtk/spice-option.c +++ b/gtk/spice-option.c @@ -36,6

Re: [Spice-devel] [PATCH spice-gtk v2 1/2] Change the setting of the images cache size and the glz window size

2012-01-24 Thread Yonit Halperin
Hi, On 01/23/2012 12:36 PM, Hans de Goede wrote: Hi, I've various remarks, see my comments inline. On 01/22/2012 09:12 AM, Yonit Halperin wrote: Set the default sizes to be the same as in the old linux spice client. cache_size=20M pixels (instead of 32M), window_size=8M pixels for a 64MB dev

Re: [Spice-devel] RFC: remove Adler checksum and zlib header/trailer from zlib compressed images

2012-02-05 Thread Yonit Halperin
On 02/06/2012 09:02 AM, Yaniv Kaul wrote: On 01/29/2012 11:29 AM, Alon Levy wrote: On Sun, Jan 29, 2012 at 09:28:34AM +0200, Yaniv Kaul wrote: These small changes to server and (gtk) client seem to work, and remove both the zlib header/trailer from the deflate stream as well as the Adler

[Spice-devel] [PATCH] server: support IPV6 addresses in channel events sent to qemu

2012-02-08 Thread Yonit Halperin
RHBZ #788444 CC: Gerd Hoffmann kra...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Yonit Halperin yhalp...@redhat.com --- server/reds.c | 21 + server/spice.h |6 ++ 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/server

[Spice-devel] [PATCH] spice: support ipv6 channel address in monitor events and in spice info

2012-02-08 Thread Yonit Halperin
RHBZ #788444 CC: Gerd Hoffmann kra...@redhat.com Signed-off-by: Yonit Halperin yhalp...@redhat.com --- ui/spice-core.c | 37 - 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 5639c6f..60fd6c3 100644

Re: [Spice-devel] spice configuration - problem with connection

2012-02-11 Thread Yonit Halperin
On 02/11/2012 01:29 PM, Daniel Parnak wrote: Hello, I want to test spice on my virtual machines but I have problem. I create 2 virtual machines (one for server, one for client) on VMware Workstation 8 and I run on them Fedora-16-x86_64-Live-Desktop. # On server I do: yum -y install qemu-kvm

Re: [Spice-devel] spice problem with firewall or natting

2012-02-11 Thread Yonit Halperin
Hi, On 02/09/2012 05:40 AM, abdulkader wrote: hai, I installed rhev-v and everything working perfect. inside network, I can access spice desktop. but when I am trying to connect to desktop from outside(natted public IP, my firewall ASA) through user portal, spice showing starting screen, but it

Re: [Spice-devel] Untested idea: enlarge the TCP send buffer (server), receive buffer (client)

2012-02-13 Thread Yonit Halperin
On 02/13/2012 10:47 PM, Yaniv Kaul wrote: For both LAN (high bandwidth, high performance) and WAN (high latency) perhaps it may be worthwhile to increase (via socket options) the TCP receive (on the client) and send (on the server) buffers for the display channel? It will cause: - bigger TCP

[Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
RHBZ #790083 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- hw/qxl.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index bc03c1d..a2a3380 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1478,14 +1478,21 @@ static void

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 10:35 AM, Gerd Hoffmann wrote: On 02/14/12 09:10, Yonit Halperin wrote: RHBZ #790083 Signed-off-by: Yonit Halperinyhalp...@redhat.com You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b) skip vram when

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 11:10 AM, Yonit Halperin wrote: On 02/14/2012 10:35 AM, Gerd Hoffmann wrote: On 02/14/12 09:10, Yonit Halperin wrote: RHBZ #790083 Signed-off-by: Yonit Halperinyhalp...@redhat.com You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch

Re: [Spice-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-14 Thread Yonit Halperin
On 02/14/2012 11:24 AM, Gerd Hoffmann wrote: Hi, I can do it, by retrieving the surfaces addresses from the tracked guest commands. Exactly. However, if we already do it, it would be even better if we just dirty only the areas that are actually modified by the update_area calls. The

[Spice-devel] [PATCH v2 1/2] qxl: set only off-screen surfaces dirty instead of the whole vram

2012-02-15 Thread Yonit Halperin
We used to assure the guest surfaces were saved before migration by setting the whole vram dirty. This patch sets dirty only the areas that are actually used in the vram. Signed-off-by: Yonit Halperin yhalp...@redhat.com --- hw/qxl.c | 53

[Spice-devel] [PATCH v2 2/2] qxl: make sure primary surface is saved on migration also in compat mode

2012-02-15 Thread Yonit Halperin
RHBZ #790083 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index df55de1..10137f9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1470,7 +1470,7 @@ static void qxl_dirty_surfaces(PCIQXLDevice

Re: [Spice-devel] Performance expectations

2012-02-15 Thread Yonit Halperin
On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice from inside a VM on my local machine to view video streaming services like Youtube, Hulu, and Netflix? I have RHEL 6 Workstation for my host, and Win7 Pro as my guest. I've installed the

Re: [Spice-devel] [PATCH 1/3] README: make a note of SPICE_DEBUG_ALLOW_MC

2012-02-15 Thread Yonit Halperin
Ack series. Thanks, Yonit. On 02/15/2012 03:09 PM, Alon Levy wrote: --- README |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/README b/README index a27dc06..e146a95 100644 --- a/README +++ b/README @@ -79,4 +79,9 @@ version 2.1 of the License, or (at your

Re: [Spice-devel] Performance expectations

2012-02-20 Thread Yonit Halperin
Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice from inside a VM on my local machine to view video streaming services like Youtube, Hulu

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Yonit Halperin
Hi, On 02/19/2012 02:53 PM, Alon Levy wrote: On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 in 0.8 branch - the syms file is updated to contain 0.8.3 and 0.8.4. Forgot to change this comment. I'll drop the

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Yonit Halperin
On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Yonit Halperin
On 02/21/2012 09:56 PM, Kai Meyer wrote: On 02/21/2012 12:34 PM, Yonit Halperin wrote: On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16

Re: [Spice-devel] RFC: remove Adler checksum and zlib header/trailer from zlib compressed images

2012-02-26 Thread Yonit Halperin
On 02/23/2012 08:46 PM, Yaniv Kaul wrote: On 02/06/2012 09:43 AM, Yonit Halperin wrote: On 02/06/2012 09:02 AM, Yaniv Kaul wrote: On 01/29/2012 11:29 AM, Alon Levy wrote: On Sun, Jan 29, 2012 at 09:28:34AM +0200, Yaniv Kaul wrote: These small changes to server and (gtk) client seem to work

[Spice-devel] [PATCH 1/2] client: keyboard - add mapping for volume keys

2012-02-29 Thread Yonit Halperin
Add support for sending volume keys scancodes to the guest RHBZ #552539 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- client/inputs_channel.cpp |3 +++ client/red_key.h |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/client/inputs_channel.cpp b

[Spice-devel] [PATCH 2/2] client X11: support volume keys when evdev is in use

2012-02-29 Thread Yonit Halperin
Add support for sending volume keys scancodes to the guest RHBZ #552539 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- client/x11/red_window.cpp |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/client/x11/red_window.cpp b/client/x11/red_window.cpp index

Re: [Spice-devel] Cross-device access in SPICE server

2012-03-04 Thread Yonit Halperin
On 03/02/2012 09:06 PM, Noel Van Hook wrote: I was wondering if anyone had any experience or insight into a way for a worker in the server to get access to data from the other workers? Specifically I am looking into some optimization that would require a worker to have access to the surfaces

Re: [Spice-devel] Cross-device access in SPICE server

2012-03-06 Thread Yonit Halperin
On 03/05/2012 06:40 PM, Noel Van Hook wrote: On Sun, Mar 4, 2012 at 12:29 PM, Yonit Halperinyhalp...@redhat.com wrote: On 03/02/2012 09:06 PM, Noel Van Hook wrote: I was wondering if anyone had any experience or insight into a way for a worker in the server to get access to data from the

[Spice-devel] seamless migration with spice

2012-03-11 Thread Yonit Halperin
Hi, We would like to implement seamless migration for Spice, i.e., keeping the currently opened spice client session valid after migration. Today, the spice client establishes the connection to the destination before migration starts, and when migration completes, the client's session is

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-11 Thread Yonit Halperin
Hi. On 03/11/2012 05:36 PM, Anthony Liguori wrote: On 03/11/2012 10:25 AM, Alon Levy wrote: On Sun, Mar 11, 2012 at 09:18:17AM -0500, Anthony Liguori wrote: On 03/11/2012 08:16 AM, Yonit Halperin wrote: Hi, We would like to implement seamless migration for Spice, i.e., keeping the currently

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-12 Thread Yonit Halperin
On 03/12/2012 11:46 AM, Gerd Hoffmann wrote: Hi, The problem with (b) is, that iirc the way b was implemented in the past was still the big blob approach, but then pass the blob through the client, which means an evil client could modify it, causing all sorts of interesting behavior inside

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-12 Thread Yonit Halperin
Hi, On 03/12/2012 03:50 PM, Gerd Hoffmann wrote: Hi, Can you explain/exemplify, why sending data as a blob (either by (a) or (b)), that is verified only by the two ends that actually use it, is a problem? It tends to be not very robust. Especially when the creating/parsing is done ad-hoc

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-13 Thread Yonit Halperin
Hi, On 03/13/2012 08:40 AM, Gerd Hoffmann wrote: On 03/12/12 19:45, Yonit Halperin wrote: Hi, On 03/12/2012 03:50 PM, Gerd Hoffmann wrote: Hi, Can you explain/exemplify, why sending data as a blob (either by (a) or (b)), that is verified only by the two ends that actually use

[Spice-devel] log file for spice-gtk

2012-03-15 Thread Yonit Halperin
Hi, Are there any plans to have a log file for spice-gtk? I think that it is very important to have logging with configurable debug level via a configuration file. It will be helpful for live debugging of user problems that are hard to reproduce. I also saw there was some discussion about

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Yonit Halperin
On 03/15/2012 01:25 PM, Marc-André Lureau wrote: On Thu, Mar 15, 2012 at 11:39 AM, Alon Levyal...@redhat.com wrote: OK, so I think there is place to make remote-viewer produce a log file by default. The caller of virt-viewer/spice-gtk can redirect logging to files. By experience, I'd say

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Yonit Halperin
On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can avoid it. Especially since there is no functional reason for making the qemu/client

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Yonit Halperin
Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-18 Thread Yonit Halperin
Hi, On 03/15/2012 04:23 PM, Hans de Goede wrote: Hi, On 03/15/2012 03:07 PM, Yonit Halperin wrote: Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-18 Thread Yonit Halperin
Hi, On 03/15/2012 04:07 PM, Yonit Halperin wrote: Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-18 Thread Yonit Halperin
Hi, On 03/15/2012 04:23 PM, Hans de Goede wrote: Hi, On 03/15/2012 03:07 PM, Yonit Halperin wrote: Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components

Re: [Spice-devel] [bug spice-gtk] spice-gtk memory leak

2012-03-19 Thread Yonit Halperin
On 03/16/2012 08:13 PM, Marc-André Lureau wrote: - Mensaje original - Also, running spicy under valgrind leak check tool shows quite clearly that there is nothing being leaked directly from spice-gtk, it seems. As I told you off-line, It happened to me that remote-viewer (spice-gtk

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-20 Thread Yonit Halperin
Hi, On 03/20/2012 03:58 PM, Gerd Hoffmann wrote: Hi, We can either store and migrate the cache, or choose to reset it. In the extinct spice seamless migration solution, the cache was reset. Hmm, this makes me wonder what the main advantage of seamless migration used to be? image cache

Re: [Spice-devel] [PATCH spice-gtk] RFC: always release shm of primary surfaces

2012-03-22 Thread Yonit Halperin
On 03/21/2012 08:53 PM, Marc-André Lureau wrote: Note: I can't reproduce the leak, even after dozen of resolution switch. Always delete shared memory segment of primary surfaces when destroying its canvas. Ack. Tested. Just notice that it is not only for the primary surface, but for every

Re: [Spice-devel] SPICE_CHANNEL_TUNNEL

2012-03-25 Thread Yonit Halperin
Hi, On 03/23/2012 11:59 AM, Charles.Tsai-蔡清海-研究發展部 wrote: Alon, I read the spice code and found a spice tunnel channel there. What is the purpose of the tunnel channel? Is it for network tunneling? What is the use case for tunnel channel in spice? The tunnel was intended for

[Spice-devel] [PATCH spice-protocol] controller: add COLOR_DEPTH and DISABLE_EFFECTS messages

2012-04-02 Thread Yonit Halperin
rhbz #787447 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- spice/controller_prot.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/spice/controller_prot.h b/spice/controller_prot.h index a60b122..f7b1f26 100644 --- a/spice/controller_prot.h +++ b/spice

[Spice-devel] [PATCH spice-common] updated submodule spice-protocol

2012-04-02 Thread Yonit Halperin
added the disable-effects and color-depth options to the controller Signed-off-by: Yonit Halperin yhalp...@redhat.com --- spice-protocol |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spice-protocol b/spice-protocol index 32da251..8cf92f0 16 --- a/spice-protocol

[Spice-devel] [PATCH spice-gtk] controller: add support for DISABLE_EFFECTS and COLOR_DEPTH

2012-04-02 Thread Yonit Halperin
rhbz #787449 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- data/spice-protocol.vapi |3 +++ gtk/controller/controller.vala |9 + spice-common |2 +- 3 files changed, 13 insertions(+), 1 deletions(-) diff --git a/data/spice-protocol.vapi b/data

[Spice-devel] [PATCH spice-xpi] add support for DisableEffects and ColorDepth

2012-04-02 Thread Yonit Halperin
rhbz #747313 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- SpiceXPI/src/plugin/nsISpicec.idl|2 ++ SpiceXPI/src/plugin/nsScriptablePeer.cpp | 16 +++- SpiceXPI/src/plugin/nsScriptablePeer.h |2 ++ SpiceXPI/src/plugin/plugin.cpp | 26

[Spice-devel] [PATCH virt-viewer] spice/controller: add support for the properties disable-effects color-depth

2012-04-02 Thread Yonit Halperin
rhbz #808986 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- src/remote-viewer.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 7dda7fe..5f7685f 100644 --- a/src/remote-viewer.c +++ b/src/remote-viewer.c @@ -583,7

[Spice-devel] [PATCH spice-common 5/6] video streaming: add support for frames of different sizes

2012-04-08 Thread Yonit Halperin
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to clients with SPICE_DISPLAY_CAP_SIZED_STREAM. Signed-off-by: Yonit Halperin yhalp...@redhat.com --- common/messages.h | 15

[Spice-devel] [PATCH spice 01/11] server/red_worker: fix dump_bitmap

2012-04-08 Thread Yonit Halperin
Signed-off-by: Yonit Halperin yhalp...@redhat.com --- server/red_worker.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 07782c8..5350195 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -11348,10

Re: [Spice-devel] [PATCH spice-common 2/6] rect: add rect_get_area

2012-04-10 Thread Yonit Halperin
On 04/08/2012 07:36 PM, Marc-André Lureau wrote: - Mensaje original - Signed-off-by: Yonit Halperinyhalp...@redhat.com --- common/rect.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/common/rect.h b/common/rect.h index 655e9e8..0e4b01e 100644

Re: [Spice-devel] [PATCH spice-common 4/6] Update spice-protocol submodule

2012-04-10 Thread Yonit Halperin
On 04/08/2012 09:44 PM, Alon Levy wrote: On Sun, Apr 08, 2012 at 06:42:36PM +0300, Yonit Halperin wrote: For STREAM_DATA_SIZED and QOS_QUERY messages. Signed-off-by: Yonit Halperinyhalp...@redhat.com --- common/rect.h |2 +- spice-protocol |2 +- 2 files changed, 2 insertions

Re: [Spice-devel] [PATCH spice-common 4/6] Update spice-protocol submodule

2012-04-10 Thread Yonit Halperin
On 04/09/2012 09:49 AM, Hans de Goede wrote: Hi, On 04/08/2012 08:44 PM, Alon Levy wrote: On Sun, Apr 08, 2012 at 06:42:36PM +0300, Yonit Halperin wrote: For STREAM_DATA_SIZED and QOS_QUERY messages. Signed-off-by: Yonit Halperinyhalp...@redhat.com --- common/rect.h | 2 +- spice-protocol | 2

Re: [Spice-devel] [PATCH spice-protocol 2/2] Add qos related messages

2012-04-10 Thread Yonit Halperin
On 04/10/2012 12:13 PM, Marc-André Lureau wrote: On Sun, Apr 8, 2012 at 5:42 PM, Yonit Halperinyhalp...@redhat.com wrote: If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server's channel can send SPICE_MSG_QOS_QUERY to the client. In response, the client is expected to send back

Re: [Spice-devel] [PATCH spice-protocol 1/2] video streaming: add support for frames of different sizes

2012-04-10 Thread Yonit Halperin
On 04/10/2012 12:22 PM, Marc-André Lureau wrote: On Sun, Apr 8, 2012 at 5:42 PM, Yonit Halperinyhalp...@redhat.com wrote: Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to

Re: [Spice-devel] [PATCH spice-protocol 1/2] video streaming: add support for frames of different sizes

2012-04-10 Thread Yonit Halperin
On 04/10/2012 01:12 PM, Christophe Fergeau wrote: On Sun, Apr 08, 2012 at 06:42:10PM +0300, Yonit Halperin wrote: Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to clients

Re: [Spice-devel] [PATCH spice 04/11] client: handle the new SpiceMsgDisplayStreamData (common/messages.h)

2012-04-10 Thread Yonit Halperin
On 04/10/2012 01:31 PM, Christophe Fergeau wrote: On Sun, Apr 08, 2012 at 06:43:13PM +0300, Yonit Halperin wrote: SpiceMsgDisplayStreamData now contains SpiceStreamDataHeader, which is shared with SpiceMsgDisplayStreamDataSized. Signed-off-by: Yonit Halperinyhalp...@redhat.com --- client

Re: [Spice-devel] [PATCH spice 10/11] server/video-streams: adjust mjpeg quality and frame rate according to the current bit rate

2012-04-10 Thread Yonit Halperin
On 04/10/2012 03:48 PM, Christophe Fergeau wrote: On Sun, Apr 08, 2012 at 06:43:19PM +0300, Yonit Halperin wrote: Previously, the mjpeg quality was always 70. The frame rate was tuned according to the frames' congestion in the pipe. This patch sets the mjpeg quality and frame rate according

Re: [Spice-devel] [PATCH spice 03/11] server: video streaming: add support for frames of different sizes

2012-04-10 Thread Yonit Halperin
Hi, please wait with the review for this one. I may have a better way to identify such frames, using the current tree. If it works, I will send it in v2. On 04/08/2012 06:43 PM, Yonit Halperin wrote: When playing a youtube video on Windows guest, the driver sometimes sends images which

Re: [Spice-devel] [PATCH spice-gtk] Set new cert-subject when switching host

2012-04-15 Thread Yonit Halperin
Ack On 04/15/2012 10:32 PM, Marc-André Lureau wrote: https://bugzilla.redhat.com/show_bug.cgi?id=802574 --- gtk/channel-main.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 8d0a809..9de51d7 100644 ---

Re: [Spice-devel] [PATCH spice-gtk] Clear cache and glz dictionnary on switch-host

2012-04-15 Thread Yonit Halperin
Ack On 04/15/2012 11:01 PM, Marc-André Lureau wrote: If we don't clear the glz dictionnary, this might lead to corrupted/invalid dictionnary and invalid memory allocation due unbounded increase of dictionnary size --- gtk/spice-session.c |8 ++-- 1 file changed, 6 insertions(+), 2

[Spice-devel] [PATCH v2 spice-protocol 0/2] video streaming enhancements and bandwidth monitoring

2012-04-17 Thread Yonit Halperin
references Regards, Yonit. Yonit Halperin (2): video streaming: add support for frames of different sizes Add qos related messages spice/enums.h|3 +++ spice/protocol.h |5 + 2 files changed, 8 insertions(+), 0 deletions(-) -- 1.7.7.6 Hi, This patch series includes also patches

[Spice-devel] [PATCH v2 spice-protocol 1/2] video streaming: add support for frames of different sizes

2012-04-17 Thread Yonit Halperin
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that in addition to the mjpeg data, also contains the (1) width and height of the compressed frame. (2) the destination box of the frame. The server can send such messages only to clients with SPICE_DISPLAY_CAP_SIZED_STREAM. When

[Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-17 Thread Yonit Halperin
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server's channel can send SPICE_MSG_QOS_QUERY to the client. In response, the client is expected to send back SPICE_MSG_QOS_ACK immediately after it receives the message following the query, and before handling this message. The server

[Spice-devel] [PATCH v2 spice-common 1/5] rect: add rect_contains

2012-04-17 Thread Yonit Halperin
--- common/rect.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/common/rect.h b/common/rect.h index a63d785..655e9e8 100644 --- a/common/rect.h +++ b/common/rect.h @@ -74,6 +74,12 @@ static INLINE int rect_is_same_size(const SpiceRect *r1, const SpiceRect

[Spice-devel] [PATCH v2 spice-common 2/5] rect: add rect_get_area

2012-04-17 Thread Yonit Halperin
--- common/rect.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/common/rect.h b/common/rect.h index 655e9e8..a9c1b08 100644 --- a/common/rect.h +++ b/common/rect.h @@ -80,6 +80,11 @@ static INLINE int rect_contains(const SpiceRect *big, const SpiceRect

[Spice-devel] [PATCH v2 spice-common 4/5] video streaming: add support for frames of different sizes

2012-04-17 Thread Yonit Halperin
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to clients with SPICE_DISPLAY_CAP_SIZED_STREAM. --- common/messages.h | 15 ++- spice.proto | 19

[Spice-devel] [PATCH v2 spice-common 5/5] Add qos related messages

2012-04-17 Thread Yonit Halperin
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server's channel can send SPICE_MSG_QOS_QUERY to the client. In response, the client is expected to send back SPICE_MSG_QOS_ACK immediately after it receives the message following the query, and before handling the message. The server can

[Spice-devel] [PATCH v2 spice 01/11] server/red_worker: fix dump_bitmap

2012-04-17 Thread Yonit Halperin
--- server/red_worker.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 07782c8..5350195 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -11348,10 +11348,11 @@ static void dump_bitmap(RedWorker *worker,

[Spice-devel] [PATCH v2 spice 02/11] server/red_worker: dump_bitmap: add surface_id to the bitmap file name

2012-04-17 Thread Yonit Halperin
Also replaced sprintf with snprintf --- server/red_worker.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5350195..99a8948 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1014,7 +1014,7 @@

[Spice-devel] [PATCH v2 spice 03/11] Update the spice-common submodule

2012-04-17 Thread Yonit Halperin
spice-common changes: STREAM_DATA_SIZED message was added in order to support video streams with frames that their size is different from the initial size that the stream was created with. This patch also includes server and client adjustments to the new SpiceMsgDisplayStreamData. ---

[Spice-devel] [PATCH v2 spice 04/11] server: video streaming: add support for frames of different sizes

2012-04-17 Thread Yonit Halperin
When playing a youtube video on Windows guest, the driver sometimes sends images which contain the video frames, but also other parts of the screen (e.g., the youtube process bar). In order to prevent glitches, we send these images as part of the stream, using SPICE_MSG_DISPLAY_STREAM_DATA_SIZED.

[Spice-devel] [PATCH v2 spice 06/11] server/red_worker: assign timer callbacks to worker_core, using spice_timer_queue

2012-04-17 Thread Yonit Halperin
display channel: Supplying timeouts interface to red_channel, in order to allow periodic network monitoring (see next 2 patches). --- server/red_worker.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index

[Spice-devel] [PATCH v2 spice 07/11] server/red_channel: support network monitoring

2012-04-17 Thread Yonit Halperin
If the client's channel has SPICE_COMMON_CAP_QOS_QUERY, the server channel's can send it SPICE_MSG_QOS_QUERY. The client is supposed to respond by SPICE_MSG_QOS_ACK right after it receives the one message that follows SPICE_MSG_QOS_QUERY. For channels that are characterized mainly by transmissions

[Spice-devel] [PATCH v2 spice 08/11] server/red_worker: enable periodic network monitoring in the display channel

2012-04-17 Thread Yonit Halperin
--- server/red_worker.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 2de96d2..1e74662 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9719,6 +9719,7 @@ static CommonChannelClient

[Spice-devel] [PATCH v2 spice-gtk 3/3] display: debug video streams frames dropping

2012-04-17 Thread Yonit Halperin
--- gtk/channel-display-priv.h |5 + gtk/channel-display.c | 19 +++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/gtk/channel-display-priv.h b/gtk/channel-display-priv.h index 1969697..8aac8d8 100644 --- a/gtk/channel-display-priv.h +++

Re: [Spice-devel] [PATCH v2 spice 01/11] server/red_worker: fix dump_bitmap

2012-04-17 Thread Yonit Halperin
On 04/17/2012 01:46 PM, Alon Levy wrote: On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote: --- server/red_worker.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 07782c8..5350195 100644 --- a/server

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-19 Thread Yonit Halperin
On 04/18/2012 08:47 PM, Marc-André Lureau wrote: Hi On Wed, Apr 18, 2012 at 7:34 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: It would be - QOS_QUERY(nbytes) - nbytes of various messages 1 or n - QOS_ACK Further questions about this, how can the server really determine the

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-22 Thread Yonit Halperin
On 04/19/2012 02:58 PM, Marc-André Lureau wrote: On Thu, Apr 19, 2012 at 9:30 AM, Yonit Halperinyhalp...@redhat.com wrote: The latency factor is in my TODO (see cover letter). I use ioctl(socket, TIOCOUTQ) in order to find how many bytes are pending in the tcp snd buffer, in addition to the

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-22 Thread Yonit Halperin
On 04/22/2012 04:23 PM, Marc-André Lureau wrote: On Sun, Apr 22, 2012 at 10:39 AM, Yonit Halperinyhalp...@redhat.com wrote: A top with N bytes sent This is the simpler mechanism I have in mind: the client receives a start mark knowing N bytes are following that were sent directly (in

[Spice-devel] [PATCH xf86-video-qxl] Do not call update_area when lacking device memory

2012-04-23 Thread Yonit Halperin
primary surface, but rather renders the oldest X drawables. The call to update_area is redundant, and its effect on performance is noticeable when playing full screen video. Signed-off-by: Yonit Halperin yhalp...@redhat.com --- src/qxl_driver.c | 14 -- 1 files changed, 0 insertions

Re: [Spice-devel] Client Graphics Filtering

2012-04-24 Thread Yonit Halperin
Hi, On 04/24/2012 09:12 AM, Alon Levy wrote: On Tue, Apr 24, 2012 at 09:47:47AM +0800, 蒋媛园 wrote: Hi I want to filter the graphics to the client. For example, only the graphics of a calculator(in guest OS Win7) are send to the client. I know that there is always the possibility of

Re: [Spice-devel] [bug] tripping an assert (regularly!) in release_drawable in red_worker.c

2012-05-01 Thread Yonit Halperin
Hi, On 05/01/2012 05:39 PM, Nahum Shalman wrote: I'm much happier about this one since it now happens to me pretty much every time I use a VM. Once again, I'm using the latest bits as of a couple days ago with a modified qemu running under illumos. I'm reliably tripping an assert in

[Spice-devel] [PATCH spice-common 1/5] rect: add rect_contains

2012-05-02 Thread Yonit Halperin
--- common/rect.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/common/rect.h b/common/rect.h index a63d785..655e9e8 100644 --- a/common/rect.h +++ b/common/rect.h @@ -74,6 +74,12 @@ static INLINE int rect_is_same_size(const SpiceRect *r1, const SpiceRect

[Spice-devel] [PATCH spice-common 3/5] rect: add rect_debug

2012-05-02 Thread Yonit Halperin
--- common/rect.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/common/rect.h b/common/rect.h index a9c1b08..f8bacf1 100644 --- a/common/rect.h +++ b/common/rect.h @@ -21,6 +21,7 @@ #include spice/macros.h #include draw.h +#include log.h

[Spice-devel] [PATCH spice-common 4/5] region: add region_extents

2012-05-02 Thread Yonit Halperin
--- common/region.c | 11 +++ common/region.h |2 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/common/region.c b/common/region.c index 30a11e3..cd9ade0 100644 --- a/common/region.c +++ b/common/region.c @@ -386,6 +386,17 @@ void region_ret_rects(const QRegion

[Spice-devel] [PATCH spice-common 5/5] video streaming: add support for frames of different sizes

2012-05-02 Thread Yonit Halperin
rhbz #813826, #815426 Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to clients with SPICE_DISPLAY_CAP_SIZED_STREAM. --- common/messages.h | 15 ++- spice-protocol

[Spice-devel] [PATCH spice 01/18] Update the spice-common submodule

2012-05-02 Thread Yonit Halperin
We need some rect/region getters methods that were added --- spice-common |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spice-common b/spice-common index 6af29a9..178c7ea 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit

[Spice-devel] [PATCH spice 02/18] server/red_worker: add get_stream_id

2012-05-02 Thread Yonit Halperin
--- server/red_worker.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 07782c8..09a9357 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -2485,6 +2485,11 @@ static void

[Spice-devel] [PATCH spice 03/18] server/red_worker/video: maintain visible region and clip region for streams

2012-05-02 Thread Yonit Halperin
Differentiate between the clipping of the video stream, and the region that currently displays fragments of the video stream (henceforth, vis_region). The latter equals or contains the former one. For example, let c1 be the clip area at time t1, and c2 be the clip area at time t2, where t1 t2. If

[Spice-devel] [PATCH spice 04/18] server/red_worker/video: upgrade stream by a screenshot instead of the last frame, if needed

2012-05-02 Thread Yonit Halperin
Upgrading a stream: When the stream's visible region is bigger than the one of the last frame, we will send an updated screenshot of the visible region, instead of sending the last frame losslessly. --- server/red_worker.c | 92 +++--- 1 files

[Spice-devel] [PATCH spice 05/18] server/red_worker/video: don't detach a drawable from a stream due to it being rendered.

2012-05-02 Thread Yonit Halperin
The previous patch took care that streams will be upgraded by a surface screenshot and not the last frame, if necessary. Thus, there is no more a reason for detaching drawables from streams when they are rendered. Moreover, detaching such drawables can cause glitches, in case they are still in the

[Spice-devel] [PATCH spice 06/18] Update the spice-common submodule

2012-05-02 Thread Yonit Halperin
spice-common changes: STREAM_DATA_SIZED message was added in order to support video streams with frames that their size is different from the initial size that the stream was created with. This patch also includes server and client adjustments to the new SpiceMsgDisplayStreamData. ---

[Spice-devel] [PATCH spice 07/18] server/red_worker.c/video: add support for frames of different sizes

2012-05-02 Thread Yonit Halperin
rhbz #813826 When playing a youtube video on Windows guest, the driver sometimes sends images which contain the video frames, but also other parts of the screen (e.g., the youtube process bar). In order to prevent glitches, we send these images as part of the stream, using

[Spice-devel] [PATCH spice 08/18] server/red_worker/video: don't override the clip in areas that belong only to sized frames

2012-05-02 Thread Yonit Halperin
--- server/red_worker.c | 42 -- 1 files changed, 12 insertions(+), 30 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 306b316..18d6309 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -2454,31 +2454,6 @@ static

[Spice-devel] [PATCH spice 10/18] server/tests/test_display_base: fix two int to pointer cast warnings

2012-05-02 Thread Yonit Halperin
From: Alon Levy al...@redhat.com --- server/tests/test_display_base.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index e376195..d060f3f 100644 --- a/server/tests/test_display_base.c +++

[Spice-devel] [PATCH spice 11/18] server/tests: add test_get_width/test_get_height

2012-05-02 Thread Yonit Halperin
From: Alon Levy al...@redhat.com --- server/tests/test_display_base.c | 16 server/tests/test_display_base.h |3 +++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index d060f3f..fd9a37e

[Spice-devel] [PATCH spice 13/18] server/tests: add SIMPLE_DRAW_SOLID and SIMPLE_DRAW_BITMAP

2012-05-02 Thread Yonit Halperin
From: Alon Levy al...@redhat.com --- server/tests/test_display_base.c | 43 - server/tests/test_display_base.h |2 + 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index

[Spice-devel] [PATCH spice 14/18] server/tests/test_display_streaming: update to create sized frames

2012-05-02 Thread Yonit Halperin
From: Alon Levy al...@redhat.com --- server/tests/test_display_streaming.c | 44 +++- 1 files changed, 37 insertions(+), 7 deletions(-) diff --git a/server/tests/test_display_streaming.c b/server/tests/test_display_streaming.c index 1b81d76..b4fe013 100644 ---

[Spice-devel] [PATCH spice 15/18] server/tests: add clip to SIMPLE_DRAW_BITMAP

2012-05-02 Thread Yonit Halperin
--- server/tests/test_display_base.c | 34 -- server/tests/test_display_base.h |2 ++ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index b43859c..79781f7 100644 ---

<    1   2   3   4   5   6   7   8   >