Re: [Spice-devel] [PATCH] usbredirparser: prevent endless recursion if interface_count == 0

2016-08-03 Thread Alon Levy
Thanks! On Wed, Aug 3, 2016, at 01:49 PM, Christophe Fergeau wrote: > Hey, > > I've pushed the patch now, thanks! > > Christophe > > On Tue, Jul 26, 2016 at 01:47:16PM +0300, Alon Levy wrote: > > On fedora 24 this function is tail optimized, resulting in a busy

[Spice-devel] [PATCH] usbredirparser: prevent endless recursion if interface_count == 0

2016-07-26 Thread Alon Levy
On fedora 24 this function is tail optimized, resulting in a busy wait. This happens to me with virt-manager running a win7 vm usbredir-0.7.1-2.fc24.x86_64 --- Hi Guys! One liner to fix an issue I had with virt-manager - symptom is 100% cpu taken in it, stack traced to the problem fixed by

Re: [Spice-devel] Virtual Smartcard GPG

2015-04-30 Thread Alon Levy
On 04/29/2015 09:22 PM, r...@openmailbox.org wrote: On 2015-04-29 11:41, Alon Levy wrote: On 04/29/2015 02:20 PM, r...@openmailbox.org wrote: Hi. I am trying to get a virtual smartcard attached to a vm but I want it to use GPG instead of NSS. RedHat focuses on NSS becuase of PKCS#11

Re: [Spice-devel] Virtual Smartcard GPG

2015-04-29 Thread Alon Levy
On 04/29/2015 02:20 PM, r...@openmailbox.org wrote: Hi. I am trying to get a virtual smartcard attached to a vm but I want it to use GPG instead of NSS. RedHat focuses on NSS becuase of PKCS#11 requirements and FIPS approval, but for most of the community its GPG that matters for smartcards.

Re: [Spice-devel] [xf86-video-qxl v6] Enable smartcard support for XSpice.

2015-01-08 Thread Alon Levy
On 01/08/2015 04:10 PM, Jeremy White wrote: On 01/08/2015 03:53 AM, Uri Lublin wrote: Hi Jeremy, Ack. Thanks. h-length is unsigned. 1. Why is there a need to check that h-length 0 ? There is no need, changed. 2. What happens if h-length == 0 ? Note that I believe that could

Re: [Spice-devel] [PATCH spice-protocol] build-sys: simplify autogen

2014-12-05 Thread Alon Levy
[snip] At the same time, I'm not sure mailing lists are the right tool for code review. It's difficult to track which patches have been reviewed and which haven't. http://patchwork.freedesktop.org/project/Spice/list/ can help, linked from the wiki btw

Re: [Spice-devel] [PATCH spice-protocol] build-sys: simplify autogen

2014-12-05 Thread Alon Levy
On 12/06/2014 12:00 AM, Jonathon Jongsma wrote: On Fri, 2014-12-05 at 23:41 +0200, Alon Levy wrote: [snip] At the same time, I'm not sure mailing lists are the right tool for code review. It's difficult to track which patches have been reviewed and which haven't. http

Re: [Spice-devel] Spice agent and LXC

2014-11-27 Thread Alon Levy
On 11/27/2014 02:02 PM, Charles Ricketts wrote: Well, I have Spice working perfectly fine in a Windows install. However, seeing as that's not pertinent to the Linux side of things I went ahead and installed Ubuntu 14.04 in Qemu and, as expected, everything worked. I didn't bother with the git

Re: [Spice-devel] [xf86-video-qxl] Enable smartcard support for XSpice.

2014-11-21 Thread Alon Levy
On 11/21/2014 05:03 PM, Jeremy White wrote: Thanks for the careful review. +static void push_apdu(smartcard_ccid_t *ccid, void *data, int len) +{ +apdu_t *a = calloc(1, sizeof(*a) + len); +apdu_t **p; + +a-data = malloc(len); +memcpy(a-data, data, len); 1. No need to

Re: [Spice-devel] [PATCH][spice-gtk] Add GStreamer 1.0 support

2014-10-30 Thread Alon Levy
On 10/30/2014 06:39 PM, vtoso...@redhat.com wrote: From: Christophe Fergeau cferg...@redhat.com This commit adds GStreamer 1.0 support. To enable GStreamer 1.0: --with-audio=gstreamer1 commit first line should say audio somewhere. There is only a few changes between those versions, worth

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-24 Thread Alon Levy
On 10/08/2014 01:10 PM, Marc-André Lureau wrote: ping I didn't test this, looks good, just one single line if, do with it as you will. And unrelated, but you use TRUE/FALSE constants for handled, maybe nice to use them too (at least be consistent that is) in vdagent_x11_handle_event. On Mon,

Re: [Spice-devel] Fwd: a question about Xspice

2014-10-22 Thread Alon Levy
On 10/22/2014 11:37 AM, Hans de Goede wrote: Hi, Forwarding this to you guys from the xorg-devel list. Regards, Hans Forwarded Message Subject: a question about Xspice Date: Tue, 21 Oct 2014 17:30:54 +0800 (CST) From: cynthia cynthia_...@163.com To:

Re: [Spice-devel] unwatchable choppy performance using fullscreen flash in windows VM

2014-10-15 Thread Alon Levy
On 10/16/2014 04:25 AM, Greg Sheremeta wrote: Hey all, Using a high-end Fedora 20 host, I get very poor choppy performance running flash full-screen in a Windows VM. I need to use Windows due to DRM stuff (nflsundayticket.tv). I've tried different virtual graphics adapters, but nothing

Re: [Spice-devel] [PATCH xf86-qxl 1/2] Assert on QXL_INTERRUPT_ERROR

2014-10-12 Thread Alon Levy
On 10/12/2014 03:24 PM, Marc-André Lureau wrote: From: Marc-Andre Lureau marcandre.lur...@redhat.com When qemu qxl device reaches a guest bug, it might set the QXL_INTERRUPT_ERROR interrupt flag, and stops processing guest commands. Therefore, it makes sense to check that flag in the guest

Re: [Spice-devel] Wiki cleanup

2014-09-29 Thread Alon Levy
On 09/29/2014 03:30 PM, Jeremy White wrote: If the idea seems sensible, then I'd propose that we work on the Wiki until we feel it stands mostly on it's own, and when we hit that point, we shift the main pages to reflect that. The website/wiki content needs some reorganization for sure, and

Re: [Spice-devel] protocol 2.0 document?

2014-09-15 Thread Alon Levy
On 09/15/2014 05:30 AM, Brade-Atrust wrote: Hi guys, This is brade huang from taiwan, right now I try to dig into spice client source code and hopefully do some developments on spice, but when I investigated the code, I realized it already enhanced to protocol v2. I tried very hard to

Re: [Spice-devel] Odd issue with OSX Guest

2014-09-02 Thread Alon Levy
On 09/01/2014 09:01 PM, Brad Campbell wrote: G'day All, I'm attempting to run an OSX guest using spice as the remote display protocol (Yes, it's running on Apple hardware). The guest is using the standard vga driver. I'm using the latest git of spice, spice-gtk, qemu and the kernel.

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Alon Levy
With agent running we do. On August 22, 2014 7:55:19 AM EDT, Marc-André Lureau mlur...@redhat.com wrote: Hi Jeremy I wish we could have dynamic allocation for Xspice, avoiding those parameters, but this could be improved later. Few remarks below: - Original Message - Also adjust the

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Alon Levy
wrote: On 08/22/2014 07:52 AM, Alon Levy wrote: With agent running we do. ?? I'm sorry, I don't follow. Can you explain what you mean? Cheers, Jeremy On August 22, 2014 7:55:19 AM EDT, Marc-André Lureau mlur...@redhat.com wrote: Hi Jeremy I wish we could have dynamic

Re: [Spice-devel] [PATCH] [xf86-video-qxl] In XSpice mode, enable the ability to specify the various ram buffer sizes.

2014-08-22 Thread Alon Levy
On August 22, 2014 9:16:31 AM EDT, Jeremy White jwh...@codeweavers.com wrote: On 08/22/2014 08:07 AM, Alon Levy wrote: Sorry for top posting. I was replying to Marc-Andre's assertion. If the subject isnt arbitrary resolution, aka dynamic, continuous, then I missed it. If it is, since agent

Re: [Spice-devel] Bad display of the download-section on gitweb

2014-08-06 Thread Alon Levy
On 08/06/2014 05:27 AM, Cody Chan wrote: Bad display of the download-section, http://cgit.freedesktop.org/spice/spice-gtk/ Tag Download v0.25 commit 31c099c931... v0.24 commit 6356941903... v0.23 commit 75176968b0... v0.22 commit 2e3aa29794... v0.21 commit 632836ed77... v0.20 commit

Re: [Spice-devel] Help with SmartCards and XSpice

2014-08-06 Thread Alon Levy
On 08/06/2014 06:14 PM, Jeremy White wrote: And, finally, if that's all right - on to the next question: where should spiceccid fit in the XSpice stack? Should it be part of the Xorg driver? Should it be a vd_agent process? I'm not sure - I was thinking a third part, this time it's a bit

Re: [Spice-devel] Questions on usbredir + XSpice

2014-08-06 Thread Alon Levy
On 08/06/2014 06:17 PM, Jeremy White wrote: I would advice against going for a protocol translater, your time would better spend on doing this properly right away. You don't think the kernel guys will push back, saying there is already an existing ip-to-usb device, and we should just use

Re: [Spice-devel] Help with SmartCards and XSpice

2014-08-05 Thread Alon Levy
On 07/25/2014 12:01 AM, Jeremy White wrote: I think I have a tentative, but sufficient grasp of how the Smart Card stuff flows from the client into the server. It's not quite as clear how the server bridges it into qemu, but I think I have the gist of it. However, that doesn't work for

Re: [Spice-devel] [PATCH] Release 0.1.2

2014-07-24 Thread Alon Levy
On 23.07.2014 14:40, Marc-André Lureau wrote: ack, thanks! Are you picking up this one for Fedora? The actual patches for any relevant bugs should already be there, doing a rebase will probably happen the next time someone needs to fix something (i.e. some bz). remote desktop fan

Re: [Spice-devel] [PATCH] Release 0.1.2

2014-07-24 Thread Alon Levy
On 07/24/2014 03:58 PM, poma wrote: On 24.07.2014 14:43, Alon Levy wrote: On 23.07.2014 14:40, Marc-André Lureau wrote: ack, thanks! Are you picking up this one for Fedora? The actual patches for any relevant bugs should already be there, doing a rebase will probably happen the next time

[Spice-devel] [PATCH] Release 0.1.2

2014-07-23 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- NEWS | 10 ++ configure.ac | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 4ece9fe..86fe9f8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,13 @@ +Major changes in 0.1.2

[Spice-devel] [ANNOUNCE] xf86-video-qxl 0.1.2

2014-07-23 Thread Alon Levy
: restore cursor after resolution change fix cursor2 support in older kernels FD 79317 - prevent crash on dual head systems Enjoy, Alon Alon Levy (11): tests/xspice_util.py: fix hardcoded port spiceqxl_spice_server: no need to call spice_server_set_noauth twice xspice: chown both

Re: [Spice-devel] [vdagent-linux 2/2] Handle STRING selection type

2014-07-21 Thread Alon Levy
This is to please vncviewer. https://bugzilla.redhat.com/show_bug.cgi?id=1117764 ACK --- src/vdagent-x11-priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vdagent-x11-priv.h b/src/vdagent-x11-priv.h index 4a5729b..38f852e 100644 ---

Re: [Spice-devel] [vdagent-linux 1/2] Reply to TIMESTAMP requests

2014-07-21 Thread Alon Levy
This is to please vncviewer. Commit message can say 'add TIMESTAMP handling'. ACK. btw wrt the TODO, xsel seems to do the same as you. https://bugzilla.redhat.com/show_bug.cgi?id=1117764 --- src/vdagent-x11-priv.h | 1 + src/vdagent-x11.c | 15 +++ 2 files changed, 16

Re: [Spice-devel] [PATCH (v2)] Make sure the child is able to connect to the X server before exiting the mainline.

2014-07-10 Thread Alon Levy
On 07/09/2014 10:08 PM, Jeremy White wrote: This allows the vdagent to be used in the Xsetup phase of an xdm session; otherwise, it's X11 connection fails because of the greeter display grab. The issue is that we daemonize before attempting the X connection. We then immediately exit the main

Re: [Spice-devel] Setting colour depths

2014-07-10 Thread Alon Levy
On 06/23/2014 06:59 PM, Damien Dye wrote: Hi all am testing Xspice to replace VNC at our company an have some questions I can't seam to solve 1) when I set the color depth in the config file to 16 the server fails to start saying it's unsupported. I never tried it. Seems sensible - I

Re: [Spice-devel] [PATCH xf86-qxl] drm: restore cursor after resolution change

2014-07-07 Thread Alon Levy
On 07/02/2014 01:22 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@gmail.com The Spice server qemu reset the cursor state when changing resolution. Although X does restore the cursor on framebuffer changes, it doesn't for crtc config. Restoring the cursor here is the

Re: [Spice-devel] [vdagentd] Add an explicit switch to signal fake uinput devices.

2014-07-07 Thread Alon Levy
On 06/23/2014 11:41 PM, Jeremy White wrote: ACK Signed-off-by: Jeremy White jwh...@codeweavers.com --- src/vdagentd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index 1098fb6..fa47997 100644 --- a/src/vdagentd.c

Re: [Spice-devel] [vdagent] Make sure the child is able to connect to the X server before exiting the mainline.

2014-07-07 Thread Alon Levy
On 06/24/2014 12:05 AM, Jeremy White wrote: This allows the vdagent to be used in the Xsetup phase of an xdm session; otherwise, its X11 connection fails because of the greeter display grab. relies on the fact the socketpair fd's are never 0 (i.e. fd[1] below is never 0). Which I think is

Re: [Spice-devel] [vdagent] Make sure the child is able to connect to the X server before exiting the mainline.

2014-07-07 Thread Alon Levy
On 06/24/2014 12:05 AM, Jeremy White wrote: This allows the vdagent to be used in the Xsetup phase of an xdm session; otherwise, its X11 connection fails because of the greeter display grab. But could you make the comment contain the discussion where you explained this in more detail?

Re: [Spice-devel] [PATCH spice-gtk] session: prefix proxy lookup errors

2014-07-07 Thread Alon Levy
On 07/03/2014 07:49 PM, Marc-André Lureau wrote: Proxy errors are already reported with G_IO_ERROR_PROXY messages, however proxy name lookup error can be more detailed. ACK https://bugzilla.redhat.com/show_bug.cgi?id=1115986 --- gtk/spice-session.c | 1 + 1 file changed, 1 insertion(+)

Re: [Spice-devel] [vdagentd] Add an option such that the daemon will exit after processing a single session.

2014-07-07 Thread Alon Levy
On 06/24/2014 12:05 AM, Jeremy White wrote: ACK Signed-off-by: Jeremy White jwh...@codeweavers.com --- src/vdagentd.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index fa47997..b5c7d14 100644 --- a/src/vdagentd.c

Re: [Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-25 Thread Alon Levy
On Mon, Jun 09, 2014 at 04:08:37PM +0300, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/qxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index b9aa0e9..d9bf447 100644 --- a/src/qxl_driver.c

[Spice-devel] [PATCH] qxl_image.c: fix compilation break

2014-06-25 Thread Alon Levy
Since 3d511c30206bd8c9a207c436186a03af0bb02962 Xspice building is broken due to undefined MAX_RELOCS when not building with XF86DRM_MODE. --- src/qxl_image.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qxl_image.c b/src/qxl_image.c index eb66b63..8927fd4 100644 --- a/src/qxl_image.c

Re: [Spice-devel] [PATCH 0/2] stability for dual head

2014-06-18 Thread Alon Levy
On 06/17/2014 04:08 PM, David Mansfield wrote: On 06/17/2014 03:24 AM, Alon Levy wrote: On 06/16/2014 04:16 PM, David Mansfield wrote: On 06/09/2014 09:29 AM, Alon Levy wrote: On 06/09/2014 04:18 PM, David Mansfield wrote: On 06/09/2014 07:18 AM, Alon Levy wrote: On 06/03/2014 04:14 PM

Re: [Spice-devel] [PATCH 0/2] stability for dual head

2014-06-17 Thread Alon Levy
On 06/16/2014 04:16 PM, David Mansfield wrote: On 06/09/2014 09:29 AM, Alon Levy wrote: On 06/09/2014 04:18 PM, David Mansfield wrote: On 06/09/2014 07:18 AM, Alon Levy wrote: On 06/03/2014 04:14 PM, David Mansfield wrote: Bump. I'll make it easy. This is a multiple choice response form

Re: [Spice-devel] how to read the spice-server source code?

2014-06-09 Thread Alon Levy
On 05/29/2014 11:16 AM, aaron_0119 wrote: hi, guys, i built the spice-gtk on an arm board(Contex A9). i test it and found that it is not very smoothly when i playing the video. so i decided to how the video streamer be transmitted or compressed between the server and client. i try to read

Re: [Spice-devel] [PATCH spice-protocol] RFC: Add VD_AGENT_CAP_ANY_SELECTION_TYPE

2014-06-09 Thread Alon Levy
On 06/04/2014 07:45 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@gmail.com When both the client and the agent advertize VD_AGENT_CAP_ANY_SELECTION_TYPE capability, the existing VDAgentClipboard messages are modified to embed string representation of the selection

Re: [Spice-devel] [PATCH 0/2] stability for dual head

2014-06-09 Thread Alon Levy
On 06/03/2014 04:14 PM, David Mansfield wrote: Bump. I'll make it easy. This is a multiple choice response form. Anyone reading this can respond with one letter so save time and effort. a) We're too busy with RHEL 7/paying clients, come back in a month/some timeframe b) There's an SEP

Re: [Spice-devel] [PATCH spice-protocol] RFC: Add VD_AGENT_CAP_ANY_SELECTION_TYPE

2014-06-09 Thread Alon Levy
On 06/09/2014 02:20 PM, Marc-André Lureau wrote: - Original Message - On 06/04/2014 07:45 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@gmail.com When both the client and the agent advertize VD_AGENT_CAP_ANY_SELECTION_TYPE capability, the existing

[Spice-devel] [PATCH] qxl_kms: read virtual monitor size from xorg.conf

2014-06-09 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/qxl_kms.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qxl_kms.c b/src/qxl_kms.c index c31c62d..d952495 100644 --- a/src/qxl_kms.c +++ b/src/qxl_kms.c @@ -164,8 +164,8 @@ Bool qxl_pre_init_kms(ScrnInfoPtr pScrn

[Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-09 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/qxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index b9aa0e9..d9bf447 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1242,7 +1242,7 @@ qxl_init_scrn (ScrnInfoPtr pScrn

Re: [Spice-devel] [PATCH 0/2] stability for dual head

2014-06-09 Thread Alon Levy
On 06/09/2014 04:18 PM, David Mansfield wrote: On 06/09/2014 07:18 AM, Alon Levy wrote: On 06/03/2014 04:14 PM, David Mansfield wrote: Bump. I'll make it easy. This is a multiple choice response form. Anyone reading this can respond with one letter so save time and effort. a) We're too

[Spice-devel] glz cleanup

2014-05-11 Thread Alon Levy
Hi, Hopefully this is not something someone discussed in the 193 unread mails from spice-devel I have. I'm trying to look more closely at the glz code, and it seems to be split: decoder in glz, encoder in spice. I propose to move them to spice-common. any objections? The reason I propose

Re: [Spice-devel] [PATCH 11/12] add benchmarks for memcpy (RtlCopyMemory) vs fast - fast is slower

2014-05-04 Thread Alon Levy
On 05/02/2014 02:21 PM, Marc-André Lureau wrote: - Original Message - Two benchmarks: 1. standalone, actually uses LIBCMT's memcpy to compare. 2. Part of qxldd.dll (in display/res.c called from display/driver.c) so using the same implementation. Note: next commit removes

Re: [Spice-devel] [PATCH 01/12] Revert miniport: halve QXL_IO_UPDATE_IRQ calls

2014-05-01 Thread Alon Levy
On 04/30/2014 07:28 PM, Marc-André Lureau wrote: ack, should the bug state be changed back to ASSIGNED? I did that. - Original Message - From: Yonit Halperin yhalp...@redhat.com This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046. The patch causes the display to get

Re: [Spice-devel] [PATCH 05/12] build.bat: fix copy to install dir for amd64

2014-05-01 Thread Alon Levy
On 04/30/2014 07:32 PM, Marc-André Lureau wrote: - Original Message - --- xddm/build.bat | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xddm/build.bat b/xddm/build.bat index 1d19875..7dfe51b 100755 --- a/xddm/build.bat +++ b/xddm/build.bat

[Spice-devel] [PATCH 02/12] miniport/qxl.inf: simplify by having FeatureScore for everyone

2014-04-30 Thread Alon Levy
FeatureScore is the only difference between the _vista options and the rest, so just setting it also for windows xp using drivers results in a simplification of the inf file, and no downside. According to [1] we use a feature score of FC to indicate a windows 2000 display driver [1]

[Spice-devel] [PATCH 05/12] build.bat: fix copy to install dir for amd64

2014-04-30 Thread Alon Levy
--- xddm/build.bat | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xddm/build.bat b/xddm/build.bat index 1d19875..7dfe51b 100755 --- a/xddm/build.bat +++ b/xddm/build.bat @@ -16,6 +16,12 @@ if not DEFINED SPICE_COMMON_DIR ( set

[Spice-devel] [PATCH 06/12] build.bat: more verbose build

2014-04-30 Thread Alon Levy
--- xddm/build.bat | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xddm/build.bat b/xddm/build.bat index 7dfe51b..b2c5149 100755 --- a/xddm/build.bat +++ b/xddm/build.bat @@ -30,9 +30,10 @@ if not x%1 == x set DEST=%1 :build cd miniport -build -cZg +build -ceZg cd

[Spice-devel] [PATCH 08/12] adding initial empty AMD64 only external asm file

2014-04-30 Thread Alon Levy
--- xddm/display/amd64/x64.asm | 1 + xddm/display/sources | 1 + 2 files changed, 2 insertions(+) create mode 100644 xddm/display/amd64/x64.asm diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm new file mode 100644 index 000..e32b0df --- /dev/null +++

[Spice-devel] [PATCH 03/12] display/res.h: remove whitespace at EOF

2014-04-30 Thread Alon Levy
--- xddm/display/res.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xddm/display/res.h b/xddm/display/res.h index 6ce9a68..4d179c5 100644 --- a/xddm/display/res.h +++ b/xddm/display/res.h @@ -74,4 +74,4 @@ void EmptyReleaseRing(PDev *pdev); void

[Spice-devel] [PATCH 04/12] display\driver.c: remove unused FlotaToFixed

2014-04-30 Thread Alon Levy
--- xddm/display/driver.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/xddm/display/driver.c b/xddm/display/driver.c index aa4fe42..5a3dbfa 100644 --- a/xddm/display/driver.c +++ b/xddm/display/driver.c @@ -1252,20 +1252,6 @@ char *BitmapTypeToStr(int type) #include utils.h

[Spice-devel] [PATCH 01/12] Revert miniport: halve QXL_IO_UPDATE_IRQ calls

2014-04-30 Thread Alon Levy
From: Yonit Halperin yhalp...@redhat.com This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046. The patch causes the display to get stuck. Till we understand exactly why, I'm reverting it. --- xddm/miniport/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xddm/miniport/qxl.c

[Spice-devel] [PATCH 07/12] xddm/display/res.c: move ALIGN out of Save/RestoreFPU for easier amd64 implementation

2014-04-30 Thread Alon Levy
--- xddm/display/res.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/xddm/display/res.c b/xddm/display/res.c index bfb3571..289ece5 100644 --- a/xddm/display/res.c +++ b/xddm/display/res.c @@ -1811,13 +1811,11 @@ static void FreeBitmapImage(PDev *pdev,

[Spice-devel] [PATCH 00/12] Fix 705785 (remove fast_memcpy_*)

2014-04-30 Thread Alon Levy
: halve QXL_IO_UPDATE_IRQ calls is included. Alon Levy (11): miniport/qxl.inf: simplify by having FeatureScore for everyone display/res.h: remove whitespace at EOF display\driver.c: remove unused FlotaToFixed build.bat: fix copy to install dir for amd64 build.bat: more verbose build xddm

[Spice-devel] [PATCH 12/12] display: use RtlCopyMemory instead of fast_memcpy_*

2014-04-30 Thread Alon Levy
It is common practice to use RtlCopyMemory. Currently it is defined by the preprocessor to be memcpy, which outperforms our implementation, see previous benchmark commit. This commit removes the benchmarks and our internal implementation in favor of RtlCopyMemory. RHBZ: 705785 ---

[Spice-devel] [PATCH 09/12] xddm/display/amd64: implement CheckAndSetSSE2

2014-04-30 Thread Alon Levy
--- xddm/display/amd64/x64.asm | 13 + xddm/display/res.c | 4 2 files changed, 17 insertions(+) diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm index e32b0df..36971d3 100644 --- a/xddm/display/amd64/x64.asm +++ b/xddm/display/amd64/x64.asm @@ -1

[Spice-devel] [PATCH 11/12] add benchmarks for memcpy (RtlCopyMemory) vs fast - fast is slower

2014-04-30 Thread Alon Levy
Two benchmarks: 1. standalone, actually uses LIBCMT's memcpy to compare. 2. Part of qxldd.dll (in display/res.c called from display/driver.c) so using the same implementation. Note: next commit removes benchmark code as well as fast_memcpy_* code and related SSE check and FPU save/restore.

[Spice-devel] [PATCH 10/12] xddm/display/amd64: implement Save/RestoreFPU fast_memcpy_*

2014-04-30 Thread Alon Levy
Some notes: Follows AMD64 calling conventions. Uses masm 64 (ml64.exe). Dropped in the next patches because it is too slow. --- xddm/display/amd64/x64.asm | 236 + xddm/display/res.c | 13 +-- 2 files changed, 241 insertions(+), 8 deletions(-)

Re: [Spice-devel] [PATCH 02/12] miniport/qxl.inf: simplify by having FeatureScore for everyone

2014-04-30 Thread Alon Levy
I forgot to mention in the cover letter: I fixed the comment here per old review by Yonit. Review appreciated! On 04/30/2014 05:40 PM, Alon Levy wrote: FeatureScore is the only difference between the _vista options and the rest, so just setting it also for windows xp using drivers results

Re: [Spice-devel] [PATCH 3/2] marshaller: Use #include for headers in $srcdir/common

2014-04-06 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/02/2014 12:27 PM, Christophe Fergeau wrote: Ping ? If this doesn't break (i.e. we have a -I directive for every required directory) then ack. On Tue, Mar 25, 2014 at 04:40:14PM +0100, Christophe Fergeau wrote: Since the (de)marshallers

Re: [Spice-devel] [PATCH spice-gtk 1/2] Add webdav channel

2014-03-20 Thread Alon Levy
On 03/19/2014 07:33 PM, Marc-André Lureau wrote: Hi On Mon, Mar 17, 2014 at 8:54 AM, Alon Levy al...@redhat.com wrote: Would be nice to use an actual constant for this instead of relying on G_MAXUINT16 here and above. Sorry, I forgot to address your comments. What about

Re: [Spice-devel] [PATCH spice-gtk 1/2] Add webdav channel

2014-03-17 Thread Alon Levy
On 02/28/2014 02:16 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com See spice-common for protocol details. phodav, a webdav server library, is imported thanks to a submodule, until this project has a stable API and releases. The webdav channel is

Re: [Spice-devel] [PATCH spice-common] RFC: spice.proto: add webdav channel

2014-03-17 Thread Alon Levy
On 03/14/2014 06:17 PM, Marc-André Lureau wrote: If no further comments, can I move ahead adding that new channel? ACK by me. On Fri, Feb 28, 2014 at 4:39 PM, David Jaša dj...@redhat.com wrote: On Čt, 2014-02-27 at 18:27 +0100, Marc-André Lureau wrote: Hi On Wed, Feb 26, 2014 at 11:00

Re: [Spice-devel] [PATCH] Don't truncate large 'now' values in _spice_timer_set

2014-03-17 Thread Alon Levy
On 03/10/2014 12:58 PM, Christophe Fergeau wrote: From: David Gibson dgib...@redhat.com static void _spice_timer_set(SpiceTimer *timer, uint32_t ms, uint32_t now) The _spice_timer_set() function takes a 32-bit integer for the now value. The now value passed in however, can exceed 2^32

Re: [Spice-devel] Mouse mode client vs Mouse mode server

2014-03-17 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/15/2014 06:33 AM, Lindsay Mathieson wrote: Whats the significance of this? does server mode come into play when there is no qxl spice agent in the guest? client/server mode has the client/server determine the location of the cursor and

Re: [Spice-devel] [PATCH] migration: Don't assert() if MIGRATE_DATA comes before attaching the agent

2014-03-17 Thread Alon Levy
On 02/24/2014 07:44 PM, Christophe Fergeau wrote: During seamless migration, after switching host, if a client was connected during the migration, it will have data to send back to the new qemu/spice-server instance. This is handled through MIGRATE_DATA messages. SPICE char devices use such

Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-03-16 Thread Alon Levy
On 01/12/2014 07:34 PM, Marc-André Lureau wrote: For example, with qemu, a webdav channel can be created this way: -chardev spiceport,name=org.spice-space.webdav.0,... And redirected to a virtio port: -device virtserialport,...,name=org.spice-space.webdav.0 Ack. Still reviewing the

Re: [Spice-devel] [vdagent-win 0/2] Add VD_AGENT_CAP_MAX_CLIPBOARD support

2014-03-10 Thread Alon Levy
On 03/09/2014 07:01 PM, Uri Lublin wrote: This patch-set adds support for max-clipboard. The implementation is similar to the implementation of linux-vdagent. Patch1 fixes clipboard error handling (also will be used in Patch2) Patch2 implements max-clipboard support Patches look good to me.

Re: [Spice-devel] [PATCH spice-gtk 0/2] WebDAV channel

2014-03-03 Thread Alon Levy
On 02/28/2014 02:16 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Hi, This is the client bits to get folder sharing capability using the WebDAV channel. How to test it? You'll need spice-server with this patch:

Re: [Spice-devel] Kubuntu as a KVM virtualised guest with spice drivers

2014-03-02 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/2014 05:30 AM, Lindsay Mathieson wrote: My apologies if this is inappropriate for the list. I run a proxmox cluster at work (kvm/qemu 1.7) and X just restarts constantly when trying to use the guest drivers for spice (QXL,

Re: [Spice-devel] How to start with Spice Development?

2014-02-25 Thread Alon Levy
On 02/17/2014 08:14 PM, Jeremy White wrote: On 02/17/2014 08:44 AM, Alf G. wrote: Hi, I am very interested to delve into spice and perhaps do some work on it. What is the best way to start? Can I use the documents on spice-space.org/documentation.html

Re: [Spice-devel] Building Spice in an IDE

2014-02-24 Thread Alon Levy
On 02/01/2014 12:54 AM, Wade Johnson wrote: Hi, I am trying to build Spice in Eclipse and make a test environment, but I am having some issues mostly with some dependencies not being resolved, and some constant definitions not being found. Are there any pointers or build guides to getting

[Spice-devel] [PATCH] Handle SIGUSR1 from and SIGHUP to X

2014-01-27 Thread Alon Levy
From: Anonymous wishes@to.remain Relevant excerpt from Xserver(1) man page: /SIGUSR1/ This signal is used quite differently from either of the above. When the server starts, it checks to see if it has inherited SIGUSR1 as SIG_IGN instead of the usual SIG_DFL. In this case, the

Re: [Spice-devel] [Users] Windows guest

2014-01-20 Thread Alon Levy
: Alon Levy [mailto:al...@redhat.com] Sent: Sunday, January 19, 2014 9:06 AM To: Itamar Heim; Maurice James; us...@ovirt.org; spice-devel Subject: Re: [Spice-devel] [Users] Windows guest On 01/18/2014 12:36 AM, Itamar Heim wrote: On 01/16/2014 04:22 PM, Maurice James wrote: Does anyone know

Re: [Spice-devel] [PATCH] randr: Make resolution changing more robust

2014-01-20 Thread Alon Levy
On 01/20/2014 06:43 PM, Christophe Fergeau wrote: When running a guest using a KMS QXL driver on a RHEL6 hypervisor, spice_vdagent would crash on resolution changes with: X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request:

Re: [Spice-devel] Meeting at FOSDEM'14

2014-01-19 Thread Alon Levy
On 01/17/2014 10:24 PM, Fedor Lyakhov wrote: Hi, Who is going to visit FOSDEM this year? It would be nice to meet you there! I'll be giving a talk https://fosdem.org/2014/schedule/event/virtiaas23/ on Sunday (Feb 2nd) in the Virtualisation dev room, and you're very welcome! I am going to

Re: [Spice-devel] [Users] Windows guest

2014-01-19 Thread Alon Levy
On 01/18/2014 12:36 AM, Itamar Heim wrote: On 01/16/2014 04:22 PM, Maurice James wrote: Does anyone know if directdraw/directx works on windows guests in Ovirt? adding spice devel There is no direct3d or directdraw implementation in the driver we provide.

Re: [Spice-devel] [PATCH 00/17] Split RedsStream out of reds.c

2014-01-13 Thread Alon Levy
On 01/07/2014 01:14 PM, Christophe Fergeau wrote: Hey, This is a series I've had locally for a while. It moves RedsStream related code out of reds.c to its own file. This shaves ~1000 lines of code out of reds.c The patch series could be split in 2 independent series, first one would be

Re: [Spice-devel] [PATCH 03/17] Move sync_write* to reds_stream.h

2014-01-13 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/13/2014 01:00 PM, Christophe Fergeau wrote: On Sun, Jan 12, 2014 at 01:04:10PM +0200, Alon Levy wrote: On 01/07/2014 01:14 PM, Christophe Fergeau wrote: They are renamed to reds_stream_write* You also changed the return type

Re: [Spice-devel] [PATCH 3/3] Add VD_AGENT_CAP_MAX_CLIPBOARD support

2014-01-12 Thread Alon Levy
On 01/07/2014 01:28 AM, Marc-André Lureau wrote: ping Looks good to me. On Thu, Nov 14, 2013 at 5:03 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: From: Marc-André Lureau marcandre.lur...@gmail.com Do not send clipboard data bigger than last received VDAgentMaxClipboard.

Re: [Spice-devel] Fw: Re: multiple client connect spice-server

2014-01-12 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/07/2014 01:10 PM, Lindsay Mathieson wrote: On Tue, 7 Jan 2014 10:38:26 AM David Ja?a wrote: No, only one client can connect at the same time. David On Út, 2014-01-07 at 10:05 +0800, hhb584520 wrote: how to multiple spice clients can

Re: [Spice-devel] [PATCH 03/17] Move sync_write* to reds_stream.h

2014-01-12 Thread Alon Levy
On 01/07/2014 01:14 PM, Christophe Fergeau wrote: They are renamed to reds_stream_write* You also changed the return type for reds_stream_write_all (was sync_write) to bool, which is now being cast to int in some code paths. Not an objection, but perhaps worth a later patch (unless it's already

Re: [Spice-devel] [PATCH 16/17] Introduce reds_stream_set_channel()

2014-01-12 Thread Alon Levy
On 01/07/2014 01:14 PM, Christophe Fergeau wrote: --- server/reds.c| 6 +++--- server/reds_stream.c | 9 + server/reds_stream.h | 2 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index a993f2c..c6983d8 100644 ---

Re: [Spice-devel] some question about spice client project cegui gui implement

2014-01-05 Thread Alon Levy
On 12/23/2013 04:19 AM, feifei li wrote: Dear all: I read spice client project,find that gui is implement by CEGUI.The taharez_look.scheme,taharez_look.looknfeel,taharez_look.imageset files are provied by XML foemat in CEGUI system, but are provided by .c format in spice client project.I

Re: [Spice-devel] SPICE and guest breakout risk assessment

2014-01-01 Thread Alon Levy
On 12/30/2013 08:44 AM, adrelanos wrote: Hi, I am currently working on testing out KVM as a platform for Whonix, a Debian based spin with anonymity enforcement via usage of virtual machines. All traffic from a workstation vm is forced through a Tor gateway on the second gateway vm.

Re: [Spice-devel] Why spice server can't update area by tree?

2013-12-12 Thread Alon Levy
On 12/08/2013 08:57 AM, thddu wrote: I found some guest applications create a lot of unnecessary qxl commands rendering. But update_area logic of spice server does not utilize the current tree. 1、Why spice server can't update area by tree? I think it's just a todo item. You can see

Re: [Spice-devel] Mouse Edit Cursor invisible on dark backgrounds in Win 7 Guest

2013-12-09 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/07/2013 05:06 PM, Lindsay Mathieson wrote: On Sat, 7 Dec 2013 09:21:44 AM Marian Krcmarik wrote: Most likely The problem you described is fixed by http://lists.freedesktop.org/archives/spice-devel/2013-October/015079.html, So The bug

Re: [Spice-devel] [PATCH spice-gtk 3/5] Add SpiceVMC GIOStream

2013-11-18 Thread Alon Levy
On 11/18/2013 01:03 AM, Marc-André Lureau wrote: Hey Fedor On Sun, Nov 17, 2013 at 5:48 PM, Fedor Lyakhov fedor.lyak...@gmail.com wrote: Marc, What does VMC stand for here? Is it related to my idea of virtual media controller, or just a coincidence? It's a coincidence ;) Hans should

Re: [Spice-devel] [PATCH 9/9] chardev: learn to keep running when vm is stopped

2013-11-18 Thread Alon Levy
On 11/18/2013 12:28 PM, Marc-André Lureau wrote: All chardev channels are stopped when calling spice_server_vm_stop(), which prevents them from doing any i/o. However, the Spice block device channel needs to keep running even when the VM is stopped. It is entirely drived by the server, so it

Re: [Spice-devel] [PATCH 4/9] build-sys: bump current, as ABI is going to be broken next

2013-11-18 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2013 02:21 PM, Christophe Fergeau wrote: On Mon, Nov 18, 2013 at 11:28:28AM +0100, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Spice-devel] [Qemu-devel] [PATCH 05/21] char: add qemu_chr_fe_event()

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com The patch description is incomplete, or the patch should be split - this patch also implements qemu_chr_fe_event for spiceport. Signed-off-by: Marc-André Lureau marcandre.lur...@redhat.com

Re: [Spice-devel] [PATCH 20/21] spice-core: allow an interface to be in AIO context

2013-11-18 Thread Alon Levy
On 11/18/2013 02:25 PM, Marc-André Lureau wrote: The Spice block driver must be able complete operations within a AIO context only. Spice is currently only running within the main loop, and doesn't allow the block driver to complete operations, such as flush during migration. This patch

  1   2   3   4   5   6   7   8   9   10   >