Re: [Spice-devel] No Sound with RemoteViewer on OSX Client

Forgot to include the mailing list, so I'm replying again, sorry. Jakub On Wed, Feb 24, 2021 at 12:49 PM Jakub Janku wrote: > > On Tue, Feb 23, 2021 at 11:47 PM Matthew Sienko wrote: > > > > Thanks for the reply. I installed gst-plugins-good using brew and I still >

Re: [Spice-devel] No Sound with RemoteViewer on OSX Client

Hi, On Sun, Feb 21, 2021 at 9:37 AM Matthew Sienko wrote: > > Hello, > > When connecting to a VM running on a Linux server from a client on OSX, the > connection works but without sound. I am using the RemoteViewer bundle > version 0.5.7 on OS X 11.2.1. When the guest OS sends audio, I get the

Re: [Spice-devel] Working seamless mode

Hi, On Sat, Jan 2, 2021 at 9:49 AM Roland Baudin wrote: > > Hi, > > perhaps this is not the right place for this request? Could you give me > some place where I can post this request? This is the right place, I believe. Alternatively, you could open a new issue here:

Re: [Spice-devel] How to build Windows vdagent?

Hi, are you using mingw64-configure? Sometimes, when you don't know how to build something, you can get some hints from the pipeline configuration file, in this case .gitlab-ci.yml. Regards, Jakub On Thu, Oct 29, 2020 at 4:10 PM Ian Pilcher wrote: > > On 10/29/20 3:10 AM, Frediano Ziglio

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

On Wed, Sep 9, 2020 at 5:27 PM Frediano Ziglio wrote: > > > Hi > > > On Wed, Sep 9, 2020 at 6:45 PM Jakub Janku < jja...@redhat.com > wrote: > > > > On Wed, Sep 9, 2020 at 4:36 PM Frediano Ziglio < fzig...@redhat.com > > > > wrote: > > >

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

On Wed, Sep 9, 2020 at 4:36 PM Frediano Ziglio wrote: > > > On Wed, Sep 9, 2020 at 4:16 PM Frediano Ziglio wrote: > > > > > > > > commit 4b9092b96b8da946ff3d17922b0fcf225c5dc81f > > > > > > > > > Author: Jakub Janků < jja...@redhat.com > > > > > > > > > > Date: Sat May 23 16:28:52 2020 +0200 > >

Re: [Spice-devel] [Spice-commits] 6 commits - meson.build src/map-file src/spice-glib-sym-file src/spice-gtk-session.c src/spice-session.c src/spice-session.h src/spice-session-priv.h

On Wed, Sep 9, 2020 at 4:16 PM Frediano Ziglio wrote: > > > > commit 4b9092b96b8da946ff3d17922b0fcf225c5dc81f > > > > > Author: Jakub Janků < jja...@redhat.com > > > > > > Date: Sat May 23 16:28:52 2020 +0200 > > > > > > session: make spice_session_get_webdav_server() public > > > > > > It will

Re: [Spice-devel] Can't write from guest to host with webdav

On Sun, Jul 19, 2020 at 10:04 PM Koopa Koopa wrote: > > On 7/19/20, Jakub Janku wrote: > > On Sun, Jul 19, 2020 at 6:12 PM Koopa Koopa wrote: > >> > >> On 7/19/20, Jakub Janku wrote: > >> > Hi! > >> > > >> > On Sun, Jul 19,

Re: [Spice-devel] Can't write from guest to host with webdav

On Sun, Jul 19, 2020 at 6:12 PM Koopa Koopa wrote: > > On 7/19/20, Jakub Janku wrote: > > Hi! > > > > On Sun, Jul 19, 2020 at 9:34 AM Koopa Koopa wrote: > >> > >> Hi all, > >> > >> I'm looking to share a folder between my Arch Linux

Re: [Spice-devel] Can't write from guest to host with webdav

Hi! On Sun, Jul 19, 2020 at 9:34 AM Koopa Koopa wrote: > > Hi all, > > I'm looking to share a folder between my Arch Linux host and a Windows 10 > guest, and SPICE's folder sharing with webdav seems to be the best option for > me. I've set up the QEMU devices that webdav needs, and installed

Re: [Spice-devel] Is it possible to put spice channels into different threads?

Hi, yes, I think this is a real issue. I feel like I've stumbled across something similar in the past when working on webdav. So yeah, it seems like the channel might get blocked in one direction -- meaning data isn't sent until you read all available data. However, that doesn't mean that other

[Spice-devel] phodav: OutputQueue refactor & misc

https://gitlab.gnome.org/GNOME/phodav/merge_requests/5/ ping ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk] webdav: fix usecase with multiple concurrent connections

Hi, On Fri, Aug 23, 2019 at 3:36 PM Victor Toso wrote: > > Hi, > > On Fri, Aug 23, 2019 at 11:57:55AM +0200, Jakub Janku wrote: > > ping > > Yep, sorry > > > > > Also forgot to mention that this fixes a regression introduced by me > > in 9f5aee05. &

Re: [Spice-devel] [PATCH spice-gtk] webdav: fix usecase with multiple concurrent connections

ping Also forgot to mention that this fixes a regression introduced by me in 9f5aee05. On Thu, Aug 8, 2019 at 11:03 AM Jakub Janků wrote: > > GOutputStream does not allow simultaneous tasks on a single > stream. An attempt to transfer two files therefore > results into one of the clients being

Re: [Spice-devel] [PATCH spice-gtk 1/2 v2] channel-webdav: Write mux message in a single memory block

Acked-by: Jakub Janků On Wed, Jul 3, 2019 at 11:42 AM Frediano Ziglio wrote: > > Reduce number of write to the channel. > This will also help making the write to socket all asynchronous > avoiding potential blockages. > > Signed-off-by: Frediano Ziglio > --- > Changes sinve v1: > - make "mux"

Re: [Spice-devel] [PATCH spice-gtk 1/2] channel-webdav: Write mux message in a single memory block

On Wed, Jul 3, 2019 at 10:35 AM Frediano Ziglio wrote: > > Reduce number of write to the channel. > This will also help making the write to socket all asynchronous > avoiding potential blockages. > > Signed-off-by: Frediano Ziglio > --- > src/channel-webdav.c | 28 +--- >

Re: [Spice-devel] [PATCH spice-gtk] webdav: don't buffer input from phodav

Hi again, On Mon, Jul 1, 2019 at 3:16 PM Jakub Janku wrote: > > Hi, > > On Mon, Jul 1, 2019 at 1:02 PM Frediano Ziglio wrote: > > > > > > > > The current approach with OutputQueue in webdav has several problems: > > > > > > * if th

Re: [Spice-devel] [PATCH spice-gtk] webdav: don't buffer input from phodav

Hi, On Mon, Jul 1, 2019 at 1:02 PM Frediano Ziglio wrote: > > > > > The current approach with OutputQueue in webdav has several problems: > > > > * if the connection is slow, webdav keeps reading from phodav > > and pushing messages to the internal channel xmit_queue. > > This way, the queue can

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: return if has_error is TRUE in spice_channel_write_msg

Hi, On Thu, Jun 27, 2019 at 10:10 AM Frediano Ziglio wrote: > > > > > Avoid linearizing if the message isn't written out anyway > > "linearizing" ? What do you mean about that? > Looking at definitions it seems not correct to me. I was simply referring to the spice_marshaller_linearize() call.

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Fix typo in comment

Sure, Acked-by: Jakub Janků On Tue, Jun 25, 2019 at 12:13 PM Frediano Ziglio wrote: > > explicitely -> explicitly > > Signed-off-by: Frediano Ziglio > --- > src/channel-main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-main.c b/src/channel-main.c >

Re: [Spice-devel] [PATCH spice-gtk 4/5] webdav: remove client on empty message

Hi, On Wed, Jun 19, 2019 at 11:59 AM Frediano Ziglio wrote: > > > > > Message with no data from spice-webdav daemon means > > the client disconnected. > > > > In this case, the client connection to phodav > > should be closed as well. > > > > This can happen e.g. when file transfer gets

Re: [Spice-devel] [PATCH phodav 03/13] spice: handle SIGINT properly

Hi, On Mon, May 27, 2019 at 5:58 PM Frediano Ziglio wrote: > > > > > Hi, > > > > On Thu, May 23, 2019 at 3:31 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Thu, May 23, 2019 at 10:37 AM Jakub Janků wrote: > > > > > > > > According to [0], g_debug should not be used in a signal

Re: [Spice-devel] [PATCH phodav 03/13] spice: handle SIGINT properly

Hi, On Thu, May 23, 2019 at 3:31 PM Marc-André Lureau wrote: > > Hi > > On Thu, May 23, 2019 at 10:37 AM Jakub Janků wrote: > > > > According to [0], g_debug should not be used in a signal handler. > > So, to avoid reentrancy, do not print debug message when quit is > > called with SIGINT. > >

Re: [Spice-devel] [PATCH spice-gtk v2] Add Czech Translation

On Thu, Apr 18, 2019 at 1:27 PM David Jaša wrote: > > Changes since v1: > * added 'cs' to LINGUAS > * added both plurals after fix of > https://gitlab.freedesktop.org/spice/spice-gtk/issues/95 > * tried to address review comments by Jakub > > Signed-off-by: David Jaša > --- > po/LINGUAS | 1

Re: [Spice-devel] [PATCH spice-gtk] Add Czech translation

Hi David, On Fri, Apr 12, 2019 at 3:15 PM David Jaša wrote: > > At last. :) Great, thanks a lot! > > Signed-off-by: David Jaša > --- > po/cs.po | 336 +++ > 1 file changed, 336 insertions(+) > create mode 100644 po/cs.po > > diff --git

Re: [Spice-devel] [PATCH spice-gtk] gettext: fix ngettext usage

On Wed, Apr 17, 2019 at 6:24 PM Frediano Ziglio wrote: > > > > > _() should not be used in conjunction with ngettext(), > > otherwise it's impossible to properly translate the message into > > languages that have multiple plural forms, such as Czech. > > > > Fix ngettext usage in

Re: [Spice-devel] [PATCH spice-gtk] gettext: fix ngettext usage

On Wed, Apr 17, 2019 at 5:25 PM Frediano Ziglio wrote: > > > > > _() should not be used in conjunction with ngettext(), > > otherwise it's impossible to properly translate the message into > > languages that have multiple plural forms, such as Czech. > > > > Fix ngettext usage in

Re: [Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

Hi, On Sun, Mar 24, 2019 at 7:40 PM Marc-André Lureau wrote: > > Hi > > On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote: > > > > On Fri, Mar 22, 2019 at 2:57 PM wrote: > > > > > > From: Marc-André Lureau > > > > > > When t

Re: [Spice-devel] [PATCH spice-gtk 2/2] clipboard: do not release between remote grabs

Hi, On Sun, Mar 24, 2019 at 7:45 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > > Hi > > On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote: > > > > Hi, > > > > On Thu, Mar 21, 2019 at 1:21 PM wrote: > > > > > > From: Mar

Re: [Spice-devel] [PATCH spice-gtk 1/2] clipboard: do not release between client grabs

Hi, On Sun, Mar 24, 2019 at 7:26 PM Marc-André Lureau wrote: > > Hi > > On Sun, Mar 24, 2019 at 6:50 PM Jakub Janku wrote: > > > > Hi, > > > > On Thu, Mar 21, 2019 at 1:21 PM wrote: > > > > > > From: Marc-André Lureau > >

Re: [Spice-devel] [PATCH linux/vd-agent 08/11] clipboard: gobject-ify VDAgentClipboards

Hi, On Mon, Mar 25, 2019, 11:34 AM Marc-André Lureau wrote: > Hi > > On Mon, Mar 25, 2019 at 10:26 AM Frediano Ziglio > wrote: > > > > > > > > From: Marc-André Lureau > > > > > > This will allow easier lifecycle management, > > > and usage of gtk_clipboard_set_with_owner() > > > > > >

Re: [Spice-devel] [PATCH linux/vd-agent 02/11] session: free active session

On Fri, Mar 22, 2019 at 4:13 PM wrote: > > From: Marc-André Lureau > > According to sd_seat_get_active(2), you must free() the pointer. > > Signed-off-by: Marc-André Lureau > --- > src/vdagentd/systemd-login.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk 0/2] clipboard: skip release between grabs

Hi, On Fri, Mar 22, 2019 at 10:15 AM Victor Toso wrote: > > Hi James, > > If you have the time, could you give this a try? CC-ing James > > Cheers, > > On Thu, Mar 21, 2019 at 01:21:32PM +0100, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > There has been

Re: [Spice-devel] [PATCH spice-gtk 1/2] clipboard: do not release between client grabs

Hi, On Thu, Mar 21, 2019 at 1:21 PM wrote: > > From: Marc-André Lureau > > On the client side, whenever the grab owner changes (and the clipboard > was previously grabbed), spice-gtk sends a clipboard release followed > immediately by a new grab. But some clipboard managers on the remote > side

Re: [Spice-devel] [PATCH spice-gtk 2/2] clipboard: do not release between remote grabs

Hi, On Thu, Mar 21, 2019 at 1:21 PM wrote: > > From: Marc-André Lureau > > Delay the release events for 0.5 sec. If no further grab comes in, > then release the grab. Otherwise, let's skip the release. This avoids > some races with clipboard managers. > > Related to: >

Re: [Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

On Fri, Mar 22, 2019 at 2:57 PM wrote: > > From: Marc-André Lureau > > When this capability is negoticated by both the client & the agent, > the clipboard grab messages have an associated serial counter. > > The serial is reset to 0 upon client connection. > > The counter is increment by 1 on

Re: [Spice-devel] [PATCH linux/vd-agent 06/11] configure: bump gobject >= 2.50

Hi, On Fri, Mar 22, 2019 at 4:13 PM wrote: > > From: Marc-André Lureau > > This is required for using the new GObject macros. Which macros are you referring to? G_DECLARE_FINAL_TYPE is available since 2.44 > > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump > GLib version

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

Hey, On Fri, Mar 15, 2019 at 8:02 PM Marc-André Lureau wrote: > > Hi > > On Fri, Mar 15, 2019 at 4:43 PM Jakub Janku wrote: > > > > Hi, > > > > On Thu, Mar 14, 2019 at 6:18 PM Marc-André Lureau > > wrote: > > > > > > Hi &g

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

Hi, On Thu, Mar 14, 2019 at 6:18 PM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > If two grab messages in opposite directions "meet" on their way > > to their destinations, we end up in a state when both spice-gtk > > and spice-vdagent think that

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

Hi again, On Fri, Mar 8, 2019 at 4:00 PM Marc-André Lureau wrote: > > Hi > > On Fri, Mar 8, 2019 at 1:41 PM Jakub Janku wrote: > > > > Hi, > > > > On Fri, Mar 8, 2019 at 1:15 PM Marc-André Lureau > > wrote: > > > > > > Hi &g

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

Hi, On Fri, Mar 8, 2019 at 1:15 PM Marc-André Lureau wrote: > > Hi > > On Thu, Mar 7, 2019 at 10:36 PM Jakub Janku wrote: > > > > Hi, > > > > thanks for having a look! > > > > On Wed, Mar 6, 2019 at 6:42 PM Marc-André Lureau > > wrote: >

Re: [Spice-devel] [PATCH spice-gtk 3/3] clipboard: invalidate targets request when needed

Hi, On Wed, Mar 6, 2019 at 7:11 PM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > Targets request is no longer relevant when > > clipboard owner changes since the retrieved targets > > will be outdated. > > > > When the request is no longer

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

Hi, thanks for having a look! On Wed, Mar 6, 2019 at 6:42 PM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > > > If two grab messages in opposite directions "meet" on their way > > to their destinations, we end up in a state when both spice-gtk > >

Re: [Spice-devel] [linux/vd-agent v2 3/5] README: Remove non relevant features information

Hi, On Mon, Feb 25, 2019 at 6:04 PM Victor Toso wrote: > > From: Victor Toso > > It is not relevant nowadays that *spicec* client was removed and even > monitors_config does not reach spice-vdagent in modern Guests. > Can't really evaluate this with my current knowledge of spice & monitor

Re: [Spice-devel] [linux/vd-agent 5/5] CHANGELOG: Move NEWS' content

Hi, NEWS is appended to EXTRA_DIST var in Makefile.am, so we should change that to CHANGELOG.md, if I'm not mistaken. Jakub On Fri, Feb 22, 2019 at 6:23 PM Victor Toso wrote: > > From: Victor Toso > > And add some Markdown style. > > Signed-off-by: Victor Toso > --- > CHANGELOG.md | 47

Re: [Spice-devel] [linux/vd-agent 3/3] README: Use block quotes for code or paths

Hi, in the README file, there are some formatting errors that I think could be fixed in this patch as well, namely: * Sentence starting with "Then connect" should be in a new paragraph, not in the nested list * the command "spicec --full-screen=auto-config" could be enclosed in backquotes rather

Re: [Spice-devel] [linux/vd-agent 0/3] rm TODO and README -> README.md

Hi, while we're at it, what about merging ChangeLog and NEWS into one file and using markdown here as well? Gitlab seems to favour ChangeLog over NEWS, so if you click the "CHANGELOG" button at [0], the ChangeLog file is shown which does not contain the latest updates. [0]

Re: [Spice-devel] [spice-gtk [rfc] 1/2] gtk-session: introduce clipboard-managers property

Hi, On Tue, Jan 15, 2019 at 5:11 PM Victor Toso wrote: > > From: Victor Toso > > SpiceGtkSession::allow-clipboard-managers property is introduced to > enable other applications in the Client OS to set or fetch clipboard > data from a spice-gtk-session that is under keyboard-grab, which is >

Re: [Spice-devel] [spice-gtk [rfc] 0/2] Clipboard managers and Spice

On Mon, Feb 11, 2019 at 3:05 PM Victor Toso wrote: > > Hi, > > On Mon, Feb 11, 2019 at 02:46:55PM +0100, Jakub Janku wrote: > > Hi, > > > > not a full review, but this is my main concern with this series: > > > > If you enable the new --allow-clipboard-

Re: [Spice-devel] [spice-gtk [rfc] 0/2] Clipboard managers and Spice

Hi, not a full review, but this is my main concern with this series: If you enable the new --allow-clipboard-managers property, the behaviour stays the same as it is at the moment, so you're basically enabling a bug in the code and it's being advertised as a feature. This seems just wrong to me.

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

On Mon, Feb 11, 2019 at 10:30 AM Victor Toso wrote: > > Hi, > > On Mon, Feb 11, 2019 at 10:12:42AM +0100, Jakub Janku wrote: > > ping? > > Should be fixed by: You can double-check with James to be sure, but I don't think that's true. If you look at the logs ( https://ter

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

ping? On Mon, Jan 28, 2019 at 10:29 AM Jakub Janku wrote: > > Hi, > > I tried to fix this bug in a less radical way, but my patch unfortunately did > not cover all the cases. > > I obtained some logs from James Harvey which make the situation clearer - it > ca

Re: [Spice-devel] [vdagent-linux v3] vdagent: Use g_file_test() instead of direct stat call

On Wed, Jan 30, 2019 at 1:50 PM Christophe Fergeau wrote: > > vdagent.c has a 'file_test' function which tests for the existence of > the /dev entry for the spicevmc channel. glib already provides such a > g_file_test() function, so we can use it instead. > > Signed-off-by: Christophe Fergeau >

Re: [Spice-devel] [vdagent-linux v2 1/2] vdagent: Silently ignore missing spicevmc device

On Wed, Jan 30, 2019 at 6:06 PM Christophe Fergeau wrote: > > On Wed, Jan 30, 2019 at 01:46:21PM +0100, Jakub Janku wrote: > > On Wed, Jan 30, 2019 at 1:23 PM Christophe Fergeau > > wrote: > > > > > > On most distros, spice-vdagent will be autostarted as part

Re: [Spice-devel] [vdagent-linux v2 1/2] vdagent: Silently ignore missing spicevmc device

On Wed, Jan 30, 2019 at 1:23 PM Christophe Fergeau wrote: > > On most distros, spice-vdagent will be autostarted as part of the > startup of the desktop environment session. This is done by > spice-vdagent.desktop, which has no way of checking if we are in a virt > environment with the needed

Re: [Spice-devel] [vdagent-linux v2 2/2] vdagent: Favour access() over stat()

Hi, On Wed, Jan 30, 2019 at 1:23 PM Christophe Fergeau wrote: > > vdagent.c has a 'file_test' function which tests for the existence of > the /dev entry for the spicevmc channel. This commit reworks it to give > it a better name, to make it return a boolean, and to use access() > rather than

Re: [Spice-devel] [spice-gtk v1 2/2] gtk-session: clipboard: add some more debugs

Hi, On Mon, Jan 28, 2019 at 1:23 PM Victor Toso wrote: > > From: Victor Toso > > To help track race conditions and bad/unexpected behavior in general. Awesome! I was planning on sending something similar too. > > Signed-off-by: Victor Toso > --- > src/spice-gtk-session.c | 24

Re: [Spice-devel] [spice-gtk v1 1/2] gtk-session: clipboard: rename functions

Hi, On Mon, Jan 28, 2019 at 1:23 PM Victor Toso wrote: > > From: Victor Toso > > * Attaching the 'guest_' prefix for actions that were started from > guest agent, those renames are: > > clipboard_grab -> guest_clipboard_grab > clipboard_release -> guest_clipboard_release > clipboard_request

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

Hi, I tried to fix this bug in a less radical way, but my patch unfortunately did not cover all the cases. I obtained some logs from James Harvey which make the situation clearer - it can be found here: https://termbin.com/40un So I'll try to explain what's happening: James uses KDE which has a

Re: [Spice-devel] [spice-gtk v2] gtk-session: clipboard request: notify agent on failure

Hi, On Wed, Jan 16, 2019 at 10:11 AM Victor Toso wrote: > > From: Victor Toso > > Similar to 172c521271a3d - if we don't, the agent might be waiting for > data till some timeout happens in the system, blocking copy-paste > feature and possibly freezing applications. > > A way to reproduce is

Re: [Spice-devel] [spice-gtk v5] gtk-session: improve doc on owner-changed

Hi, On Tue, Jan 15, 2019 at 11:22 AM Victor Toso wrote: > > From: Victor Toso > > * Set -> Sets (Jakub) > * Clarify when onwer-changed event is called with > owner == self (Jakub) > > Signed-off-by: Victor Toso > --- > src/spice-gtk-session.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [Spice-devel] [spice-gtk v3 1/3] gtk-session: clipboard: document owner-changed event

Hi, On Mon, Jan 14, 2019 at 10:34 AM Victor Toso wrote: > > Hi, > > On Sun, Jan 13, 2019 at 09:59:11PM +0100, Jakub Janku wrote: > > Hi, > > > > I see that I'm being late to the party as this has already been > > pushed upstream, but I'd like to comment anywa

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

Hi, On Mon, Jan 14, 2019 at 1:41 PM Marc-André Lureau wrote: > > Hi > > On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote: > > > > From: Victor Toso > > > > On X11, the release-grab message might end up clearing the > > GtkClipboard which triggers the owner-changed callback having the > >

Re: [Spice-devel] [spice-gtk v3 1/3] gtk-session: clipboard: document owner-changed event

Hi, I see that I'm being late to the party as this has already been pushed upstream, but I'd like to comment anyway: On Thu, Jan 10, 2019 at 1:47 PM Victor Toso wrote: > > From: Victor Toso > > This patch improves the code style by adding braces, removing the > single case switch and add

Re: [Spice-devel] [PATCH spice-gtk] gtk: don't request clipboard targets when there is no owner

Hi, On Fri, Jan 11, 2019 at 11:40 AM wrote: > > From: Marc-André Lureau > > After a clipboard-clear, the owner-changed signal is triggered, with > no owner. Let's avoid requesting for targets, that would lead to a > failure. > > Fixes: > (lt-spicy:23226): GSpice-DEBUG: 13:36:38.741:

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

On Tue, Jan 8, 2019 at 10:06 AM Victor Toso wrote: > > Hi, > > Thanks for review! > > On Mon, Jan 07, 2019 at 09:28:04PM +0100, Jakub Janku wrote: > > Hi, > > > > On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote: > > > > > > From:

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

Hi, On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote: > > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that the client should not be requesting guest's clipboard data yet. > > This patch adds a check in clipboard_get() callback, to avoid such >

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

Hi, On Wed, Jan 2, 2019, 5:31 PM Victor Toso Hi, > > Thanks for taking a look! > > On Sun, Dec 30, 2018 at 10:23:02PM +0100, Jakub Janku wrote: > > Hi, > > > > On Wed, Dec 19, 2018 at 3:30 PM Victor Toso > wrote: > > > > > > From: Vic

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

Hi, On Wed, Dec 19, 2018 at 3:30 PM Victor Toso wrote: > > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that we should not be requesting clipboard data yet. The proper time > to request it is when another application in the client machine is >

Re: [Spice-devel] [spice-gtk v2 2/7] channel-main: clipboard request: wakeup only when needed

Hi, On Mon, Dec 10, 2018 at 12:03 PM Victor Toso wrote: > > From: Victor Toso > > This patch makes agent_clipboard_request() to return true only when > the message request to the agent is successfully queued to be sent. > > By checking the return value, we can avoid wakeup the channel >

Re: [Spice-devel] [PATCH vdagent-linux 3/4] introduce VDAgentConnection

Hi, Victor! Many thanks for reviewing this series. On Thu, Dec 6, 2018 at 4:20 PM Victor Toso wrote: > > Hi, > > First of all, tested. Seems to work fine! Great! > > This one I think it can be improved to have a clear design around > VDAgentConnection. The other three patches could be merged

Re: [Spice-devel] spice can't transfer files from gust OS to client

Hi, You can use a shared folder for this purpose, consult the Spice User Manual for more details: https://www.spice-space.org/spice-user-manual.html Drag& dropping files from guest to client is currently not supported. Regards, Jakub On Nov 21, 2018 7:53 AM, "wangjiedong" wrote: I

Re: [Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

On Tue, Sep 4, 2018 at 7:02 AM Victor Toso wrote: > > Hi, > > On Mon, Sep 03, 2018 at 06:06:01PM +0200, Jakub Janku wrote: > > Hi, > > > > > I think that after "vdagentd: use GMainLoop" patch, we should > > > also include glib's command l

Re: [Spice-devel] [RFC spice-vdagent 00/18] GLib integration

Hi, On Tue, Sep 4, 2018 at 7:33 AM Victor Toso wrote: > > Hi, > > On Mon, Sep 03, 2018 at 09:03:38PM +0200, Jakub Janku wrote: > > I do agree that turning VDAgentConnection into a GObject is > > probably a good idea, however, I do not see how it could help > > us i

Re: [Spice-devel] [RFC spice-vdagent 00/18] GLib integration

On Tue, Aug 28, 2018 at 9:33 AM Victor Toso wrote: > > Hi, > > First of all, thanks for your work on this :) > > I'm still looking into the glib-integration related patches so I > might still reply once more afterwards. To keep things easy to > review, I take we could split this series in three

Re: [Spice-devel] [RFC spice-vdagent 05/18] add VDAgentConnection

Hey, On Tue, Aug 28, 2018 at 10:04 AM Victor Toso wrote: > > Hi, > > On Tue, Aug 14, 2018 at 08:53:39PM +0200, Jakub Janků wrote: > > Add a set of helper functions built around GIO that can be used to > > easily write messages to and read from the given FD. > > > > Since VDAgentConnection uses

Re: [Spice-devel] [RFC spice-vdagent 03/18] vdagentd: use GMainLoop

Hi Victor, On Tue, Aug 28, 2018 at 9:38 AM Victor Toso wrote: > > Hi, > > On Tue, Aug 14, 2018 at 08:53:37PM +0200, Jakub Janků wrote: > > This is purely a preparatory patch as it renders > > the vdagentd non-functional. > > I would rather not break it unless it really helps a lot. It was >

Re: [Spice-devel] [RFC spice-vdagent 02/18] vport: add by_user param to vdagent_virtio_port_disconnect_callback

Hi, On Tue, Aug 28, 2018 at 7:52 AM Victor Toso wrote: > > Hi, > > Took me a while to get the rationale behind this so some more > info in the commit log might help. OK, will do, sorry. > > On Tue, Aug 14, 2018 at 08:53:36PM +0200, Jakub Janků wrote: > > If the virtio port is destroyed

Re: [Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

Hi, On Tue, Aug 28, 2018 at 7:16 AM Victor Toso wrote: > > Hi, > > Just for reference, the output of spice-vdagentd -h before was: > > | $ spice-vdagentd -h > | Usage: spice-vdagentd [OPTIONS] > | > | Spice guest agent daemon, version 0.17.0. > | > | Options: > | -h print

Re: [Spice-devel] 3D and clipboard (was: Windows 10 KVM guest very slow in SPICE console)

Hi, On Thu, Jun 28, 2018 at 4:53 PM, Frediano Ziglio wrote: >> 2018-06-26 14:06 GMT-05:00 Carlos González < piteccel...@gmail.com > : > >> > I guess the spice-server patch will need more testing before release? >> > >> > Finally, and just mere curiosity, >> >> > with 3D would you perhaps mean 3D

Re: [Spice-devel] [PATCH vdagent v2 1/1] vdagent: add GTK+ clipboard handling

Hi Victor, On Tue, Feb 27, 2018 at 9:02 AM, Victor Toso wrote: > Hi Jakub, > > On Mon, Feb 26, 2018 at 08:01:28PM +0100, Jakub Janků wrote: >> From: Jakub Janků >> >> Add clipboard handling that uses GTK+ instead of Xlib. >> Place the code into new

Re: [Spice-devel] [PATCH vdagent 1/2] vdagent-x11: remove clipboard handling

Hi, On Mon, Feb 12, 2018 at 10:40 AM, Victor Toso wrote: > Hi, > > Follow up after the comment in the cover letter. > > On Sun, Jan 21, 2018 at 09:03:13PM +0100, Jakub Janků wrote: >> From: Jakub Janků >> >> The code will be replaced by GTK+ in the

Re: [Spice-devel] [PATCH vdagent 2/2] vdagent: handle clipboard using GTK+

Hi Victor, sorry for the delayed reply. On Mon, Feb 12, 2018 at 2:11 PM, Victor Toso wrote: > Hi, > > On Sun, Jan 21, 2018 at 09:03:14PM +0100, Jakub Janků wrote: >> From: Jakub Janků >> >> Place the code that handles clipboard >> into a separate file

Re: [Spice-devel] RFC [spice-gtk] session: Allow to delay sending clipboard to the guest

On Thu, Jan 11, 2018 at 5:42 PM, Marc-André Lureau wrote: > Hi > > - Original Message - >> On Thu, Jan 11, 2018 at 3:29 PM, Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > - Original Message - >> > > On Wed, Jan 10,

Re: [Spice-devel] RFC [spice-gtk] session: Allow to delay sending clipboard to the guest

On Thu, Jan 11, 2018 at 3:29 PM, Marc-André Lureau wrote: > > Hi > > - Original Message - > > On Wed, Jan 10, 2018 at 06:48:14PM -0500, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Tue, Jan 09, 2018 at 12:16:33PM -0500,