the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hi,
sorry about the noise, v4 still isn't passing the check. I didn't know
the check script is in the git tree. This one should pass.
Changes since v4:
* Really fix comments according
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hi,
Changes since v3:
* Fix comments according to patchew check script.
Cheers,
Lukas
hw/display/qxl.c | 14 ++-
include/ui/spice-display.h | 4
ui/spice-core.c
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
Hi,
I've fixed the undefined reference by checking the parent_dev pointer
directly instead of through pci_bus_is_root(), that was the only
function needed that's not built with PCI_CONFIG=n
Hi,
On Thu, 2019-01-31 at 11:44 +0100, Christophe Fergeau wrote:
> On Wed, Jan 30, 2019 at 03:13:06PM +, Frediano Ziglio wrote:
> > Avoid using strncpy, considered not secure.
> > In this case a simple memcpy is used, we are going to terminate
> > the string in any case on the next line.
> >
Just sent the same patch... oh well.
Acked-by: Lukáš Hrázký
On Wed, 2019-01-30 at 15:13 +, Frediano Ziglio wrote:
> Avoid using strncpy, considered not secure.
> In this case a simple memcpy is used, we are going to terminate
> the string in any case on the next line.
>
Signed-off-by: Lukáš Hrázký
---
server/red-stream-device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/red-stream-device.c b/server/red-stream-device.c
index 440b2689..2a210cc7 100644
--- a/server/red-stream-device.c
+++ b/server/red-stream-device.c
@@ -330,9
For the series:
Acked-by: Lukáš Hrázký
On Wed, 2019-01-23 at 16:18 -0600, Jonathon Jongsma wrote:
> This is a patch set that handles the PCI address and device dispay ID
> sent down to the agent by the server, and uses that to maintain a map
> for looking up a particular xran
Adds serialization of the GraphicsDeviceInfo message and sends it to the
server when it starts to stream.
Signed-off-by: Lukáš Hrázký
Acked-by: Jonathon Jongsma
---
configure.ac | 2 +-
src/spice-streaming-agent.cpp | 65 ++-
2 files changed
version is rather limited
and may not work for more complex setups) as well as some helper
functions to make it easier for plugins to implement this and avoid code
duplication.
Implements the new interface method for the two built-in plugins
(mjpeg-fallback and gst-plugin).
Signed-off-by: Lukáš
Receives the GraphicsDeviceInfo message from the streaming agent and
stores the data in a list on the streaming device.
Signed-off-by: Lukáš Hrázký
---
server/display-limits.h| 3 ++
server/red-qxl.c | 2 +-
server/red-stream-device.c | 78
The graphics_device_info message contains the device display ID
information (device address and device display ID). Stores the data in a
hash table in vdagent.
Signed-off-by: Lukáš Hrázký
Acked-by: Jonathon Jongsma
---
configure.ac | 2 +-
src/vdagent/vdagent.c| 3
Sends the device address and device display IDs to the vdagent. The
message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START
message or when the graphics device info changes.
Signed-off-by: Lukáš Hrázký
Acked-by: Jonathon Jongsma
---
configure.ac | 2 +-
meson.build
Adds serialization of the GraphicsDeviceInfo message and sends it to the
server when it starts to stream.
Signed-off-by: Lukáš Hrázký
Reviewed-by: Jonathon Jongsma
---
configure.ac | 2 +-
src/spice-streaming-agent.cpp | 60 +--
2 files changed
Hello,
this series introduces a new mechanism to identify monitors across the
host and guest boundary, using the pair (device_address and
device_display_id). device_address is a HW address of a graphics device
(a PCI address to be specific, though other address domains can be
used as well),
Adds the graphics device info from the streaming device(s) to the
VDAgentGraphicsDeviceInfo message sent to the vd_agent.
Signed-off-by: Lukáš Hrázký
Acked-by: Jonathon Jongsma
---
server/red-stream-device.c | 18 +++
server/red-stream-device.h | 7 +
server/reds.c
Instead of one unsupported example, present two real world examples.
Signed-off-by: Lukáš Hrázký
---
server/spice-qxl.h | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/server/spice-qxl.h b/server/spice-qxl.h
index e7af5e5e..2f47910b 100644
I'd also squash this up to 7/9. It just reworks what was not a complete
solution.
Cheers,
Lukas
On Thu, 2019-01-17 at 16:14 -0600, Jonathon Jongsma wrote:
> In the case where we have an mjpeg plugin running in the streaming
> agent, we have two spice displays representing the same guest
I'd squash this to the previous patch.
On Thu, 2019-01-17 at 16:14 -0600, Jonathon Jongsma wrote:
> When the agent gets a new device info message (from the daemon), we need
> to re-calculate the guest output map and send that information back down
> to the daemon so that it can handle mouse
ht)
> @@ -1075,11 +1103,12 @@ void vdagent_x11_send_daemon_guest_xorg_res(struct
> vdagent_x11 *x11, int update)
> for (i = 0; i < screen_count; i++) {
> struct vdagentd_guest_xorg_resolution *curr = [i];
> if (!get_monitor_info_for_output_index(x11, i, >x,
>
Reviewed-by: Lukáš Hrázký
On Thu, 2019-01-17 at 16:14 -0600, Jonathon Jongsma wrote:
> Rather than getting the current guest resolution in a
> VDAgentMonitorsConfig struct and then translating it to a new struct
> type for sending down to the daemon, simply use the new
;monitors[i].x = crtc->x;
> -mon_config->monitors[i].y = crtc->y;
> -mon_config->monitors[i].width = mode->width;
> -mon_config->monitors[i].height = mode->height;
> +VDAgentMonConfig *mon = _config->monitors[i];
> +mon->x = x;
> +mon->y = y;
> +mon->width = width;
> +mon->height = height;
> num_of_monitors = i + 1;
> }
> mon_config->num_of_monitors = num_of_monitors;
Reviewed-by: Lukáš Hrázký
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
dd_and_set(x11, output_index, x, y, width, height)
> &&
> enabled_monitors(mon_config) == 1) {
> -set_screen_to_best_size(x11, width, height,
> -_w, _h);
> -break;
> +set_screen_to_best_size(x11, width, height,
> +_w, _h);
> +break;
> +}
> +} else {
> +syslog(LOG_WARNING, "Unable to find a guest output index for
> spice display %i", i);
> }
> }
Reviewed-by: Lukáš Hrázký
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
log(LOG_ERR, "could not connect to X-server");
> @@ -322,12 +322,6 @@ struct vdagent_x11 *vdagent_x11_create(struct
> udscs_connection *vdagentd,
> __func__, net_wm_name, vdagent_x11_has_icons_on_desktop(x11));
> g_free(net_wm_name);
>
assert(!compare_addresses(, ));
> +}
> +// mismatched slot
> +{
> +PciDevice da1 = {0, 0, 2, 0};
> +PciAddress a1 = {0, NULL};
> +a1.domain = 0;
> +a1.devices = g_list_append(a1.devices, );
> +
> +PciDevice db1 = {0, 0
On Thu, 2019-01-17 at 14:29 -0600, Jonathon Jongsma wrote:
> On Wed, 2019-01-16 at 13:52 +0100, Lukáš Hrázký wrote:
> > Adds serialization of the GraphicsDeviceInfo message and sends it to
> > the
> > server when it starts to stream.
> >
> > Signed-off-by: Luk
On Thu, 2019-01-17 at 14:09 -0600, Jonathon Jongsma wrote:
> A couple minor comments below.
>
> On Wed, 2019-01-16 at 13:52 +0100, Lukáš Hrázký wrote:
> > Adds an interface method to the FrameCapture class to get the device
> > display info (device address and device display
On Thu, 2019-01-17 at 13:10 -0600, Jonathon Jongsma wrote:
> On Wed, 2019-01-16 at 13:52 +0100, Lukáš Hrázký wrote:
> > Adds the graphics device info from the streaming device(s) to the
> > VDAgentGraphicsDeviceInfo message sent to the vd_agent.
> >
> >
019-01-16 at 13:52 +0100, Lukáš Hrázký wrote:
> > The message contains information about the graphics device and
> > monitor
> > belonging to a particular video stream (which maps to a channel) from
> > the streaming agent.
> >
> > Signed-off-by: Lukáš Hrázký
version is rather limited
and may not work for more complex setups) as well as some helper
functions to make it easier for plugins to implement this and avoid code
duplication.
Implements the new interface method for the two built-in plugins
(mjpeg-fallback and gst-plugin).
Signed-off-by: Lukáš
Receives the GraphicsDeviceInfo message from the streaming agent and
stores the data in a list on the streaming device.
Signed-off-by: Lukáš Hrázký
---
server/display-limits.h| 3 ++
server/red-qxl.c | 2 +-
server/red-stream-device.c | 78
Adds the graphics device info from the streaming device(s) to the
VDAgentGraphicsDeviceInfo message sent to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
server/red-stream-device.c | 18 +++
server/red-stream-device.h | 7 +
server/reds.c | 63
The message contains information about the graphics device and monitor
belonging to a particular video stream (which maps to a channel) from
the streaming agent.
Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
---
spice/stream-device.h | 31 +++
1 file changed
The graphics_device_info message contains the device display ID
information (device address and device display ID). Stores the data in a
hash table in vdagent.
Signed-off-by: Lukáš Hrázký
---
src/vdagent/vdagent.c| 3 ++
src/vdagent/x11-priv.h | 1 +
src/vdagent/x11-randr.c
Adds serialization of the GraphicsDeviceInfo message and sends it to the
server when it starts to stream.
Signed-off-by: Lukáš Hrázký
---
src/spice-streaming-agent.cpp | 54 +--
1 file changed, 45 insertions(+), 9 deletions(-)
diff --git a/src/spice-streaming
The message serves for passing the device address and device display ID
information for all display channels from SPICE server to the vd_agent.
Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
---
spice/vd_agent.h | 23 +++
1 file changed, 23 insertions(+)
diff --git
On Tue, 2019-01-15 at 08:31 -0500, Frediano Ziglio wrote:
> >
> > Receives the GraphicsDeviceInfo message from the streaming agent and
> > stores the data in a list on the streaming device.
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > server/display
The graphics_device_info message contains the device display ID
information (device address and device display ID). Stores the data in a
hash table in vdagent.
Signed-off-by: Lukáš Hrázký
---
src/vdagent/vdagent.c| 3 ++
src/vdagent/x11-priv.h | 1 +
src/vdagent/x11-randr.c
The message serves for passing the device address and device display ID
information for all display channels from SPICE server to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
spice/vd_agent.h | 23 +++
1 file changed, 23 insertions(+)
diff --git a/spice/vd_agent.h b/spice
Adds the graphics device info from the streaming device(s) to the
VDAgentGraphicsDeviceInfo message sent to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
server/red-stream-device.c | 18 +++
server/red-stream-device.h | 7 +
server/reds.c | 63
version is rather limited
and may not work for more complex setups) as well as some helper
functions to make it easier for plugins to implement this and avoid code
duplication.
Implements the new interface method for the two built-in plugins
(mjpeg-fallback and gst-plugin).
Signed-off-by: Lukáš
Sends the device address and device display IDs to the vdagent. The
message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START
message or when the graphics device info changes.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 20 +
server/red-qxl.h | 3
Hello,
this series introduces a new mechanism to identify monitors across the
host and guest boundary, using the pair (device_address and
device_display_id). device_address is a HW address of a graphics device
(a PCI address to be specific, though other address domains can be
used as well),
The message contains information about the graphics device and monitor
belonging to a particular video stream (which maps to a channel) from
the streaming agent.
Signed-off-by: Lukáš Hrázký
---
spice/stream-device.h | 31 +++
1 file changed, 31 insertions(+)
diff
("default") attribute to the namespace
containing the Error class, as that one needs to be exported and have
its typeinfo defined for exception catching to work.
Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
---
include/spice-streaming-agent/error.hpp | 2 +-
src/M
is and avoid code
> > duplication.
> >
> > Implements the new interface method for the two built-in plugins
> > (mjpeg-fallback and gst-plugin).
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > configure.ac | 2 +
>
On Fri, 2019-01-11 at 05:45 -0500, Frediano Ziglio wrote:
> > On Thu, 2019-01-10 at 14:28 -0600, Jonathon Jongsma wrote:
> > > On Wed, 2019-01-09 at 12:43 +0100, Lukáš Hrázký wrote:
> > > > On Wed, 2019-01-09 at 02:38 -0500, Frediano Ziglio wrote:
> > > >
On Wed, 2019-01-09 at 11:36 -0600, Jonathon Jongsma wrote:
> On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote:
> > Adds a function to let QEMU provide information to identify graphics
> > devices and their monitors in the guest. The function
> > (spice_qxl_set_device_
On Thu, 2019-01-10 at 15:07 -0600, Jonathon Jongsma wrote:
> On Tue, 2019-01-08 at 16:28 +0100, Lukáš Hrázký wrote:
> > Sends the device address and device display IDs to the vdagent. The
> > message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START
> > message
On Thu, 2019-01-10 at 14:28 -0600, Jonathon Jongsma wrote:
> On Wed, 2019-01-09 at 12:43 +0100, Lukáš Hrázký wrote:
> > On Wed, 2019-01-09 at 02:38 -0500, Frediano Ziglio wrote:
> > > >
> > > > The message contains information about the graphics device and
Hi,
On Thu, 2019-01-10 at 14:13 -0600, Jonathon Jongsma wrote:
> On Tue, 2019-01-08 at 16:28 +0100, Lukáš Hrázký wrote:
> > The message serves for passing the device address and device display
> > ID
> > information for all display channels from SPICE server to the
> >
Hi,
On Thu, 2019-01-10 at 15:27 -0600, Jonathon Jongsma wrote:
> On Tue, 2019-01-08 at 16:28 +0100, Lukáš Hrázký wrote:
> > Receives the GraphicsDeviceInfo message from the streaming agent and
> > stores the data in a list on the streaming device.
> >
> >
On Mon, 2019-01-07 at 15:50 -0600, Jonathon Jongsma wrote:
> Instead of storing each device address and device display ID in the hash
> table, simply use the lookup_xrandr_output_for_device_info() function to
> look up the ID of the xrandr output and store that in the hash table.
> ---
>
Hello,
On Thu, 2019-01-03 at 16:45 -0600, Jonathon Jongsma wrote:
> Add a function to look up an xrandr output for a given device display
> id. This uses sysfs and the drm subsystem to lookup information about a
> graphics device output. It then compares the drm output name to xrandr
> output
On Wed, 2019-01-09 at 03:25 -0500, Frediano Ziglio wrote:
> >
> > Adds the graphics device info from the streaming device(s) to the
> > VDAgentGraphicsDeviceInfo message sent to the vd_agent.
> >
> > Signed-off-by: Lukáš Hrázký
> > ---
> > server/red-s
>
> > TODO: doesn't resend the message on agent reconnect, FIXIT.
>
> Why is this a problem? What if the agent get restarted?
Ah, sorry, forgot this TODO here. It is the agent reconnect issue we
discussed (off-list). I'll remove this TODO, we are taking care of it.
> >
> >
splay channels from SPICE server to the vd_agent.
> > > >
> > > > Signed-off-by: Lukáš Hrázký
> > > > ---
> > > > spice/vd_agent.h | 15 +++
> > > > 1 file changed, 15 insertions(+)
> > > >
> > > > diff
On Wed, 2019-01-09 at 02:41 -0500, Frediano Ziglio wrote:
> >
> > The message serves for passing the device address and device display ID
> > information for all display channels from SPICE server to the vd_agent.
> >
> > Signed-off-by: Lukáš Hrázký
>
version is rather limited
and may not work for more complex setups) as well as some helper
functions to make it easier for plugins to implement this and avoid code
duplication.
Implements the new interface method for the two built-in plugins
(mjpeg-fallback and gst-plugin).
Signed-off-by: Lukáš
The graphics_device_info message contains the device display ID
information (device address and device display ID). Stores the data in a
hash table in vdagent.
Signed-off-by: Lukáš Hrázký
---
src/vdagent/vdagent.c| 3 ++
src/vdagent/x11-priv.h | 1 +
src/vdagent/x11-randr.c
Receives the GraphicsDeviceInfo message from the streaming agent and
stores the data in a list on the streaming device.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 1 -
server/red-stream-device.c | 66 --
server/red-stream-device.h | 8
Sends the device address and device display IDs to the vdagent. The
message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START
message or when the graphics device info changes.
TODO: doesn't resend the message on agent reconnect, FIXIT.
Signed-off-by: Lukáš Hrázký
---
server/red
The message contains information about the graphics device and monitor
belonging to a particular video stream (which maps to a channel) from
the streaming agent.
Signed-off-by: Lukáš Hrázký
---
spice/stream-device.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/spice/stream
Adds the graphics device info from the streaming device(s) to the
VDAgentGraphicsDeviceInfo message sent to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
server/red-stream-device.c | 14 ++
server/red-stream-device.h | 4 +++
server/reds.c | 56
Hello,
this series introduces a new mechanism to identify monitors across the
host and guest boundary, using the pair (device_address and
device_display_id). device_address is a HW address of a graphics device
(a PCI address to be specific, though other address domains can be
used as well),
The message serves for passing the device address and device display ID
information for all display channels from SPICE server to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
spice/vd_agent.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/spice/vd_agent.h b/spice
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
hw/display/qxl.c | 14 -
include/ui/spice-display.h | 2 ++
ui/spice-core.c| 42 ++
ui/spice-display.c | 11
Hello,
this is the final version of the new QXL interface to identify the
graphics device monitors in the guest. This interface adds a function
that allows to set the device path (e.g. a PCI path) and the IDs of the
device's displays from QEMU to SPICE server. The server will forward
this
Replace it by spice_qxl_set_device_info. Note we can't use
monitors_count for what's stored in max_monitors, because monitors_count
denotes the length of the device_display_ids array, which
spice_qxl_set_max_monitors doesn't touch.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 1
off-by: Lukáš Hrázký
---
server/red-qxl.c | 44 ++
server/spice-qxl.h | 46
server/spice-server.syms | 5 +
3 files changed, 95 insertions(+)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index 97940
Hi,
sorry about piecemealing this.
On Thu, 2018-12-13 at 16:46 -0600, Jonathon Jongsma wrote:
> Add a function to look up an xrandr output for a given device display
> id. This uses sysfs and the drm subsystem to lookup information about a
> graphics device output. It then compares the drm
ent_x11_set_monitor_config(struct vdagent_x11
> *x11,
> g_free(config);
>
> for (i = mon_config->num_of_monitors; i < x11->randr.res->noutput; i++)
> -xrandr_disable_output(x11, i);
> +xrandr_disable_nth_output(x11, i);
>
> /* First, disable disabled CRTCs
utput only has a single crtc
> s = XRRSetCrtcConfig(x11->display, x11->randr.res,
> - x11->randr.res->crtcs[output],
> + oinfo->crtcs[0],
> CurrentTime, 0, 0, None, RR_Rotate_0,
>
* Hello,
On Thu, 2018-12-13 at 16:46 -0600, Jonathon Jongsma wrote:
> Add a function to look up an xrandr output for a given device display
> id. This uses sysfs and the drm subsystem to lookup information about a
> graphics device output. It then compares the drm output name to xrandr
> output
The syslog() helper for logging an error is not necessary, leave it out
of the API and move it to a new private utils module.
Signed-off-by: Lukáš Hrázký
---
include/spice-streaming-agent/error.hpp | 8
src/Makefile.am | 1 +
src/cursor-updater.cpp
("default") attribute to the namespace
containing the Error class, as that one needs to be exported and have
its typeinfo defined for exception catching to work.
Signed-off-by: Lukáš Hrázký
---
include/spice-streaming-agent/error.hpp | 2 +-
src/Makefile.am |
and clang so for these two
compilers it is safe.
Signed-off-by: Lukáš Hrázký
---
include/spice-streaming-agent/Makefile.am | 1 +
.../spice-streaming-agent}/error.hpp | 22 +--
src/Makefile.am | 2 --
src/cursor-updater.cpp
caught.
Cheers,
Lukas
Lukáš Hrázký (3):
Make error.hpp and the Error class a public API
Move the syslog() helper for errors to a new utils module
Export symbols in the binary to use by the plugins
include/spice-streaming-agent/Makefile.am | 1 +
include/spice-streaming-agent/error.hpp
On Mon, 2018-11-19 at 11:42 -0500, Frediano Ziglio wrote:
> >
> > On Mon, 2018-11-19 at 10:23 +, Frediano Ziglio wrote:
> > > Do not try indefinitely to connect to the daemon, should not
> > > take long to activate.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > >
On Mon, 2018-11-19 at 10:23 +, Frediano Ziglio wrote:
> Do not try indefinitely to connect to the daemon, should not
> take long to activate.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> Changes since v1:
> - log error
Hi,
On Fri, 2018-11-16 at 16:21 +, Frediano Ziglio wrote:
> Do not try indefinitely to connect to the daemon, should not
> take long to activate.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git
On Mon, 2018-11-12 at 14:44 -0600, Jonathon Jongsma wrote:
> On Mon, 2018-11-12 at 11:01 +0100, Lukáš Hrázký wrote:
> > On Thu, 2018-11-08 at 11:36 -0600, Jonathon Jongsma wrote:
> > > On Wed, 2018-11-07 at 18:23 +0100, Lukáš Hrázký wrote:
> > > > The message serves
Hi,
On Tue, 2018-11-13 at 09:04 +0100, Gerd Hoffmann wrote:
> Hi,
>
> > To look up a PCI device by address, I could use the /sys filesystem. So
> > for pci//02.0, I would translate the domain into the
> > filesystem path '/sys/devices/pci:00/' assuming bus '00'? And then
> > look
On Thu, 2018-11-08 at 11:36 -0600, Jonathon Jongsma wrote:
> On Wed, 2018-11-07 at 18:23 +0100, Lukáš Hrázký wrote:
> > The message serves for passing the device address and device display
> > ID
>
> "serves for passing..." is a little strange to my ear.
Hello,
On Mon, 2018-11-05 at 17:09 -0600, Jonathon Jongsma wrote:
> This is just a proof of concept utility that takes a PCI device address
> and a monitor ID and finds the xrandr output associated with that
> monitor id.
> ---
>
> Changes in v2:
> - used different format for specifying the PCI
On Thu, 2018-11-08 at 05:18 -0500, Frediano Ziglio wrote:
> >
> > The graphics_device_info message contains the device display ID
> > information (device address and device display ID). Stores the data in a
> > hash table in vdagent.
> >
> > Signed-off-by: Lu
Hello,
On Thu, 2018-11-08 at 17:38 +0800, wangjiedong wrote:
> Recently I compile spice-protocol-0.12.15 and
> spice-server-0.14.1(--enable-lz4=yes --enable-gstreamer=yes
> --enable-smartcard=yes --with-sasl=yes) on host Ubuntu 18.04, and compile
> spice-protocol-0.12.15 and
On Wed, 2018-11-07 at 16:01 -0600, Jonathon Jongsma wrote:
> On Wed, 2018-11-07 at 11:49 +0100, Lukáš Hrázký wrote:
> > Adds a function to let QEMU provide information to identify graphics
> > devices and their monitors in the guest. The function
> > (spice_qxl_set_device_
Hello,
On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote:
> Hi,
>
> > + * The device_display_id_{start,count} denotes the sequence of device
> > display
> > + * IDs that map to the zero-based sequence of monitor IDs provided by
> > monitors
> > + * config on this interface. For example
t; } else {
> dev->priv->cur_write_buf =
> -__red_char_device_write_buffer_get(dev, NULL,
> +red_char_device_write_buffer_get(dev, NULL,
> mig_data->write_size, WRITE_BUFFER_ORIGIN_SERVER, 0);
&
Hello,
this series follows these two:
https://lists.freedesktop.org/archives/spice-devel/2018-November/046088.html
https://lists.freedesktop.org/archives/spice-devel/2018-November/046093.html
It sends the graphics device info (I've added the "graphics" to the name
here, as "device info" seems
The graphics_device_info message contains the device display ID
information (device address and device display ID). Stores the data in a
hash table in vdagent.
Signed-off-by: Lukáš Hrázký
---
src/vdagent/vdagent.c| 69
src/vdagentd-proto-strings.h
Sends the device address and device display IDs to the vdagent. The
message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START
message or when the graphics device ino changes.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 20 +
server/red-qxl.h | 3
The message serves for passing the device address and device display ID
information for all display channels from SPICE server to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
spice/vd_agent.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/spice/vd_agent.h b/spice
shouldn't need to parametrize that.
For the server case, add a use_token parameter instead of a separate
red_char_device_write_buffer_get_server_no_token function, as you may
want to parametrize that.
Signed-off-by: Lukáš Hrázký
---
server/char-device.c | 22
Hello,
this is a small refactor I did for the char-device write buffer
creation, in particular for creating a write buffer for the vd_agent.
Of note, I didn't know how to test the smartcard and spicevmc codepaths,
I just assume they should be fine...
Lukáš Hrázký (2):
char-device: separate
Adds a function to create a write buffer for sending a message to
vdagent from the server to prevent code duplication.
Signed-off-by: Lukáš Hrázký
---
server/reds.c | 76 +++
1 file changed, 40 insertions(+), 36 deletions(-)
diff --git a/server
the deprecated spice_qxl_set_max_monitors, the new
interface function replaces it.
Signed-off-by: Lukáš Hrázký
---
hw/display/qxl.c | 14 -
include/ui/spice-display.h | 2 ++
ui/spice-core.c| 42 ++
ui/spice-display.c | 11
Hello,
another version of the proposed API for monitor identification
information. Still not for merge yet, the plan is to merge when it's
complete.
Changes since v2:
* Merged the two API functions into one:
spice_qxl_set_device_info(QXLInstance *instance,
const
Replace it by spice_qxl_set_device_info. Note we can't use
monitors_count for what's stored in max_monitors, because monitors_count
denotes the length of the device_display_ids array, which
spice_qxl_set_max_monitors doesn't touch.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 1
off-by: Lukáš Hrázký
---
server/red-qxl.c | 44 ++
server/spice-qxl.h | 46
server/spice-server.syms | 5 +
3 files changed, 95 insertions(+)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index 97940
1 - 100 of 581 matches
Mail list logo
