> its core, it appears to use the same spice-qxl X driver that x11spice uses,
> just with a simple Python wrapper script for generating an X config file
> and starting the X server/display. So, I think it's still pretty "safe" for
> attempting to develop this Guacamole integration - if for some reason you
> believe me to be wrong about that, please let me know.
>
Your testing environment shouldn't be a problem, it's really your
client-side code integration with spice-glib that looks broken.
--
Marc-André Lureau
APIs don't make it easy to handle events..)
--
Marc-André Lureau
ot;spiceai" instead. It would avoid the confusion.
Ideally github.com/spice should redirect to the various "spice" projects,
in a wiki-index fashion, but I don't think we can do that yet.
--
Marc-André Lureau
___
Spice-devel mailing li
E-Autostart-Phase=WindowManager was not
meant to be a generic solution anyway. It seems reasonable to have a
systemd session solution nowadays. Even if both compete at startup, only
one should stay.
Can you make a merge request on gitlab?
--
Marc-André Lureau
__
h dumpxml
fedora34gnomehttps://germano.fedorapeople.org/bugreport/spice/virsh_dumpxml.txt
>
> What can be the problem?
> Thank you
>
>
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
>
ols in spice-gtk source tree, for example
spicy-screenshot.c ?
https://gitlab.freedesktop.org/spice/spice-gtk/-/blob/master/tools/spicy-screenshot.c,
this should give you a simple way to get started. You will need to handle
the SpiceDisplayChannel, SpiceCursorCha
ready.
> > >
> > > Cheers,
> > > Jakub
> > >
> >
> > To be honest I don't see the need to revert commits, it's just a change
> > from public to private.
>
> Ok, so should I open a separate MR?
>
> To make sure that I didn't misunderstand it: the suggestion is to keep
> spice_session_get_webdav_server() private and install a new
> SpiceSession read-only property "webdav", correct?
>
>
yes (the main motivation is to avoid adding new library symbols, and
properties can be looked up at runtime, which may avoid bumping
dependencies in some cases)
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
o make it a
read-only property instead?
>
> Signed-off-by: Jakub Janků
> Acked-by: Frediano Ziglio
>
> diff --git a/src/map-file b/src/map-file
> index acdd38f..86f371d 100644
> --- a/src/map-file
> +++ b/src/map-file
> @@ -144,6 +144,7 @@ spice_session_new;
>
and kernel to prioritize channels: this isn't great in
some cases and may receive improvements.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Mon, Jun 8, 2020 at 6:00 PM wrote:
> Hello everyone,
>
> when using Qemu 4.2.0 with a Windows host, qemu-system-x86_64 reports:
> "QXL VGA not available"
>
> I used the following Qemu args for testing:
> qemu-system-x86-x64.exe -accel hax -machine q35 -m 4GB -cdrom
>
Hi
On Thu, May 14, 2020 at 2:32 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Mon, May 11, 2020 at 12:16 PM Marc-André Lureau <
> marcandre.lur...@redhat.com> wrote:
>
>> Hi,
>>
>> About "Move code to C++":
>> h
would have modern instincts on how to more
> correctly implement the third use case. Clue bats or other ideas welcome.
>
This is systemd/desktop territories, and I don't know what would be the
best way to do all that. I would suggest you ask the gnome-remote-desktop &
systemd/logind devel
prioritize our work better, and
reaching out for help. Not rush the changes, please.
if somebody is very busy in daily activity or on holidays whomever remains
> should be in charge. Is not that is a person in a team goes on holiday all
> the work of the team is impeded.
>
I don'
e is doing the job. Perhaps Spice needs to define new
objectives. These are interesting topics that I believe people would want
to discuss and participate. If not, we are doing it wrong.
thanks
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Thu, May 14, 2020 at 2:32 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Mon, May 11, 2020 at 12:16 PM Marc-André Lureau <
> marcandre.lur...@redhat.com> wrote:
>
>> Hi,
>>
>> About "Move code to C++":
>> h
Hi
On Mon, May 11, 2020 at 12:16 PM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Hi,
>
> About "Move code to C++":
> https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62
>
> I would like to know how the decision happened. As long as I
hone UI either.
> 5video from mobile phones
>
What do you mean? Playback of video on mobile phones should work. Recording
of video isn't probably possible, since afaik the only solution with Spice
today is to use USB passthrough.
--
Marc-André Lureau
-level solution, afaik.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Tue, May 12, 2020 at 10:08 PM Francesco Giudici wrote:
>
>
>
> On 12/05/20 19:13, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, May 12, 2020 at 5:07 PM Francesco Giudici
> > wrote:
> >>
> >>
> >>
> >> On 12/05/20 1
Hi
On Tue, May 12, 2020 at 5:07 PM Francesco Giudici wrote:
>
>
>
> On 12/05/20 11:24, Daniel P. Berrangé wrote:
> > On Mon, May 11, 2020 at 12:16:24PM +0200, Marc-André Lureau wrote:
> >> Hi,
> >>
> >> About "Move code to C++":
> >>
evolve more quicker.
There are many contributions, in many projects, that can take years to
be merged. And many contributions never get merged.
Spice is no exception. If there are enough interest, there are enough
people behind it to polish the work. If not, then you cannot put the
project at risk by rushing work.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi,
About "Move code to C++":
https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62
I would like to know how the decision happened. As long as I have been
involved in the Spice project, we had open discussions and did
mandatory review for anything non-trivial.
This change is
ceMainChannel
> *channel, int id,
> * Since: 0.35
> **/
> void spice_main_channel_update_display(SpiceMainChannel *channel, int id,
> int x, int y, int width,
> - int height, gboolean update)
> + int height, gboolean update)
> {
> SpiceMainChannelPrivate *c;
>
> ___
> Spice-commits mailing list
> spice-comm...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-commits
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
> + rm -rf meson-dist
> + ninja -C build dist
> + rpmbuild -bs ./build/*spec --define "_sourcedir
> $$PWD/build/meson-dist/" --define "_srcrpmdir $(outdir)"
Too much hacks for my taste here.
> --
e_gtk_global_cflags),
>language : 'c')
>
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
ay)) *
> gdk_scale;
> } else {
> ww = fbw;
> wh = fbh;
> @@ -3091,7 +3105,8 @@ void spice_display_widget_gl_scanout(SpiceDisplay
> *display)
> g_clear_error();
> }
>
> -spice_egl_resize_display(display, d->ww, d->wh);
&g
_
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
e from NEWS
> rename to NEWS.md
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
duct=phodav
>
> -Forking and sending github pull requests is also welcome.
> \ No newline at end of file
> +Forking and sending pull requests is also welcome.
> \ No newline at end of file
> --
> 2.21.0
>
> ___
> Spice-devel mai
;
> - e->user_data = user_data;
> - e->queue = q;
> - g_queue_push_tail (q->queue, e);
> -
> - if (!q->idle_id && !q->flushing)
> -q->idle_id = g_idle_add (output_queue_idle, output_queue_ref (q));
> -}
> -
> -
> static stru
map_drive_data->service_data->drive_letter = drive_letter;
>g_mutex_unlock(_drive_data->service_data->mutex);
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedes
break;
> }
>
> - if (map_drive (drive_letter) != MAP_DRIVE_TRY_AGAIN)
> + if (map_drive (drive_letter) != ERROR_ALREADY_ASSIGNED)
> {
> break;
> }
> --
> 2.21.0
>
> ___
};
>if (!no_service && !getenv("DEBUG"))
> {
> --
> 2.21.0
>
> _______
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
);
> + g_object_unref (saddr);
>if (error)
> {
>g_printerr ("%s\n", error->message);
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedes
, g_strerror(errsv));
>exit (1);
> +}
>
>wait_for_virtio_host (port_fd);
>
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lur
main_loop_unref);
>
> #ifdef G_OS_WIN32
>g_cancellable_cancel (map_drive_data.cancel_map);
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinf
CE_STOPPED;
> @@ -1154,8 +1158,7 @@ main (int argc, char *argv[])
> }
> } else
> #endif
> - while (!quit_service) {
> -run_service (_data);
> + while (run_service(_data)) {
> g_usleep (G_USEC_PER_SEC);
>}
>
> --
> 2.21.0
>
&g
ove the g_debug() call then.
(maybe we should have a different function for the signal handler)
>if (sig == SIGINT || sig == SIGTERM)
>quit_service = TRUE;
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
>
4),
> G_PRIORITY_DEFAULT,
> - cancel, mux_client_read_cb, NULL);
> + input_stream_read_async_thread (istream,
> + , sizeof (gint64),
> G_PRIORITY_DEFAULT,
> + cancel, mux_client_read_cb, NULL);
> }
>
> static void client_start_read (Client *client);
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
#ifdef G_OS_UNIX
> static void
> wait_for_virtio_host (gint fd)
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
0ac 100644
> --- a/src/spice-widget-priv.h
> +++ b/src/spice-widget-priv.h
> @@ -149,6 +149,7 @@ struct _SpiceDisplayPrivate {
> EGLImageKHR image;
> gbooleancall_draw_done;
> SpiceGlScanout scanout;
> +gint
Hi
On Fri, Mar 29, 2019 at 10:17 AM Frediano Ziglio wrote:
>
> >
> > Hi
> >
> > On Thu, Mar 28, 2019 at 5:30 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > Do not send a
Initial state is undefined, and currently whatever the guest or client
> > > > side state is. Iow, Spice client/agent doen't do anything afaik. They
> > > > will only react to further grab events.
> > > >
> > >
> > > I suppose the agent will keep its state while the client if was not
> > > connected get some initial state (boolean variables have to be true or
> > > false at the end).
> > >
> > > > We could change the client or the guest to take the grab on connect,
> > > > if clipboard data is available. That doesn't require protocol change.
> > > > Although in case of conflict, we would probably end in the same
> > > > situation that this protocol change is aiming to solve.
> > > >
> > >
> > > When there's a disconnection we should drop the ownership as we
> > > cannot anymore get the data from the remote in case other application
> > > are asking so the "disconnected" state should be no ownership of
> > > the clipboard on both ends (although I suppose the client will be
> > > closed at that time).
> >
> > That's an implementation issue, not related to the protocol and the
> > problem discussed here.
> >
> > >
> > > Once a connection happens we could however have both ends with
> > > data on the clipboard (the total states are 3 (a) client/agent have
> > > ownership (b) other application have ownership (c) no ownership/data
> > > on clipboard, here (a) should be impossible).
> > > Which one "win" I would say hard to tell.
> > >
> >
> > If both sides would try to take the grab simultaneously at init time,
> > they would race, and we get back to the problem we are solving here.
> >
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Thu, Mar 28, 2019 at 6:05 PM Frediano Ziglio wrote:
>
> >
> > ..Hi
> >
> > On Thu, Mar 28, 2019 at 4:14 PM Frediano Ziglio wrote:
> > > > The role of the grab message is to take ownership of the clipboard (to
> > > > advertize clipboard data available). It may come at any time from both
>
Hi
On Thu, Mar 28, 2019 at 5:30 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Do not send a release event between two grabs, this helps with window
> > manager interaction issues on peer side.
> >
>
> I would explain which kind
Hi
On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote:
>
> Hi,
>
> On Fri, Mar 22, 2019 at 4:13 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > This is required for using the new GObject macros.
>
> Which macros are you referring to?
> G_DECLA
Hi
On Thu, Mar 28, 2019 at 4:27 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > This is required for using the new GObject macros.
> >
> > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump
> > GL
est to take the grab on connect,
if clipboard data is available. That doesn't require protocol change.
Although in case of conflict, we would probably end in the same
situation that this protocol change is aiming to solve.
> But from the stable state (one and only one has the ownership)
> is no
Hi
On Wed, Mar 27, 2019 at 4:50 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Wed, Mar 27, 2019 at 8:23 AM Frediano Ziglio wrote:
> > >
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > When this ca
Hi
On Wed, Mar 27, 2019 at 8:23 AM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > When this capability is negoticated by both the client & the agent,
>
> negotiated
>
> > the clipboard grab messages have an associated serial
Hi
On Mon, Mar 25, 2019 at 10:26 AM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > This will allow easier lifecycle management,
> > and usage of gtk_clipboard_set_with_owner()
> >
> > Signed-off-by: Marc-André Lure
Hi
On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote:
>
> On Fri, Mar 22, 2019 at 2:57 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > When this capability is negoticated by both the client & the agent,
> > the clipboard grab messages have an assoc
Hi
On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote:
>
> Hi,
>
> On Thu, Mar 21, 2019 at 1:21 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > Delay the release events for 0.5 sec. If no further grab comes in,
> > then release the grab. Otherwise, le
> > On Thu, Mar 21, 2019 at 01:21:32PM +0100, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > Hi,
> > >
> > > There has been several reports of clipboard issues that seem related
> > > to clipboard managers inter
Hi
On Sun, Mar 24, 2019 at 6:50 PM Jakub Janku wrote:
>
> Hi,
>
> On Thu, Mar 21, 2019 at 1:21 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > On the client side, whenever the grab owner changes (and the clipboard
> > was previously grabbed), sp
Hi
On Sun, Mar 24, 2019 at 6:50 PM Jakub Janku wrote:
>
> On Fri, Mar 22, 2019 at 4:13 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > According to sd_seat_get_active(2), you must free() the pointer.
> >
> > Signed-off-by: Marc-André Lureau
>
*emul_args = NULL;
> @@ -442,6 +460,7 @@ init:
> "Failed to initialize smartcard");
> goto end;
> }
> +smartcard_check_reader_count();
>
> retval = TRUE;
>
> --
> 2.20.1
>
> ______
Hi
On Fri, Mar 15, 2019 at 4:43 PM Jakub Janku wrote:
>
> Hi,
>
> On Thu, Mar 14, 2019 at 6:18 PM Marc-André Lureau
> wrote:
> >
> > Hi
> >
> > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote:
> > >
> > > If two
es; ++n) {
> found = FALSE;
> for (m = 0; m < SPICE_N_ELEMENTS(atom2agent); m++) {
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Fri, Mar 8, 2019 at 1:41 PM Jakub Janku wrote:
>
> Hi,
>
> On Fri, Mar 8, 2019 at 1:15 PM Marc-André Lureau
> wrote:
> >
> > Hi
> >
> > On Thu, Mar 7, 2019 at 10:36 PM Jakub Janku wrote:
> > >
> > > Hi,
> > >
> > >
Hi
On Thu, Mar 7, 2019 at 10:36 PM Jakub Janku wrote:
>
> Hi,
>
> thanks for having a look!
>
> On Wed, Mar 6, 2019 at 6:42 PM Marc-André Lureau
> wrote:
> >
> > Hi
> >
> > On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote:
> > >
&
6,6 +883,8 @@ static gboolean clipboard_grab(SpiceMainChannel *main,
> guint selection,
> return TRUE;
> }
>
> +nullify_weak_ref(>last_targets_request[selection]);
> +
> if (!gtk_clipboard_set_with_owner(cb,
>targets,
>num_targets,
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
> +}
> +
> for (n = 0; n < ntypes; ++n) {
> found = FALSE;
> for (m = 0; m < SPICE_N_ELEMENTS(atom2agent); m++) {
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> usleep under Windows does not seem to have the required precision.
> Use milliseconds and adjust check times according.
>
> Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
> ---
> server/t
= sa2.sin_addr.s_addr) {
> > > +goto cleanup;
> > > +}
> > > +
> > > +closesocket(s);
> > > +sv[0] = pairs[0];
> > > +sv[1] = pairs[1];
> > > +return 0;
> > > +
> > > +cleanup:
> > > +socket_win32_set_errno();
> > > +closesocket(s);
> > > +closesocket(pairs[0]);
> > > +closesocket(pairs[1]);
> > > +return -1;
> > > +}
> > > #endif
> > > diff --git a/server/sys-socket.h b/server/sys-socket.h
> > > index 65062571..3a3b7878 100644
> > > --- a/server/sys-socket.h
> > > +++ b/server/sys-socket.h
> > > @@ -134,6 +134,9 @@ socket_accept(int sock, struct sockaddr *addr, int
> > > *addrlen)
> > > }
> > > #undef accept
> > > #define accept socket_accept
> > > +
> > > +int socket_newpair(int type, int protocol, int sv[2]);
> > > +#define socketpair(family, type, protocol, sv) socket_newpair(type,
> > > protocol, sv)
> > > #endif
> > >
> > > #endif // RED_SYS_SOCKET_H_
>
> Frediano
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
gt; > > reds_set_video_codecs_from_string(RedsState *reds, const char *codec
> > > g_array_append_val(video_codecs, new_codec);
> > > }
> > >
> > > -/* these are allocated by sscanf, do not use g_fre
d-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
> ---
> server/char-device.c | 3 ++-
> server/gstreamer-encoder.c | 4 ++--
> server/main-channel-client.c | 6 +++---
> server/memslot.c | 2 +-
> server/mjpeg-encoder.c | 6 --
> serve
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> Windows needs some specific setting to use network.
>
> Signed-off-by: Frediano Ziglio
autotools only?
Reviewed-by: Marc-André Lureau
> ---
> configure.ac | 20 +++-
> 1 file changed, 19 inse
t; +spice_warning("ioctlsocket(FIONBIO) failed, %d", WSAGetLastError());
> +return false;
> +}
> +return true;
> +#endif
> }
>
> /**
> --
> 2.20.1
>
> _______
> Spice-devel mailing list
&
> #undef accept
> #define accept socket_accept
> +
> +int socket_newpair(int type, int protocol, int sv[2]);
> +#define socketpair(family, type, protocol, sv) socket_newpair(type,
> protocol, sv)
> #endif
>
> #endif // RED_SYS_SOCKET_H_
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
cket error instead of changing all code handling.
> Fortunately on Windows Qemu core interface accepts socket (but not
> other types like C file descriptors!).
>
> Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
> ---
> server/Makefile.am | 2 +
> server/sys-
nt(info.min, <, 1);
> -g_assert_cmpuint(info.total, >=, 5000);
> +g_assert_cmpuint(info.total, >=, 500);
> g_assert_cmpuint(info.orig_size, ==, 1100);
> g_assert_cmpuint(info.comp_size, ==, 550);
> #endif
> --
> 2.20
endif
> +
> #define REDS_MAX_STAT_NODES 100
>
> static void reds_client_monitors_config(RedsState *reds,
> VDAgentMonitorsConfig *monitors_config);
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
&
ctor this parsing code out of RedsState and make
some unit tests.
> if (video_codecs->len == 0) {
> spice_warning("Failed to set video codecs, input string: '%s'",
> codecs);
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
message {
> -uint16 connection_id;
> -uint8 data[] @end;
> -} socket_data;
> -
> -message {
> -uint16 connection_id;
> -uint32 num_tokens;
> -} @ctype(SpiceMsgcTunnelSocketTokens) socket_token;
> -};
> -
> e
t;Failed to initialize smartcard");
> > goto end;
> > }
> > + smartcard_check_reader_count();
> >
> > retval = TRUE;
> >
>
> I think the ack from Marc-andre is still valid, nothing against it.
>
> Frediano
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
---
ui/spice-app.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/spice-app.c b/ui/spice-app.c
index 4f5229f3ee..925b27b708 100644
--- a/ui/spice-app.c
+++ b/ui/spice-app.c
@@ -181,6 +181,8 @@ static void spice_app_display_init(DisplayState *ds,
DisplayOptions *opts)
Hi
On Thu, Feb 21, 2019 at 4:21 PM Christophe Fergeau wrote:
>
> On Thu, Feb 21, 2019 at 03:59:00PM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Feb 20, 2019 at 5:17 PM Christophe Fergeau
> > wrote:
> > >
> > > spice-server does n
Hi
On Wed, Feb 20, 2019 at 5:17 PM Christophe Fergeau wrote:
>
> spice-server does not deal properly with multiple smartcard readers,
> only the first one will be working. Add a warning when this happens to
> make it easier to diagnose such issues.
>
> Signed-off-by: Christophe Fergeau
> ---
>
text(meson.project_name(),
> + args : '--msgid-bugs-address=' +
> config_data['PACKAGE_BUGREPORT'],
> preset : 'glib')
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Tue, Feb 19, 2019 at 6:02 PM Victor Toso wrote:
>
> Hi,
>
> On Tue, Feb 19, 2019 at 05:37:38PM +0100, Marc-André Lureau wrote:
> > > > > -SPICE_DEBUG("frame mm_time %u size %u creation time %"
> > > > > G_GINT64_
uot; queue %u",
> > > -frame->mm_time, frame->size, frame->creation_time,
> > > -duration, decoder->decoding_queue->length);
> > > +record(frames_stats,
> > > + "frame mm_time %u
+ " decoded time %" PRId64 " queue %u",
> + frame->mm_time, frame->size, frame->creation_time,
> + duration, decoder->decoding_queue->length);
Why SPICE_DEBUG log is remo
Hi
On Fri, Feb 15, 2019 at 8:49 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Fri, Feb 15, 2019 at 6:21 PM Frediano Ziglio wrote:
> > Looking at http://mesonbuild.com/Subprojects.html looks like
> > subprojects should be Meson project too.
> > While spice-common is no
project.
Ok, it's a bit silly imho. Let's make one then:
https://gitlab.com/keycodemap/keycodemapdb/merge_requests/7
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Fri, Feb 15, 2019 at 5:21 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > Follow m
Hi
On Fri, Feb 15, 2019 at 5:19 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote:
> > >
> > > > From: Marc-André Lureau
> > > >
> > > > Our own handling was limited, since it c
On Fri, Feb 15, 2019 at 4:54 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > Follow meson build system c
Hi
On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Use the trick recommended here to generate a vcs_tag.h at build-time:
> > https://github.com/mesonbuild/meson/issues/3903
> >
> > Hopefully, meson wi
Hi
On Fri, Feb 15, 2019 at 4:04 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Follow meson build system conventions.
> >
> > This will allow meson to handle it as a subproject.
> >
> > Signed-off-by: Marc-André
Hi
On Fri, Feb 15, 2019 at 3:57 PM Frediano Ziglio wrote:
>
> > From: Marc-André Lureau
> >
> > Our own handling was limited, since it checked only spice-common.
> >
> > This is handled by meson since v0.40 for subprojects.
> >
> > Signed-off-by: Ma
reedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
On Tue, Feb 12, 2019 at 12:35 PM Frediano Ziglio wrote:
>
>
> > From: Marc-André Lureau
> >
> > Use glib preset (from meson v0.37) to catch all our translatable
> > strings and use good default settings.
> >
> > While at it, remove the needless direc
Hi
On Mon, Feb 11, 2019 at 6:16 PM Frediano Ziglio wrote:
>
> > >
> > > From: Marc-André Lureau
> > >
> > > - Fix the following warnings:
> > > ./spice-gtk-sections.txt:467: warning: No declaration found for
> > > SPICE_GTK_C
mingw64-opus
> mingw64-gstreamer1-plugins-base mingw64-gstreamer1-plugins-good
> +- (cd spice-protocol && make clean && mingw64-configure --prefix=/usr &&
> make install)
> +- NOCONFIGURE=yes ./autogen.sh
> +- PYTHON=python3 mingw64-configure --enable-static
> +- make -j4
> --
> 2.20.1
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
> -{
> -"type": "git",
> -"url":
> "https://gitlab.freedesktop.org/spice/spice-protocol.git;
> -}
> -]
> -},
> - {
> - "builddir": true,
> -"name": "spic
It doesn't make much sense to have it included imho, unless we have a
good reason to build it on a regular basis, which imho is not
something we need as a library or even a testing client.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice
Hi
On Mon, Feb 11, 2019 at 2:57 PM Victor Toso wrote:
>
> On Mon, Feb 11, 2019 at 02:44:23PM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Feb 11, 2019 at 2:21 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Mo
Hi
On Mon, Feb 11, 2019 at 2:21 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 02:06:19PM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Feb 11, 2019 at 1:59 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > >
Hi
On Mon, Feb 11, 2019 at 1:59 PM Victor Toso wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 01:09:41PM +0100, Marc-André Lureau wrote:
> > > Having a virt-viewer flatpak does not mean _not_ having a
> > > spicy.flatkpak (to me); one is full featured spice client w
1 - 100 of 3826 matches
Mail list logo
