Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-03-17 Thread Christophe Fergeau 
On Sun, Mar 16, 2014 at 07:01:16PM +0200, Alon Levy wrote:
 On 01/12/2014 07:34 PM, Marc-André Lureau wrote:
  For example, with qemu, a webdav channel can be created this way:
  
   -chardev spiceport,name=org.spice-space.webdav.0,...
  
  And redirected to a virtio port:
  
   -device virtserialport,...,name=org.spice-space.webdav.0
 
 Ack. Still reviewing the gtk part. I've tested this.

(don't forget to add
http://lists.freedesktop.org/archives/spice-devel/2014-February/016259.html
in there, but I assume the doc build patches you sent mean you looked at
that).

Christophe


pgpAEK87yvZJN.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-03-16 Thread Alon Levy 
On 01/12/2014 07:34 PM, Marc-André Lureau wrote:
 For example, with qemu, a webdav channel can be created this way:
 
  -chardev spiceport,name=org.spice-space.webdav.0,...
 
 And redirected to a virtio port:
 
  -device virtserialport,...,name=org.spice-space.webdav.0

Ack. Still reviewing the gtk part. I've tested this.

 ---
  server/reds.c | 7 ++-
  1 file changed, 6 insertions(+), 1 deletion(-)
 
 diff --git a/server/reds.c b/server/reds.c
 index 2a0002b..2c63154 100644
 --- a/server/reds.c
 +++ b/server/reds.c
 @@ -3668,7 +3668,11 @@ static int 
 spice_server_char_device_add_interface(SpiceServer *s,
  dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_USBREDIR);
  }
  else if (strcmp(char_device-subtype, SUBTYPE_PORT) == 0) {
 -dev_state = spicevmc_device_connect(char_device, SPICE_CHANNEL_PORT);
 +if (strcmp(char_device-portname, org.spice-space.webdav.0) == 0) {
 +dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_WEBDAV);
 +} else {
 +dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_PORT);
 +}
  }
  
  if (dev_state) {
 @@ -4206,6 +4210,7 @@ SPICE_GNUC_VISIBLE int 
 spice_server_set_channel_security(SpiceServer *s, const c
  [ SPICE_CHANNEL_SMARTCARD] = smartcard,
  #endif
  [ SPICE_CHANNEL_USBREDIR ] = usbredir,
 +[ SPICE_CHANNEL_WEBDAV ] = webdav,
  };
  int i;
  
 

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-03-13 Thread Marc-André Lureau 
Hi

I would like to push this change, along with the protocol channel
change. I believe the implementation has been around and stable for a
while, and is good enough for inclusion.

This isn't a fundamental change, it's an optional new channel, and as
such I think it shouldn't be any trouble.


On Sun, Jan 12, 2014 at 6:34 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
 For example, with qemu, a webdav channel can be created this way:

  -chardev spiceport,name=org.spice-space.webdav.0,...

 And redirected to a virtio port:

  -device virtserialport,...,name=org.spice-space.webdav.0
 ---
  server/reds.c | 7 ++-
  1 file changed, 6 insertions(+), 1 deletion(-)

 diff --git a/server/reds.c b/server/reds.c
 index 2a0002b..2c63154 100644
 --- a/server/reds.c
 +++ b/server/reds.c
 @@ -3668,7 +3668,11 @@ static int 
 spice_server_char_device_add_interface(SpiceServer *s,
  dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_USBREDIR);
  }
  else if (strcmp(char_device-subtype, SUBTYPE_PORT) == 0) {
 -dev_state = spicevmc_device_connect(char_device, SPICE_CHANNEL_PORT);
 +if (strcmp(char_device-portname, org.spice-space.webdav.0) == 0) {
 +dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_WEBDAV);
 +} else {
 +dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_PORT);
 +}
  }

  if (dev_state) {
 @@ -4206,6 +4210,7 @@ SPICE_GNUC_VISIBLE int 
 spice_server_set_channel_security(SpiceServer *s, const c
  [ SPICE_CHANNEL_SMARTCARD] = smartcard,
  #endif
  [ SPICE_CHANNEL_USBREDIR ] = usbredir,
 +[ SPICE_CHANNEL_WEBDAV ] = webdav,
  };
  int i;

 --
 1.8.4.2




-- 
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-01-13 Thread Fedor Lyakhov 
May be better to avoid hardcoding the port name there using e.g.
static const char * instead?

On Sun, Jan 12, 2014 at 9:34 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
 For example, with qemu, a webdav channel can be created this way:

  -chardev spiceport,name=org.spice-space.webdav.0,...

 And redirected to a virtio port:

  -device virtserialport,...,name=org.spice-space.webdav.0
 ---
  server/reds.c | 7 ++-
  1 file changed, 6 insertions(+), 1 deletion(-)

 diff --git a/server/reds.c b/server/reds.c
 index 2a0002b..2c63154 100644
 --- a/server/reds.c
 +++ b/server/reds.c
 @@ -3668,7 +3668,11 @@ static int 
 spice_server_char_device_add_interface(SpiceServer *s,
  dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_USBREDIR);
  }
  else if (strcmp(char_device-subtype, SUBTYPE_PORT) == 0) {
 -dev_state = spicevmc_device_connect(char_device, SPICE_CHANNEL_PORT);
 +if (strcmp(char_device-portname, org.spice-space.webdav.0) == 0) {
 +dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_WEBDAV);
 +} else {
 +dev_state = spicevmc_device_connect(char_device, 
 SPICE_CHANNEL_PORT);
 +}
  }

  if (dev_state) {
 @@ -4206,6 +4210,7 @@ SPICE_GNUC_VISIBLE int 
 spice_server_set_channel_security(SpiceServer *s, const c
  [ SPICE_CHANNEL_SMARTCARD] = smartcard,
  #endif
  [ SPICE_CHANNEL_USBREDIR ] = usbredir,
 +[ SPICE_CHANNEL_WEBDAV ] = webdav,
  };
  int i;

 --
 1.8.4.2

 ___
 Spice-devel mailing list
 Spice-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Best regards,
Fedor
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-01-12 Thread Marc-André Lureau 
For example, with qemu, a webdav channel can be created this way:

 -chardev spiceport,name=org.spice-space.webdav.0,...

And redirected to a virtio port:

 -device virtserialport,...,name=org.spice-space.webdav.0
---
 server/reds.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/server/reds.c b/server/reds.c
index 2a0002b..2c63154 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3668,7 +3668,11 @@ static int 
spice_server_char_device_add_interface(SpiceServer *s,
 dev_state = spicevmc_device_connect(char_device, 
SPICE_CHANNEL_USBREDIR);
 }
 else if (strcmp(char_device-subtype, SUBTYPE_PORT) == 0) {
-dev_state = spicevmc_device_connect(char_device, SPICE_CHANNEL_PORT);
+if (strcmp(char_device-portname, org.spice-space.webdav.0) == 0) {
+dev_state = spicevmc_device_connect(char_device, 
SPICE_CHANNEL_WEBDAV);
+} else {
+dev_state = spicevmc_device_connect(char_device, 
SPICE_CHANNEL_PORT);
+}
 }
 
 if (dev_state) {
@@ -4206,6 +4210,7 @@ SPICE_GNUC_VISIBLE int 
spice_server_set_channel_security(SpiceServer *s, const c
 [ SPICE_CHANNEL_SMARTCARD] = smartcard,
 #endif
 [ SPICE_CHANNEL_USBREDIR ] = usbredir,
+[ SPICE_CHANNEL_WEBDAV ] = webdav,
 };
 int i;
 
-- 
1.8.4.2

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel